GNU bug report logs -
#10878
"make dist" with read-only srcdir generates read-only tarball
Previous Next
Reported by: Nick Bowler <nbowler <at> elliptictech.com>
Date: Fri, 24 Feb 2012 16:06:02 UTC
Severity: minor
Tags: patch
Done: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
Message #14 received at 10878 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
severity 10878 wishlist
tags 10878 wontfix
close 10878
thanks
On 02/24/2012 08:09 AM, Nick Bowler wrote:
>
> Automake should at least add user write permissions to all files in
> distdir prior to running dist-hook (and hence prior to generating the
> distribution tarball).
>
I disagree; in case the user wants to change the permission of the distributed
files from the ones that they have in the builddir/srcdir, he can do so in the
dist-hook already, with full control (I've just added a tiny test to verify
this behaviour, see attached patch). So we don't need to change the automake
behaviour in this respect (but a documentation improvement might be nice, in
case someone feels like writing it).
On 02/24/2012 05:12 PM, Eric Blake replied:
>
> Automake must not add write permissions to files that were intended to
> be shipped as read-only. For example, coreutils intentionally converts
> generated-but-distributed files to read-only, so that users are more
> likely to notice that they should edit the source that generates the
> file, and not the generated file itself.
>
> So how do you propose to tell automake which files are supposed to be
> read-only, vs. those that should be writable even if the tarball was
> re-created from a read-only srcdir?
>
With a dist-hook ;-)
Regards,
Stefano
[0001-coverage-test-that-dist-hook-can-modify-file-permiss.patch (text/x-diff, attachment)]
This bug report was last modified 13 years and 147 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.