GNU bug report logs - #10846
warning: non-literal format string

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#10846: closed (warning: non-literal format string)
Date: Sun, 19 Feb 2012 23:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 19 Feb 2012 23:57:49 +0100
with message-id <87aa4ewhw2.fsf <at> gnu.org>
and subject line Re: bug#10846: warning: non-literal format string
has caused the debbugs.gnu.org bug report #10846,
regarding warning: non-literal format string
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
10846: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10846
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Bruno Haible <bruno <at> clisp.org>
To: bug-guile <at> gnu.org
Subject: warning: non-literal format string
Date: Sun, 19 Feb 2012 13:52:33 +0100

Hi,

With the default settings, guile's compiler warns about a format string
that is returned by the gettext function.

How to reproduce:
================================= prog.scm =================================
(use-modules (ice-9 format))

(setlocale LC_ALL "")
(textdomain "prog")
(bindtextdomain "prog" ".")

(define n (string->number (list-ref (command-line) 1)))

(format #t "~A~%" (gettext "'Your command, please?', asked the waiter."))

(format #t "~@?~%" (ngettext "a piece of cake" "~D pieces of cake" n) n)

(format #t "~A~%" (format #f (gettext "~A is replaced by ~A.") "FF" "EUR"))
============================================================================

$ uname -srm
SunOS 5.11 i86pc
$ guile --version
guile (GNU Guile) 2.0.3.152-c5f6c2
...
$ guile -s prog.scm 2
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=0
;;;       or pass the --no-auto-compile argument to disable.
;;; compiling /home/bruno/gettext-0.18.2-32-static/gettext-tools/tests/prog.scm
;;; /home/bruno/gettext-0.18.2-32-static/gettext-tools/tests/prog.scm:13:18: warning: non-literal format string
;;; compiled /home/bruno/.cache/guile/ccache/2.0-LE-4-2.0/home/bruno/gettext-0.18.2-32-static/gettext-tools/tests/prog.scm.go
'Your command, please?', asked the waiter.
2 pieces of cake
FF is replaced by EUR.

Given that
  - It is normal for a program to be internationalized,
  - It is normal for an internationalized program to have its format strings
    passed through the gettext function.
such situations should not produce warnings with the default settings.

It's OK in my opinion to have this warning enabled through special options
or settings, though.

Bruno

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Bruno Haible <bruno <at> clisp.org>
Cc: 10846-done <at> debbugs.gnu.org
Subject: Re: bug#10846: warning: non-literal format string
Date: Sun, 19 Feb 2012 23:57:49 +0100

Hi Bruno,

Bruno Haible <bruno <at> clisp.org> skribis:

> Given that
>   - It is normal for a program to be internationalized,
>   - It is normal for an internationalized program to have its format strings
>     passed through the gettext function.
> such situations should not produce warnings with the default settings.

Thanks, fixed here:

  http://git.savannah.gnu.org/cgit/guile.git/commit/?h=stable-2.0&id=afc9803113de660a761f476b7957e92cc60bad19
  http://git.savannah.gnu.org/cgit/guile.git/commit/?h=stable-2.0&id=98385ed20abdc191a67daef8a00b1df0290a074a

> It's OK in my opinion to have this warning enabled through special options
> or settings, though.

The ‘format’ warning is in ‘%auto-compilation-options’, but it can be
turned off at the user’s option.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.