From unknown Sat Aug 16 16:55:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10816: automake: autoreconf -i fails if macro dir does not exist (it should automatically create new directories) Resent-From: "David A. Wheeler" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 15 Feb 2012 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10816 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 10816@debbugs.gnu.org Cc: dwheeler@dwheeler.com X-Debbugs-Original-To: bug-automake@gnu.org Reply-To: dwheeler@dwheeler.com Received: via spool by submit@debbugs.gnu.org id=B.132931804830717 (code B ref -1); Wed, 15 Feb 2012 15:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2012 15:00:48 +0000 Received: from localhost ([127.0.0.1]:41558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxgLb-0007zK-M0 for submit@debbugs.gnu.org; Wed, 15 Feb 2012 10:00:48 -0500 Received: from eggs.gnu.org ([140.186.70.92]:57026) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxgLU-0007z1-M2 for submit@debbugs.gnu.org; Wed, 15 Feb 2012 10:00:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxgJd-00037g-Jg for submit@debbugs.gnu.org; Wed, 15 Feb 2012 09:58:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:35727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgJd-00037c-IE for submit@debbugs.gnu.org; Wed, 15 Feb 2012 09:58:41 -0500 Received: from eggs.gnu.org ([140.186.70.92]:59008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgJZ-00061x-7E for bug-automake@gnu.org; Wed, 15 Feb 2012 09:58:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxgJM-00035a-LX for bug-automake@gnu.org; Wed, 15 Feb 2012 09:58:37 -0500 Received: from aibo.runbox.com ([91.220.196.211]:43402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgJM-00035C-GL for bug-automake@gnu.org; Wed, 15 Feb 2012 09:58:24 -0500 Received: from [10.9.9.130] (helo=fenris.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1RxgJI-0002s6-Vk for bug-automake@gnu.org; Wed, 15 Feb 2012 15:58:21 +0100 Received: from mail by fenris.runbox.com with local (Exim 4.50) id 1RxgJI-0007hc-DJ; Wed, 15 Feb 2012 15:58:20 +0100 Content-Type: text/plain; charset="iso-8859-15" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received: from [129.246.80.34] by secure.runbox.com with http (uid:258406) (RMM 4.0); Wed, 15 Feb 2012 14:58:20 GMT From: "David A. Wheeler" Date: Wed, 15 Feb 2012 09:58:20 -0500 (EST) X-Mailer: RMM Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Problem: "autoreconf -i" fails if you follow the libtool advice and use put this in = configure.ac: AC_CONFIG_MACRO_DIR([m4]) and add "-I m4" to ACLOCAL_AMFLAGS in Makefile.am It will instead report: aclocal: couldn't open directory `m4': No such file or directory autoreconf: aclocal failed with exit status: 1 The whole point of "autoreconf -i" is to create "whatever is needed", and clearly MACRO_DIRs are needed, yet autoreconf fails to do so. Therefor= e, this is a bug. This is *especially* a problem when using the widely-used "git" tool, because "git" does not store empty directories (only files). The symptom is= that you "git clone" a fresh repository, and then "autoreconf -i" fails. You ca= n work around this using: "mkdir m4 ; touch m4/dummy ; git add m4/dummy" or similar, but you shouldn'= t need to work around this at all. This is already a bug report in Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D565663 reported against automake 1.11. Solution: Please patch aclocal (part of automake) to automatically create these direc= tories. A patch has already been created in 2010: http://permalink.gmane.org/gmane.linux.debian.devel.bugs.general/678260 http://permalink.gmane.org/gmane.comp.sysutils.automake.patches/3859 --- David A. Wheeler From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 12:52:33 2012 Received: (at control) by debbugs.gnu.org; 19 Feb 2012 17:52:33 +0000 Received: from localhost ([127.0.0.1]:46173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RzAw4-0007Ux-D6 for submit@debbugs.gnu.org; Sun, 19 Feb 2012 12:52:32 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]:42423) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RzAw1-0007Uj-Nb for control@debbugs.gnu.org; Sun, 19 Feb 2012 12:52:30 -0500 Received: by eekc41 with SMTP id c41so2868451eek.3 for ; Sun, 19 Feb 2012 09:50:17 -0800 (PST) Received-SPF: pass (google.com: domain of stefano.lattarini@gmail.com designates 10.14.199.193 as permitted sender) client-ip=10.14.199.193; Authentication-Results: mr.google.com; spf=pass (google.com: domain of stefano.lattarini@gmail.com designates 10.14.199.193 as permitted sender) smtp.mail=stefano.lattarini@gmail.com; dkim=pass header.i=stefano.lattarini@gmail.com Received: from mr.google.com ([10.14.199.193]) by 10.14.199.193 with SMTP id x41mr8974355een.29.1329673817800 (num_hops = 1); Sun, 19 Feb 2012 09:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=gcp6Iaid6iBVNUsFjYj82QG4gMLY/qndYKWSn6Vlhq0=; b=OhrwTdWSeI2Rvts53/hn7KihV4mevC+HTK2tuJ9WOi+fhhwxV39vV0kkwR28CyojZL KQ1LJ/V4nNoSyFTz7wI47BnlUR/MYIFj8tdjsS6JN19G/56Uv3gkHWWOsU4Qkbo5v8+W TN2gQa7vyExRsetPfBhzHzPiJu8rQxMSLpGbw= Received: by 10.14.199.193 with SMTP id x41mr7153038een.29.1329673817748; Sun, 19 Feb 2012 09:50:17 -0800 (PST) Received: from [79.20.98.232] (host232-98-dynamic.20-79-r.retail.telecomitalia.it. [79.20.98.232]) by mx.google.com with ESMTPS id u9sm50321141eem.11.2012.02.19.09.50.16 (version=SSLv3 cipher=OTHER); Sun, 19 Feb 2012 09:50:16 -0800 (PST) Message-ID: <4F413656.7060102@gmail.com> Date: Sun, 19 Feb 2012 18:50:14 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) retitle 10473 get directory holding automake-provided scripts and data files severity 10473 wishlist tags 10473 patch severity 10816 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 15 12:30:46 2012 Received: (at control) by debbugs.gnu.org; 15 Mar 2012 16:30:46 +0000 Received: from localhost ([127.0.0.1]:52249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8DZc-0000oM-93 for submit@debbugs.gnu.org; Thu, 15 Mar 2012 12:30:45 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:40785) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8DZV-0000lK-06 for control@debbugs.gnu.org; Thu, 15 Mar 2012 12:30:41 -0400 Received: by bkuw5 with SMTP id w5so2199677bku.3 for ; Thu, 15 Mar 2012 09:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=kZzKmqyTkDIDjE5OpkpZHWiP2OZVaY7Sso6OA+IMI88=; b=PIfUxhysEGuaK+9i6kIuIZmJEc7QoC/PyQbg63DliSJrCe0DKp7dBlKouVj/KDwVGM 9H480i2Z1DD6o5kDEG56kxr9715IfWdHOqpWrdzglFtmkKcjFZoxTErOeIDgXgXNhi1f qCnzZOyXr53ZqYqxZShj3ftddhd9jy4KejBihHefvZ0PaZwGHN5VCH/2IOlhX1Kem7Zq VaZZGZzEHTEh/YPMgqS5D9Aby9SB01tODqkGRCzCQgpryoPDHUGe2UoH3Yws5Oxvdimp MXTWL4sdMCDKIY/fDuWATR1jShVZn94QZltWJMx70h0MtK3IQyEVzdwWAjSmSMT2Btyo 1Bzg== Received: by 10.204.154.2 with SMTP id m2mr2638145bkw.110.1331827227899; Thu, 15 Mar 2012 09:00:27 -0700 (PDT) Received: from [82.60.30.174] (host174-30-dynamic.60-82-r.retail.telecomitalia.it. [82.60.30.174]) by mx.google.com with ESMTPS id f5sm4567065bke.9.2012.03.15.09.00.24 (version=SSLv3 cipher=OTHER); Thu, 15 Mar 2012 09:00:25 -0700 (PDT) Message-ID: <4F621216.9050900@gmail.com> Date: Thu, 15 Mar 2012 17:00:22 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: foo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) severity 8168 wishlist tags 10816 patch merge 10816 8168 thanks From unknown Sat Aug 16 16:55:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10816: [PATCH] aclocal: create local directory where to install m4 files References: In-Reply-To: Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 15 Mar 2012 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10816 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: automake-patches@gnu.org Cc: 8168@debbugs.gnu.org, dwheeler@dwheeler.com, jjardon@gnome.org, 10816@debbugs.gnu.org Received: via spool by 10816-submit@debbugs.gnu.org id=B10816.133184328027377 (code B ref 10816); Thu, 15 Mar 2012 20:28:01 +0000 Received: (at 10816) by debbugs.gnu.org; 15 Mar 2012 20:28:00 +0000 Received: from localhost ([127.0.0.1]:52363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8HHC-00077T-KW for submit@debbugs.gnu.org; Thu, 15 Mar 2012 16:28:00 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:57866) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8HGz-000774-Kb; Thu, 15 Mar 2012 16:27:57 -0400 Received: by werb10 with SMTP id b10so3791787wer.3 for ; Thu, 15 Mar 2012 12:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=5+hfO2UGMtVawQEv4y7vpbmpcBxS7yrerQAFOf3q89k=; b=ZzquJgghlnIBFWZbcHwVc2W9PVrQSw6NLOx1ATeEQnxatuOJhVcHAh/nd9SPLHmVHK XDkoqZMu8RE3quOvJNJxuD1c+NsUIi21pcjGwL9r6JHzj3SIT7Lnu131hZlULIMj6umm uc45VreZVx4yCnbUlFHv0W+PgDSMdfxi0EFZ34nhgtCR+krYWRjylVw25wKH3cvzkM0a QEhWQeT/z1Fk7X3AXb2Adh8HE63yXRGfBwvyFfpfwvusO6ouLBkWp42XnCJPWPQGv56y uKN+OW/zr9SO+rV1/ogY9tGwnTxvMcOuvYLQZEdqmJk+7lmO01QEOEFOwxYi70JCKfbs BuFw== Received: by 10.180.91.10 with SMTP id ca10mr29221136wib.17.1331841455152; Thu, 15 Mar 2012 12:57:35 -0700 (PDT) Received: from localhost.localdomain (host40-92-dynamic.4-87-r.retail.telecomitalia.it. [87.4.92.40]) by mx.google.com with ESMTPS id k6sm7531186wiy.7.2012.03.15.12.57.32 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Mar 2012 12:57:33 -0700 (PDT) From: Stefano Lattarini Date: Thu, 15 Mar 2012 20:57:22 +0100 Message-Id: <9c7254b76bc0016595bf3815213e6c83b62f7a39.1331841335.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.7.9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixes automake bug#8168 and bug#10816. A call like "aclocal -I m4 --install" used to fail if the 'm4' directory wasn't pre-existing. This could be particularly annoying when running in a checked-out version from a VCS like git, which doesn't allow empty directories to be tracked. * aclocal.in (File::Path): New import. (scan_m4_dirs): Don't die if the first directory of type FT_USER doesn't exist and the '--install' option was given; that directory will be created later in ... (install_file): ... here. Change signature: now it takes as second argument the destination directory rather than the destination file. Crate the destination directory if it doesn't already exist. In verbose mode, tell what is being copied where. (write_aclocal): Update. * NEWS, THANKS: Update. * tests/aclocal-install-fail.test: New test. * tests/aclocal-install-mkdir.test: Likewise. * tests/aclocal-no-install-no-mkdir.test: Likewise. * tests/aclocal-verbose-install.test: Likewise. * tests/list-of-tests.mk: Add them. Signed-off-by: Stefano Lattarini --- I will push this in a couple of days if there is no objection. Thanks to David and Javier, and sorry for the awful delay. Regards, Stefano NEWS | 4 ++ THANKS | 2 + aclocal.in | 40 +++++++++++++++---- tests/aclocal-install-fail.test | 65 ++++++++++++++++++++++++++++++++ tests/aclocal-install-mkdir.test | 62 ++++++++++++++++++++++++++++++ tests/aclocal-no-install-no-mkdir.test | 39 +++++++++++++++++++ tests/aclocal-verbose-install.test | 54 ++++++++++++++++++++++++++ tests/list-of-tests.mk | 4 ++ 8 files changed, 261 insertions(+), 9 deletions(-) create mode 100755 tests/aclocal-install-fail.test create mode 100755 tests/aclocal-install-mkdir.test create mode 100755 tests/aclocal-no-install-no-mkdir.test create mode 100755 tests/aclocal-verbose-install.test diff --git a/NEWS b/NEWS index b998ce4..2b5f68f 100644 --- a/NEWS +++ b/NEWS @@ -122,6 +122,10 @@ New in 1.11.0a: optional space between the -I, -L and -l options and their respective arguments, for better POSIX compliance. + - If "aclocal --install" is used, and the first directory specified with + '-I' is non-existent, aclocal will now create it before trying to copy + files in it. + Bugs fixed in 1.11.0a: * Bugs introduced by 1.11.2: diff --git a/THANKS b/THANKS index 8363126..d7b3658 100644 --- a/THANKS +++ b/THANKS @@ -73,6 +73,7 @@ Dave Brolley brolley@redhat.com Dave Korn dave.korn.cygwin@googlemail.com Dave Morrison dave@bnl.gov David A. Swierczek swiercze@mr.med.ge.com +David A. Wheeler dwheeler@dwheeler.com David Byron dbyron@dbyron.com Davyd Madeley davyd@fugro-fsi.com.au David Pashley david@davidpashley.com @@ -149,6 +150,7 @@ Janos Farkas chexum@shadow.banki.hu Jared Davis abiword@aiksaurus.com Jason Duell jcduell@lbl.gov Jason Molenda crash@cygnus.co.jp +Javier Jardón jjardon@gnome.org Jeff Bailey Jbailey@phn.ca Jeff Garzik jgarzik@pobox.com Jeff Squyres jsquyres@lam-mpi.org diff --git a/aclocal.in b/aclocal.in index ed1d8d9..ca15732 100644 --- a/aclocal.in +++ b/aclocal.in @@ -7,9 +7,7 @@ eval 'case $# in 0) exec @PERL@ -S "$0";; *) exec @PERL@ -S "$0" "$@";; esac' # aclocal - create aclocal.m4 by scanning configure.ac -# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, -# 2005, 2006, 2007, 2008, 2009, 2010, 2011 Free Software Foundation, -# Inc. +# Copyright (C) 1996-2012 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -45,6 +43,7 @@ use Automake::FileUtils; use File::Basename; use File::stat; use Cwd; +use File::Path (); # Some globals. @@ -181,6 +180,17 @@ sub unlink_tmp $SIG{'INT'} = $SIG{'TERM'} = $SIG{'QUIT'} = $SIG{'HUP'} = 'unlink_tmp'; END { unlink_tmp } +sub xmkdir_p ($) +{ + my $dir = shift; + local $@ = undef; + return + if -d $dir or eval { File::Path::mkpath $dir }; + chomp $@; + $@ =~ s/\s+at\s.*\bline\s\d+.*$//; + fatal "could not create directory '$dir': $@"; +} + # Check macros in acinclude.m4. If one is not used, warn. sub check_acinclude () { @@ -210,12 +220,15 @@ sub reset_maps () undef &search; } -# install_file ($SRC, $DEST) +# install_file ($SRC, $DESTDIR) sub install_file ($$) { - my ($src, $dest) = @_; + my ($src, $destdir) = @_; + my $dest = $destdir . "/" . basename ($src); my $diff_dest; + verb "installing $src to $dest"; + if ($force_output || !exists $file_contents{$dest} || $file_contents{$src} ne $file_contents{$dest}) @@ -268,6 +281,7 @@ sub install_file ($$) } elsif (!$dry_run) { + xmkdir_p ($destdir); xsystem ('cp', $src, $dest); } } @@ -307,6 +321,7 @@ sub list_compare (\@\@) # -------------------------- # Scan all M4 files installed in @DIRS for new macro definitions. # Register each file as of type $TYPE (one of the FT_* constants). +my $first_user_m4dir = 1; sub scan_m4_dirs ($@) { my ($type, @dirlist) = @_; @@ -315,7 +330,16 @@ sub scan_m4_dirs ($@) { if (! opendir (DIR, $m4dir)) { - fatal "couldn't open directory `$m4dir': $!"; + if ($install && $type == FT_USER && $first_user_m4dir) + { + # We will try to create this directory later, so don't + # complain if it doesn't exist. + # TODO: maybe we should avoid complaining only if errno + # is ENONENT? + $first_user_m4dir = 0; + next; + } + fatal "couldn't open directory '$m4dir': $!"; } # We reverse the directory contents so that foo2.m4 gets @@ -773,9 +797,7 @@ sub write_aclocal ($@) my $dest; for my $ifile (@{$file_includes{$file}}, $file) { - $dest = "$user_includes[0]/" . basename $ifile; - verb "installing $ifile to $dest"; - install_file ($ifile, $dest); + install_file ($ifile, $user_includes[0]); } $installed = 1; } diff --git a/tests/aclocal-install-fail.test b/tests/aclocal-install-fail.test new file mode 100755 index 0000000..cf493aa --- /dev/null +++ b/tests/aclocal-install-fail.test @@ -0,0 +1,65 @@ +#! /bin/sh +# Copyright (C) 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check that "aclocal --install" fails when it should. +# FIXME: this is a good candidate for a conversion to TAP. + +am_create_testdir=empty +required=ro-dir +. ./defs || Exit 1 + +set -e + +cat > configure.in < sys-acdir/my-defs.m4 < a-regular-file +mkdir unwritable-dir +chmod a-w unwritable-dir + +$ACLOCAL -I a-regular-file --install 2>stderr \ + && { cat stderr >&2; Exit 1; } +cat stderr >&2 +$EGREP '(mkdir:|directory ).*a-regular-file' stderr +test ! -f aclocal.m4 + +$ACLOCAL --install -I unwritable-dir/sub 2>stderr \ + && { cat stderr >&2; Exit 1; } +cat stderr >&2 +$EGREP '(mkdir:|directory ).*unwritable-dir/sub' stderr +test ! -f aclocal.m4 + +$ACLOCAL -I unwritable-dir --install 2>stderr \ + && { cat stderr >&2; Exit 1; } +cat stderr >&2 +$EGREP '(cp:|copy ).*unwritable-dir' stderr +test ! -f aclocal.m4 + +# Sanity check. +mkdir m4 +$ACLOCAL -I m4 --install && test -f aclocal.m4 \ + || fatal_ "aclocal failed also when expected to succeed" + +: diff --git a/tests/aclocal-install-mkdir.test b/tests/aclocal-install-mkdir.test new file mode 100755 index 0000000..61a3d19 --- /dev/null +++ b/tests/aclocal-install-mkdir.test @@ -0,0 +1,62 @@ +#! /bin/sh +# Copyright (C) 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check that "aclocal --install" creates the local m4 directory if +# necessary. +# FIXME: this is a good candidate for a conversion to TAP. + +am_create_testdir=empty +. ./defs || Exit 1 + +set -e + +cat > configure.in < sys-acdir/my-defs.m4 <. + +# Check that aclocal does not create a non-existent local m4 directory +# if the '--install' option is not given. + +am_create_testdir=empty +. ./defs || Exit 1 + +set -e + +cat > configure.in < sys-acdir/my-defs.m4 <. + +# Check verbose messages by `aclocal --install'. + +am_create_testdir=empty +. ./defs || Exit 1 + +set -e + +cat > configure.in < sys-acdir/bar.m4 < sys-acdir/quux.m4 < foodir/bar.m4 + +$ACLOCAL --system-acdir=sys-acdir --install --verbose -I foodir 2>stderr \ + || { cat stderr >&2; Exit 1; } +cat stderr >&2 +grep ' installing .*sys-acdir/bar\.m4.* to .*foodir/bar\.m4' stderr +grep ' installing .*sys-acdir/quux\.m4.* to .*foodir/quux\.m4' stderr +grep ' overwriting .*foodir/bar\.m4.* with .*sys-acdir/bar\.m4' stderr +grep ' installing .*foodir/quux\.m4.* from .*sys-acdir/quux\.m4' stderr + +# Sanity checks. +ls -l foodir +grep MY_MACRO_BAR foodir/bar.m4 +grep MY_MACRO_QUUX foodir/quux.m4 + +: diff --git a/tests/list-of-tests.mk b/tests/list-of-tests.mk index b5a604c..f9109c0 100644 --- a/tests/list-of-tests.mk +++ b/tests/list-of-tests.mk @@ -64,6 +64,10 @@ aclocal-path-install.test \ aclocal-path-install-serial.test \ aclocal-path-nonexistent.test \ aclocal-path-precedence.test \ +aclocal-install-fail.test \ +aclocal-install-mkdir.test \ +aclocal-no-install-no-mkdir.test \ +aclocal-verbose-install.test \ acoutnoq.test \ acoutpt.test \ acoutpt2.test \ -- 1.7.9 From unknown Sat Aug 16 16:55:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: dwheeler@dwheeler.com Subject: bug#10816: closed (Re: bug#10816: [PATCH] aclocal: create local directory where to install m4 files) Message-ID: References: <4F644F66.2020402@gmail.com> X-Gnu-PR-Message: they-closed 10816 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: patch Reply-To: 10816@debbugs.gnu.org Date: Sat, 17 Mar 2012 09:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1331975882-20542-1" This is a multi-part message in MIME format... ------------=_1331975882-20542-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #10816: automake: autoreconf -i fails if macro dir does not exist (it shoul= d automatically create new directories) which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 10816@debbugs.gnu.org. --=20 10816: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10816 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1331975882-20542-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 10816-done) by debbugs.gnu.org; 17 Mar 2012 09:17:08 +0000 Received: from localhost ([127.0.0.1]:54344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8pl6-0005Jq-8A for submit@debbugs.gnu.org; Sat, 17 Mar 2012 05:17:08 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:44722) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8pkr-0005J4-PV; Sat, 17 Mar 2012 05:17:05 -0400 Received: by wibhm17 with SMTP id hm17so1671899wib.15 for ; Sat, 17 Mar 2012 01:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=i34b2PJOREKbuBagEHGtIMGZqXLxdMm0ZSzpA1riW0A=; b=G1vEQ4MNijq1fQSFZdoR+Z09BtLnb6czuBcJNbBks91IFWQEzyYkgq48lhovuk008V VLUqfpy+IHFOl6sUddUi8DBH9Fx9LaJxshq+sW4OEvdW6xN4S2nt0w9LZh98YNcX/6cH CnxPufFij3iWkSNzoeAx37cl1xMizLRTrSuU7eERkD8A1RjmExrDq8hWAUSqC3OMTCLt ZR/eznfSPcYejZR0vavdBfn+tuf/4+RFSVRgUM7euscN6A0U5iX75CEkQRgMrqBrAW/p L6YTd18SqKKnrxxLaPwQURP8lhjFfuMRAFDuhOwCPzURG3PWFb6C52z2z8Ul4nYUf9mw OzRQ== Received: by 10.216.131.98 with SMTP id l76mr3217657wei.62.1331973994754; Sat, 17 Mar 2012 01:46:34 -0700 (PDT) Received: from [80.116.81.50] (host50-81-dynamic.116-80-r.retail.telecomitalia.it. [80.116.81.50]) by mx.google.com with ESMTPS id fz9sm5751152wib.3.2012.03.17.01.46.32 (version=SSLv3 cipher=OTHER); Sat, 17 Mar 2012 01:46:33 -0700 (PDT) Message-ID: <4F644F66.2020402@gmail.com> Date: Sat, 17 Mar 2012 09:46:30 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: automake-patches@gnu.org Subject: Re: bug#10816: [PATCH] aclocal: create local directory where to install m4 files References: <9c7254b76bc0016595bf3815213e6c83b62f7a39.1331841335.git.stefano.lattarini@gmail.com> In-Reply-To: <9c7254b76bc0016595bf3815213e6c83b62f7a39.1331841335.git.stefano.lattarini@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10816-done Cc: 10816-done@debbugs.gnu.org, 8168-done@debbugs.gnu.org, dwheeler@dwheeler.com, jjardon@gnome.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 03/15/2012 08:57 PM, Stefano Lattarini wrote: > Fixes automake bug#8168 and bug#10816. > > A call like "aclocal -I m4 --install" used to fail if the 'm4' > directory wasn't pre-existing. This could be particularly > annoying when running in a checked-out version from a VCS like > git, which doesn't allow empty directories to be tracked. > > * aclocal.in (File::Path): New import. > (scan_m4_dirs): Don't die if the first directory of type FT_USER > doesn't exist and the '--install' option was given; that directory > will be created later in ... > (install_file): ... here. Change signature: now it takes as second > argument the destination directory rather than the destination file. > Crate the destination directory if it doesn't already exist. In > verbose mode, tell what is being copied where. > (write_aclocal): Update. > * NEWS, THANKS: Update. > * tests/aclocal-install-fail.test: New test. > * tests/aclocal-install-mkdir.test: Likewise. > * tests/aclocal-no-install-no-mkdir.test: Likewise. > * tests/aclocal-verbose-install.test: Likewise. > * tests/list-of-tests.mk: Add them. > > Signed-off-by: Stefano Lattarini > --- > > I will push this in a couple of days if there is no objection. > Thanks to David and Javier, and sorry for the awful delay. > No objection seen so far, so I've pushed this patch (with minor adjustments, see commit a75a1a52). I'm also closing the relevant bug reports. Regards, Stefano ------------=_1331975882-20542-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Feb 2012 15:00:48 +0000 Received: from localhost ([127.0.0.1]:41558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxgLb-0007zK-M0 for submit@debbugs.gnu.org; Wed, 15 Feb 2012 10:00:48 -0500 Received: from eggs.gnu.org ([140.186.70.92]:57026) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxgLU-0007z1-M2 for submit@debbugs.gnu.org; Wed, 15 Feb 2012 10:00:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxgJd-00037g-Jg for submit@debbugs.gnu.org; Wed, 15 Feb 2012 09:58:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:35727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgJd-00037c-IE for submit@debbugs.gnu.org; Wed, 15 Feb 2012 09:58:41 -0500 Received: from eggs.gnu.org ([140.186.70.92]:59008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgJZ-00061x-7E for bug-automake@gnu.org; Wed, 15 Feb 2012 09:58:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxgJM-00035a-LX for bug-automake@gnu.org; Wed, 15 Feb 2012 09:58:37 -0500 Received: from aibo.runbox.com ([91.220.196.211]:43402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgJM-00035C-GL for bug-automake@gnu.org; Wed, 15 Feb 2012 09:58:24 -0500 Received: from [10.9.9.130] (helo=fenris.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1RxgJI-0002s6-Vk for bug-automake@gnu.org; Wed, 15 Feb 2012 15:58:21 +0100 Received: from mail by fenris.runbox.com with local (Exim 4.50) id 1RxgJI-0007hc-DJ; Wed, 15 Feb 2012 15:58:20 +0100 Content-Type: text/plain; charset="iso-8859-15" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received: from [129.246.80.34] by secure.runbox.com with http (uid:258406) (RMM 4.0); Wed, 15 Feb 2012 14:58:20 GMT From: "David A. Wheeler" To: bug-automake@gnu.org Subject: automake: autoreconf -i fails if macro dir does not exist (it should automatically create new directories) Date: Wed, 15 Feb 2012 09:58:20 -0500 (EST) X-Mailer: RMM Message-Id: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: dwheeler@dwheeler.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: dwheeler@dwheeler.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Problem: "autoreconf -i" fails if you follow the libtool advice and use put this in = configure.ac: AC_CONFIG_MACRO_DIR([m4]) and add "-I m4" to ACLOCAL_AMFLAGS in Makefile.am It will instead report: aclocal: couldn't open directory `m4': No such file or directory autoreconf: aclocal failed with exit status: 1 The whole point of "autoreconf -i" is to create "whatever is needed", and clearly MACRO_DIRs are needed, yet autoreconf fails to do so. Therefor= e, this is a bug. This is *especially* a problem when using the widely-used "git" tool, because "git" does not store empty directories (only files). The symptom is= that you "git clone" a fresh repository, and then "autoreconf -i" fails. You ca= n work around this using: "mkdir m4 ; touch m4/dummy ; git add m4/dummy" or similar, but you shouldn'= t need to work around this at all. This is already a bug report in Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D565663 reported against automake 1.11. Solution: Please patch aclocal (part of automake) to automatically create these direc= tories. A patch has already been created in 2010: http://permalink.gmane.org/gmane.linux.debian.devel.bugs.general/678260 http://permalink.gmane.org/gmane.comp.sysutils.automake.patches/3859 --- David A. Wheeler ------------=_1331975882-20542-1-- From unknown Sat Aug 16 16:55:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Javier =?UTF-8?Q?Jard=EF=BF=BDn?= Subject: bug#8168: closed (Re: bug#10816: [PATCH] aclocal: create local directory where to install m4 files) Message-ID: References: <4F644F66.2020402@gmail.com> <201103032136.52231.stefano.lattarini@gmail.com> X-Gnu-PR-Message: they-closed 8168 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: patch Reply-To: 8168@debbugs.gnu.org Date: Sat, 17 Mar 2012 09:18:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1331975883-20542-3" This is a multi-part message in MIME format... ------------=_1331975883-20542-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #10816: macros directory not created automatically which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8168@debbugs.gnu.org. --=20 10816: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10816 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1331975883-20542-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 10816-done) by debbugs.gnu.org; 17 Mar 2012 09:17:08 +0000 Received: from localhost ([127.0.0.1]:54344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8pl6-0005Jq-8A for submit@debbugs.gnu.org; Sat, 17 Mar 2012 05:17:08 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:44722) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S8pkr-0005J4-PV; Sat, 17 Mar 2012 05:17:05 -0400 Received: by wibhm17 with SMTP id hm17so1671899wib.15 for ; Sat, 17 Mar 2012 01:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=i34b2PJOREKbuBagEHGtIMGZqXLxdMm0ZSzpA1riW0A=; b=G1vEQ4MNijq1fQSFZdoR+Z09BtLnb6czuBcJNbBks91IFWQEzyYkgq48lhovuk008V VLUqfpy+IHFOl6sUddUi8DBH9Fx9LaJxshq+sW4OEvdW6xN4S2nt0w9LZh98YNcX/6cH CnxPufFij3iWkSNzoeAx37cl1xMizLRTrSuU7eERkD8A1RjmExrDq8hWAUSqC3OMTCLt ZR/eznfSPcYejZR0vavdBfn+tuf/4+RFSVRgUM7euscN6A0U5iX75CEkQRgMrqBrAW/p L6YTd18SqKKnrxxLaPwQURP8lhjFfuMRAFDuhOwCPzURG3PWFb6C52z2z8Ul4nYUf9mw OzRQ== Received: by 10.216.131.98 with SMTP id l76mr3217657wei.62.1331973994754; Sat, 17 Mar 2012 01:46:34 -0700 (PDT) Received: from [80.116.81.50] (host50-81-dynamic.116-80-r.retail.telecomitalia.it. [80.116.81.50]) by mx.google.com with ESMTPS id fz9sm5751152wib.3.2012.03.17.01.46.32 (version=SSLv3 cipher=OTHER); Sat, 17 Mar 2012 01:46:33 -0700 (PDT) Message-ID: <4F644F66.2020402@gmail.com> Date: Sat, 17 Mar 2012 09:46:30 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: automake-patches@gnu.org Subject: Re: bug#10816: [PATCH] aclocal: create local directory where to install m4 files References: <9c7254b76bc0016595bf3815213e6c83b62f7a39.1331841335.git.stefano.lattarini@gmail.com> In-Reply-To: <9c7254b76bc0016595bf3815213e6c83b62f7a39.1331841335.git.stefano.lattarini@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10816-done Cc: 10816-done@debbugs.gnu.org, 8168-done@debbugs.gnu.org, dwheeler@dwheeler.com, jjardon@gnome.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 03/15/2012 08:57 PM, Stefano Lattarini wrote: > Fixes automake bug#8168 and bug#10816. > > A call like "aclocal -I m4 --install" used to fail if the 'm4' > directory wasn't pre-existing. This could be particularly > annoying when running in a checked-out version from a VCS like > git, which doesn't allow empty directories to be tracked. > > * aclocal.in (File::Path): New import. > (scan_m4_dirs): Don't die if the first directory of type FT_USER > doesn't exist and the '--install' option was given; that directory > will be created later in ... > (install_file): ... here. Change signature: now it takes as second > argument the destination directory rather than the destination file. > Crate the destination directory if it doesn't already exist. In > verbose mode, tell what is being copied where. > (write_aclocal): Update. > * NEWS, THANKS: Update. > * tests/aclocal-install-fail.test: New test. > * tests/aclocal-install-mkdir.test: Likewise. > * tests/aclocal-no-install-no-mkdir.test: Likewise. > * tests/aclocal-verbose-install.test: Likewise. > * tests/list-of-tests.mk: Add them. > > Signed-off-by: Stefano Lattarini > --- > > I will push this in a couple of days if there is no objection. > Thanks to David and Javier, and sorry for the awful delay. > No objection seen so far, so I've pushed this patch (with minor adjustments, see commit a75a1a52). I'm also closing the relevant bug reports. Regards, Stefano ------------=_1331975883-20542-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Mar 2011 20:37:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvFH4-0002vP-Bx for submit@debbugs.gnu.org; Thu, 03 Mar 2011 15:37:26 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvFH2-0002vB-F1 for submit@debbugs.gnu.org; Thu, 03 Mar 2011 15:37:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PvFGw-0004ez-Cx for submit@debbugs.gnu.org; Thu, 03 Mar 2011 15:37:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:49313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvFGw-0004ev-Ax for submit@debbugs.gnu.org; Thu, 03 Mar 2011 15:37:18 -0500 Received: from [140.186.70.92] (port=57658 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PvFGv-0000by-BM for bug-automake@gnu.org; Thu, 03 Mar 2011 15:37:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PvFGu-0004eQ-EQ for bug-automake@gnu.org; Thu, 03 Mar 2011 15:37:17 -0500 Received: from mail-wy0-f169.google.com ([74.125.82.169]:46790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvFGs-0004e3-8m; Thu, 03 Mar 2011 15:37:14 -0500 Received: by wyi11 with SMTP id 11so1688618wyi.0 for ; Thu, 03 Mar 2011 12:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:references :in-reply-to:cc:mime-version:content-type:content-transfer-encoding :message-id; bh=V0fMSwOuxGqW1/qfySSOmxfIcJivGNmx7fFh4SLcR7s=; b=HBmdKB+e50Dq+QvElt65y1JnanasyEw6fYBwXERKk35Wka4uV7JBDZ5p7LYMx0xOTl UxVtv3zMxOSB4uanz1LdzZJjOEH+Nr/M6yDjFcXBF4vnTu7lJeeIxkkJ3di0zIZlRRHf OkbnGE8/O8B9KNGePTYP1sQI7iVKEFQ1Nz4iA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:references:in-reply-to:cc :mime-version:content-type:content-transfer-encoding:message-id; b=f3o8nXTsQwj/N2ClvIteK2/dap/+Epo3EluFtzMEmQjAXhe2qhqlRgvgedWClTYxy9 cUBHsM3gNqBN4lSNZpLp6bhi5Id9dyrs+xrfLDrI3uDDM2y42Sm2HKa7Tw19jDeA74A4 gYlEkqyOE42FyJzkDQsmv+tdHfmQ2KXPeEi0M= Received: by 10.216.158.21 with SMTP id p21mr976854wek.99.1299184633065; Thu, 03 Mar 2011 12:37:13 -0800 (PST) Received: from bigio.localnet (host30-97-dynamic.0-87-r.retail.telecomitalia.it [87.0.97.30]) by mx.google.com with ESMTPS id m6sm789416wej.10.2011.03.03.12.37.10 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2011 12:37:11 -0800 (PST) From: Stefano Lattarini To: automake@gnu.org Subject: Re: macros directory not created automatically Date: Thu, 3 Mar 2011 21:36:51 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201103032136.52231.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit Cc: bug-automake@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) [adding bug-automake] On Thursday 03 March 2011, Javier Jard=F3n wrote: > Hi, > Hi Javier, and thanks for the report. > I'm using >=20 > ACLOCAL_AMFLAGS =3D -I m4 ${ACLOCAL_FLAGS} >=20 > in my main Makefile.am, but I have to add the m4 directory to the git > tree, or create it in my autogen script (and this doesnt work if I do > not use a autogen file and only autoreconf instead) >=20 > Shouldnt be automake smart enough to create that directory automatically? > Probably yes -- but IMHO it should then also be smart enough to create the directory *only* when it makes sense, i.e. only when the `--install' flag is used too. Also, it might be useful if aclocal would not complain (or at least would not error out) in case it is passed a non-existent or unreadable directory through the `-I' option. This "laxer" behaviour is implemented in many other gnu tools already (e.g., make, m4. gcc). I might take a look at this issues in the next(ish) days. Thanks, Stefano ------------=_1331975883-20542-3--