GNU bug report logs - #10808
gnus-summary-cancel-article does not check from-address of current group

Previous Next

Full log

View this message in rfc822 format

From: Peter Münster <pmlists <at> free.fr>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 10808 <at> debbugs.gnu.org
Subject: bug#10808: gnus-summary-cancel-article does not check from-address of current group
Date: Mon, 03 Feb 2014 01:18:18 +0100

On Sun, Feb 02 2014, Lars Ingebrigtsen wrote:

> Peter Münster <pmlists <at> free.fr> writes:
>
>> I don't know. For me it's quite natural, because of the first `let' in
>> the function:
>>   (let ((message-post-method
>> 	 `(lambda (arg)
>> 	    (gnus-post-method (eq ',symp 'a) ,gnus-newsgroup-name)))
>> 	(user-mail-address user-mail-address))
>> `user-mail-address' gets the value of `user-mail-address'.
>
> The code looks like this:
>
>   (let ((message-post-method
> 	 `(lambda (arg)
> 	    (gnus-post-method (eq ',symp 'a) ,gnus-newsgroup-name)))
> 	(user-mail-address user-mail-address))
>
> [...]
>
> 		(setq user-mail-address
> 		      (car (mail-header-parse-address from)))))
> 	    (kill-buffer (current-buffer))))
>
> The interesting bit is what `user-mail-address' is after the `setq'
> there.

Hi Lars,

`user-mail-address' is "pmlists <at> free.fr" after the `setq'. So it's the
right address. But this is dead code, isn't it?
It's the `user-mail-address' of the `let', not the global one. And it's
no more used after the `setq'.

Inside the `message-cancel-news' function, the value of
`user-mail-address' is still "pmrb <at> free.fr"...

-- 
           Peter

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.