From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 17:30:12 2012 Received: (at submit) by debbugs.gnu.org; 13 Feb 2012 22:30:12 +0000 Received: from localhost ([127.0.0.1]:39330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rx4PT-0002UN-Lp for submit@debbugs.gnu.org; Mon, 13 Feb 2012 17:30:11 -0500 Received: from eggs.gnu.org ([140.186.70.92]:51197) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rx4PO-0002TU-LL for submit@debbugs.gnu.org; Mon, 13 Feb 2012 17:30:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rx4No-0005gW-2r for submit@debbugs.gnu.org; Mon, 13 Feb 2012 17:28:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:59838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx4No-0005gS-1N for submit@debbugs.gnu.org; Mon, 13 Feb 2012 17:28:28 -0500 Received: from eggs.gnu.org ([140.186.70.92]:49542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx4Nn-0004pk-5J for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2012 17:28:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rx4Nl-0005gA-Uy for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2012 17:28:27 -0500 Received: from fmmailgate04.web.de ([217.72.192.242]:57093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx4Nl-0005fv-QC for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2012 17:28:25 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate04.web.de (Postfix) with ESMTP id AD66A7184299 for ; Mon, 13 Feb 2012 23:28:17 +0100 (CET) Received: from snow.dragon ([82.113.119.109]) by smtp.web.de (mrweb001) with ESMTPA (Nemesis) id 0LlFOY-1SXlyh0UKs-00aquX; Mon, 13 Feb 2012 23:28:17 +0100 Date: Mon, 13 Feb 2012 23:29:39 +0100 Message-Id: <87y5s6l63w.fsf@web.de> From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer X-Provags-ID: V02:K0:6Ndh+Z2oldkXVBgZ/xJfcpJR+qDI2Fe4X+ihgrtcS51 yMMWkfpFaDHH3+NgSAw8QHkk1hADg4owtGuuUlSaGoh3cT6tEK Zg1Szn/LNdCA2/XTAo3LjIds75zBfqWi2K22LQ/7N8T/2QEd3p DG72zgdxG17aloCnXCUAZk4N15KEjI739/yEZwPlbfXY1Kv170 4XWNidU31VP/lpdl19b3WRXqRlVbPf30HIR7XECV88= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) E.g. 1. emacs -Q 2. I write this into the scratch buffer: (defun f (x) (if (> x 0) (* x (f (1- x))) 0)) and do M-1 C-M-x 3. M-: (setq edebug-trace t) RET 4. M-: (f 5) RET Then, "{ f args: (5)" is inserted into *scratch*. The bug is related to this commented code at the end of `edebug-pop-to-buffer': ;; Selecting the window does not set the buffer until command loop. ;;(set-buffer buffer) If I uncomment this call to `set-buffer', the problem disappears. Seems the one who commented this line of code wanted to test if it is (still) needed - seems it is. Thanks, Michael. In GNU Emacs 24.0.93.1 (i486-pc-linux-gnu, GTK+ Version 3.2.3) of 2012-02-08 on zelenka, modified by Debian (emacs-snapshot package, version 2:20120208-1) Windowing system distributor `The X.Org Foundation', version 11.0.11103901 Configured using: `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.0.93/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.0.93/site-lisp:/usr/share/emacs/site-lisp' '--without-compress-info' '--with-crt-dir=/usr/lib/i386-linux-gnu/' '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2'' From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 05:55:34 2012 Received: (at 10805) by debbugs.gnu.org; 14 Feb 2012 10:55:34 +0000 Received: from localhost ([127.0.0.1]:39707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxG2n-0003WR-Vf for submit@debbugs.gnu.org; Tue, 14 Feb 2012 05:55:34 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:45207) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1RxG2l-0003WD-5R for 10805@debbugs.gnu.org; Tue, 14 Feb 2012 05:55:32 -0500 Received: (qmail invoked by alias); 14 Feb 2012 10:53:48 -0000 Received: from 62-47-58-233.adsl.highway.telekom.at (EHLO [62.47.58.233]) [62.47.58.233] by mail.gmx.net (mp029) with SMTP; 14 Feb 2012 11:53:48 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX191Ns4tS4N1VrmsRw31oaCZiiVKF0ESUth++qP11Z NXdVJTGK5Qf7Vp Message-ID: <4F3A3D3C.8020002@gmx.at> Date: Tue, 14 Feb 2012 11:53:48 +0100 From: martin rudalics MIME-Version: 1.0 To: michael_heerdegen@web.de Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> In-Reply-To: <87y5s6l63w.fsf@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10805 Cc: 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > 1. emacs -Q > 2. I write this into the scratch buffer: > (defun f (x) (if (> x 0) (* x (f (1- x))) 0)) > and do M-1 C-M-x > 3. M-: (setq edebug-trace t) RET > 4. M-: (f 5) RET > > Then, "{ f args: (5)" is inserted into *scratch*. > > The bug is related to this commented code at the end of > `edebug-pop-to-buffer': > > ;; Selecting the window does not set the buffer until command loop. > ;;(set-buffer buffer) > > If I uncomment this call to `set-buffer', the problem disappears. > > Seems the one who commented this line of code wanted to test if it is > (still) needed - seems it is. More or less so, yes. This is yet another incarnation of the "unless WINDOW already is the selected window, its buffer becomes the current buffer" problem of `select-window'. We have three possibilites to fix this: (1) Fix this in `select-window' and friends. This should be done sooner or later but I'm not sure whether "now" is the right moment. (2) Fix this by uncommenting the line above. I suppose, however, that line was commented out on purpose, hence we might experience more surprises in edebug. (3) Do something like the patch below. This is the most conservative approach and will consequently fail to fix similar problems. Note also that my experience with `edebug-trace' is zero. martin *** lisp/emacs-lisp/edebug.el 2012-01-19 07:21:25 +0000 --- lisp/emacs-lisp/edebug.el 2012-02-14 10:43:52 +0000 *************** *** 4129,4146 **** ;; (point) (window-start)) (let* ((oldbuf (current-buffer)) (selected-window (selected-window)) ! (buffer (get-buffer-create buf-name)) ! buf-window) ;; (message "before pop-to-buffer") (sit-for 1) (edebug-pop-to-buffer buffer) ! (setq truncate-lines t) ! (setq buf-window (selected-window)) ! (goto-char (point-max)) ! (insert (apply 'edebug-format fmt args) "\n") ! ;; Make it visible. ! (vertical-motion (- 1 (window-height))) ! (set-window-start buf-window (point)) ! (goto-char (point-max)) ;; (set-window-point buf-window (point)) ;; (edebug-sit-for 0) (bury-buffer buffer) --- 4129,4145 ---- ;; (point) (window-start)) (let* ((oldbuf (current-buffer)) (selected-window (selected-window)) ! (buffer (get-buffer-create buf-name))) ;; (message "before pop-to-buffer") (sit-for 1) (edebug-pop-to-buffer buffer) ! (with-current-buffer buffer ! (setq truncate-lines t) ! (goto-char (point-max)) ! (insert (apply 'edebug-format fmt args) "\n") ! ;; Make it visible. ! (vertical-motion (- 1 (window-height))) ! (set-window-start nil (point)) ! (goto-char (point-max))) ;; (set-window-point buf-window (point)) ;; (edebug-sit-for 0) (bury-buffer buffer) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 18:54:10 2012 Received: (at 10805) by debbugs.gnu.org; 14 Feb 2012 23:54:11 +0000 Received: from localhost ([127.0.0.1]:40768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxSCI-0001Aw-Am for submit@debbugs.gnu.org; Tue, 14 Feb 2012 18:54:10 -0500 Received: from fmmailgate05.web.de ([217.72.192.243]:37379) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxSCG-0001Aj-Ou for 10805@debbugs.gnu.org; Tue, 14 Feb 2012 18:54:09 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate05.web.de (Postfix) with ESMTP id 84E7969AD8BD for <10805@debbugs.gnu.org>; Wed, 15 Feb 2012 00:52:23 +0100 (CET) Received: from snow.dragon ([89.204.139.35]) by smtp.web.de (mrweb001) with ESMTPA (Nemesis) id 0MDxWR-1Ripy50euF-00HWME; Wed, 15 Feb 2012 00:52:23 +0100 From: Michael Heerdegen To: martin rudalics Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> <4F3A3D3C.8020002@gmx.at> Date: Wed, 15 Feb 2012 00:53:44 +0100 In-Reply-To: <4F3A3D3C.8020002@gmx.at> (martin rudalics's message of "Tue, 14 Feb 2012 11:53:48 +0100") Message-ID: <87vcn97z07.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V02:K0:3M+NF18+9DTt7KezfEvdr0gjFJOvQ6dFQcgjdP4HHkl tZaw/MtRJYhjtfwsfoX2k59k/InV1kUpMhitbajf/oxQk0wh6y Ers/q2qnoCf6AN6a6WxW+7IOXVJANSySn4lrcoJSAcPgEsCMMM s+yLN3jA1XqzmSL686W52MNxJatnOkoTS/OUXAms2HSogsibXO EDNQidYdIY/+vbJ64z6sDKujkEi92knoox15J7XR98= X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10805 Cc: 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Note that my experience with `edebug-trace' is also zero, I only tried it out, so take my comments with some care. > More or less so, yes. This is yet another incarnation of the "unless > WINDOW already is the selected window, its buffer becomes the current > buffer" problem of `select-window'. Maybe. But please keep in mind that `edebug-trace-display' is about _displaying_ a buffer. We don't want the user to edit the trace buffer, so calling `select-window' is in fact not necessary in this case. The former window is instantly re-selected by `edebug-trace-display'. Please also note (another issue, but related) that if the trace buffer is already visible in another (visible) frame, a new window pops up in the current frame nevertheless, which is kind of annoying if source files are spread over multiple frames. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 04:58:27 2012 Received: (at 10805) by debbugs.gnu.org; 15 Feb 2012 09:58:27 +0000 Received: from localhost ([127.0.0.1]:41073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rxbd5-0000HV-EN for submit@debbugs.gnu.org; Wed, 15 Feb 2012 04:58:27 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:33744) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1Rxbd0-0000HD-4D for 10805@debbugs.gnu.org; Wed, 15 Feb 2012 04:58:26 -0500 Received: (qmail invoked by alias); 15 Feb 2012 09:56:34 -0000 Received: from 62-47-41-132.adsl.highway.telekom.at (EHLO [62.47.41.132]) [62.47.41.132] by mail.gmx.net (mp028) with SMTP; 15 Feb 2012 10:56:34 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18YzJNS2c4YhOUHjqHdSYNGmasb3IwuRFU8CcwzO+ +/Iyh9cdZ2pMIC Message-ID: <4F3B814D.3060607@gmx.at> Date: Wed, 15 Feb 2012 10:56:29 +0100 From: martin rudalics MIME-Version: 1.0 To: Michael Heerdegen Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> <4F3A3D3C.8020002@gmx.at> <87vcn97z07.fsf@web.de> In-Reply-To: <87vcn97z07.fsf@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10805 Cc: 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Maybe. But please keep in mind that `edebug-trace-display' is about > _displaying_ a buffer. We don't want the user to edit the trace buffer, > so calling `select-window' is in fact not necessary in this case. The > former window is instantly re-selected by `edebug-trace-display'. IIUC edebug conflates the concepts of displaying and popping to buffers. Take `edebug-bounce-point': (save-excursion ;; If the buffer's currently displayed, avoid set-window-configuration. ---> Since `save-window-excursion' calls `set-window-configuration' we don't "avoid" anything here. (save-window-excursion (edebug-pop-to-buffer edebug-outside-buffer) ---> Here the `select-window' problem might strike as well. But why should the window be selected? To make `goto-char', `current-buffer' and `point' work? (goto-char edebug-outside-point) (message "Current buffer: %s Point: %s Mark: %s" (current-buffer) (point) (if (marker-buffer (edebug-mark-marker)) (marker-position (edebug-mark-marker)) "")) (edebug-sit-for arg) ---> Popping back to the original window as the _last_ action of a `save-window-excursion' doesn't make any sense. (edebug-pop-to-buffer edebug-buffer (car edebug-window-data))))) This may select a window up to three times for the apparent single purpose to display the context of a position in some buffer. > Please also note (another issue, but related) that if the trace buffer > is already visible in another (visible) frame, a new window pops up in > the current frame nevertheless, which is kind of annoying if source > files are spread over multiple frames. Probably because `edebug-get-buffer-window' (aliased to `get-buffer-window') is called with a nil ALL-FRAMES argument. Try to use another argument (you probably have to raise frames to make this useful). martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 21:19:08 2012 Received: (at 10805) by debbugs.gnu.org; 17 Feb 2012 02:19:08 +0000 Received: from localhost ([127.0.0.1]:43104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyDPf-00033R-S7 for submit@debbugs.gnu.org; Thu, 16 Feb 2012 21:19:08 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:40381) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyDPZ-00032t-Im for 10805@debbugs.gnu.org; Thu, 16 Feb 2012 21:19:06 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 902AD1C25099B for <10805@debbugs.gnu.org>; Fri, 17 Feb 2012 03:17:04 +0100 (CET) Received: from snow.dragon ([89.204.139.100]) by smtp.web.de (mrweb002) with ESMTPA (Nemesis) id 0MEmKo-1RjJ923VFq-00Fj9D; Fri, 17 Feb 2012 03:17:04 +0100 From: Michael Heerdegen To: martin rudalics Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> <4F3A3D3C.8020002@gmx.at> <87vcn97z07.fsf@web.de> <4F3B814D.3060607@gmx.at> Date: Fri, 17 Feb 2012 03:18:24 +0100 In-Reply-To: <4F3B814D.3060607@gmx.at> (martin rudalics's message of "Wed, 15 Feb 2012 10:56:29 +0100") Message-ID: <878vk2kxsf.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V02:K0:3/jcdJG3o7YDfoVETtBdo3l4hvA6Qp+Axir4j2mh9PQ cAUkd3Gb3v1ykUes1SexmvJb/kg15BQQ0hw3meCgdiI3O3Ixzz kQQSf/kHGtVmDKIkZT/xNTM3kSOjZ09tXkP0Xk2Zkw4p49gD/m aArFs6jIRA3WUrUefHAtrpJzqW4ICa2idUYHsW/a6OgcOP8o2z pv1nP6dzkU0hbwk6sVfBPpfPbX5qFZ/73OkkNAufIQ= X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10805 Cc: 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) martin rudalics writes: > IIUC edebug conflates the concepts of displaying and popping to buffers. > Take `edebug-bounce-point': > > (save-excursion > ;; If the buffer's currently displayed, avoid set-window-configuration. > ---> Since `save-window-excursion' calls `set-window-configuration' > we don't "avoid" anything here. > (save-window-excursion > (edebug-pop-to-buffer edebug-outside-buffer) > ---> Here the `select-window' problem might strike as well. But > why should the window be selected? To make `goto-char', > `current-buffer' and `point' work? > (goto-char edebug-outside-point) > (message "Current buffer: %s Point: %s Mark: %s" > (current-buffer) (point) > (if (marker-buffer (edebug-mark-marker)) > (marker-position (edebug-mark-marker)) "")) > (edebug-sit-for arg) > ---> Popping back to the original window as the _last_ action of > a `save-window-excursion' doesn't make any sense. > (edebug-pop-to-buffer edebug-buffer (car edebug-window-data))))) > > This may select a window up to three times for the apparent single > purpose to display the context of a position in some buffer. I agree, I see no reason for doing this. > > Please also note (another issue, but related) that if the trace buffer > > is already visible in another (visible) frame, a new window pops up in > > the current frame nevertheless, which is kind of annoying if source > > files are spread over multiple frames. > > Probably because `edebug-get-buffer-window' (aliased to > `get-buffer-window') is called with a nil ALL-FRAMES argument. Try to > use another argument (you probably have to raise frames to make this > useful). Yes, of course, that works. The same applies to the source code buffers. Maybe we could introduce a user option specifying if windows in other (visible) frames should be considered or not. Dunno if that would be appropriate, I didn't use edebug much before. Currently, edebug never considers other frames (most of the code seems to have been written at a time when Emacs did not yet have frames). Some users might find it handy if they could use source buffers spread over several frames, and edebug would work with them. Michael From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 05:00:50 2012 Received: (at 10805) by debbugs.gnu.org; 17 Feb 2012 10:00:50 +0000 Received: from localhost ([127.0.0.1]:43348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyKcU-00061k-4G for submit@debbugs.gnu.org; Fri, 17 Feb 2012 05:00:50 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:34635) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1RyKcO-00061L-Ui for 10805@debbugs.gnu.org; Fri, 17 Feb 2012 05:00:46 -0500 Received: (qmail invoked by alias); 17 Feb 2012 09:58:46 -0000 Received: from 62-47-62-21.adsl.highway.telekom.at (EHLO [62.47.62.21]) [62.47.62.21] by mail.gmx.net (mp020) with SMTP; 17 Feb 2012 10:58:46 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19/tTcDLVt/Tbc1vLT/0CyXbdr+/2dfBUij/SlOB8 jYtMdyWVDvrC9K Message-ID: <4F3E24D5.7090003@gmx.at> Date: Fri, 17 Feb 2012 10:58:45 +0100 From: martin rudalics MIME-Version: 1.0 To: michael_heerdegen@web.de Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> <4F3A3D3C.8020002@gmx.at> <87vcn97z07.fsf@web.de> <4F3B814D.3060607@gmx.at> <878vk2kxsf.fsf@web.de> In-Reply-To: <878vk2kxsf.fsf@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10805 Cc: 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Yes, of course, that works. The same applies to the source code > buffers. Maybe we could introduce a user option specifying if windows > in other (visible) frames should be considered or not. Dunno if that > would be appropriate, I didn't use edebug much before. Currently, > edebug never considers other frames (most of the code seems to have been > written at a time when Emacs did not yet have frames). Some users might > find it handy if they could use source buffers spread over several > frames, and edebug would work with them. Adding an appropriate rule for these buffers to `display-buffer-alist' should be the appropriate solution. The problem is that it's non-trivial to identify source code buffers in `display-buffer-alist'. For example, in the case that the user wants to make buffer display via edebug behave differently from via `find-file'. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 10:14:57 2012 Received: (at 10805) by debbugs.gnu.org; 17 Feb 2012 15:14:58 +0000 Received: from localhost ([127.0.0.1]:43808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyPWT-0006Ur-PP for submit@debbugs.gnu.org; Fri, 17 Feb 2012 10:14:57 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34552) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyPWS-0006Uk-1z for 10805@debbugs.gnu.org; Fri, 17 Feb 2012 10:14:57 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q1HFD0u0009938; Fri, 17 Feb 2012 10:13:00 -0500 Received: by pastel.home (Postfix, from userid 20848) id D824F593DD; Fri, 17 Feb 2012 10:12:59 -0500 (EST) From: Stefan Monnier To: martin rudalics Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer Message-ID: References: <87y5s6l63w.fsf@web.de> <4F3A3D3C.8020002@gmx.at> <87vcn97z07.fsf@web.de> <4F3B814D.3060607@gmx.at> <878vk2kxsf.fsf@web.de> <4F3E24D5.7090003@gmx.at> Date: Fri, 17 Feb 2012 10:12:59 -0500 In-Reply-To: <4F3E24D5.7090003@gmx.at> (martin rudalics's message of "Fri, 17 Feb 2012 10:58:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4135=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4135> : streams <729564> : uri <1067186> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 10805 Cc: michael_heerdegen@web.de, 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > For example, in the case that the user wants to make buffer display via > edebug behave differently from via `find-file'. You can check whether the buffer is in `edebug-mode'. This may require some tweaks in edebug.el (e.g. I'm not sure whether edebug-mode is set before or after displaying the buffer currently, and IIRC edebug-mode is neither a proper major-mode nor a proper minor-mode so you'll probably have to detect it in an ad-hoc way, or change edebug.el to use a proper major/minor mode). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 12:06:46 2012 Received: (at 10805) by debbugs.gnu.org; 18 Feb 2012 17:06:46 +0000 Received: from localhost ([127.0.0.1]:44875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RynkD-0001zN-Ub for submit@debbugs.gnu.org; Sat, 18 Feb 2012 12:06:46 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:53554) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1RynkB-0001zA-Jc for 10805@debbugs.gnu.org; Sat, 18 Feb 2012 12:06:45 -0500 Received: (qmail invoked by alias); 18 Feb 2012 17:04:36 -0000 Received: from 62-47-46-255.adsl.highway.telekom.at (EHLO [62.47.46.255]) [62.47.46.255] by mail.gmx.net (mp069) with SMTP; 18 Feb 2012 18:04:36 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/vOvRnU9PvFsso5myRQDi2Ji0DLIv4iVcMGNzJA7 XasogIHSwvy+E4 Message-ID: <4F3FDA24.50900@gmx.at> Date: Sat, 18 Feb 2012 18:04:36 +0100 From: martin rudalics MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> <4F3A3D3C.8020002@gmx.at> <87vcn97z07.fsf@web.de> <4F3B814D.3060607@gmx.at> <878vk2kxsf.fsf@web.de> <4F3E24D5.7090003@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10805 Cc: michael_heerdegen@web.de, 10805@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > You can check whether the buffer is in `edebug-mode'. This may require > some tweaks in edebug.el (e.g. I'm not sure whether edebug-mode is set > before or after displaying the buffer currently, and IIRC edebug-mode is > neither a proper major-mode nor a proper minor-mode so you'll probably > have to detect it in an ad-hoc way, or change edebug.el to use a proper > major/minor mode). IIUC `edebug-active' is the variable to consult in this case. But the plethora of declared and undocumented variables and aliased functions in edebug.el is overwhelming. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 04 09:17:48 2012 Received: (at 10805-done) by debbugs.gnu.org; 4 Oct 2012 13:17:48 +0000 Received: from localhost ([127.0.0.1]:52596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJlJ9-0005XQ-Pb for submit@debbugs.gnu.org; Thu, 04 Oct 2012 09:17:48 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:57361) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1TJlJ6-0005XC-4c for 10805-done@debbugs.gnu.org; Thu, 04 Oct 2012 09:17:41 -0400 Received: (qmail invoked by alias); 04 Oct 2012 13:17:29 -0000 Received: from 62-47-48-227.adsl.highway.telekom.at (EHLO [62.47.48.227]) [62.47.48.227] by mail.gmx.net (mp028) with SMTP; 04 Oct 2012 15:17:29 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/azi4aHIraBjQdGrxFRF5KqlporBgol1fqXmn23x CelarKdlp2i/Cf Message-ID: <506D8C82.1020202@gmx.at> Date: Thu, 04 Oct 2012 15:17:54 +0200 From: martin rudalics MIME-Version: 1.0 To: 10805-done@debbugs.gnu.org Subject: Re: bug#10805: 24.0.93; edebug-trace t may cause stuff being inserted into current buffer References: <87y5s6l63w.fsf@web.de> In-Reply-To: <87y5s6l63w.fsf@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10805-done Cc: michael_heerdegen@web.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > 1. emacs -Q > 2. I write this into the scratch buffer: > (defun f (x) (if (> x 0) (* x (f (1- x))) 0)) > and do M-1 C-M-x > 3. M-: (setq edebug-trace t) RET > 4. M-: (f 5) RET > > Then, "{ f args: (5)" is inserted into *scratch*. Should be fixed with revision 110359 on trunk. Bug closed. Thanks, martin From unknown Thu Aug 21 12:11:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Nov 2012 11:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator