Subject: bug#10760: 24.0.93; [patch] Convert artist-mode to use define-minor-mode

From: Stefan Monnier <[email-masked]>
Date: Wed, 08 Feb 2012 14:25:20 -0500

Thank you.

> - (defvar artist-mode-map

The keymap does not have to be defined within the call to
define-minor-mode (actually I recommend you don't do that in general),
so you can leave the (defvar artist-mode-map ...) untouched.

> ! (defun artist-mode-init ()
[...]
> ! (defun artist-mode-exit ()

You can also keep these functions.  This will significantly reduce the
size of your patch and will make it much easier to figure out what is
really changed (and hence, whether or not the change is safe).

> !   :init-value nil   :group 'artist :lighter " Artist"

You should use artist-mode-name here.

        Stefan "who actually prefers `diff -u' format"