From unknown Fri Jun 20 20:10:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#1075 <1075@debbugs.gnu.org> To: bug#1075 <1075@debbugs.gnu.org> Subject: Status: 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color Reply-To: bug#1075 <1075@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:10:41 +0000 retitle 1075 23.0.60; [NS] wrong number of arguments in call to ns_free_ind= exed_color reassign 1075 emacs,ns submitter 1075 Lennart Staflin severity 1075 normal thanks From lenst@lysator.liu.se Fri Oct 3 07:39:26 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Oct 2008 14:39:26 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93EdI15006310 for ; Fri, 3 Oct 2008 07:39:19 -0700 Received: from mx10.gnu.org ([199.232.76.166]:39594) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kllm9-0004NV-4R for emacs-pretest-bug@gnu.org; Fri, 03 Oct 2008 10:37:01 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KlloH-0006uL-NB for emacs-pretest-bug@gnu.org; Fri, 03 Oct 2008 10:39:17 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:35838) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KlloH-0006tN-AZ for emacs-pretest-bug@gnu.org; Fri, 03 Oct 2008 10:39:13 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id A3ABC40018 for ; Fri, 3 Oct 2008 16:39:10 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1674) id 9756040029; Fri, 3 Oct 2008 16:39:10 +0200 (CEST) Received: from [172.17.0.4] (90-227-135-28-no52.tbcn.telia.com [90.227.135.28]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTP id F2C7840018 for ; Fri, 3 Oct 2008 16:39:07 +0200 (CEST) Message-ID: <48E62E8B.5010905@lysator.liu.se> Date: Fri, 03 Oct 2008 16:39:07 +0200 From: Lennart Staflin User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) After a crash I with ns_free_indexed_color, and x_clear_image_1 on the stack. I noticed that x_clear_image_1 calls ns_free_indexed_color with only one argument, but it takes two arguments. Perhaps that explains a number of crashes in ns_free_indexed_color. //Lennart Staflin In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0) of 2008-10-03 on sin Windowing system distributor `Apple', version 49.46.48 configured using `configure '--with-ns' '--enable-maintainer-mode' '--without-x' '--with-jpeg' '--with-gif' '--with-png' 'CFLAGS=-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: show-paren-mode: t auto-insert-mode: t iswitchb-mode: t partial-completion-mode: t recentf-mode: t cua-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t global-auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: M-x r e p o r t SPC b u g Recent messages: Loading /Users/lenst/emacs/lenst-lisp/loaddefs.el (source)...done Loading /Users/lenst/emacs/lenst-lisp/suck.el (source)...done Loading ~/emacs/lenst-lisp/lenst...done Loading /Users/lenst/emacs/lisp/loaddefs.el (source)...done Loading /Users/lenst/src/emorb/loaddefs.el (source)...done Loading /Users/lenst/.recentf...done Cleaning up the recentf list...done (0 removed) Loading paren...done Loading /Users/lenst/.emacs-records...done For information about GNU Emacs and the GNU system, type C-h C-a. From rgm@gnu.org Fri Oct 3 09:55:29 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 3 Oct 2008 16:55:29 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93GtQxi008857 for ; Fri, 3 Oct 2008 09:55:27 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Klnts-0000sO-8p; Fri, 03 Oct 2008 12:53:08 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18662.19956.166654.505905@fencepost.gnu.org> Date: Fri, 3 Oct 2008 12:53:08 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: YN_B2-0?q'1B0y.i,.?ZMC|.%)a X-Debbugs-No-Ack: yes merge 1070 1076 reassign 1075 emacs,ns From geb-bug-gnu-emacs@m.gmane.org Fri Oct 3 10:25:49 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, IMPRONONCABLE_1,IMPRONONCABLE_2,MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2, PHONENUMBER,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Oct 2008 17:25:49 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93HPgWt016838 for ; Fri, 3 Oct 2008 10:25:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KloPN-00005h-2v for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 13:25:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KloPL-00004s-G7 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 13:25:40 -0400 Received: from [199.232.76.173] (port=51216 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KloPL-0008WV-6F for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 13:25:39 -0400 Received: from main.gmane.org ([80.91.229.2]:49426 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KloPJ-0004Yn-N2 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 13:25:39 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KloP8-0007Hi-Ok for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 17:25:27 +0000 Received: from p54980d1b.dip0.t-ipconnect.de ([84.152.13.27]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 03 Oct 2008 17:25:26 +0000 Received: from harald by p54980d1b.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 03 Oct 2008 17:25:26 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Harald Maier Subject: Re: bug#1075: 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color Followup-To: gmane.emacs.pretest.bugs Date: Fri, 03 Oct 2008 19:24:54 +0200 Lines: 251 Message-ID: References: <48E62E8B.5010905@lysator.liu.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: p54980d1b.dip0.t-ipconnect.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (darwin) Cancel-Lock: sha1:YuKOPi70NzXnbntvuiTx+B+s8jo= Sender: news Cc: emacs-pretest-bug@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Lennart Staflin writes: > After a crash I with ns_free_indexed_color, and x_clear_image_1 on the > stack. I noticed that x_clear_image_1 calls ns_free_indexed_color with > only one argument, but it takes two arguments. Perhaps that explains a > number of crashes in ns_free_indexed_color. > > //Lennart Staflin > > > In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0) > of 2008-10-03 on sin > Windowing system distributor `Apple', version 49.46.48 > configured using `configure '--with-ns' '--enable-maintainer-mode' > --without-x' '--with-jpeg' '--with-gif' '--with-png' 'CFLAGS=-g'' I am facing this bug too. Here is a full backtrace. It happens for me intermittent. Harald Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_PROTECTION_FAILURE at address: 0x00000028 0x0015e306 in ns_free_indexed_color (idx=0, f=0x0) at nsterm.m:1310 (gdb) bt #0 0x0015e306 in ns_free_indexed_color (idx=0, f=0x0) at nsterm.m:1310 #1 0x0018513a in x_clear_image_1 (f=, img=0x195778f0, pixmap_p=, mask_p=1, colors_p=1) at image.c:1627 #2 0x00184b93 in free_image (f=0x0, img=0x195778f0) at image.c:1322 #3 0x001854db in clear_image_cache (f=0x8b7150, filter=25165833) at image.c:1836 #4 0x001855b6 in clear_image_caches (filter=25165833) at image.c:1873 #5 0x00035868 in redisplay_internal (preserve_echo_area=) at xdisp.c:12060 #6 0x00035d28 in redisplay_preserve_echo_area (from_where=13) at xdisp.c:12094 #7 0x00146de7 in status_notify (deleting_process=0x0) at process.c:6906 #8 0x001498dc in wait_reading_process_output (time_limit=30, microsecs=0, read_kbd=-1, do_display=1, wait_for_cell=25165833, wait_proc=0x0, just_wait_proc=0) at process.c:4678 #9 0x0000c296 in sit_for (timeout=240, reading=1, do_display=1) at dispnew.c:6619 #10 0x0009bbf8 in read_char (commandflag=1, nmaps=6, maps=0xbfffdfd0, prev_event=25165833, used_mouse_menu=0xbfffe0d8, end_time=0x0) at keyboard.c:2895 #11 0x0009dc3b in read_key_sequence (keybuf=0xbfffe198, bufsize=30, prompt=25165833, dont_downcase_last=0, can_return_switch_frame=1, fix_current_buffer=1) at keyboard.c:9349 #12 0x000a012a in command_loop_1 () at keyboard.c:1620 #13 0x00101ffd in internal_condition_case (bfun=0x9fef0 , handlers=25205497, hfun=0x96ba0 ) at eval.c:1511 #14 0x0008ff38 in command_loop_2 () at keyboard.c:1338 #15 0x00101edc in internal_catch (tag=0, func=0x8fef0 , arg=25165833) at eval.c:1247 #16 0x0008fc8e in command_loop () at keyboard.c:1317 #17 0x0008fd52 in recursive_edit_1 () at keyboard.c:942 #18 0x0008fed1 in Frecursive_edit () at keyboard.c:1004 #19 0x0008eb6b in main (argc=1, argv=0xbfffe5a4) at emacs.c:1689 (gdb) bt full #0 0x0015e306 in ns_free_indexed_color (idx=0, f=0x0) at nsterm.m:1310 color_table = #1 0x0018513a in x_clear_image_1 (f=, img=0x195778f0, pixmap_p=, mask_p=1, colors_p=1) at image.c:1627 No locals. #2 0x00184b93 in free_image (f=0x0, img=0x195778f0) at image.c:1322 c = (struct image_cache *) 0x16f0c540 #3 0x001854db in clear_image_cache (f=0x8b7150, filter=25165833) at image.c:1836 img = (struct image *) 0x195778f0 t = { tv_sec = 1218913349, tv_usec = 686755 } old = 1218911549 i = 3 nfreed = 2 c = (struct image_cache *) 0x16f0c540 #4 0x001855b6 in clear_image_caches (filter=25165833) at image.c:1873 tail = 4300800 #5 0x00035868 in redisplay_internal (preserve_echo_area=) at xdisp.c:12060 w = (struct window *) 0x195978f0 f = pause = 0 must_finish = 1 tlbufpos = { charpos = 425537696, bytepos = 425537696 } number_of_visible_frames = 1 polling_stopped_here = 1 old_frame = 9138516 consider_all_windows_p = #6 0x00035d28 in redisplay_preserve_echo_area (from_where=13) at xdisp.c:12094 No locals. #7 0x00146de7 in status_notify (deleting_process=0x0) at process.c:6906 proc = 422480020 buffer = 425665812 tail = msg = 51929347 #8 0x001498dc in wait_reading_process_output (time_limit=30, microsecs=0, read_kbd=-1, do_display=1, wait_for_cell=25165833, wait_proc=0x0, just_wait_proc=0) at process.c:4678 Atemp = { fds_bits = {0 } } Ctemp = { fds_bits = {0 } } timeout_reduced_for_timers = 1 channel = nfds = 1 Available = { fds_bits = {128, 0 } } Connecting = { fds_bits = {0 } } check_connect = 0 check_delay = 0 no_avail = xerrno = proc = timeout = { tv_sec = 0, tv_usec = 0 } end_time = { tv_sec = 1218913379, tv_usec = 636576 } wait_channel = -1 got_some_input = 1 #9 0x0000c296 in sit_for (timeout=240, reading=1, do_display=1) at dispnew.c:6619 sec = usec = 0 #10 0x0009bbf8 in read_char (commandflag=1, nmaps=6, maps=0xbfffdfd0, prev_event=25165833, used_mouse_menu=0xbfffe0d8, end_time=0x0) at keyboard.c:2895 tem0 = delay_level = 4 buffer_size = c = 25165833 count = jmpcount = 2 local_getcjmp = {918399, 0, 8098, 633595, 981200, 3440316, 0, 3440316, -1073750152, -1073750544, 25165855, 662, 635534, 23, 31, 31, 33554432, -1073807305} save_jump = {0 } key_already_recorded = 0 tem = save = previous_echo_area_message = 25165833 also_record = 25165833 reread = 0 polling_stopped_here = orig_kboard = (struct kboard *) 0x83b140 #11 0x0009dc3b in read_key_sequence (keybuf=0xbfffe198, bufsize=30, prompt=25165833, dont_downcase_last=0, can_return_switch_frame=1, fix_current_buffer=1) at keyboard.c:9349 interrupted_kboard = (KBOARD *) 0x83b140 key = 1058327 used_mouse_menu = 0 echo_local_start = 0 last_real_key_start = 0 keys_local_start = 0 local_first_binding = 0 from_string = 25165833 count = 2 t = 0 echo_start = 0 keys_start = 0 nmaps = 6 nmaps_allocated = 6 defs = (Lisp_Object * volatile) 0xbfffdfa0 submaps = (Lisp_Object * volatile) 0xbfffdfd0 orig_local_map = 50222101 orig_keymap = 25165833 localized_local_map = 0 first_binding = 0 first_unbound = 31 mock_input = 0 fkey = { parent = 4941253, map = 4941253, start = 0, end = 0 } keytran = { parent = 4386685, map = 4386685, start = 0, end = 0 } indec = { parent = 4941261, map = 4941261, start = 0, end = 0 } shift_translated = 0 delayed_switch_frame = 25165833 original_uppercase = -1073749720 original_uppercase_position = -1 starting_buffer = (struct buffer *) 0x19523aa0 fake_prefixed_keys = 25165833 #12 0x000a012a in command_loop_1 () at keyboard.c:1620 cmd = lose = nonundocount = 0 keybuf = {35523785, 617387, 3441000, 25165833, -1073749464, 617600, 366757405, -1073749538, -1073749512, -1880941328, 4301001, 152, -1073749538, 25165833, 1, 10, 0, -1895817300, 6307477, 1, -1073749448, -1791741113, 50388496, 0, -1073749492, -1073749680, 0, 3866624, 25165833, 33476529} i = 1 prev_modiff = 25222 prev_buffer = (struct buffer *) 0x19523aa0 already_adjusted = 0 #13 0x00101ffd in internal_condition_case (bfun=0x9fef0 , handlers=25205497, hfun=0x96ba0 ) at eval.c:1511 val = c = { tag = 25165833, val = 25165833, next = 0xbfffe34c, gcpro = 0x0, jmp = {-1073806465, -1880940628, 8098, 1056523, 25165833, 25165833, 3440252, 3440316, -1073749272, -1073749456, 31, 662, 1056666, 1245207, 3407903, 3407903, -1073807360, -1073807305}, backlist = 0x0, handlerlist = 0x0, lisp_eval_depth = 0, pdlcount = 2, poll_suppress_count = 1, interrupt_input_blocked = 0, byte_stack = 0x0 } h = { handler = 25205497, var = 25165833, chosen_clause = 25165881, tag = 0xbfffe248, next = 0x0 } #14 0x0008ff38 in command_loop_2 () at keyboard.c:1338 val = 0 #15 0x00101edc in internal_catch (tag=0, func=0x8fef0 , arg=25165833) at eval.c:1247 c = { tag = 25201569, val = 25165833, next = 0x0, gcpro = 0x0, jmp = {-1791753345, 0, 8098, 1056313, -1791740947, 19216, 3440384, 3440316, -1073749048, -1073749200, 25296927, 662, 1056463, 25296919, 25296927, 25165855, 6291456, 4259895}, backlist = 0x0, handlerlist = 0x0, lisp_eval_depth = 0, pdlcount = 2, poll_suppress_count = 1, interrupt_input_blocked = 0, byte_stack = 0x0 } #16 0x0008fc8e in command_loop () at keyboard.c:1317 No locals. #17 0x0008fd52 in recursive_edit_1 () at keyboard.c:942 val = #18 0x0008fed1 in Frecursive_edit () at keyboard.c:1004 buffer = 25165833 #19 0x0008eb6b in main (argc=1, argv=0xbfffe5a4) at emacs.c:1689 dummy = 0 stack_bottom_variable = 0 '\000' do_initial_setlocale = 1 skip_args = 0 rlim = { rlim_cur = 8388608, rlim_max = 67104768 } no_loadup = 0 junk = 0x0 From rgm@gnu.org Fri Oct 3 10:31:09 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 3 Oct 2008 17:31:09 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93HV6Y0018094 for ; Fri, 3 Oct 2008 10:31:07 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KloSP-0002Cw-Fb; Fri, 03 Oct 2008 13:28:49 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18662.22097.430953.420279@fencepost.gnu.org> Date: Fri, 3 Oct 2008 13:28:49 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: X^AhIwc&gda3kGTBg8."ck*s\:QoNX`1zQI_NU=J$83r@dEI>IOtTUtkdN-XlM3Rr9&?YM X-Debbugs-No-Ack: yes merge 606 1075 From rgm@gnu.org Fri Oct 3 10:39:01 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 3 Oct 2008 17:39:01 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93HctOU019316 for ; Fri, 3 Oct 2008 10:38:56 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KloZy-0002UG-5J; Fri, 03 Oct 2008 13:36:38 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18662.22566.92465.183621@fencepost.gnu.org> Date: Fri, 3 Oct 2008 13:36:38 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: white X-Ran: VIB{hIE8+$4,:F!'Z#s,qAr~TQ,_$2AZfw]9Xf3JhOX95_bQw&N%xSQrx0Q.s=("9UGmEM X-Debbugs-No-Ack: yes merge 588 589 596 602 605 606 769 822 826 863 968 stop Wow... From rgm@gnu.org Fri Oct 3 10:55:47 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1075) by emacsbugs.donarmstrong.com; 3 Oct 2008 17:55:47 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93HtiOB024152 for <1075@emacsbugs.donarmstrong.com>; Fri, 3 Oct 2008 10:55:46 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KloqE-0003Nz-Sm; Fri, 03 Oct 2008 13:53:26 -0400 From: Glenn Morris To: Lennart Staflin Cc: 1075@debbugs.gnu.org Subject: Re: bug#1075: 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color References: <48E62E8B.5010905@lysator.liu.se> X-Spook: strategic Saudi Arabia Aladdin ARPA assassination X-Ran: 1?nsuy0*&u+3oW,36N94,fAm\q+RzPgC5$6]F]5-1Y$67&J|;.9q1Fz8RH|TE3#O2mI+0~ X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 03 Oct 2008 13:53:26 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Lennart Staflin wrote: > After a crash I with ns_free_indexed_color, and x_clear_image_1 on the > stack. I noticed that x_clear_image_1 calls ns_free_indexed_color with > only one argument, but it takes two arguments. Perhaps that explains a > number of crashes in ns_free_indexed_color. Wow. I have just noticed how many ns crash reports have basically the same backtrace. I for one am sorry for not noticing that before. Your observation looks good to me. From adrian.b.robert@gmail.com Fri Oct 3 11:31:14 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1075) by emacsbugs.donarmstrong.com; 3 Oct 2008 18:31:14 +0000 Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.30]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93IVBwK001348 for <1075@emacsbugs.donarmstrong.com>; Fri, 3 Oct 2008 11:31:12 -0700 Received: by yw-out-2324.google.com with SMTP id 3so314980ywj.31 for <1075@emacsbugs.donarmstrong.com>; Fri, 03 Oct 2008 11:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=pEIMkoCL4kISclpUMhWET5PjlWNI7CWTUU/mTBlWAGk=; b=hg1MeXF5GLpYxUyNYk11XspDx7H+FqbLSaW4TJXaJSoTeQ2BTgWt4ncygkiFY/9/z1 f2y5yv5XqQnUdgKrprJhAi1S7W9Dd/DE/w0e5kPBcT3a2HlLenzayyoVBZpUy42W7K5/ LHHb2BQ17dKm5WOxZYFR1kzhruFWoaloruVWA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=uS/rA8CnA5sMgU5RUR8+5ecuq8P7tuOJXoG1/X2ctHEPmFbUfD68Nc0b70/xm+gtww XDGZHIWiMWy21XxHFR9SFVj+R8lp4O7AjZxT0IpBKLDX1qZ6BB32HXWNKMg/DaYzUgDm NrQrDGdlvIAvhetryzUxvcljHaPYBPk1h/aEc= Received: by 10.90.55.9 with SMTP id d9mr1680708aga.49.1223058670494; Fri, 03 Oct 2008 11:31:10 -0700 (PDT) Received: from ?10.0.1.199? ([72.169.150.82]) by mx.google.com with ESMTPS id y56sm2877639hsb.9.2008.10.03.11.30.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 03 Oct 2008 11:31:03 -0700 (PDT) Message-Id: From: Adrian Robert To: 1075@debbugs.gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: #1075 - 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color - Emacs bug report logs Date: Fri, 3 Oct 2008 14:30:23 -0400 X-Mailer: Apple Mail (2.926) > After a crash I with ns_free_indexed_color, and x_clear_image_1 on > the stack. I noticed that x_clear_image_1 calls > ns_free_indexed_color with only one argument, but it takes two > arguments. Perhaps that explains a number of crashes in > ns_free_indexed_color Thanks for this info. I checked in a fix based on your suggestion, but am unsure whether this will solve the crash since I have not experienced it. If it seems to go away could you please let me know? thanks From adrian.b.robert@gmail.com Mon Nov 24 20:46:23 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1075-done) by emacsbugs.donarmstrong.com; 25 Nov 2008 04:46:23 +0000 Received: from smtprelay.b.hostedemail.com (smtprelay0187.b.hostedemail.com [64.98.42.187]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP4kKc8007174 for <1075-done@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 20:46:21 -0800 Received: from filter.hostedemail.com (b-bigip1 [10.5.19.254]) by smtprelay05.b.hostedemail.com (Postfix) with SMTP id E093AD9D62A for <1075-done@emacsbugs.donarmstrong.com>; Tue, 25 Nov 2008 04:46:19 +0000 (UTC) X-SpamScore: 1 Received: from [10.0.1.198] (unknown [72.169.150.82]) (Authenticated sender: arobert@hughes.net) by omf08.b.hostedemail.com (Postfix) with ESMTP for <1075-done@emacsbugs.donarmstrong.com>; Tue, 25 Nov 2008 04:46:15 +0000 (UTC) Message-Id: <0419D148-710C-48C8-9817-2D323CE8C693@gmail.com> From: Adrian Robert To: 1075-done@debbugs.gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: #1075 - 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color - Emacs bug report logs Date: Mon, 24 Nov 2008 23:46:03 -0500 X-Mailer: Apple Mail (2.929.2) X-session-marker: 61726F62657274406875676865732E6E6574 I am closing this bug. The call to ns_free_indexed_color() in x_clear_image_1() (image.c:1625) had no business being there -- that color is not indexed, but a long RGB value derived from four_corners_best() or x_alloc_image_color() (which eventually calls ns_defined_color() with makeIndex=0). I checked in a removal as of 11/24, after closer examination prompted by yet another posting bug #1362. Hopefully this is the end of this! From unknown Fri Jun 20 20:10:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Jan 2009 15:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator