GNU bug report logs - #10748
colours in client on xterm (if an X frame is open at same time)

Previous Next

Package: emacs;

Reported by: sam <garen <at> tychoish.com>

Date: Tue, 7 Feb 2012 05:03:01 UTC

Severity: normal

Merged with 10905

Found in version 24.0.94

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Oleksandr Manzyuk <manzyuk <at> gmail.com>
To: 10748 <at> debbugs.gnu.org
Subject: bug#10748: 
Date: Mon, 27 Feb 2012 22:10:33 +0000
I'd like to confirm this problem.  I've chased it down to the function
`face-spec-reset-face' from lisp/faces.el.  The version from Emacs
23.2:

(defun face-spec-reset-face (face &optional frame)
  "Reset all attributes of FACE on FRAME to unspecified."
  (let ((attrs face-attribute-name-alist))
    (while attrs
      (let ((attr-and-name (car attrs)))
	(set-face-attribute face frame (car attr-and-name) 'unspecified))
      (setq attrs (cdr attrs)))))

The same function from trunk:

(defun face-spec-reset-face (face &optional frame)
  "Reset all attributes of FACE on FRAME to unspecified."
  (unless (eq face 'default)
    (let (reset-args)
      (dolist (attr-and-name face-attribute-name-alist)
	(push 'unspecified reset-args)
	(push (car attr-and-name) reset-args))
      (apply 'set-face-attribute face frame reset-args))))

Why does the latter not reset the default face?  If I start Emacs with
"emacs -Q", start the server with M-x server-start, and evaluate the
former definition in the *scratch* buffer, then doing "emacsclient -t"
from the terminal gives me a frame that respects my terminal
background color.

Best,
Sasha
-- 
Oleksandr Manzyuk
http://oleksandrmanzyuk.wordpress.com




This bug report was last modified 12 years and 340 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.