GNU bug report logs - #10743
24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief

Previous Next

Package: emacs;

Reported by: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>

Date: Tue, 7 Feb 2012 00:50:01 UTC

Severity: normal

Found in version 24.0.93

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 10743 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
Cc: 10743 <at> debbugs.gnu.org
Subject: Re: bug#10743: 24.0.93;
	missing type checking for Vtool_bar_button_margin in
	x_draw_image_relief
Date: Wed, 22 Feb 2012 14:01:42 +0800

YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp> writes:

> The current code in x_draw_image_relief (in xterm.c) applies XINT to
> Vtool_bar_button_margin without INTEGERP:
>
>   2326	  extra = s->face->id == TOOL_BAR_FACE_ID
>   2327	    ? XINT (Vtool_bar_button_margin) : 0;
>
> Other than an integer, a cons of integers is also a valid value for
> Vtool_bar_button_margin.

Thanks.  Fixed in trunk.
This bug report was last modified 13 years and 150 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.