From unknown Fri Aug 15 15:55:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10743 <10743@debbugs.gnu.org> To: bug#10743 <10743@debbugs.gnu.org> Subject: Status: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief Reply-To: bug#10743 <10743@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:55:36 +0000 retitle 10743 24.0.93; missing type checking for Vtool_bar_button_margin in= x_draw_image_relief reassign 10743 emacs submitter 10743 YAMAMOTO Mitsuharu severity 10743 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 19:49:30 2012 Received: (at submit) by debbugs.gnu.org; 7 Feb 2012 00:49:31 +0000 Received: from localhost ([127.0.0.1]:57856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RuZFS-0000ij-2d for submit@debbugs.gnu.org; Mon, 06 Feb 2012 19:49:30 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46213) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RuZFQ-0000iX-1u for submit@debbugs.gnu.org; Mon, 06 Feb 2012 19:49:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuZET-0006uI-Hi for submit@debbugs.gnu.org; Mon, 06 Feb 2012 19:48:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:34311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuZET-0006uE-GH for submit@debbugs.gnu.org; Mon, 06 Feb 2012 19:48:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuZES-0005xk-GY for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 19:48:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuZEQ-0006tp-7l for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 19:48:28 -0500 Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:57636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuZEP-0006si-Nj for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 19:48:26 -0500 Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 77397C055D for ; Tue, 7 Feb 2012 09:48:18 +0900 (JST) Date: Tue, 07 Feb 2012 09:48:18 +0900 Message-ID: From: YAMAMOTO Mitsuharu To: bug-gnu-emacs@gnu.org Subject: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) Organization: Faculty of Science, Chiba University MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) The current code in x_draw_image_relief (in xterm.c) applies XINT to Vtool_bar_button_margin without INTEGERP: 2326 extra = s->face->id == TOOL_BAR_FACE_ID 2327 ? XINT (Vtool_bar_button_margin) : 0; Other than an integer, a cons of integers is also a valid value for Vtool_bar_button_margin. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp In GNU Emacs 24.0.93.1 (x86_64-apple-darwin11.3.0, X toolkit, Xaw scroll bars) of 2012-02-07 on yamamoto-no-iMac.local Windowing system distributor `The X.Org Foundation', version 11.0.11003000 Configured using: `configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no' '--enable-asserts' '--enable-checking'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ja_JP.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 01:04:29 2012 Received: (at 10743) by debbugs.gnu.org; 22 Feb 2012 06:04:29 +0000 Received: from localhost ([127.0.0.1]:49839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S05JR-0007WT-AJ for submit@debbugs.gnu.org; Wed, 22 Feb 2012 01:04:29 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:58885 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S05JE-0007Vy-As for 10743@debbugs.gnu.org; Wed, 22 Feb 2012 01:04:23 -0500 Received: from [155.69.16.15] (port=57160 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S05Gv-0001tL-Ra; Wed, 22 Feb 2012 01:01:50 -0500 From: Chong Yidong To: YAMAMOTO Mitsuharu Subject: Re: bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief References: Date: Wed, 22 Feb 2012 14:01:42 +0800 In-Reply-To: (YAMAMOTO Mitsuharu's message of "Tue, 07 Feb 2012 09:48:18 +0900") Message-ID: <87hayjl83d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10743 Cc: 10743@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) YAMAMOTO Mitsuharu writes: > The current code in x_draw_image_relief (in xterm.c) applies XINT to > Vtool_bar_button_margin without INTEGERP: > > 2326 extra = s->face->id == TOOL_BAR_FACE_ID > 2327 ? XINT (Vtool_bar_button_margin) : 0; > > Other than an integer, a cons of integers is also a valid value for > Vtool_bar_button_margin. Thanks. Fixed in trunk. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 01:04:17 2012 Received: (at control) by debbugs.gnu.org; 22 Feb 2012 06:04:17 +0000 Received: from localhost ([127.0.0.1]:49837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S05JH-0007W8-N4 for submit@debbugs.gnu.org; Wed, 22 Feb 2012 01:04:16 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:58887 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S05JE-0007Vz-Aw for control@debbugs.gnu.org; Wed, 22 Feb 2012 01:04:13 -0500 Received: from [155.69.16.15] (port=57161 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S05Gx-0001tU-Bn for control@debbugs.gnu.org; Wed, 22 Feb 2012 01:01:51 -0500 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 10743 Date: Wed, 22 Feb 2012 14:01:45 +0800 Message-ID: <87boors8xi.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) close 10743 thanks From unknown Fri Aug 15 15:55:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 21 Mar 2012 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator