GNU bug report logs - #10736
Add "underwave" face attribute

Previous Next

Package: emacs;

Reported by: Aurélien Aptel <aurelien.aptel <at> gmail.com>

Date: Mon, 6 Feb 2012 17:00:01 UTC

Severity: wishlist

Tags: patch

Fixed in version 24.2

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Forwarded to http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00022.html

Full log

View this message in rfc822 format

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 10736 <at> debbugs.gnu.org, Aurélien Aptel <aurelien.aptel <at> gmail.com>
Subject: bug#10736: Add "underwave" face attribute
Date: Fri, 13 Apr 2012 19:49:24 +0200

Hello.

12 apr 2012 kl. 23:57 skrev Stefan Monnier:

>> Looking at the mailing list, it seems like it was agreed that this is
>> useful, and that this interface is correct.  Since we're in Emacs 24.2
>> territory now, should this go in?
> 
> Assuming the code is OK, yes.   I'd like to hear someone's opinion on
> the code, tho (Jan, maybe?).
> 

Looks OK.  In general I don't like the "Get GC values, change some GC value, draw, restore changed GC value" technique. It is better to create more GC:s.  But the new code just mimics the old, so it is nothing particular for this patch.

	Jan D.
This bug report was last modified 12 years and 352 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.