GNU bug report logs - #10730
is_newest function fails on txinfo21

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10730 in the body.
You can then email your comments to 10730 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Sampson <ats <at> offog.org>
To: bug-automake <at> gnu.org
Subject: is_newest function fails on txinfo21
Date: Sun, 5 Feb 2012 01:27:17 +0000

[Message part 1 (text/plain, inline)]

Hi,

In automake 1.11.3, the txinfo21 test uses is_newest to compare the
timestamps of main.html (a directory) and main.texi (a file). This
fails, because the find call inside is_newest also finds the files
inside main.html.

Adding -maxdepth 0 to the find invocation fixes this. A patch is
attached, as is a log of it failing without the patch.

Thanks,

-- 
Adam Sampson <ats <at> offog.org>                         <http://offog.org/>

[newest.diff (text/plain, attachment)]

[txinfo21.log (text/plain, attachment)]

Message #8 received at 10730 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Adam Sampson <ats <at> offog.org>
Cc: 10730 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#10730: is_newest function fails on txinfo21
Date: Sun, 05 Feb 2012 23:13:02 +0100

[Message part 1 (text/plain, inline)]

severity 10730 minor
tags 10730 patch
close 10730
thanks

On 02/05/2012 02:27 AM, Adam Sampson wrote:
> Hi,
>
Hi Adam, thanks for the report.

> In automake 1.11.3, the txinfo21 test uses is_newest to compare the
> timestamps of main.html (a directory) and main.texi (a file). This
> fails, because the find call inside is_newest also finds the files
> inside main.html.
>
Ouch.  We had already encountered and fixed this bug, but I applied
the fix to master only, so that the problem is still present in the
maintenance version :-(  I've now backported the patch from master,
which should fix the issue, and added you to THANKS.  See attached
patch.

> Adding -maxdepth 0 to the find invocation fixes this.
>
The '-maxdepth' option seems to be a GNU extensions, and not portable
to POSIX find(1); the attached fix uses the '-prune' option instead.

> A patch is attached, as is a log of it failing without the patch.
> 
Thanks,
  Stefano

[0001-test-defs-function-is_newest-now-works-also-with-dir.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.