GNU bug report logs - #1066
23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1066 in the body.
You can then email your comments to 1066 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Romain Francoise <romain <at> orebokech.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 02 Oct 2008 20:13:32 +0200

When Emacs is started with --daemon, (tool-bar-mode -1) has no
effect when used in ~/.emacs.

To reproduce:
1. echo "(tool-bar-mode -1)" >~/.emacs
2. Start Emacs, note that it has no tool bar, exit
3. emacs --daemon
4. emacsclient -c: the frame has a tool bar when it should not

In the created frame, the first call to M-x tool-bar-mode has no
effect.  A second call finally disables the tool bar.



In GNU Emacs 23.0.60.12 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2008-10-02 on elegiac
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  'CFLAGS=-O0 -g''

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Romain Francoise <romain <at> orebokech.com>
Cc: 1066 <at> debbugs.gnu.org, emacs-pretest-bug <at> gnu.org
Subject: Re: bug#1066: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 2 Oct 2008 12:47:29 -0700 (PDT)

Romain Francoise <romain <at> orebokech.com> writes:

  > When Emacs is started with --daemon, (tool-bar-mode -1) has no
  > effect when used in ~/.emacs.
  > 
  > To reproduce:
  > 1. echo "(tool-bar-mode -1)" >~/.emacs
  > 2. Start Emacs, note that it has no tool bar, exit
  > 3. emacs --daemon
  > 4. emacsclient -c: the frame has a tool bar when it should not
  > 
  > In the created frame, the first call to M-x tool-bar-mode has no
  > effect.  A second call finally disables the tool bar.

Can you please test this patch:

--- faces.el.~1.425.~	2008-09-24 12:55:17.000000000 -0700
+++ faces.el	2008-10-02 12:39:46.000000000 -0700
@@ -2001,7 +2001,6 @@ Value is the new frame created."
 	  ;; Make sure the tool-bar is ready to be enabled.  The
 	  ;; `tool-bar-lines' frame parameter will not take effect
 	  ;; without this call.
-	  (tool-bar-setup frame)
 	  (if (null visibility-spec)
 	      (make-frame-visible frame)
 	    (modify-frame-parameters frame (list visibility-spec)))

Message #20 received at 1066 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Romain Francoise <romain <at> orebokech.com>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1066 <at> debbugs.gnu.org
Subject: Re: bug#1066: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 02 Oct 2008 22:07:58 +0200

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> Can you please test this patch:

> --- faces.el.~1.425.~	2008-09-24 12:55:17.000000000 -0700
> +++ faces.el	2008-10-02 12:39:46.000000000 -0700
> @@ -2001,7 +2001,6 @@ Value is the new frame created."
>  	  ;; Make sure the tool-bar is ready to be enabled.  The
>  	  ;; `tool-bar-lines' frame parameter will not take effect
>  	  ;; without this call.
> -	  (tool-bar-setup frame)
>  	  (if (null visibility-spec)
>  	      (make-frame-visible frame)
>  	    (modify-frame-parameters frame (list visibility-spec)))

Works for me, thanks.

While I'm at it: the user who reported this bug to me also has the
problem with `set-default-font', it seems to have no effect with
--daemon.

Message #25 received at 1066 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Romain Francoise <romain <at> orebokech.com>
Cc: 1066 <at> debbugs.gnu.org
Subject: Re: bug#1066: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 2 Oct 2008 13:52:12 -0700 (PDT)

Romain Francoise <romain <at> orebokech.com> writes:

  > Dan Nicolaescu <dann <at> ics.uci.edu> writes:
  > 
  > > Can you please test this patch:
  > 
  > > --- faces.el.~1.425.~	2008-09-24 12:55:17.000000000 -0700
  > > +++ faces.el	2008-10-02 12:39:46.000000000 -0700
  > > @@ -2001,7 +2001,6 @@ Value is the new frame created."
  > >  	  ;; Make sure the tool-bar is ready to be enabled.  The
  > >  	  ;; `tool-bar-lines' frame parameter will not take effect
  > >  	  ;; without this call.
  > > -	  (tool-bar-setup frame)
  > >  	  (if (null visibility-spec)
  > >  	      (make-frame-visible frame)
  > >  	    (modify-frame-parameters frame (list visibility-spec)))
  > 
  > Works for me, thanks.

Thanks, I am not completely convinced it's the right fix, given the
comment that precedes this code.  Not sure what to do...

  > While I'm at it: the user who reported this bug to me also has the
  > problem with `set-default-font', it seems to have no effect with
  > --daemon.

Unfortunately I don't know much about the font stuff, and I don't have
time at the moment to deal with it, so someone else will have to deal
with that.

Message #30 received at 1066 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Romain Francoise <romain <at> orebokech.com>
Cc: 1066 <at> debbugs.gnu.org
Subject: Re: bug#1066: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 2 Oct 2008 14:14:31 -0700 (PDT)

Romain Francoise <romain <at> orebokech.com> writes:

  > While I'm at it: the user who reported this bug to me also has the
  > problem with `set-default-font', it seems to have no effect with
  > --daemon.

Another thing:

set-default-font is an alias for `set-frame-font' in `frame.el'.

(set-default-font font-name &optional keep-size)

Set the font of the selected frame to font-name.
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
when .emacs is run, the selected frame is not an X11 frame, so this
function does not seem to be the right one to use.

Message #35 received at 1066 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefano Zacchiroli <zack <at> upsilon.cc>
To: 1078 <at> debbugs.gnu.org
Cc: 1066 <at> debbugs.gnu.org
Subject: Re: bug#1078: Acknowledgement (23.0.60; font faces setting ignored
	by emacsclient run against --daemon)
Date: Fri, 3 Oct 2008 22:10:17 +0100

FWIW, it is very likely that this bug (#1078) is a duplicate of #1066.

Cheers.

-- 
Stefano Zacchiroli -*- PhD in Computer Science \ PostDoc @ Univ. Paris 7
zack@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
I'm still an SGML person,this newfangled /\ All one has to do is hit the
XML stuff is so ... simplistic  -- Manoj \/ right keys at the right time

Message #40 received at 1066 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Romain Francoise <romain <at> orebokech.com>, Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1066 <at> debbugs.gnu.org
Subject: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 09 Oct 2008 15:49:16 -0400

I've reorganized the semantics of tool-bar-mode slightly to deal with
the multi-tty situation.

Now, tool-bar-mode is always turned on unless the user explicitly
disables it in X resources or .emacs --- even if the initial frame is on
a tty.  Even though tool-bar-mode doesn't display a tool-bar on a tty,
its value is meaningful: it says whether or not any graphical frame we
create will have a tool-bar.

This should resolve the current bug.

Message #45 received at 1066 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 1066 <at> debbugs.gnu.org, Romain Francoise <romain <at> orebokech.com>
Subject: Re: bug#1066: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Thu, 9 Oct 2008 18:17:04 -0700 (PDT)

Chong Yidong <cyd <at> stupidchicken.com> writes:

  > I've reorganized the semantics of tool-bar-mode slightly to deal with
  > the multi-tty situation.
  > 
  > Now, tool-bar-mode is always turned on unless the user explicitly
  > disables it in X resources or .emacs --- even if the initial frame is on
  > a tty.  Even though tool-bar-mode doesn't display a tool-bar on a tty,
  > its value is meaningful: it says whether or not any graphical frame we
  > create will have a tool-bar.
  > 
  > This should resolve the current bug.

Thanks for doing this!  There's still a missing part: it needs to work
when using --without-x.

Message #50 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>, 1066 <at> debbugs.gnu.org
Cc: cyd <at> stupidchicken.com, romain <at> orebokech.com, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#1066: 23.0.60;	(tool-bar-mode -1) in ~/.emacs has no effect with --daemon
Date: Fri, 10 Oct 2008 10:58:03 +0200

> Date: Thu, 9 Oct 2008 18:17:04 -0700 (PDT)
> From: Dan Nicolaescu <dann <at> ics.uci.edu>
> Cc: Romain Francoise <romain <at> orebokech.com>, 1066 <at> emacsbugs.donarmstrong.com
> 
> Chong Yidong <cyd <at> stupidchicken.com> writes:
> 
>   > I've reorganized the semantics of tool-bar-mode slightly to deal with
>   > the multi-tty situation.
>   > 
>   > Now, tool-bar-mode is always turned on unless the user explicitly
>   > disables it in X resources or .emacs --- even if the initial frame is on
>   > a tty.  Even though tool-bar-mode doesn't display a tool-bar on a tty,
>   > its value is meaningful: it says whether or not any graphical frame we
>   > create will have a tool-bar.
>   > 
>   > This should resolve the current bug.
> 
> Thanks for doing this!  There's still a missing part: it needs to work
> when using --without-x.

I think I fixed that part, please try again.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.