GNU bug report logs - #10650
view-mode inconsistencies wrt special mode-class

Previous Next

Package: emacs;

Reported by: Glenn Morris <rgm <at> gnu.org>

Date: Mon, 30 Jan 2012 09:06:01 UTC

Severity: minor

Found in version 24.0.93

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: Stefan Monnier <monnier <at> IRO.UMontreal.CA>, 10650 <at> debbugs.gnu.org
Subject: bug#10650: view-mode inconsistencies wrt special mode-class
Date: Wed, 01 Feb 2012 12:15:12 -0500
Chong Yidong wrote:

> I changed view-buffer-other-* to behave like view-buffer.
> (Could have changed view-mode-enter instead, but that is called from
> other placed in Emacs so it didn't seem worth the risk.)

Probably not for 24.1 indeed, but the first usage I looked at is in
files.el and it duplicates the same logic wrt mode-class:

(when (and buffer-read-only
             view-read-only
             (not (eq (get major-mode 'mode-class) 'special)))
      (view-mode-enter))

I'd guess (with no data) that most of the other callers either use
something similar, should use something similar but did not think of it,
or would not be affected if something similar were added.




This bug report was last modified 13 years and 109 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.