GNU bug report logs - #10633
Please mark invalid "; !important;" in CSS

Previous Next

Full log

Message #67 received at 10633 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Chong Yidong <cyd <at> gnu.org>, 10633 <at> debbugs.gnu.org
Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS
Date: Tue, 31 Jan 2012 03:36:11 +0100

[Message part 1 (text/plain, inline)]

On Tue, Jan 31, 2012 at 02:48, Stefan Monnier <monnier <at> iro.umontreal.ca>wrote:

> >> >> However there are a lot of things that can go wrong when you work
> with
> >> >> things like css.
> >> > I don't think it should be the job of CSS mode to highlight ad-hoc
> >> > mistake conditions like that.
> >> There's cwarn-mode for something similar, so the question really is
> >> whether this error is common or specific to a particular user.
> >> I have no idea which it is.
> > The "!important" is colored as it is now even when I happen to put it
> > after the ";". Not syntax coloring that would be enough to easily
> > detect the problem.
>
> That would be perfect, yes.  Patch welcome,
>
> I think this is enough:

    ;;("!\\s-*important" . font-lock-builtin-face)
    ("[^; \t\n]\\s-*\\(!\\s-*important\\)"
     (1 'font-lock-builtin-face))

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.