GNU bug report logs - #10633
Please mark invalid "; !important;" in CSS

Previous Next

Package: emacs;

Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>

Date: Sat, 28 Jan 2012 22:03:02 UTC

Severity: wishlist

Tags: wontfix

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: monnier <at> iro.umontreal.ca, 10633 <at> debbugs.gnu.org
Subject: bug#10633: Please mark invalid "; !important;" in CSS
Date: Sun, 29 Jan 2012 00:52:25 +0100

On Sun, Jan 29, 2012 at 00:26, Lennart Borgman
<lennart.borgman <at> gmail.com> wrote:
> On Sun, Jan 29, 2012 at 00:18, Juanma Barranquero <lekktu <at> gmail.com> wrote:
>> On Sat, Jan 28, 2012 at 23:01, Lennart Borgman
>> <lennart.borgman <at> gmail.com> wrote:
>>
>>> One of my most common mistakes when editing CSS files is that I leave
>>> a ";" before "!important", like this:
>>>
>>>   width: 500px; !important;
>>>
>>> This should have been
>>>
>>>   width: 500px !important;
>>>
>>> Could Emacs please help me with this?;-)
>>
>> Sure. Use hi-lock-mode, add a "; +!important" regexp as a file
>> pattern, set the mode in the css-mode-hook, and for added simplicity
>> do also
>>
>> (setq hi-lock-file-patterns-policy (lambda (patterns)
>>                                            (if (eq major-mode 'css-mode)
>>                                                t
>>                                              (y-or-n-p "Add patterns
>> from this buffer to hi-lock? "))))
>>
>> Look, ma, no hands.
>
> Thanks, it is a great tip until it is fixed!

Though it was a bit unpractical. It would be easier to just add it to
css-mode-hook and forget hi-lock-mode. Since isearch does it without
hi-lock-mode that is doable. Anyone remember how to do it offhand? (Or
do I have to search the isearch code... ?;-)
This bug report was last modified 12 years and 224 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.