From unknown Thu Aug 14 20:50:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10633 <10633@debbugs.gnu.org> To: bug#10633 <10633@debbugs.gnu.org> Subject: Status: Please mark invalid "; !important;" in CSS Reply-To: bug#10633 <10633@debbugs.gnu.org> Date: Fri, 15 Aug 2025 03:50:44 +0000 retitle 10633 Please mark invalid "; !important;" in CSS reassign 10633 emacs submitter 10633 Lennart Borgman severity 10633 wishlist tag 10633 wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 17:02:21 2012 Received: (at submit) by debbugs.gnu.org; 28 Jan 2012 22:02:22 +0000 Received: from localhost ([127.0.0.1]:42465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrGLl-0001Bz-K0 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 17:02:21 -0500 Received: from eggs.gnu.org ([140.186.70.92]:35462) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrGLk-0001Bl-BE for submit@debbugs.gnu.org; Sat, 28 Jan 2012 17:02:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrGLe-0007fJ-8K for submit@debbugs.gnu.org; Sat, 28 Jan 2012 17:02:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:46378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrGLe-0007fF-3p for submit@debbugs.gnu.org; Sat, 28 Jan 2012 17:02:14 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrGLd-0002aU-2F for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 17:02:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrGLc-0007ew-4s for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 17:02:13 -0500 Received: from mail-lpp01m020-f169.google.com ([209.85.217.169]:36679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrGLb-0007eo-RS for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 17:02:12 -0500 Received: by lbbgg6 with SMTP id gg6so200188lbb.0 for ; Sat, 28 Jan 2012 14:02:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; bh=AVFerXLXHcp7y0Kwt/4ZJ4bOgN7XccRAWfm/rnOCVfA=; b=m4zd426ac+JkKPWUWvUrERjluEkSQfryHZNwRcYjN0s81M+ER0R0BQ+Ipvc8fLO2mS X5+N6J1bLxuUuwh1LoHidOX68GNpdc8YSEMlFNI4DoKvSj8v5y3MKP7O+a237dGnBTaN vxF2lY/G7NVOzZY+PH5YWHKdlvgRdoaJJqghU= Received: by 10.112.36.103 with SMTP id p7mr3087956lbj.91.1327788130200; Sat, 28 Jan 2012 14:02:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 14:01:50 -0800 (PST) From: Lennart Borgman Date: Sat, 28 Jan 2012 23:01:50 +0100 Message-ID: Subject: Please mark invalid "; !important;" in CSS To: Emacs Bugs , Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) One of my most common mistakes when editing CSS files is that I leave a ";" before "!important", like this: width: 500px; !important; This should have been width: 500px !important; Could Emacs please help me with this?;-) From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 18:19:32 2012 Received: (at 10633) by debbugs.gnu.org; 28 Jan 2012 23:19:32 +0000 Received: from localhost ([127.0.0.1]:42522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrHYR-0002vJ-Pi for submit@debbugs.gnu.org; Sat, 28 Jan 2012 18:19:32 -0500 Received: from mail-pw0-f44.google.com ([209.85.160.44]:61637) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrHYQ-0002v8-EQ for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 18:19:31 -0500 Received: by pbdu7 with SMTP id u7so2125139pbd.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 15:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=P1MQW+JiFfwx4axp57lxQHb8B7CRXhWmuMiZhFF70jk=; b=Ecv31ve1MUH8u7BhBJ4Y62HArgViscNu6EXT/2C8DWMcMy9dejKXC72AoTJ+2lNh+O tQyyhHpr8MhbE5PB5iwanSGPd08maPFZjLkE+LMpH6+UXwhFAIRbWUnHPUpVyUC0nEDK buPijJSk0CI/ftZs1W+z/iA10UX705TOuG7so= Received: by 10.68.199.38 with SMTP id jh6mr26880711pbc.77.1327792764178; Sat, 28 Jan 2012 15:19:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.37.9 with HTTP; Sat, 28 Jan 2012 15:18:44 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 29 Jan 2012 00:18:44 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: monnier@iro.umontreal.ca, 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sat, Jan 28, 2012 at 23:01, Lennart Borgman wrote: > One of my most common mistakes when editing CSS files is that I leave > a ";" before "!important", like this: > > =C2=A0 width: 500px; !important; > > This should have been > > =C2=A0 width: 500px !important; > > Could Emacs please help me with this?;-) Sure. Use hi-lock-mode, add a "; +!important" regexp as a file pattern, set the mode in the css-mode-hook, and for added simplicity do also (setq hi-lock-file-patterns-policy (lambda (patterns) (if (eq major-mode 'css-mode) t (y-or-n-p "Add patterns from this buffer to hi-lock? ")))) Look, ma, no hands. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 18:26:54 2012 Received: (at 10633) by debbugs.gnu.org; 28 Jan 2012 23:26:54 +0000 Received: from localhost ([127.0.0.1]:42539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrHfZ-00035Y-O1 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 18:26:54 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:59246) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrHfY-00035L-6o for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 18:26:52 -0500 Received: by lahl5 with SMTP id l5so1542634lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 15:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=RyNGBX0aikR8Ly4zoLFpc9rW1l0OH1jwOfC3EBsY0EQ=; b=bN7/olsrkjbWgnhSvzSwg5QCAEgQukLYws0QDDIYDTmqNsmEajQ1+QavIWqEKTWzzL JPX0EQN3mieAThYvgj3vuknwg6clZJwKiOEAu4gWMcO2vQS+gGTlvJToaqPyhC8fDSj+ r5Ddh2m67hVC4NdNG7rRRJOe2ILuhtrEOHtiw= Received: by 10.112.103.131 with SMTP id fw3mr3062772lbb.78.1327793205242; Sat, 28 Jan 2012 15:26:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 15:26:25 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 00:26:25 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: monnier@iro.umontreal.ca, 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 00:18, Juanma Barranquero wrote: > On Sat, Jan 28, 2012 at 23:01, Lennart Borgman > wrote: > >> One of my most common mistakes when editing CSS files is that I leave >> a ";" before "!important", like this: >> >> =C2=A0 width: 500px; !important; >> >> This should have been >> >> =C2=A0 width: 500px !important; >> >> Could Emacs please help me with this?;-) > > Sure. Use hi-lock-mode, add a "; +!important" regexp as a file > pattern, set the mode in the css-mode-hook, and for added simplicity > do also > > (setq hi-lock-file-patterns-policy (lambda (patterns) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(if (eq major-mode 'css-mode) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0t > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0(y-or-n-p "Add patterns > from this buffer to hi-lock? ")))) > > Look, ma, no hands. Thanks, it is a great tip until it is fixed! From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 18:52:54 2012 Received: (at 10633) by debbugs.gnu.org; 28 Jan 2012 23:52:54 +0000 Received: from localhost ([127.0.0.1]:42586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrI4j-0003io-VR for submit@debbugs.gnu.org; Sat, 28 Jan 2012 18:52:54 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:51893) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrI4h-0003ia-N3 for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 18:52:52 -0500 Received: by lahl5 with SMTP id l5so1547350lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 15:52:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=elKd3pHRZ0YxYQCpFR0Hbof7j/y3ZfZMb/HoRYsKl/o=; b=AZRCUIBnSbxGT92iz3ZAVOZF9Uy++FjZtYXmrezrfZ7Ui46wMVsBbgYCeY+Hq9ZBIO U+rMuESCa/CDd+KATxbFs45aLYWcddM9y31bRoFjeHDSH2F2ZBgVgMEJabPa75OOnKhg 4NcfC71MhyqBL+DVXKnTGf8K9h0VlFcCuegKA= Received: by 10.152.129.226 with SMTP id nz2mr2583107lab.7.1327794765220; Sat, 28 Jan 2012 15:52:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 15:52:25 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 00:52:25 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: monnier@iro.umontreal.ca, 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 00:26, Lennart Borgman wrote: > On Sun, Jan 29, 2012 at 00:18, Juanma Barranquero wrot= e: >> On Sat, Jan 28, 2012 at 23:01, Lennart Borgman >> wrote: >> >>> One of my most common mistakes when editing CSS files is that I leave >>> a ";" before "!important", like this: >>> >>> =C2=A0 width: 500px; !important; >>> >>> This should have been >>> >>> =C2=A0 width: 500px !important; >>> >>> Could Emacs please help me with this?;-) >> >> Sure. Use hi-lock-mode, add a "; +!important" regexp as a file >> pattern, set the mode in the css-mode-hook, and for added simplicity >> do also >> >> (setq hi-lock-file-patterns-policy (lambda (patterns) >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(if (eq major-mode 'css-mode) >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0t >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(y-or-n-p "Add patterns >> from this buffer to hi-lock? ")))) >> >> Look, ma, no hands. > > Thanks, it is a great tip until it is fixed! Though it was a bit unpractical. It would be easier to just add it to css-mode-hook and forget hi-lock-mode. Since isearch does it without hi-lock-mode that is doable. Anyone remember how to do it offhand? (Or do I have to search the isearch code... ?;-) From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 19:11:27 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 00:11:27 +0000 Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrIMg-000490-VY for submit@debbugs.gnu.org; Sat, 28 Jan 2012 19:11:27 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:62551) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrIMd-00048m-NE for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 19:11:25 -0500 Received: by lahl5 with SMTP id l5so1550691lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 16:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=g1U0iNIwo2HZLTBDeTEYB9myxXy7DLOwUQGYo9ekmkA=; b=Wn4/LtRfNPRtluUiQhD4mKb5WEMKBq31qIFWSE4/v3Nq11JqnAB7mvq0CbhMVMdL6A kgAT1mSz+1R7017IfRkb8gr7esj7na2k5UTEIBm2kOFtzFDqoSSrTqdsSKaV4Sh4xrKr 4quBJRF32H8KZ49648KQQqeNK66J5sc8nq7UM= Received: by 10.152.131.40 with SMTP id oj8mr6433034lab.24.1327795877148; Sat, 28 Jan 2012 16:11:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 16:10:57 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 01:10:57 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: monnier@iro.umontreal.ca, 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 00:52, Lennart Borgman wrote: > On Sun, Jan 29, 2012 at 00:26, Lennart Borgman > wrote: >> On Sun, Jan 29, 2012 at 00:18, Juanma Barranquero wro= te: >>> On Sat, Jan 28, 2012 at 23:01, Lennart Borgman >>> wrote: >>> >>>> One of my most common mistakes when editing CSS files is that I leave >>>> a ";" before "!important", like this: >>>> >>>> =C2=A0 width: 500px; !important; >>>> >>>> This should have been >>>> >>>> =C2=A0 width: 500px !important; >>>> >>>> Could Emacs please help me with this?;-) >>> >>> Sure. Use hi-lock-mode, add a "; +!important" regexp as a file >>> pattern, set the mode in the css-mode-hook, and for added simplicity >>> do also >>> >>> (setq hi-lock-file-patterns-policy (lambda (patterns) >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(if (eq major-mode 'css-mode) >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0t >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(y-or-n-p "Add patterns >>> from this buffer to hi-lock? ")))) >>> >>> Look, ma, no hands. >> >> Thanks, it is a great tip until it is fixed! > > Though it was a bit unpractical. It would be easier to just add it to > css-mode-hook and forget hi-lock-mode. Since isearch does it without > hi-lock-mode that is doable. Anyone remember how to do it offhand? (Or > do I have to search the isearch code... ?;-) Here is a way to do it: - In isearch-forward-regexp do M-s-h-r to hilight the pattern. - Then use hi-lock-write-interactive-patterns to write it down in the buffer for the moment (so you do not have to think about it...;-) - Now to css-mode-hook add something like this (hi-lock-face-buffer "; +!important;" 'hi-my-face) In my .emacs I added: (add-hook 'css-mode-hook 'my-hilock-css-important-errors) (defun my-hilock-css-important-errors() (hi-lock-face-buffer "; +!important;" 'hi-my-magenta)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 19:35:32 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 00:35:32 +0000 Received: from localhost ([127.0.0.1]:42622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrIjz-0004h1-Tw for submit@debbugs.gnu.org; Sat, 28 Jan 2012 19:35:32 -0500 Received: from mail-pw0-f44.google.com ([209.85.160.44]:50515) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrIjw-0004gm-7Z for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 19:35:29 -0500 Received: by pbdu7 with SMTP id u7so2153996pbd.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 16:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=C82vUOQPiRXY1plCDV5+hzvlQyfWhJ3QqAEc8/4IURA=; b=kdWVJ1xstf7e41al+vGDyxSsrIO5arivXQ/BE6ULg8unqudR07I5+VFSKFJjXSUA3x TEEtbqXLFs5mLJTbb5heeq/5N+v2RLxxJgMtm4OSYIIgTrYd+3fz05X7+aHkSrp2ZJwo tQUx5Z/2NZ0B3Fojb+zOq5E1WpDZN+5Nh4nSs= Received: by 10.68.75.135 with SMTP id c7mr27400282pbw.43.1327797321221; Sat, 28 Jan 2012 16:35:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.37.9 with HTTP; Sat, 28 Jan 2012 16:34:41 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 29 Jan 2012 01:34:41 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 01:10, Lennart Borgman wrote: > Here is a way to do it: > > - In isearch-forward-regexp do M-s-h-r to hilight the pattern. > - Then use hi-lock-write-interactive-patterns to write it down in the > buffer for the moment (so you do not have to think about it...;-) > - Now to css-mode-hook add something like this (hi-lock-face-buffer "; > +!important;" 'hi-my-face) > > In my .emacs I added: > > (add-hook 'css-mode-hook 'my-hilock-css-important-errors) > (defun my-hilock-css-important-errors() > =C2=A0(hi-lock-face-buffer "; +!important;" 'hi-my-magenta)) So you're reimplementing what the file patterns of hi-lock-mode are already designed to do. Congratulations ;-) =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 20:20:21 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 01:20:21 +0000 Received: from localhost ([127.0.0.1]:42656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrJRN-0005hY-4I for submit@debbugs.gnu.org; Sat, 28 Jan 2012 20:20:21 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:46379) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrJRK-0005hK-12 for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 20:20:19 -0500 Received: by lahl5 with SMTP id l5so1562705lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 17:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=mxeTN0TWU9niQu08QL8P2hkS4yI+Aw0MPmdDcAzc39U=; b=SRjHVlUKRuWyIVi4qvrSnrVkVGq4qTHQYH0XdrIEOqQpAHCR8nctZVM1YkvcBuIqme 92qXKTPOs6PyGwppB9xmp+KyxEz5lwRQrG1xpBPllC3McvOvV+5oOcUvb8LaV5v36FUF L/RRbMAw+AdpMLFcw8ZO28u9Pb7WKlXoolLs8= Received: by 10.152.110.102 with SMTP id hz6mr6856640lab.21.1327800011181; Sat, 28 Jan 2012 17:20:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 17:19:50 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 02:19:50 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 01:34, Juanma Barranquero wrote: > On Sun, Jan 29, 2012 at 01:10, Lennart Borgman > wrote: > >> Here is a way to do it: >> >> - In isearch-forward-regexp do M-s-h-r to hilight the pattern. >> - Then use hi-lock-write-interactive-patterns to write it down in the >> buffer for the moment (so you do not have to think about it...;-) >> - Now to css-mode-hook add something like this (hi-lock-face-buffer "; >> +!important;" 'hi-my-face) >> >> In my .emacs I added: >> >> (add-hook 'css-mode-hook 'my-hilock-css-important-errors) >> (defun my-hilock-css-important-errors() >> =C2=A0(hi-lock-face-buffer "; +!important;" 'hi-my-magenta)) > > So you're reimplementing what the file patterns of hi-lock-mode are > already designed to do. Congratulations ;-) Did I miss something? I can't see that I can directly add it to css-mode-hook. Please tell me how to do it! From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 20:38:45 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 01:38:45 +0000 Received: from localhost ([127.0.0.1]:42665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrJj9-00069q-Qd for submit@debbugs.gnu.org; Sat, 28 Jan 2012 20:38:45 -0500 Received: from mail-pw0-f44.google.com ([209.85.160.44]:45992) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrJj4-00069b-VB for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 20:38:40 -0500 Received: by pbdu7 with SMTP id u7so2178189pbd.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 17:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=UfwQGtf4RDkWd544SajOUcSun1eitSIvViQtxBEI6QU=; b=sJNpQE8uuEXOHSv3Z2iwS9PEWYaLcRlKFO2X92sPLGxiQu9PPOIxgx7cAbzxYWxpSI 3evEC4xOYSzjzSc1sENPSqZROywpAJ60cannQqNee/Wc0H7bCHpPNoxarxaWYL/RxqKP lUEp6cej6yRNbPbACV08+Ww5n52M4xurTAr/Q= Received: by 10.68.226.137 with SMTP id rs9mr27635421pbc.94.1327801112151; Sat, 28 Jan 2012 17:38:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.37.9 with HTTP; Sat, 28 Jan 2012 17:37:52 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 29 Jan 2012 02:37:52 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 02:19, Lennart Borgman wrote: > Did I miss something? I can't see that I can directly add it to > css-mode-hook. Please tell me how to do it! Add what? The regexp? No, it's not supported (other than how you're doing it) but it is not required either. The file patterns method is more flexible (you can have multiple regexps, and they don't have to be the same for every file), and easy to set up C-x C-f yourfile.css M-s h r ; +!important C-x w b C-x C-s which you have to repeat in each .css file, but you can copy&paste, or use a template for new .css, and you can set up other regexps to warn you of other common pitfalls, etc. And in your .emacs: (add-hook 'css-mode-hook 'hi-lock-mode) (setq hi-lock-file-patterns-policy t) ;; or the function I described before, or the default `ask'... Your choice. But hey, whatever works for you. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 20:54:23 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 01:54:23 +0000 Received: from localhost ([127.0.0.1]:42684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrJyJ-0006WY-8v for submit@debbugs.gnu.org; Sat, 28 Jan 2012 20:54:23 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:52996 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrJyH-0006WP-MG for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 20:54:22 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RrJyG-00018u-Hn; Sat, 28 Jan 2012 20:54:20 -0500 From: Glenn Morris To: 10633@debbugs.gnu.org Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS References: X-Spook: ARPA Roswell anarchy Dick Cheney tempest fundamentalist X-Ran: Zaw;2&WWo7>bZ0jqBC_`HTC[^1pCF\;V"vYS>#5sPoyleRw^$[/_8.@?(2CBH+|;?_&x"h X-Hue: blue X-Attribution: GM Date: Sat, 28 Jan 2012 20:54:20 -0500 In-Reply-To: (Lennart Borgman's message of "Sun, 29 Jan 2012 00:26:25 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10633 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Lennart Borgman wrote: > Thanks, it is a great tip until it is fixed! Why should this be added to css-mode - do you have some data showing that many people writing CSS make the same mistake as you? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 20:56:35 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 01:56:35 +0000 Received: from localhost ([127.0.0.1]:42688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK0Q-0006aA-MV for submit@debbugs.gnu.org; Sat, 28 Jan 2012 20:56:34 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:40862) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK0P-0006Zs-9d for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 20:56:34 -0500 Received: by lahl5 with SMTP id l5so1568956lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 17:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=qrMDNqT77P/y5XbT/1ynXN+hFAkO1yOCg8ule3vmuG8=; b=QSUCDzpgosS1yEB8v0IlxHyvs7gd7DV/79Jgyn/rrOLgvi4aA7JhNPC5GEVpzLvVSp kpK7HdYPCPak1uaWC7zD7g7MbFabm28HP5uoCVNNoGPAyXsEn3q5clcOYz4nLSZC+KBX ajCOE19GyhAtZg5IJvFde899r6Kx3R2aN0MTg= Received: by 10.112.36.103 with SMTP id p7mr3202521lbj.91.1327802186208; Sat, 28 Jan 2012 17:56:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 17:56:06 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 02:56:06 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 02:37, Juanma Barranquero wrote: > On Sun, Jan 29, 2012 at 02:19, Lennart Borgman > wrote: > >> Did I miss something? I can't see that I can directly add it to >> css-mode-hook. Please tell me how to do it! > > Add what? The regexp? No, it's not supported (other than how you're > doing it) but it is not required either. The file patterns method is > more flexible (you can have multiple regexps, and they don't have to > be the same for every file), and easy to set up I found the way I do it much easier. It essentially behaves as if it were a part of the normal syntax highliting and that is what I wanted. I suggest that the manual might include some information like the one I gave. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 21:01:29 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 02:01:29 +0000 Received: from localhost ([127.0.0.1]:42696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK5A-0006iM-Bq for submit@debbugs.gnu.org; Sat, 28 Jan 2012 21:01:29 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:63269) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK57-0006i3-Eh for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 21:01:26 -0500 Received: by lahl5 with SMTP id l5so1569725lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 18:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=1NBRArujYP++gK6FMSdvzJkBc28uQWqI6MgP+VHDERo=; b=jP775/2kmvOzm5+c4HTwCZ9YS1RSkzcqyEEI2Pv4NcO94yoc2MhiXCsbhemYXXO4qx o2Z+UjH/UneMXFp3EGFP7FcmwOw87M3p0+0tbQYJX0E3gfInnAl8PB4yR89K/euwWwsg I7dWkhMNRzpAxH7Cd3xlZh5vpsFdvPbnM7j34= Received: by 10.112.25.35 with SMTP id z3mr3277954lbf.52.1327802478299; Sat, 28 Jan 2012 18:01:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 18:00:58 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 03:00:58 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Glenn Morris Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 02:54, Glenn Morris wrote: > Lennart Borgman wrote: > >> Thanks, it is a great tip until it is fixed! > > Why should this be added to css-mode - do you have some data showing > that many people writing CSS make the same mistake as you? I have no idea. A lot of people are writing css files, but only a few of them probably are using "!important" (since it is a more advanced concept and needed mostly in special cases). However there are a lot of things that can go wrong when you work with things like css. The browser casch was maybe not updated, the css parser in the browser maybe did not care about the mistake in your css file - or it did care very much and misinterprets a lot after that. Trying to get things to work in different browsers is a bit difficult because of this. So at least knowning your css file is correct makes it very much easier. (I have previously tried to explain the difficulties with complities, but I am not sure anyone cared or understood. That was some years ago, though.) From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 21:02:07 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 02:02:07 +0000 Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK5n-0006kC-C9 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 21:02:07 -0500 Received: from mail-pw0-f44.google.com ([209.85.160.44]:41500) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK5m-0006jB-8A for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 21:02:06 -0500 Received: by pbdu7 with SMTP id u7so2186962pbd.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 18:01:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=lfZ+V1lx01Xnl+sPUqsAZn42tBw+LmzlRSeqQye3J3s=; b=nm6ZWtfkC10nEekHsJkK0WgYsAZ/sflCtsjZDm/B1tt66hhr2/eXpISaSnl78bomDV R7nImhcbWqpbkksfJlIEZtS5XQ7aOjle0jXpNbHdo56OT5y6yYq593OwiNkeGemfhVLj z1DFRYy6piLhGdacov8hNh+arO/wigCHP4LJ4= Received: by 10.68.75.199 with SMTP id e7mr28060963pbw.128.1327802519222; Sat, 28 Jan 2012 18:01:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.37.9 with HTTP; Sat, 28 Jan 2012 18:01:19 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 29 Jan 2012 03:01:19 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 02:56, Lennart Borgman wrote: > I found the way I do it much easier. It essentially behaves as if it > were a part of the normal syntax highliting and that is what I wanted. If you want it to be "a part of the normal syntax higlighting", use font-lock-add-keywords in your css-mode-hook instead of using hi-lock. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 21:05:59 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 02:05:59 +0000 Received: from localhost ([127.0.0.1]:42711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK9M-0006pF-4y for submit@debbugs.gnu.org; Sat, 28 Jan 2012 21:05:59 -0500 Received: from mail-pw0-f44.google.com ([209.85.160.44]:50939) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK9K-0006p2-0H for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 21:05:46 -0500 Received: by pbdu7 with SMTP id u7so2188427pbd.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 18:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=4E1CF2dzMbBsyuI91X09d63gBpkaea379jNj6wSjqWo=; b=vDMKzRj97LPe9yONIiELCVq3koiBG6KkUdevNCiLwgsMKazzImUWUZcgetNK3MBusp sZ2a9Bwkm9JK/EJqyie6du8RCcV47v2n9kdptt2jy5H5gj0JUETqXR8Dep/5X6N/xKFz 1OKV/Y33LeVFhYZyS8pMC5Uz8CBZQWaOGZLFM= Received: by 10.68.75.135 with SMTP id c7mr27904074pbw.43.1327802739251; Sat, 28 Jan 2012 18:05:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.37.9 with HTTP; Sat, 28 Jan 2012 18:04:59 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 29 Jan 2012 03:04:59 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: Glenn Morris , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 03:00, Lennart Borgman wrote: > A lot of people are writing css files, but only a few > of them probably are using "!important" (since it is a more advanced > concept and needed mostly in special cases). I've used quite a few times !important, and I've never written "XXX; !important;". =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 21:07:36 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 02:07:36 +0000 Received: from localhost ([127.0.0.1]:42715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrKB5-0006rq-UB for submit@debbugs.gnu.org; Sat, 28 Jan 2012 21:07:36 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:56738) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrKB4-0006re-5K for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 21:07:34 -0500 Received: by lahl5 with SMTP id l5so1570735lah.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 18:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=KTxQ335KHj2zXNQ7UBXp9e1HBvj9Qh95SGAiLDPSUBE=; b=ZmKeoPWgbL2L9xjB06Xkt35SZZxyM/7he9r6wHnickFnQLXWpchxr2xh4lPdvL8Nyh Y5NtsLEfKBovtdzsJM0ZpjBCQouHD5nY6nT7DPr4g1xhR2tPTFxyZhFQVb235iQr9zLE WJmuTKjpaUg6m2QliEJoMG7vOXLmb+Ku3P22M= Received: by 10.152.129.226 with SMTP id nz2mr2718877lab.7.1327802847126; Sat, 28 Jan 2012 18:07:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 18:07:07 -0800 (PST) In-Reply-To: References: From: Lennart Borgman Date: Sun, 29 Jan 2012 03:07:07 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: Glenn Morris , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 03:04, Juanma Barranquero wrote: > On Sun, Jan 29, 2012 at 03:00, Lennart Borgman > wrote: > >> A lot of people are writing css files, but only a few >> of them probably are using "!important" (since it is a more advanced >> concept and needed mostly in special cases). > > I've used quite a few times !important, and I've never written "XXX; > !important;". That is good, but unfortunately it does not help others. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 21:13:00 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 02:13:00 +0000 Received: from localhost ([127.0.0.1]:42720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrKGK-0006z2-KF for submit@debbugs.gnu.org; Sat, 28 Jan 2012 21:13:00 -0500 Received: from mail-pz0-f44.google.com ([209.85.210.44]:57026) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrKGI-0006yp-23 for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 21:12:59 -0500 Received: by dado14 with SMTP id o14so2427620dad.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 18:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=RzPGUCg8+kQyS8WKDuHDsh69GbNXMkrBknTloQG2pds=; b=vr+ZKn5pU3cuhxCzcaTERjY4QsQwctd0Ir6SiykbrAmrwgg7OoA0EvGv4eXJtYt04e FjaGm1tdqp5HqtipM1m+foyhkhog4hEpS/GirJQW2oI+UkWnCx5fu8pBf8d8OuGRLrtk D8OaT4TZNmntfA0g0wnf9QzoSvipCIIUmxrcc= Received: by 10.68.226.137 with SMTP id rs9mr27830017pbc.94.1327803171184; Sat, 28 Jan 2012 18:12:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.37.9 with HTTP; Sat, 28 Jan 2012 18:12:11 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 29 Jan 2012 03:12:11 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: Glenn Morris , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jan 29, 2012 at 03:07, Lennart Borgman wrote: > That is good, but unfortunately it does not help others. Of course. It was just a way to express that what you find a common problem it is perhaps not so outside your event horizon. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 23:07:23 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 04:07:24 +0000 Received: from localhost ([127.0.0.1]:42755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrM31-0001x3-3S for submit@debbugs.gnu.org; Sat, 28 Jan 2012 23:07:23 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:53944 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrM2y-0001ww-Tx for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 23:07:21 -0500 Received: from bb121-7-229-69.singnet.com.sg ([121.7.229.69]:46435 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RrM2v-0002bg-SC; Sat, 28 Jan 2012 23:07:18 -0500 From: Chong Yidong To: Lennart Borgman Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS References: Date: Sun, 29 Jan 2012 12:07:09 +0800 In-Reply-To: (Lennart Borgman's message of "Sun, 29 Jan 2012 03:00:58 +0100") Message-ID: <874nvf2lua.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10633 Cc: Glenn Morris , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Lennart Borgman writes: > However there are a lot of things that can go wrong when you work with > things like css. I don't think it should be the job of CSS mode to highlight ad-hoc mistake conditions like that. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 23:13:09 2012 Received: (at 10633) by debbugs.gnu.org; 29 Jan 2012 04:13:09 +0000 Received: from localhost ([127.0.0.1]:42761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrM8b-00025U-77 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 23:13:09 -0500 Received: from mail-lpp01m020-f172.google.com ([209.85.217.172]:56687) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrM8Y-00024z-1z for 10633@debbugs.gnu.org; Sat, 28 Jan 2012 23:13:07 -0500 Received: by lbbgk8 with SMTP id gk8so169804lbb.3 for <10633@debbugs.gnu.org>; Sat, 28 Jan 2012 20:12:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ie2CR6iPaSYQJtgePNZvMLqJPilRYDSSZyOhbu451VM=; b=pS9hzUy7hkKG3og288LNCtpqQMy9WVYCDXFs9nW/H/GpkxzpIbz+qIM57NYAJKPYUd tiAA3kjd7qUA5iEQvE49QUUSRCXs5XtfAs0h8N+dIVYvnM1LT4FTpsygU386ziDOEJzR PCoMbfBurRV4wmqhJlWzXWo42c2OjO8KEEKkQ= Received: by 10.112.36.103 with SMTP id p7mr3262360lbj.91.1327810378210; Sat, 28 Jan 2012 20:12:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sat, 28 Jan 2012 20:12:38 -0800 (PST) In-Reply-To: <874nvf2lua.fsf@gnu.org> References: <874nvf2lua.fsf@gnu.org> From: Lennart Borgman Date: Sun, 29 Jan 2012 05:12:38 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Chong Yidong Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10633 Cc: Glenn Morris , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On Sun, Jan 29, 2012 at 05:07, Chong Yidong wrote: > Lennart Borgman writes: > >> However there are a lot of things that can go wrong when you work with >> things like css. > > I don't think it should be the job of CSS mode to highlight ad-hoc > mistake conditions like that. Please make a non-syntax marking a standard in all modes. ;-) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 20:17:35 2012 Received: (at control) by debbugs.gnu.org; 30 Jan 2012 01:17:35 +0000 Received: from localhost ([127.0.0.1]:44300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrfsE-0007gB-RH for submit@debbugs.gnu.org; Sun, 29 Jan 2012 20:17:35 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:40071 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrfsC-0007g3-Ap for control@debbugs.gnu.org; Sun, 29 Jan 2012 20:17:32 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Rrfs5-0007NR-FL for control@debbugs.gnu.org; Sun, 29 Jan 2012 20:17:25 -0500 Date: Sun, 29 Jan 2012 20:17:25 -0500 Message-Id: Subject: control message for bug 10633 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) tag 10633 wontfix From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 23:31:47 2012 Received: (at 10633) by debbugs.gnu.org; 30 Jan 2012 04:31:47 +0000 Received: from localhost ([127.0.0.1]:44419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RriuB-0004b3-5e for submit@debbugs.gnu.org; Sun, 29 Jan 2012 23:31:47 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:14029) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rriu8-0004ar-R0 for 10633@debbugs.gnu.org; Sun, 29 Jan 2012 23:31:45 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EADocJk9FpZaC/2dsb2JhbABDrlqBBoFyAQEEAVYjEAsOJhIUGA0kiA+3dohlBA4CAgMHAgQFAQMCAwwGCQECAYQYAgQDH4M3BIg/mnOEVw X-IronPort-AV: E=Sophos;i="4.71,590,1320642000"; d="scan'208";a="160093940" Received: from 69-165-150-130.dsl.teksavvy.com (HELO pastel.home) ([69.165.150.130]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Jan 2012 23:31:31 -0500 Received: by pastel.home (Postfix, from userid 20848) id 7923958ECC; Sun, 29 Jan 2012 23:31:31 -0500 (EST) From: Stefan Monnier To: Chong Yidong Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS Message-ID: References: <874nvf2lua.fsf@gnu.org> Date: Sun, 29 Jan 2012 23:31:31 -0500 In-Reply-To: <874nvf2lua.fsf@gnu.org> (Chong Yidong's message of "Sun, 29 Jan 2012 12:07:09 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10633 Cc: Lennart Borgman , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> However there are a lot of things that can go wrong when you work with >> things like css. > I don't think it should be the job of CSS mode to highlight ad-hoc > mistake conditions like that. There's cwarn-mode for something similar, so the question really is whether this error is common or specific to a particular user. I have no idea which it is. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 23:45:00 2012 Received: (at 10633) by debbugs.gnu.org; 30 Jan 2012 04:45:00 +0000 Received: from localhost ([127.0.0.1]:44427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rrj6x-0004tV-Nb for submit@debbugs.gnu.org; Sun, 29 Jan 2012 23:45:00 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:47320) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rrj6v-0004tK-Ug for 10633@debbugs.gnu.org; Sun, 29 Jan 2012 23:44:58 -0500 Received: by lahl5 with SMTP id l5so1903767lah.3 for <10633@debbugs.gnu.org>; Sun, 29 Jan 2012 20:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=dNFUDztht86QJmtzEHCs5Yy7AdkvWakDdAu1RvkQyEE=; b=p+9H18PF6uN8D4qrjnHEtXjKSdDtff9xJJyxSS2Oh7PvQM9Io9Y8Ep69p7U2BTncbR oiEfN4WfI5R8IFbdsdvC+EZwvFP6gqmauYjmHtlz6+QUenXM7P2p+awjoWXVgYnrtn8j ibUw4a+WrjYTARXmTWG1HxlzFfJMKj7yWGcFk= Received: by 10.112.47.225 with SMTP id g1mr661943lbn.52.1327898684171; Sun, 29 Jan 2012 20:44:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Sun, 29 Jan 2012 20:44:24 -0800 (PST) In-Reply-To: References: <874nvf2lua.fsf@gnu.org> From: Lennart Borgman Date: Mon, 30 Jan 2012 05:44:24 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: Chong Yidong , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Mon, Jan 30, 2012 at 05:31, Stefan Monnier wrote: > > >> However there are a lot of things that can go wrong when you work with > >> things like css. > > I don't think it should be the job of CSS mode to highlight ad-hoc > > mistake conditions like that. > > There's cwarn-mode for something similar, so the question really is > whether this error is common or specific to a particular user. > I have no idea which it is. The "!important" is colored as it is now even when I happen to put it after the ";". Not syntax coloring that would be enough to easily detect the problem. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 20:48:45 2012 Received: (at 10633) by debbugs.gnu.org; 31 Jan 2012 01:48:45 +0000 Received: from localhost ([127.0.0.1]:45952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs2px-0004vL-0i for submit@debbugs.gnu.org; Mon, 30 Jan 2012 20:48:45 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:13146) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs2pv-0004v8-JE for 10633@debbugs.gnu.org; Mon, 30 Jan 2012 20:48:43 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EACdIJ09MCqD0/2dsb2JhbABDrlaBBoFyAQEFViMQCzQSFBgNJMEaiykSAgIDBgIEAgEEAgIMBgoDAYQdAQQEg1cEiD+ac4RX X-IronPort-AV: E=Sophos;i="4.71,592,1320642000"; d="scan'208";a="160382920" Received: from 76-10-160-244.dsl.teksavvy.com (HELO pastel.home) ([76.10.160.244]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Jan 2012 20:48:23 -0500 Received: by pastel.home (Postfix, from userid 20848) id DAE8959470; Mon, 30 Jan 2012 20:48:22 -0500 (EST) From: Stefan Monnier To: Lennart Borgman Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS Message-ID: References: <874nvf2lua.fsf@gnu.org> Date: Mon, 30 Jan 2012 20:48:22 -0500 In-Reply-To: (Lennart Borgman's message of "Mon, 30 Jan 2012 05:44:24 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10633 Cc: Chong Yidong , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> >> However there are a lot of things that can go wrong when you work with >> >> things like css. >> > I don't think it should be the job of CSS mode to highlight ad-hoc >> > mistake conditions like that. >> There's cwarn-mode for something similar, so the question really is >> whether this error is common or specific to a particular user. >> I have no idea which it is. > The "!important" is colored as it is now even when I happen to put it > after the ";". Not syntax coloring that would be enough to easily > detect the problem. That would be perfect, yes. Patch welcome, Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 21:36:52 2012 Received: (at 10633) by debbugs.gnu.org; 31 Jan 2012 02:36:52 +0000 Received: from localhost ([127.0.0.1]:45988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs3aW-00060M-50 for submit@debbugs.gnu.org; Mon, 30 Jan 2012 21:36:52 -0500 Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:35000) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs3aU-000605-7Y for 10633@debbugs.gnu.org; Mon, 30 Jan 2012 21:36:51 -0500 Received: by lahl5 with SMTP id l5so2489452lah.3 for <10633@debbugs.gnu.org>; Mon, 30 Jan 2012 18:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=UN1eyXZNlJQ+T1uhG5lXEem1lSLbfM7THS2rg7VfPZ8=; b=k/YRcOUfRbNpRL0Uz/KM8ME03v1+T1YmCeFdOfUAV12+f3wZrvBBn5frhloD7Mq8v3 79UBsH33rx4lqg4+jN1VPx9vd8AKIs8wzArKLQbUJNTjS+mIuwHmKx6RN9LN3boSYRhW MVUM+86RBbg7pP5ExP3JqlM10GkdEw5YILFFw= Received: by 10.112.36.103 with SMTP id p7mr5128825lbj.91.1327977391176; Mon, 30 Jan 2012 18:36:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.97.11 with HTTP; Mon, 30 Jan 2012 18:36:11 -0800 (PST) In-Reply-To: References: <874nvf2lua.fsf@gnu.org> From: Lennart Borgman Date: Tue, 31 Jan 2012 03:36:11 +0100 Message-ID: Subject: Re: bug#10633: Please mark invalid "; !important;" in CSS To: Stefan Monnier Content-Type: multipart/alternative; boundary=e0cb4efe34dcabbd4c04b7c9d465 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10633 Cc: Chong Yidong , 10633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --e0cb4efe34dcabbd4c04b7c9d465 Content-Type: text/plain; charset=UTF-8 On Tue, Jan 31, 2012 at 02:48, Stefan Monnier wrote: > >> >> However there are a lot of things that can go wrong when you work > with > >> >> things like css. > >> > I don't think it should be the job of CSS mode to highlight ad-hoc > >> > mistake conditions like that. > >> There's cwarn-mode for something similar, so the question really is > >> whether this error is common or specific to a particular user. > >> I have no idea which it is. > > The "!important" is colored as it is now even when I happen to put it > > after the ";". Not syntax coloring that would be enough to easily > > detect the problem. > > That would be perfect, yes. Patch welcome, > > I think this is enough: ;;("!\\s-*important" . font-lock-builtin-face) ("[^; \t\n]\\s-*\\(!\\s-*important\\)" (1 'font-lock-builtin-face)) --e0cb4efe34dcabbd4c04b7c9d465 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2012 at 02:48, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> >> However there are a lot of things that = can go wrong when you work with
>> >> things like css.
>> > I don't think it should be the job of CSS mode to highlig= ht ad-hoc
>> > mistake conditions like that.
>> There's cwarn-mode for something similar, so the question real= ly is
>> whether this error is common or specific to a particular user.
>> I have no idea which it is.
> The "!important" is colored as it is now even when I happen = to put it
> after the ";". Not syntax coloring that would be enough to e= asily
> detect the problem.

That would be perfect, yes. =C2=A0Patch welcome,

=
I think this is enough:

=C2=A0 =C2=A0 ;;("!\\s-*impor= tant" . font-lock-builtin-face)
=C2=A0 =C2=A0 ("[^; \t\= n]\\s-*\\(!\\s-*important\\)"
=C2=A0 =C2=A0 =C2=A0(1 'font-lock-builtin-face))
=C2=A0
=

--e0cb4efe34dcabbd4c04b7c9d465-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 21:59:43 2012 Received: (at control) by debbugs.gnu.org; 8 Dec 2012 02:59:43 +0000 Received: from localhost ([127.0.0.1]:59695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThAdi-00051J-LR for submit@debbugs.gnu.org; Fri, 07 Dec 2012 21:59:43 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34344) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThAdh-00051C-1n for control@debbugs.gnu.org; Fri, 07 Dec 2012 21:59:41 -0500 Received: by mail-pa0-f44.google.com with SMTP id hz11so859539pad.3 for ; Fri, 07 Dec 2012 18:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=ulLk8w+1WesgrxTYLuxjdBAv8o4+s5V2n0mkKKYy9ao=; b=DNmLEVssYh/jbmiFggrGdfBk41sATDqCZhcZyViS212/r8C3p7rQxe2gc5uN/QYfCz n1CYD5VWubpqr8fNneJ/mE/u8OWt4sZ6qBhYtEXSzNMpAfq2Uhu+cTELk0s9hngyZRTV XOiHJADY+zDcjofXGJuJ6U9Lig1yCZe9CkGtXWm5Dxr1sCpiR0hdIdfRf13qtgltIDpO 0yRnq71ROaBIwb+jUA8rFZHeVSYFOmfJ1wd+ri35A1TLvkq0EywBuy6Sow4H+Ekpm9bO EYoOQuXxgn4EQ6sZjimSNT6EdicTl2iKXwOTGxWnhuBTw1Ku5KhS1o/hLlqWsGxdFCqW bSxg== Received: by 10.69.1.73 with SMTP id be9mr21096989pbd.116.1354935558721; Fri, 07 Dec 2012 18:59:18 -0800 (PST) Received: from ulysses (cm107.delta179.maxonline.com.sg. [59.189.179.107]) by mx.google.com with ESMTPS id i5sm7610937pax.13.2012.12.07.18.59.16 (version=SSLv3 cipher=OTHER); Fri, 07 Dec 2012 18:59:17 -0800 (PST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 975 Date: Sat, 08 Dec 2012 10:59:13 +0800 Message-ID: <87k3st5jwe.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) close 975 close 2577 close 3640 close 3729 close 8256 close 10633 close 11407 thanks From unknown Thu Aug 14 20:50:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Jan 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator