From unknown Sun Jun 22 11:45:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10626: Should configure fail if pkg-config fails? Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2012 09:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso Cc: 10626@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.132774172622649 (code B ref -1); Sat, 28 Jan 2012 09:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2012 09:08:46 +0000 Received: from localhost ([127.0.0.1]:47474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4H8-0005tE-14 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:08:46 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58565) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4H4-0005t2-JV for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:08:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4GH-0006Ro-3F for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:07:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:35940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GH-0006Rk-1l for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:07:53 -0500 Received: from eggs.gnu.org ([140.186.70.92]:49382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GF-0001BT-TA for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4GE-0006RS-4q for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:51 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:34664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GD-0006RM-OZ for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:50 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D1C4FA60063; Sat, 28 Jan 2012 01:07:48 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9zJhslGumkRY; Sat, 28 Jan 2012 01:07:48 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E48A6A60034; Sat, 28 Jan 2012 01:07:47 -0800 (PST) Message-ID: <4F23BAE6.5080906@cs.ucla.edu> Date: Sat, 28 Jan 2012 01:07:50 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 References: <4F1F3019.8060808@cs.ucla.edu> <4F1F356F.9040501@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On 01/24/2012 06:15 PM, Jordi Guti=C3=A9rrez Hermoso wrote: > it shouldn't assume that GTK+ is working correctly if > pkg-config returns nonzero exit status. True enough. Here's a proposed patch, which I'd like to install into the trunk. I'm CC'ing this to bug-gnu-emacs instead of to emacs-devel, so that it has a proper bug number. =3D=3D=3D modified file 'ChangeLog' --- ChangeLog 2012-01-19 07:21:25 +0000 +++ ChangeLog 2012-01-28 09:04:13 +0000 @@ -1,3 +1,11 @@ +2012-01-28 Paul Eggert + + Check pkg-config exit status when configuring. + * configure.in (PKG_CHECK_MODULES): Do not assume that pkg-config + works; check its exit status. Problem reported by Jordi Guti=C3=A9rrez + Hermoso in + . + 2012-01-16 Juanma Barranquero =20 * .bzrignore: Ignore etc/__pycache__. =3D=3D=3D modified file 'configure.in' --- configure.in 2012-01-19 07:21:25 +0000 +++ configure.in 2012-01-28 09:04:13 +0000 @@ -1124,17 +1124,14 @@ if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION;= then AC_MSG_CHECKING(for $2) =20 - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD; then - AC_MSG_RESULT(yes) + if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && + $1_CFLAGS=3D`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && + $1_LIBS=3D`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then + + $1_CFLAGS=3D`AS_ECHO(["$$1_CFLAGS"]) | sed -e 's,///*,/,g'` + $1_LIBS=3D`AS_ECHO(["$$1_LIBS"]) | sed -e 's,///*,/,g'` + AC_MSG_RESULT([yes CFLAGS=3D'$$1_CFLAGS' LIBS=3D'$$1_LIBS']) succeeded=3Dyes - - AC_MSG_CHECKING($1_CFLAGS) - $1_CFLAGS=3D`$PKG_CONFIG --cflags "$2"|sed -e 's,///*,/,g'` - AC_MSG_RESULT($$1_CFLAGS) - - AC_MSG_CHECKING($1_LIBS) - $1_LIBS=3D`$PKG_CONFIG --libs "$2"|sed -e 's,///*,/,g'` - AC_MSG_RESULT($$1_LIBS) else AC_MSG_RESULT(no) $1_CFLAGS=3D"" From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 04:11:47 2012 Received: (at control) by debbugs.gnu.org; 28 Jan 2012 09:11:47 +0000 Received: from localhost ([127.0.0.1]:47479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4K2-0005xt-Iw for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:11:47 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:45291) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4K0-0005xi-S9 for control@debbugs.gnu.org; Sat, 28 Jan 2012 04:11:45 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5F55CA60063 for ; Sat, 28 Jan 2012 01:10:56 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KcTPHAS4lnMF for ; Sat, 28 Jan 2012 01:10:56 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2436BA60034 for ; Sat, 28 Jan 2012 01:10:56 -0800 (PST) Message-ID: <4F23BBA2.4010401@cs.ucla.edu> Date: Sat, 28 Jan 2012 01:10:58 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: Bug#10626 has a patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 10626 patch From unknown Sun Jun 22 11:45:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10626: Should configure fail if pkg-config fails? Resent-From: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Mar 2012 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 10626@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13323615426427 (code B ref -1); Wed, 21 Mar 2012 20:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Mar 2012 20:25:42 +0000 Received: from localhost ([127.0.0.1]:60137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAS6H-0001fb-9r for submit@debbugs.gnu.org; Wed, 21 Mar 2012 16:25:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33121) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAS6D-0001fR-CA for submit@debbugs.gnu.org; Wed, 21 Mar 2012 16:25:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SARcS-0005kb-Ci for submit@debbugs.gnu.org; Wed, 21 Mar 2012 15:54:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcS-0005kS-65 for submit@debbugs.gnu.org; Wed, 21 Mar 2012 15:54:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcQ-0006wt-5M for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:54:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SARcN-0005k1-SZ for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:54:49 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:45948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcN-0005jp-LH for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:54:47 -0400 Received: by iajr24 with SMTP id r24so2460006iaj.0 for ; Wed, 21 Mar 2012 12:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/ETZzFa/uloWI5MUBLOT0rv/3BOKRut9fypu6Uvc3Ns=; b=H2jK+xAecdPR7ySbZoqVk9S+ve+UhBFu+0KAhA6oiBxkK3i7ulekfQOTHVhWV3t23h T2pYZTsKO3DBsIBMcAFrGTXyxfJ5XJRmZmeUN0ekoPUjZTNS7TaSW7SPC3RUhOujxHlE XIg/r2s/ShMn9sRqqU7f37E412euQ6659rqjtJOSG+KIb/L06k+FTjE3hb9j+UusqVpE hFI1Fb+F0BQ4YH/Ms3iZyK6IF2v4X8kB43hdOrDmATztO88Y2AibY6mm9s2hrKyYgEZv Q0fDOv+Bxa/jyWjMS46jgwu3NSTy+45PdUKXe+m017zLvf6p3E/43kq5bu25hQA8P1RP RG9A== MIME-Version: 1.0 Received: by 10.50.160.196 with SMTP id xm4mr3792635igb.24.1332359684240; Wed, 21 Mar 2012 12:54:44 -0700 (PDT) Received: by 10.231.104.65 with HTTP; Wed, 21 Mar 2012 12:54:44 -0700 (PDT) In-Reply-To: <4F23BAE6.5080906@cs.ucla.edu> References: <4F1F3019.8060808@cs.ucla.edu> <4F1F356F.9040501@cs.ucla.edu> <4F23BAE6.5080906@cs.ucla.edu> Date: Wed, 21 Mar 2012 15:54:44 -0400 X-Google-Sender-Auth: nrWGJNGMEqOjSD__RMa9FpkTzmE Message-ID: From: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi, sorry for the late reply. 2012/1/28 Paul Eggert : > On 01/24/2012 06:15 PM, Jordi Guti=C3=A9rrez Hermoso wrote: >> it shouldn't assume that GTK+ is working correctly if >> pkg-config returns nonzero exit status. > > True enough. =C2=A0Here's a proposed patch, which I'd like to > install into the trunk. =C2=A0I'm CC'ing this to bug-gnu-emacs > instead of to emacs-devel, so that it has a proper bug number. > > > =3D=3D=3D modified file 'ChangeLog' > --- ChangeLog =C2=A0 2012-01-19 07:21:25 +0000 > +++ ChangeLog =C2=A0 2012-01-28 09:04:13 +0000 > @@ -1,3 +1,11 @@ > +2012-01-28 =C2=A0Paul Eggert =C2=A0 > + > + =C2=A0 =C2=A0 =C2=A0 Check pkg-config exit status when configuring. > + =C2=A0 =C2=A0 =C2=A0 * configure.in (PKG_CHECK_MODULES): Do not assume = that pkg-config > + =C2=A0 =C2=A0 =C2=A0 works; check its exit status. =C2=A0Problem report= ed by Jordi Guti=C3=A9rrez > + =C2=A0 =C2=A0 =C2=A0 Hermoso in > + =C2=A0 =C2=A0 =C2=A0 . > + > =C2=A02012-01-16 =C2=A0Juanma Barranquero =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* .bzrignore: Ignore etc/__pycache__. > > =3D=3D=3D modified file 'configure.in' > --- configure.in =C2=A0 =C2=A0 =C2=A0 =C2=A02012-01-19 07:21:25 +0000 > +++ configure.in =C2=A0 =C2=A0 =C2=A0 =C2=A02012-01-28 09:04:13 +0000 > @@ -1124,17 +1124,14 @@ > =C2=A0 =C2=A0 =C2=A0if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFI= G_MIN_VERSION; then > =C2=A0 =C2=A0 =C2=A0 =C2=A0 AC_MSG_CHECKING(for $2) > > - =C2=A0 =C2=A0 =C2=A0 =C2=A0if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_L= OG_FD; then > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT(yes) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_L= OG_FD && > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_CFLAGS=3D`$PKG_CONFIG --cflags "$2= " 2>&AS_MESSAGE_LOG_FD` && > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_LIBS=3D`$PKG_CONFIG --libs "$2" 2>= &AS_MESSAGE_LOG_FD`; then > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $1_CFLAGS=3D`AS_ECHO(["$$1_CFLAGS"])= | sed -e 's,///*,/,g'` > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $1_LIBS=3D`AS_ECHO(["$$1_LIBS"]) | s= ed -e 's,///*,/,g'` > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT([yes CFLAGS=3D'$= $1_CFLAGS' LIBS=3D'$$1_LIBS']) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 succeeded=3Dyes > - > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_CHECKING($1_CFLAGS) > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_CFLAGS=3D`$PKG_CONFIG --cfl= ags "$2"|sed -e 's,///*,/,g'` > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT($$1_CFLAGS) > - > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_CHECKING($1_LIBS) > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_LIBS=3D`$PKG_CONFIG --libs = "$2"|sed -e 's,///*,/,g'` > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT($$1_LIBS) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 else > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 AC_MSG_RESULT(no) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $1_CFLAGS=3D"" > This patch no longer applies today (sigh, Changelog conflicts), and I'm a bit lazy about figuring out how to rebase this. I trust your good judgement, so I say you just push this. Thanks, - Jordi G. H. From unknown Sun Jun 22 11:45:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#10626: closed (Re: Should configure fail if pkg-config fails?) Message-ID: References: <4F80A818.3040105@cs.ucla.edu> <4F23BAE6.5080906@cs.ucla.edu> X-Gnu-PR-Message: they-closed 10626 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 10626@debbugs.gnu.org Date: Sat, 07 Apr 2012 20:49:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1333831742-17438-1" This is a multi-part message in MIME format... ------------=_1333831742-17438-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #10626: Should configure fail if pkg-config fails? which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 10626@debbugs.gnu.org. --=20 10626: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10626 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1333831742-17438-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 10626-done) by debbugs.gnu.org; 7 Apr 2012 20:48:57 +0000 Received: from localhost ([127.0.0.1]:44210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGcZ6-0004X0-Bn for submit@debbugs.gnu.org; Sat, 07 Apr 2012 16:48:56 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:38171) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGcZ3-0004Ws-Kk for 10626-done@debbugs.gnu.org; Sat, 07 Apr 2012 16:48:54 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D8C0139E8008; Sat, 7 Apr 2012 13:48:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9u9Jqxk59g2f; Sat, 7 Apr 2012 13:48:05 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BFF2439E8006; Sat, 7 Apr 2012 13:48:05 -0700 (PDT) Message-ID: <4F80A818.3040105@cs.ucla.edu> Date: Sat, 07 Apr 2012 13:48:24 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: =?UTF-8?B?Sm9yZGkgR3V0acOpcnJleiBIZXJtb3Nv?= Subject: Re: Should configure fail if pkg-config fails? References: <4F1F3019.8060808@cs.ucla.edu> <4F1F356F.9040501@cs.ucla.edu> <4F23BAE6.5080906@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10626-done Cc: 10626-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 03/21/2012 12:54 PM, Jordi Guti=C3=A9rrez Hermoso wrote: > I trust your good judgement, so I say you just push this. Thanks, I waited until the trunk was open for small non-regression fixes like this, and just now pushed it as bzr 107794 in the trunk. I'm marking the bug as done. http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/107794 ------------=_1333831742-17438-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jan 2012 09:08:46 +0000 Received: from localhost ([127.0.0.1]:47474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4H8-0005tE-14 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:08:46 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58565) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4H4-0005t2-JV for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:08:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4GH-0006Ro-3F for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:07:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:35940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GH-0006Rk-1l for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:07:53 -0500 Received: from eggs.gnu.org ([140.186.70.92]:49382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GF-0001BT-TA for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4GE-0006RS-4q for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:51 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:34664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GD-0006RM-OZ for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:50 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D1C4FA60063; Sat, 28 Jan 2012 01:07:48 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9zJhslGumkRY; Sat, 28 Jan 2012 01:07:48 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E48A6A60034; Sat, 28 Jan 2012 01:07:47 -0800 (PST) Message-ID: <4F23BAE6.5080906@cs.ucla.edu> Date: Sat, 28 Jan 2012 01:07:50 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: =?UTF-8?B?Sm9yZGkgR3V0acOpcnJleiBIZXJtb3Nv?= Subject: Re: Should configure fail if pkg-config fails? References: <4F1F3019.8060808@cs.ucla.edu> <4F1F356F.9040501@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On 01/24/2012 06:15 PM, Jordi Guti=C3=A9rrez Hermoso wrote: > it shouldn't assume that GTK+ is working correctly if > pkg-config returns nonzero exit status. True enough. Here's a proposed patch, which I'd like to install into the trunk. I'm CC'ing this to bug-gnu-emacs instead of to emacs-devel, so that it has a proper bug number. =3D=3D=3D modified file 'ChangeLog' --- ChangeLog 2012-01-19 07:21:25 +0000 +++ ChangeLog 2012-01-28 09:04:13 +0000 @@ -1,3 +1,11 @@ +2012-01-28 Paul Eggert + + Check pkg-config exit status when configuring. + * configure.in (PKG_CHECK_MODULES): Do not assume that pkg-config + works; check its exit status. Problem reported by Jordi Guti=C3=A9rrez + Hermoso in + . + 2012-01-16 Juanma Barranquero =20 * .bzrignore: Ignore etc/__pycache__. =3D=3D=3D modified file 'configure.in' --- configure.in 2012-01-19 07:21:25 +0000 +++ configure.in 2012-01-28 09:04:13 +0000 @@ -1124,17 +1124,14 @@ if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION;= then AC_MSG_CHECKING(for $2) =20 - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD; then - AC_MSG_RESULT(yes) + if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && + $1_CFLAGS=3D`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && + $1_LIBS=3D`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then + + $1_CFLAGS=3D`AS_ECHO(["$$1_CFLAGS"]) | sed -e 's,///*,/,g'` + $1_LIBS=3D`AS_ECHO(["$$1_LIBS"]) | sed -e 's,///*,/,g'` + AC_MSG_RESULT([yes CFLAGS=3D'$$1_CFLAGS' LIBS=3D'$$1_LIBS']) succeeded=3Dyes - - AC_MSG_CHECKING($1_CFLAGS) - $1_CFLAGS=3D`$PKG_CONFIG --cflags "$2"|sed -e 's,///*,/,g'` - AC_MSG_RESULT($$1_CFLAGS) - - AC_MSG_CHECKING($1_LIBS) - $1_LIBS=3D`$PKG_CONFIG --libs "$2"|sed -e 's,///*,/,g'` - AC_MSG_RESULT($$1_LIBS) else AC_MSG_RESULT(no) $1_CFLAGS=3D"" ------------=_1333831742-17438-1--