From unknown Fri Jun 20 18:19:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10624 <10624@debbugs.gnu.org> To: bug#10624 <10624@debbugs.gnu.org> Subject: Status: 24.0.92; default value of `dired-do-ch*' Reply-To: bug#10624 <10624@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:19:54 +0000 retitle 10624 24.0.92; default value of `dired-do-ch*' reassign 10624 emacs submitter 10624 "Drew Adams" severity 10624 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 10:36:58 2012 Received: (at submit) by debbugs.gnu.org; 27 Jan 2012 15:36:59 +0000 Received: from localhost ([127.0.0.1]:46911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqnrG-0005Y3-Ef for submit@debbugs.gnu.org; Fri, 27 Jan 2012 10:36:58 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42861) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqnrD-0005Xq-ON for submit@debbugs.gnu.org; Fri, 27 Jan 2012 10:36:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqnqQ-00065c-KZ for submit@debbugs.gnu.org; Fri, 27 Jan 2012 10:36:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:54211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqnqQ-00065Y-J2 for submit@debbugs.gnu.org; Fri, 27 Jan 2012 10:36:06 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqnqK-00032H-O5 for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2012 10:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqnqJ-000659-2A for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2012 10:36:00 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:31864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqnqI-000654-Su for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2012 10:35:59 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id q0RFZufC007618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 Jan 2012 15:35:57 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q0RFZuSv011742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 27 Jan 2012 15:35:56 GMT Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q0RFZuqX019921 for ; Fri, 27 Jan 2012 09:35:56 -0600 Received: from dradamslap1 (/10.159.35.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 27 Jan 2012 07:35:55 -0800 From: "Drew Adams" To: Subject: 24.0.92; default value of `dired-do-ch*' Date: Fri, 27 Jan 2012 07:35:52 -0800 Message-ID: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AczdCVo2rblNt82LRBGiBBT5l+fi7g== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4F22C45D.0082,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) When multiple files are marked, the default value for `dired-do-chmod' is taken from the permissions of the first of the marked files. a. This is not helpful - why the first marked and not the last or the 23rd? b. This is not clear - we don't let the user know which file the default permissions correspond to. (Not even any doc.) An *immediate* fix would be one of these alternative approaches: 1. Do not provide any default value at all. (Easiest to do, but least helpful improvement.) 2. Use the permissions of the current file (cursor location) as default, instead of the first marked file. And document this. This lets users easily control which permissions are copied. I prefer #2, but #1 is at least better than the current situation. This bug report is a followup to bug #9361, which was diverted and never addressed. Here is the point (quoted from #9361, where it was ignored): > If we are going to copy settings from a particular file in order to > make them available for, essentially, pasting operations to other > files, then the target file being copied from should be clear. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > The copy operation should be an explicit user choice, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > not something implicit, based only on the first marked file (why > not the last? or the 23rd?). But again, #1 and #2 are only immediate, remedial, partial fixes. They are not the best approach. A better fix is to do the following (and yes, this IS part of this report, as an enhancement request): 3. Create a separate command to copy the settings (including the permissions) from a particular file that the user can choose - e.g., the current (cursor line) file. 4. Use those copied settings as the basis for the default values of _all_ of the Dired `ch*' commands (`dired-do-chmod', `dired-do-chgrp', etc.). For each such command, use only the relevant part of the copied data. A single key would copy all of the displayed field info. Only the appropriate parts of that copied info would be used for the different default values of the various application/modifying commands. 5. In the case where there is no such previous copy, use the approach of #2 above as a fallback default - but, again, use it differently for each `ch*' command: use only the appropriate info (field) from the current (cursor line) file as the default value. And of course state in the doc string for each such command where the default value comes from. IOW, let users know how they can control what default value is made available. Such a *generalized copy/paste feature* for Dired would be quite useful. You could easily modify any set of files or directories according to any of the displayed Dired/`ls' fields. Even the file/dir name could be copied this way for reuse by editing when renaming another file/dir. (When there are multiple marked files to be renamed, the copied name could perhaps be incremented with a seed string in some way (which must be made clear to users). E.g., if the copied file name is `foo' and the (prompted for seed) is "-1000" then the renamed files could be `foo-1000', `foo-1001', etc. There are various possibities here. I mention this part only as food for thought, for now.) In GNU Emacs 24.0.92.1 (i386-mingw-nt5.1.2600) of 2012-01-22 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.6) --no-opt --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include --ldflags -LD:/devel/emacs/libs/gnutls-3.0.9/lib' From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 11:24:11 2012 Received: (at 10624) by debbugs.gnu.org; 27 Jan 2012 16:24:11 +0000 Received: from localhost ([127.0.0.1]:46951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rqoaw-0006eg-EU for submit@debbugs.gnu.org; Fri, 27 Jan 2012 11:24:11 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:27485) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rqoau-0006eS-T4 for 10624@debbugs.gnu.org; Fri, 27 Jan 2012 11:24:09 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id q0RGNOm9004906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <10624@debbugs.gnu.org>; Fri, 27 Jan 2012 16:23:24 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q0RGNNpf004351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <10624@debbugs.gnu.org>; Fri, 27 Jan 2012 16:23:24 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q0RGNM0R018824 for <10624@debbugs.gnu.org>; Fri, 27 Jan 2012 10:23:23 -0600 Received: from dradamslap1 (/10.159.35.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 27 Jan 2012 08:23:23 -0800 From: "Drew Adams" To: <10624@debbugs.gnu.org> References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> Subject: RE: bug#10624: 24.0.92; default value of `dired-do-ch*' Date: Fri, 27 Jan 2012 08:23:19 -0800 Message-ID: <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> Thread-Index: AczdCVo2rblNt82LRBGiBBT5l+fi7gABiQjQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4F22CF7D.000F,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 10624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Let me include this bit also from bug #9361. It offers a bit more in the way of suggestion for the requested enhancement. > The individual commands (`chmod' etc.) would have available, > either (a) as default value (mentioned above) or (b) on-demand > via a different minibuffer key from `M-n', the pertinent part > of the copied info. > > E.g., for command `chmod', it is the file permissions part of > the copied info that is pertinent, so (only) that would be used. > For command `touch', it is the mod time of the copied file info > that is pertinent, so that would be used. > > (This is akin to what is available in some editors for copying special > properties (e.g. XML attributes, face/font info, conditional > text values) and making them available via a `Paste Special' command. > Whatever the last type of special copy, the `Paste Special' pastes > that to its target.) From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 20:05:36 2012 Received: (at 10624) by debbugs.gnu.org; 15 Sep 2012 00:05:36 +0000 Received: from localhost ([127.0.0.1]:34496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCft9-0000ld-Id for submit@debbugs.gnu.org; Fri, 14 Sep 2012 20:05:35 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:52533 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCft6-0000lV-GG for 10624@debbugs.gnu.org; Fri, 14 Sep 2012 20:05:34 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id BC3B0451CCC7; Fri, 14 Sep 2012 17:04:30 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: 24.0.92; default value of `dired-do-ch*' Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> Date: Sat, 15 Sep 2012 02:47:41 +0300 In-Reply-To: <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> (Drew Adams's message of "Fri, 27 Jan 2012 08:23:19 -0800") Message-ID: <87392k2ml9.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) This request for enhancement is implemented with the following patch where the user will be able to mark the target file with the mark. Otherwise, the marked file is used as target only when it is a single file in the list of marked files: === modified file 'lisp/dired-aux.el' --- lisp/dired-aux.el 2012-09-13 23:42:39 +0000 +++ lisp/dired-aux.el 2012-09-14 23:45:05 +0000 @@ -223,10 +237,16 @@ (defun dired-do-chxxx (attribute-name pr ;; OP-SYMBOL is the type of operation (for use in `dired-mark-pop-up'). ;; ARG describes which files to use, as in `dired-get-marked-files'. (let* ((files (dired-get-marked-files t arg)) + (default-file (or (if (and transient-mark-mode mark-active) + (save-excursion (goto-char (mark t)) + (dired-get-filename t t))) + (if (and (= (length files) 1) + (stringp (car files))) + (car files)))) (default (and (eq op-symbol 'touch) - (stringp (car files)) + default-file (format-time-string "%Y%m%d%H%M.%S" - (nth 5 (file-attributes (car files)))))) + (nth 5 (file-attributes default-file))))) (prompt (concat "Change " attribute-name " of %s to" (if (eq op-symbol 'touch) " (default now): " From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 20:38:31 2012 Received: (at 10624) by debbugs.gnu.org; 15 Sep 2012 00:38:31 +0000 Received: from localhost ([127.0.0.1]:34512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCgP1-0001Y1-7H for submit@debbugs.gnu.org; Fri, 14 Sep 2012 20:38:31 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:17361) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TCgOo-0001Xa-RG for 10624@debbugs.gnu.org; Fri, 14 Sep 2012 20:38:29 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8F0bGh4007170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 15 Sep 2012 00:37:17 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8F0bFsY006891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 15 Sep 2012 00:37:16 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8F0bFd4017896; Fri, 14 Sep 2012 19:37:15 -0500 Received: from dradamslap1 (/10.159.182.71) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 14 Sep 2012 17:37:15 -0700 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> Subject: RE: bug#10624: 24.0.92; default value of `dired-do-ch*' Date: Fri, 14 Sep 2012 17:37:10 -0700 Message-ID: <4200B2318C4140E68FA74B61375885B9@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87392k2ml9.fsf@mail.jurta.org> Thread-Index: Ac2S1a/gkm+/uja4TgS4JYqKr8YTggAARU8g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -7.4 (-------) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) > This request for enhancement is implemented with the following patch > where the user will be able to mark the target file with the mark. > Otherwise, the marked file is used as target only when it is > a single file in the list of marked files: > > + (default-file (or (if (and transient-mark-mode mark-active) > + (save-excursion (goto-char (mark t)) > + (dired-get-filename t t))) > + (if (and (= (length files) 1) > + (stringp (car files))) > + (car files)))) > (default (and (eq op-symbol 'touch) > - (stringp (car files)) > + default-file > (format-time-string "%Y%m%d%H%M.%S" > - (nth 5 > (file-attributes (car files)))))) > + (nth 5 Thanks for working on this, but I'm not crazy about that approach at all, IIUC. And it does not implement the enhancement requested. The Emacs mark is not something that is very useful in this context, IMO. It's not obvious and visible. And why use the mark only when transient-mark-mode is enabled? That obviates use of the region for something more useful in Dired (e.g., Dired-marking all files in the region). What's more, if I read your code correctly, when there is no active mark you are still picking up the first of the marked files and using its data as the default. That is precisely the behavior that I filed this bug against. It makes no sense to use the 1st of the marked files, or the 13th, or any other file except the current-line file. That _is_ this bug. I stand by my alternative suggestions: 1. Do not provide any default value at all. (Easiest to do, but least helpful improvement.) 2. Minimal, easy to do now: Use the attributes of the file on the current line, providing them as the default for the marked files according to the particular command (mod time, various permission fields, etc.). 3. More complex, but more useful: Let the user hit a key to "copy" the attributes of a given file (on the current line - the "source" file), as if to a clipboard. Then use those attributes for subsequent "paste" operations, transferring the appropriate attributes (mod time, various permission fields, etc.) to the "target" (i.e., marked) files according to the particular command. For example (for #3), for `dired-do-chmod', the file permissions copied from the source file would be the default value. For `dired-do-touch', the mod time of the source file would be the default value for the operation. And so on. See the original bug report for more details. The point is to (a) have a reasonable source-file choice from which attributes are taken for the default and (b) push those attributes to the marked files as defaults for an operation, in a operation-pertinent way. If you cannot or do not want to do something like #3, please do #1 or something like #2. In the latter case (#1 or #2), or if you decide to do something altogether different from what I suggested, please keep this enhancement request open. Thx. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 19:08:24 2012 Received: (at 10624) by debbugs.gnu.org; 15 Sep 2012 23:08:24 +0000 Received: from localhost ([127.0.0.1]:35916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD1TM-0005Fw-1e for submit@debbugs.gnu.org; Sat, 15 Sep 2012 19:08:24 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:35650 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD1TJ-0005Fj-97 for 10624@debbugs.gnu.org; Sat, 15 Sep 2012 19:08:22 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id C967C451CC45; Sat, 15 Sep 2012 16:07:13 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: 24.0.92; default value of `dired-do-ch*' Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> Date: Sun, 16 Sep 2012 01:50:06 +0300 In-Reply-To: <4200B2318C4140E68FA74B61375885B9@us.oracle.com> (Drew Adams's message of "Fri, 14 Sep 2012 17:37:10 -0700") Message-ID: <87vcfex5bx.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > The Emacs mark is not something that is very useful in this context, > IMO. It's not obvious and visible. It is visible when transient-mark-mode is enabled. > And why use the mark only when transient-mark-mode is enabled? Because when transient-mark-mode is enabled, it is possible to deactivate the mark with C-g. > That obviates use of the region for something more useful in Dired It doesn't preclude from using the region in other Dired commands. > What's more, if I read your code correctly, when there is no active > mark you are still picking up the first of the marked files and using > its data as the default. No, you read code incorrectly. You could pay more attention to the line with (= (length files) 1) > 2. Minimal, easy to do now: Use the attributes of the file on the current line, > providing them as the default for the marked files according to the particular > command (mod time, various permission fields, etc.). This makes sense, but it might be too confusing. For instance, in the following scenario: type `m' to select a file, after that point moves to the next line with an arbitrary unselected file whose attributes will be used as the default value. This would be unexpected. > 3. More complex, but more useful: Let the user hit a key to "copy" the > attributes of a given file (on the current line - the "source" file), as if to a > clipboard. Then use those attributes for subsequent "paste" operations, I suppose a key to copy the attributes to use as the default value would be like `w' (`dired-copy-filename-as-kill'). It is worth thinking about. But it has one drawback that is not too obvious. > The point is to (a) have a reasonable source-file choice from which attributes > are taken for the default and (b) push those attributes to the marked files as > defaults for an operation, in a operation-pertinent way. Using the mark in transient-mark-mode is a reasonable source-file choice from which attributes are taken for the default, and could be added among other possible methods. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 19:08:27 2012 Received: (at 10624) by debbugs.gnu.org; 15 Sep 2012 23:08:27 +0000 Received: from localhost ([127.0.0.1]:35918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD1TO-0005G4-Sz for submit@debbugs.gnu.org; Sat, 15 Sep 2012 19:08:27 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:35661 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD1TK-0005Fl-Fh for 10624@debbugs.gnu.org; Sat, 15 Sep 2012 19:08:23 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 0D512451CCCA; Sat, 15 Sep 2012 16:07:15 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: 24.0.92; default value of `dired-do-ch*' Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> Date: Sun, 16 Sep 2012 01:54:23 +0300 In-Reply-To: <4200B2318C4140E68FA74B61375885B9@us.oracle.com> (Drew Adams's message of "Fri, 14 Sep 2012 17:37:10 -0700") Message-ID: <87sjaj2atc.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Dired-marking all files in the region This is a feature that's sorely missing from Dired. Currently marking a long list of files by pressing `m' and holding it as long as the cursor eventually arrives to the last file is too tedious (and the numeric prefix doesn't help when the exact number of files to mark is not known). Now with the following patch it's possible to mark a list of files with normal region selection (and using isearch to speed it up) and type `m' (or `u' to unmark) just once. === modified file 'lisp/dired.el' --- lisp/dired.el 2012-09-14 03:55:16 +0000 +++ lisp/dired.el 2012-09-15 22:54:12 +0000 @@ -3102,12 +3120,15 @@ (defun dired-mark (arg) and \\[dired-unmark] on a subdir to remove the marks in this subdir." (interactive "P") + (if (and transient-mark-mode mark-active) + ;; Mark files in the active region. + (dired-mark-files-in-region (region-beginning) (region-end)) (if (dired-get-subdir) (save-excursion (dired-mark-subdir-files)) (let ((inhibit-read-only t)) (dired-repeat-over-lines (prefix-numeric-value arg) - (function (lambda () (delete-char 1) (insert dired-marker-char))))))) + (function (lambda () (delete-char 1) (insert dired-marker-char)))))))) (defun dired-unmark (arg) "Unmark the current (or next ARG) files. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 00:48:21 2012 Received: (at 10624) by debbugs.gnu.org; 16 Sep 2012 04:48:21 +0000 Received: from localhost ([127.0.0.1]:36201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD6mK-0007Jw-RX for submit@debbugs.gnu.org; Sun, 16 Sep 2012 00:48:21 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:23780) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD6mI-0007Jp-Mp for 10624@debbugs.gnu.org; Sun, 16 Sep 2012 00:48:19 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8G4lABG022404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 16 Sep 2012 04:47:11 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8G4l9R5010176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 16 Sep 2012 04:47:09 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8G4l9Wc001689; Sat, 15 Sep 2012 23:47:09 -0500 Received: from dradamslap1 (/10.159.221.74) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 15 Sep 2012 21:47:08 -0700 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87vcfex5bx.fsf@mail.jurta.org> Subject: RE: bug#10624: 24.0.92; default value of `dired-do-ch*' Date: Sat, 15 Sep 2012 21:47:00 -0700 Message-ID: <567949A5085246DD87365C10B6DF80FA@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87vcfex5bx.fsf@mail.jurta.org> Thread-Index: Ac2Tltmt998uMne/Sa22c2s1sUSKJAAJVapw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -7.4 (-------) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) > > What's more, if I read your code correctly, when there is no active > > mark you are still picking up the first of the marked files > > and using its data as the default. > > No, you read code incorrectly. You could pay more attention to the > line with (= (length files) 1) I meant when there are multiple marked files. When there is only one, if it is not explicitly marked in any way but just the current-line file then that is even less interesting (since it is also the target of the action). Using the current line file as the source of the default attributes is something I suggested, but only when there are other, explicitly marked files. > > 2. Minimal, easy to do now: Use the attributes of the file > > on the current line, providing them as the default for the > > marked files according to the particular command (mod time, > > various permission fields, etc.). > > This makes sense, but it might be too confusing. For instance, > in the following scenario: type `m' to select a file, after that > point moves to the next line with an arbitrary unselected file > whose attributes will be used as the default value. This would be > unexpected. Not if it is expected. ;-) Clearly, the default must come from somewhere (or else take my other, simplest suggestion and get rid of any default). And unless you adopt something like my main suggestion, which lets the user explicitly set the default (and save that until the next setting action), the current-line file makes the most sense, to me. At least I haven't seen a better suggestion. Clearly (to me anyway), just picking the first of the explicitly marked files, as we have been doing, is downright silly. We should provide some predictable way for the user to choose which file to use as the source of the default values. > > 3. More complex, but more useful: Let the user hit a key to > > "copy" the attributes of a given file (on the current line - > > the "source" file), as if to a clipboard. Then use those > > attributes for subsequent "paste" operations, > > I suppose a key to copy the attributes to use as the default value > would be like `w' (`dired-copy-filename-as-kill'). It is > worth thinking about. I have used that approach in my use of delicious-style tags for files, for quite some time now: `T c' or `T M-w' copies the tags from the current-line file. `T p' or `T C-y' pastes those tags to another current-line file, adding them to any existing tags for that file. `T q' pastes similarly, but replaces any existing tags for the target file. `T > p' (`T > C-y') and `T > q' do the same pasting thing, but for the marked files. > But it has one drawback that is not too obvious. Which is what? Or should we guess, because it is not too obvious? > > The point is to (a) have a reasonable source-file choice > > from which attributes are taken for the default and > > (b) push those attributes to the marked files as > > defaults for an operation, in a operation-pertinent way. > > Using the mark in transient-mark-mode is a reasonable > source-file choice from which attributes are taken for the > default, and could be added among other possible methods. Well, we can agree to disagree about your choice. But I agree that it _is_ one way to let users predictably choose which file to pull the defaults from. You are doing the same thing I suggest, but your key choice is `C-SPC', making that key do double duty. And distracting the user with the (irrelevant) region display, to boot. This has nothing to do with the region. And if a user sets the mark for some other reason (uh, for the region, for example) then - whoop! - the copy defaults are changed again at the same time. It is far better to separate the keys for these two totally unrelated purposes: (1) setting the region and making it active, and (2) copying attributes from the current-line file to use as defaults for subsequent operations. We and the user gain nothing by coupling those two meanings/uses of `C-SPC'. (Well, perhaps we save a key binding.) And the user loses the possibility of setting and activating the region without also copying defaults (and vice versa). Just bind a new key for such copying - that's still my suggestion. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 00:48:44 2012 Received: (at 10624) by debbugs.gnu.org; 16 Sep 2012 04:48:44 +0000 Received: from localhost ([127.0.0.1]:36204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD6mh-0007KX-CF for submit@debbugs.gnu.org; Sun, 16 Sep 2012 00:48:44 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:40488) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD6me-0007KQ-QI for 10624@debbugs.gnu.org; Sun, 16 Sep 2012 00:48:41 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8G4lV1q016421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 16 Sep 2012 04:47:32 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8G4lVb4014805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 16 Sep 2012 04:47:31 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8G4lVLV001827; Sat, 15 Sep 2012 23:47:31 -0500 Received: from dradamslap1 (/10.159.221.74) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 15 Sep 2012 21:47:30 -0700 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> Subject: RE: bug#10624: 24.0.92; default value of `dired-do-ch*' Date: Sat, 15 Sep 2012 21:47:22 -0700 Message-ID: <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87sjaj2atc.fsf@mail.jurta.org> Thread-Index: Ac2Tltreh7AWMtYtQsW16+VwSJkbhAAJ+RXw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -7.4 (-------) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) > > Dired-marking all files in the region > > This is a feature that's sorely missing from Dired. Sorely missing from vanilla Dired, indeed. But it's been a feature of Dired+ since at least 1999, and probably several years before that. And I've offered that and all other features of Dired+ to Emacs Dev multiple times. Still sorely missing, though. 1. `S-mouse-1' marks all of the files in the region (no need for it to be active). This is like Windows Explorer: click a file, S-click another file, to mark them both and all between them. And `C-mouse-1' marks/unmarks the clicked file, also as in Windows Explorer. 2. `mouse-3' with an active region brings up a menu which includes items `Mark', `Unmark', `Toggle Marked/Unmarked', and `Flag for Deletion'. There are of course individual region commands to do each of those things - not bound to any keys by default. The mouse is handy enough - drag to select, then act on the selected files. Provided you use a mouse. ;-) Screenshots & info here, if anyone is interested: http://www.emacswiki.org/cgi-bin/wiki/DiredPlus > Currently marking a long list of files by pressing `m' > and holding it as long as the cursor eventually arrives > to the last file is too tedious (and the numeric prefix > doesn't help when the exact number of files to mark is not known). > > Now with the following patch it's possible to mark a list of files > with normal region selection (and using isearch to speed it up) > and type `m' (or `u' to unmark) just once. Now it's possible, indeed. 1999. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 20:02:18 2012 Received: (at 10624) by debbugs.gnu.org; 17 Sep 2012 00:02:18 +0000 Received: from localhost ([127.0.0.1]:37838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOn3-0006Cv-Nu for submit@debbugs.gnu.org; Sun, 16 Sep 2012 20:02:18 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:36494 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOmz-0006Cg-EC for 10624@debbugs.gnu.org; Sun, 16 Sep 2012 20:02:15 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 61AA7451CAEE; Sun, 16 Sep 2012 17:01:00 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: Dired-marking all files in the region Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> Date: Mon, 17 Sep 2012 02:45:31 +0300 In-Reply-To: <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> (Drew Adams's message of "Sat, 15 Sep 2012 21:47:22 -0700") Message-ID: <87fw6his5w.fsf_-_@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >>> Dired-marking all files in the region >> >> This is a feature that's sorely missing from Dired. > > But it's been a feature of Dired+ since at least 1999, and probably several > years before that. And I've offered that and all other features of Dired+ to > Emacs Dev multiple times. Still sorely missing, though. The size of Dired+ is overwhelming, let's add its features to Dired one at a time ;-) Below is a complete tested patch for the region-marking feature: === modified file 'lisp/dired.el' --- lisp/dired.el 2012-09-14 03:55:16 +0000 +++ lisp/dired.el 2012-09-16 23:41:24 +0000 @@ -3097,21 +3115,37 @@ (defun dired-mark-files-in-region (start (defun dired-mark (arg) "Mark the current (or next ARG) files. If on a subdir headerline, mark all its files except `.' and `..'. +If the region is active in Transient Mark mode, mark all files +in the active region. Use \\[dired-unmark-all-files] to remove all marks and \\[dired-unmark] on a subdir to remove the marks in this subdir." (interactive "P") - (if (dired-get-subdir) - (save-excursion (dired-mark-subdir-files)) + (cond + ;; Mark files in the active region. + ((and transient-mark-mode mark-active) + (save-excursion + (let ((beg (region-beginning)) + (end (region-end))) + (dired-mark-files-in-region + (progn (goto-char beg) (line-beginning-position)) + (progn (goto-char end) (line-beginning-position)))))) + ;; Mark subdir files from the subdir headerline. + ((dired-get-subdir) + (save-excursion (dired-mark-subdir-files))) + ;; Mark the current (or next ARG) files. + (t (let ((inhibit-read-only t)) (dired-repeat-over-lines (prefix-numeric-value arg) - (function (lambda () (delete-char 1) (insert dired-marker-char))))))) + (function (lambda () (delete-char 1) (insert dired-marker-char)))))))) (defun dired-unmark (arg) "Unmark the current (or next ARG) files. -If looking at a subdir, unmark all its files except `.' and `..'." +If looking at a subdir, unmark all its files except `.' and `..'. +If the region is active in Transient Mark mode, unmark all files +in the active region." (interactive "P") (let ((dired-marker-char ?\040)) (dired-mark arg))) @@ -3119,8 +3153,9 @@ (defun dired-unmark (arg) (defun dired-flag-file-deletion (arg) "In Dired, flag the current line's file for deletion. With prefix arg, repeat over several lines. - -If on a subdir headerline, mark all its files except `.' and `..'." +If on a subdir headerline, flag all its files except `.' and `..'. +If the region is active in Transient Mark mode, flag all files +in the active region." (interactive "P") (let ((dired-marker-char dired-del-marker)) (dired-mark arg))) @@ -3128,7 +3163,9 @@ (defun dired-flag-file-deletion (arg) (defun dired-unmark-backward (arg) "In Dired, move up lines and remove marks or deletion flags there. Optional prefix ARG says how many lines to unmark/unflag; default -is one line." +is one line. +If the region is active in Transient Mark mode, unmark all files +in the active region." (interactive "p") (dired-unmark (- arg))) From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 20:02:20 2012 Received: (at 10624) by debbugs.gnu.org; 17 Sep 2012 00:02:20 +0000 Received: from localhost ([127.0.0.1]:37840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOn5-0006D3-Sk for submit@debbugs.gnu.org; Sun, 16 Sep 2012 20:02:20 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:36503 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOn0-0006Ck-TN for 10624@debbugs.gnu.org; Sun, 16 Sep 2012 20:02:16 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7EFE5451CCB0; Sun, 16 Sep 2012 17:01:02 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: 24.0.92; default value of `dired-do-ch*' Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87vcfex5bx.fsf@mail.jurta.org> <567949A5085246DD87365C10B6DF80FA@us.oracle.com> Date: Mon, 17 Sep 2012 02:48:09 +0300 In-Reply-To: <567949A5085246DD87365C10B6DF80FA@us.oracle.com> (Drew Adams's message of "Sat, 15 Sep 2012 21:47:00 -0700") Message-ID: <871ui1h6e2.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > `T c' or `T M-w' copies the tags from the current-line file. > > `T p' or `T C-y' pastes those tags to another current-line file, > adding them to any existing tags for that file. > > `T q' pastes similarly, but replaces any existing tags for the target file. > > `T > p' (`T > C-y') and `T > q' do the same pasting thing, but for the marked > files. Oh no, a whole prefix map for such an auxiliary feature. But I like the simplicity of your suggestion #2 - use the attributes of the file on the current line. It's implemented in a small patch below: === modified file 'lisp/dired-aux.el' --- lisp/dired-aux.el 2012-09-13 23:42:39 +0000 +++ lisp/dired-aux.el 2012-09-16 23:47:32 +0000 @@ -223,10 +247,17 @@ (defun dired-do-chxxx (attribute-name pr ;; OP-SYMBOL is the type of operation (for use in `dired-mark-pop-up'). ;; ARG describes which files to use, as in `dired-get-marked-files'. (let* ((files (dired-get-marked-files t arg)) - (default (and (eq op-symbol 'touch) - (stringp (car files)) - (format-time-string "%Y%m%d%H%M.%S" - (nth 5 (file-attributes (car files)))))) + ;; The source of default file attributes is the file at point. + (default-file (dired-get-filename t)) + (default (when default-file + (cond ((eq op-symbol 'touch) + (format-time-string + "%Y%m%d%H%M.%S" + (nth 5 (file-attributes default-file)))) + ((eq op-symbol 'chown) + (nth 2 (file-attributes default-file 'string))) + ((eq op-symbol 'chgrp) + (nth 3 (file-attributes default-file 'string)))))) (prompt (concat "Change " attribute-name " of %s to" (if (eq op-symbol 'touch) " (default now): " @@ -263,11 +294,15 @@ (defun dired-do-chxxx (attribute-name pr ;;;###autoload (defun dired-do-chmod (&optional arg) "Change the mode of the marked (or next ARG) files. -Symbolic modes like `g+w' are allowed." +Symbolic modes like `g+w' are allowed. +Type M-n to pull the file attributes of the file at point +into the minibuffer." (interactive "P") (let* ((files (dired-get-marked-files t arg)) - (modestr (and (stringp (car files)) - (nth 8 (file-attributes (car files))))) + ;; The source of default file attributes is the file at point. + (default-file (dired-get-filename t)) + (modestr (when default-file + (nth 8 (file-attributes default-file)))) (default (and (stringp modestr) (string-match "^.\\(...\\)\\(...\\)\\(...\\)$" modestr) @@ -297,7 +335,9 @@ (defun dired-do-chmod (&optional arg) ;;;###autoload (defun dired-do-chgrp (&optional arg) - "Change the group of the marked (or next ARG) files." + "Change the group of the marked (or next ARG) files. +Type M-n to pull the file attributes of the file at point +into the minibuffer." (interactive "P") (if (memq system-type '(ms-dos windows-nt)) (error "chgrp not supported on this system")) @@ -305,7 +345,9 @@ (defun dired-do-chgrp (&optional arg) ;;;###autoload (defun dired-do-chown (&optional arg) - "Change the owner of the marked (or next ARG) files." + "Change the owner of the marked (or next ARG) files. +Type M-n to pull the file attributes of the file at point +into the minibuffer." (interactive "P") (if (memq system-type '(ms-dos windows-nt)) (error "chown not supported on this system")) @@ -314,7 +356,9 @@ (defun dired-do-chown (&optional arg) ;;;###autoload (defun dired-do-touch (&optional arg) "Change the timestamp of the marked (or next ARG) files. -This calls touch." +This calls touch. +Type M-n to pull the file attributes of the file at point +into the minibuffer." (interactive "P") (dired-do-chxxx "Timestamp" dired-touch-program 'touch arg)) From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 20:40:51 2012 Received: (at 10624) by debbugs.gnu.org; 17 Sep 2012 00:40:51 +0000 Received: from localhost ([127.0.0.1]:37988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDPON-0007F2-EF for submit@debbugs.gnu.org; Sun, 16 Sep 2012 20:40:51 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:16699) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDPOJ-0007Eo-HW for 10624@debbugs.gnu.org; Sun, 16 Sep 2012 20:40:48 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8H0dYu8023496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 17 Sep 2012 00:39:35 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8H0dXWg017895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Sep 2012 00:39:34 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8H0dXVD028595; Sun, 16 Sep 2012 19:39:33 -0500 Received: from dradamslap1 (/10.159.170.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 16 Sep 2012 17:39:33 -0700 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com><87vcfex5bx.fsf@mail.jurta.org><567949A5085246DD87365C10B6DF80FA@us.oracle.com> <871ui1h6e2.fsf@mail.jurta.org> Subject: RE: bug#10624: 24.0.92; default value of `dired-do-ch*' Date: Sun, 16 Sep 2012 17:39:22 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <871ui1h6e2.fsf@mail.jurta.org> Thread-Index: Ac2UZ4i5vHaD+7QbTCaRPxigNiSy9AABFKWQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -7.4 (-------) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) > > `T c' or `T M-w' copies the tags from the current-line file. > > > > `T p' or `T C-y' pastes those tags to another current-line file, > > adding them to any existing tags for that file. > > > > `T q' pastes similarly, but replaces any existing tags for > > the target file. > > > > `T > p' (`T > C-y') and `T > q' do the same pasting thing, > > but for the marked files. > > Oh no, a whole prefix map for such an auxiliary feature. Actually, there is a lot more on prefix key `T'. But that prefix key pertains only if you load Bookmark+. All keys on `T' have to do with tagged files, where tagging is understood in the Delicious sense. The point of mentioning it in this thread was to show the use of a key to copy stuff from one file to subsequently use over and over for pasting (by another key) to other files. Dired Mode Bindings Starting With T: key binding --- ------- T C-y diredp-paste-add-tags-this-file T ESC Prefix Command T + diredp-tag-this-file T - diredp-untag-this-file T 0 diredp-remove-all-tags-this-file T > Prefix Command T c diredp-copy-tags-this-file T m Prefix Command T p diredp-paste-add-tags-this-file T q diredp-paste-replace-tags-this-file T u Prefix Command T v diredp-set-tag-value-this-file T icicle-complete-keys T u % diredp-unmark-files-tagged-regexp T u * diredp-unmark-files-tagged-all T u + diredp-unmark-files-tagged-some T u ~ Prefix Command T u icicle-complete-keys T m % diredp-mark-files-tagged-regexp T m * diredp-mark-files-tagged-all T m + diredp-mark-files-tagged-some T m ~ Prefix Command T m icicle-complete-keys T > C-y diredp-do-paste-add-tags T > + diredp-do-tag T > - diredp-do-untag T > 0 diredp-do-remove-all-tags T > p diredp-do-paste-add-tags T > q diredp-do-paste-replace-tags T > v diredp-do-set-tag-value T > icicle-complete-keys T M-w diredp-copy-tags-this-file T ESC icicle-complete-keys T u ~ * diredp-unmark-files-tagged-not-all T u ~ + diredp-unmark-files-tagged-none T u ~ icicle-complete-keys T m ~ * diredp-mark-files-tagged-not-all T m ~ + diredp-mark-files-tagged-none T m ~ icicle-complete-keys From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 19:24:19 2012 Received: (at 10624-done) by debbugs.gnu.org; 18 Sep 2012 23:24:19 +0000 Received: from localhost ([127.0.0.1]:42382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TE79N-0001zG-R9 for submit@debbugs.gnu.org; Tue, 18 Sep 2012 19:24:18 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:57770 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TE79K-0001z8-RG for 10624-done@debbugs.gnu.org; Tue, 18 Sep 2012 19:24:15 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 92482451CCB6; Tue, 18 Sep 2012 16:22:50 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: 24.0.92; default value of `dired-do-ch*' Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87vcfex5bx.fsf@mail.jurta.org> <567949A5085246DD87365C10B6DF80FA@us.oracle.com> <871ui1h6e2.fsf@mail.jurta.org> Date: Wed, 19 Sep 2012 02:22:09 +0300 In-Reply-To: <871ui1h6e2.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 17 Sep 2012 02:48:09 +0300") Message-ID: <871uhy9ase.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624-done Cc: 10624-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Installed and closed. Thanks for the suggestion. From unknown Fri Jun 20 18:19:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Oct 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 22 04:47:11 2012 Received: (at control) by debbugs.gnu.org; 22 Nov 2012 09:47:11 +0000 Received: from localhost ([127.0.0.1]:60325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbTNH-0001pz-3g for submit@debbugs.gnu.org; Thu, 22 Nov 2012 04:47:11 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:41379 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbTNF-0001ps-A1 for control@debbugs.gnu.org; Thu, 22 Nov 2012 04:47:09 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4FB35451C074 for ; Thu, 22 Nov 2012 01:45:48 -0800 (PST) From: Juri Linkov To: control@debbugs.gnu.org Subject: unarchive 10624 Organization: JURTA Date: Thu, 22 Nov 2012 11:19:32 +0200 Message-ID: <87ip8yuh97.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) unarchive 10624 stop From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 22 04:52:36 2012 Received: (at 10624) by debbugs.gnu.org; 22 Nov 2012 09:52:36 +0000 Received: from localhost ([127.0.0.1]:60356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbTSW-0001yV-Bx for submit@debbugs.gnu.org; Thu, 22 Nov 2012 04:52:36 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:44306 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbTST-0001yL-R9 for 10624@debbugs.gnu.org; Thu, 22 Nov 2012 04:52:34 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id C952B451C074 for <10624@debbugs.gnu.org>; Thu, 22 Nov 2012 01:51:12 -0800 (PST) From: Juri Linkov To: 10624@debbugs.gnu.org Subject: Re: bug#10624: Dired-marking all files in the region Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> Date: Thu, 22 Nov 2012 11:49:57 +0200 In-Reply-To: <87fw6his5w.fsf_-_@mail.jurta.org> (Juri Linkov's message of "Mon, 17 Sep 2012 02:45:31 +0300") Message-ID: <87ehjmrmzg.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) While testing changes for WDired, I noticed one potential problem with marking all files in the region in the Dired buffer: when the region is active before typing `C-c C-c' in WDired it marks renamed files with the same marker, because currently WDired uses `dired-add-entry' that calls `dired-mark'. This is a rare problem, but I'd like to fix it properly. IIUC, the right way to enable functionality only for interactive use is to add an `interactive' arg (there were some reasons not to use (called-interactively-p 'interactive) but I forgot the exact reasons). This is not a regression, so I'm not sure about installing it to the emacs-24 branch: === modified file 'lisp/dired.el' --- lisp/dired.el 2012-11-17 21:52:12 +0000 +++ lisp/dired.el 2012-11-22 09:49:38 +0000 @@ -3109,7 +3109,7 @@ (defun dired-mark-files-in-region (start (insert dired-marker-char))) (forward-line 1)))) -(defun dired-mark (arg) +(defun dired-mark (arg &optional interactive) "Mark the file at point in the Dired buffer. If the region is active, mark all files in the region. Otherwise, with a prefix arg, mark files on the next ARG lines. @@ -3119,10 +3119,10 @@ (defun dired-mark (arg) Use \\[dired-unmark-all-files] to remove all marks and \\[dired-unmark] on a subdir to remove the marks in this subdir." - (interactive "P") + (interactive (list current-prefix-arg t)) (cond ;; Mark files in the active region. - ((and transient-mark-mode mark-active) + ((and interactive (use-region-p)) (save-excursion (let ((beg (region-beginning)) (end (region-end))) @@ -3139,7 +3139,7 @@ (defun dired-mark (arg) (prefix-numeric-value arg) (function (lambda () (delete-char 1) (insert dired-marker-char)))))))) -(defun dired-unmark (arg) +(defun dired-unmark (arg &optional interactive) "Unmark the file at point in the Dired buffer. If the region is active, unmark all files in the region. Otherwise, with a prefix arg, unmark files on the next ARG lines. @@ -3147,11 +3147,11 @@ (defun dired-unmark (arg) If looking at a subdir, unmark all its files except `.' and `..'. If the region is active in Transient Mark mode, unmark all files in the active region." - (interactive "P") + (interactive (list current-prefix-arg t)) (let ((dired-marker-char ?\040)) - (dired-mark arg))) + (dired-mark arg interactive))) -(defun dired-flag-file-deletion (arg) +(defun dired-flag-file-deletion (arg &optional interactive) "In Dired, flag the current line's file for deletion. If the region is active, flag all files in the region. Otherwise, with a prefix arg, flag files on the next ARG lines. @@ -3159,9 +3159,9 @@ (defun dired-flag-file-deletion (arg) If on a subdir headerline, flag all its files except `.' and `..'. If the region is active in Transient Mark mode, flag all files in the active region." - (interactive "P") + (interactive (list current-prefix-arg t)) (let ((dired-marker-char dired-del-marker)) - (dired-mark arg))) + (dired-mark arg interactive))) (defun dired-unmark-backward (arg) "In Dired, move up lines and remove marks or deletion flags there. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 22 10:29:01 2012 Received: (at 10624) by debbugs.gnu.org; 22 Nov 2012 15:29:01 +0000 Received: from localhost ([127.0.0.1]:33295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYi4-00044n-GB for submit@debbugs.gnu.org; Thu, 22 Nov 2012 10:29:01 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:16931) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYi0-00044c-GM for 10624@debbugs.gnu.org; Thu, 22 Nov 2012 10:28:59 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qAMFRXo1017971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Nov 2012 15:27:34 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qAMFRW6X007541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Nov 2012 15:27:33 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qAMFRW7s000919; Thu, 22 Nov 2012 09:27:32 -0600 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 22 Nov 2012 07:27:32 -0800 From: "Drew Adams" To: "'Juri Linkov'" , <10624@debbugs.gnu.org> References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com><87sjaj2atc.fsf@mail.jurta.org><96319E709DC548DBADB263DA2DD11A82@us.oracle.com><87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> Subject: RE: bug#10624: Dired-marking all files in the region Date: Thu, 22 Nov 2012 07:27:29 -0800 Message-ID: <6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehjmrmzg.fsf@mail.jurta.org> Thread-Index: Ac3IlwTQ4p5eXX3oSoWLqUNXr/V29gALd63g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I noticed one potential problem > with marking all files in the region in the Dired buffer: > when the region is active before typing `C-c C-c' in WDired > it marks renamed files with the same marker, because currently > WDired uses `dired-add-entry' that calls `dired-mark'. > > This is a rare problem, but I'd like to fix it properly. > IIUC, the right way to enable functionality only for interactive use > is to add an `interactive' arg Just a quick reply - please excuse if my quick reading of this makes my reply off-the-mark (so to speak). What if some other function (perhaps a command) that someone has written takes advantage of the intended active-region behavior (by activating the region, and then...)? With your change, IIUC, that code would now need to be changed to add an additional argument to the call, to fake interactiveness. I don't see the problem you cite as having to do with interactiveness, but as having to do with WDired (or perhaps interactiveness when in WDired). (But again, I might be misunderstanding.) If the problem you refer to is really that _in WDired_ the active region should be handled this way only if interactive, then shouldn't you add an additional condition that tests for WDired mode? IOW, why change the behavior for Dired generally (i.e., including outside WDired mode), for a problem that you found only inside WDired? Again, excuse me if I've misunderstood the intention, behavior, or patch. I looked at your message quickly. Thx. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 22 10:42:06 2012 Received: (at 10624) by debbugs.gnu.org; 22 Nov 2012 15:42:06 +0000 Received: from localhost ([127.0.0.1]:33319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYuj-0004QT-Q8 for submit@debbugs.gnu.org; Thu, 22 Nov 2012 10:42:06 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:5046) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYud-0004Q1-3B for 10624@debbugs.gnu.org; Thu, 22 Nov 2012 10:41:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FpaQ6/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208223519" Received: from 69-165-164-58.dsl.teksavvy.com (HELO pastel.home) ([69.165.164.58]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Nov 2012 10:40:37 -0500 Received: by pastel.home (Postfix, from userid 20848) id 616CF597C9; Thu, 22 Nov 2012 10:40:36 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#10624: Dired-marking all files in the region Message-ID: References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> Date: Thu, 22 Nov 2012 10:40:36 -0500 In-Reply-To: <87ehjmrmzg.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 22 Nov 2012 11:49:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > is to add an `interactive' arg (there were some reasons not to use > (called-interactively-p 'interactive) but I forgot the exact reasons). One of the main reasons is reliability. If you look at the code of called-interactively-p, you'll see it's pretty hackish, so it's easy to break it. For example `called-interactively-p' may fail to work correctly in the following known cases: - when the function is advised (this was recently improved, so it will now fail sometimes rather than always). - when inside a condition-case or catch in lexical-binding code. - when inside a `pcase' branch (because pcase sometimes moves the branch to a lambda in order to avoid duplicating the code). Another reason is that it makes it more flexible for non-interactive callers, which can control whether to run the function "as if the arguments had been provided interactively". `called-interactively-p' is handy when you can't add an argument, but otherwise it's much better to add an `interactive' argument. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 23 03:02:55 2012 Received: (at 10624) by debbugs.gnu.org; 23 Nov 2012 08:02:55 +0000 Received: from localhost ([127.0.0.1]:33953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TboDt-0004fe-Ou for submit@debbugs.gnu.org; Fri, 23 Nov 2012 03:02:54 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:53775 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TboDp-0004fQ-Ua for 10624@debbugs.gnu.org; Fri, 23 Nov 2012 03:02:51 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 43AC8451CDCF; Fri, 23 Nov 2012 00:01:23 -0800 (PST) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: Dired-marking all files in the region Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> <6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> Date: Fri, 23 Nov 2012 09:51:47 +0200 In-Reply-To: <6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> (Drew Adams's message of "Thu, 22 Nov 2012 07:27:29 -0800") Message-ID: <87ehjkg404.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > IOW, why change the behavior for Dired generally (i.e., including outside WDired > mode), for a problem that you found only inside WDired? This problem is not WDired specific. It is better to opt-in this functionality by setting the `interactive' arg than to opt-out it in specific packages because this feature makes sense only for interactive use in Dired. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 23 03:02:58 2012 Received: (at 10624) by debbugs.gnu.org; 23 Nov 2012 08:02:58 +0000 Received: from localhost ([127.0.0.1]:33955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TboDx-0004fq-CK for submit@debbugs.gnu.org; Fri, 23 Nov 2012 03:02:57 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:53785 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TboDs-0004fX-5z for 10624@debbugs.gnu.org; Fri, 23 Nov 2012 03:02:53 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F2F23451CDDB; Fri, 23 Nov 2012 00:01:25 -0800 (PST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#10624: Dired-marking all files in the region Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> Date: Fri, 23 Nov 2012 09:59:54 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 22 Nov 2012 10:40:36 -0500") Message-ID: <87vccweolh.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > `called-interactively-p' is handy when you can't add an argument, but > otherwise it's much better to add an `interactive' argument. I added an `interactive' argument to the emacs-24 branch since its lack might cause regressions in external packages. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 23 12:13:45 2012 Received: (at 10624) by debbugs.gnu.org; 23 Nov 2012 17:13:45 +0000 Received: from localhost ([127.0.0.1]:35179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tbwoz-0006Bv-02 for submit@debbugs.gnu.org; Fri, 23 Nov 2012 12:13:45 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:17871) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tbwov-0006Bn-Kf for 10624@debbugs.gnu.org; Fri, 23 Nov 2012 12:13:43 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qANHCD9O015071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Nov 2012 17:12:13 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qANHCCQO028330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Nov 2012 17:12:12 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qANHCBhW002214; Fri, 23 Nov 2012 11:12:11 -0600 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 23 Nov 2012 09:12:11 -0800 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com><87sjaj2atc.fsf@mail.jurta.org><96319E709DC548DBADB263DA2DD11A82@us.oracle.com><87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org><6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> <87ehjkg404.fsf@mail.jurta.org> Subject: RE: bug#10624: Dired-marking all files in the region Date: Fri, 23 Nov 2012 09:12:06 -0800 Message-ID: <089809C342424A529E4FEAA49440F205@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehjkg404.fsf@mail.jurta.org> Thread-Index: Ac3JULx1+xwJfw9BTkWL9vwB80f6vgAS1Qaw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > > IOW, why change the behavior for Dired generally (i.e., > > including outside WDired mode), for a problem that you > > found only inside WDired? > > This problem is not WDired specific. I have not seen a description of "this" problem, other than a description of a problem for WDired. Can you characterize "this problem" for Dired generally? This is the only description I've seen, and it seems quite WDired-specific: >> when the region is active before typing `C-c C-c' >> in WDired it marks renamed files with the same marker, ^^^^^^^^^ >> because currently WDired uses `dired-add-entry' ^^^^^^^^^^^^^^^^ >> that calls `dired-mark'. How is "this problem" manifested for Dired, other than for WDired? And I don't understand this: > It is better to opt-in this functionality by setting the > `interactive' arg than to opt-out it in specific packages > because this feature makes sense only for interactive use in Dired. What is the argument as to why this makes sense only for interactive use in Dired? Or that it makes sense always for interactive use in Dired? Sorry, but this is not yet clear to me. Seems like maybe some steps are missing from your argument. They are no doubt obvious to you, but not yet to me. Could you please fill in the blanks a bit? Again, excuse me for not grasping this quickly. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 04:54:27 2012 Received: (at 10624) by debbugs.gnu.org; 25 Nov 2012 09:54:27 +0000 Received: from localhost ([127.0.0.1]:37486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TcYux-0001Pj-NY for submit@debbugs.gnu.org; Sun, 25 Nov 2012 04:54:27 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:45959 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TcYut-0001PP-I8 for 10624@debbugs.gnu.org; Sun, 25 Nov 2012 04:54:24 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A908E451E1A9; Sun, 25 Nov 2012 01:52:45 -0800 (PST) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: Dired-marking all files in the region Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> <6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> <87ehjkg404.fsf@mail.jurta.org> <089809C342424A529E4FEAA49440F205@us.oracle.com> Date: Sun, 25 Nov 2012 11:16:56 +0200 In-Reply-To: <089809C342424A529E4FEAA49440F205@us.oracle.com> (Drew Adams's message of "Fri, 23 Nov 2012 09:12:06 -0800") Message-ID: <87r4niavvr.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > What is the argument as to why this makes sense only for interactive use in > Dired? Or that it makes sense always for interactive use in Dired? Sorry, I don't understand whether your questions are rhetorical. If you disagree with this change, please provide counterexamples that support your point. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 10:51:06 2012 Received: (at 10624) by debbugs.gnu.org; 25 Nov 2012 15:51:06 +0000 Received: from localhost ([127.0.0.1]:38320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TceU5-000285-Eq for submit@debbugs.gnu.org; Sun, 25 Nov 2012 10:51:06 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20714) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TceU2-00027n-J9 for 10624@debbugs.gnu.org; Sun, 25 Nov 2012 10:51:03 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qAPFnMWp013751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 25 Nov 2012 15:49:23 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qAPFnLD4018413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 25 Nov 2012 15:49:22 GMT Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qAPFnLwC009993; Sun, 25 Nov 2012 09:49:21 -0600 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 25 Nov 2012 07:49:21 -0800 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com><87sjaj2atc.fsf@mail.jurta.org><96319E709DC548DBADB263DA2DD11A82@us.oracle.com><87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org><6AEA16518F864D14983BCA3F42788FF0@us.oracle.com><87ehjkg404.fsf@mail.jurta.org><089809C342424A529E4FEAA49440F205@us.oracle.com> <87r4niavvr.fsf@mail.jurta.org> Subject: RE: bug#10624: Dired-marking all files in the region Date: Sun, 25 Nov 2012 07:49:10 -0800 Message-ID: <85B6F5F9267E4B8384E2F6611EBE5803@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87r4niavvr.fsf@mail.jurta.org> Thread-Index: Ac3K8qFCXmpmYvCVShiJW6qfFxn1uAAMUtaQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > > What is the argument as to why this makes sense only for > > interactive use in Dired? Or that it makes sense always for > > interactive use in Dired? > > Sorry, I don't understand whether your questions are rhetorical. Not rhetorical at all. > If you disagree with this change, please provide counterexamples > that support your point. It's not a question of disagreement at this point, but of trying to understand. Please answer the questions. Why only interactive? Why always when interactive? What is the rationale for this design? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 11:17:49 2012 Received: (at 10624) by debbugs.gnu.org; 25 Nov 2012 16:17:49 +0000 Received: from localhost ([127.0.0.1]:38374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcetx-0002lo-16 for submit@debbugs.gnu.org; Sun, 25 Nov 2012 11:17:49 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:42237 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcetu-0002lg-Bt for 10624@debbugs.gnu.org; Sun, 25 Nov 2012 11:17:47 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 8467B451CCB2; Sun, 25 Nov 2012 08:16:06 -0800 (PST) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#10624: Dired-marking all files in the region Organization: JURTA References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> <6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> <87ehjkg404.fsf@mail.jurta.org> <089809C342424A529E4FEAA49440F205@us.oracle.com> <87r4niavvr.fsf@mail.jurta.org> <85B6F5F9267E4B8384E2F6611EBE5803@us.oracle.com> Date: Sun, 25 Nov 2012 18:12:06 +0200 In-Reply-To: <85B6F5F9267E4B8384E2F6611EBE5803@us.oracle.com> (Drew Adams's message of "Sun, 25 Nov 2012 07:49:10 -0800") Message-ID: <87a9u5vezt.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > Why only interactive? Why always when interactive? Because it fixed the problem that I described earlier. I cannot think of a better fix. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 12:04:30 2012 Received: (at 10624) by debbugs.gnu.org; 25 Nov 2012 17:04:30 +0000 Received: from localhost ([127.0.0.1]:38410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcfd8-0003qs-5C for submit@debbugs.gnu.org; Sun, 25 Nov 2012 12:04:30 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:27737) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcfd5-0003ql-Pk for 10624@debbugs.gnu.org; Sun, 25 Nov 2012 12:04:28 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qAPH2mfo028612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 25 Nov 2012 17:02:48 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qAPH2lN4029988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 25 Nov 2012 17:02:48 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qAPH2lXo005367; Sun, 25 Nov 2012 11:02:47 -0600 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 25 Nov 2012 09:02:46 -0800 From: "Drew Adams" To: "'Juri Linkov'" References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com><87sjaj2atc.fsf@mail.jurta.org><96319E709DC548DBADB263DA2DD11A82@us.oracle.com><87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org><6AEA16518F864D14983BCA3F42788FF0@us.oracle.com><87ehjkg404.fsf@mail.jurta.org><089809C342424A529E4FEAA49440F205@us.oracle.com><87r4niavvr.fsf@mail.jurta.org><85B6F5F9267E4B8384E2F6611EBE5803@us.oracle.com> <87a9u5vezt.fsf@mail.jurta.org> Subject: RE: bug#10624: Dired-marking all files in the region Date: Sun, 25 Nov 2012 09:02:36 -0800 Message-ID: <8B04793C62064872AA574981777760E1@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87a9u5vezt.fsf@mail.jurta.org> Thread-Index: Ac3LKC0ibtGsD5DJTtKQjC6woM8CRgABiyVA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10624 Cc: 10624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > > Why only interactive? Why always when interactive? > > Because it fixed the problem that I described earlier. > I cannot think of a better fix. Why is interactiveness as the exact condition important for your fix? How is it related to the problem you wanted to solve? You are not helping understanding of the fix/design. You are just saying that's what you did and it fixes the problem. From unknown Fri Jun 20 18:19:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Dec 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator