GNU bug report logs - #10623
Bugs in ecmascript/base.scm

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10623 in the body.
You can then email your comments to 10623 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: bug-guile <at> gnu.org
Subject: Bugs in ecmascript/base.scm
Date: Fri, 27 Jan 2012 03:31:48 -0500

These are genuine bugs:

language/ecmascript/base.scm:179:31: warning: wrong number of arguments to `object->number'
language/ecmascript/base.scm:95:6: warning: possibly unbound variable `v'
language/ecmascript/base.scm:181:14: warning: possibly unbound variable `o'

     Mark

Message #8 received at 10623 <at> debbugs.gnu.org (full text, mbox):

From: Sjoerd van Leent <svanleent <at> gmail.com>
To: 10623 <at> debbugs.gnu.org
Cc: Sjoerd van Leent <svanleent <at> gmail.com>
Subject: [PATCH] Fixed unbound variables and unbound values
Date: Tue, 15 May 2012 20:48:40 +0200

---
 module/language/ecmascript/base.scm |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/module/language/ecmascript/base.scm b/module/language/ecmascript/base.scm
index b244bec..6f5c65b 100644
--- a/module/language/ecmascript/base.scm
+++ b/module/language/ecmascript/base.scm
@@ -92,7 +92,7 @@
   (pdel o (string->symbol p)))
 
 (define-method (has-property? (o <js-object>) p)
-  (if (hashq-get-handle (js-props o) v)
+  (if (hashq-get-handle (js-props o) p)
       #t
       (let ((proto (js-prototype o)))
         (if proto
@@ -176,9 +176,9 @@
         ((boolean? x) (if x 1 0))
         ((null? x) 0)
         ((eq? x *undefined*) +nan.0)
-        ((is-a? x <js-object>) (object->number x))
+        ((is-a? x <js-object>) (object->number x #t))
         ((string? x) (string->number x))
-        (else (throw 'TypeError o '->number))))
+        (else (throw 'TypeError x '->number))))
 
 (define (->integer x)
   (let ((n (->number x)))
-- 
1.7.5.4

Message #11 received at 10623 <at> debbugs.gnu.org (full text, mbox):

From: Noah Lavine <noah.b.lavine <at> gmail.com>
To: Sjoerd van Leent <svanleent <at> gmail.com>
Cc: 10623 <at> debbugs.gnu.org
Subject: Re: bug#10623: [PATCH] Fixed unbound variables and unbound values
Date: Sat, 19 May 2012 10:24:24 -0400

Hello,

This looks correct to me. It would be ideal if you could make the
patch with "git format-patch". That will let you write the log entry
for the change.

If you plan to make bigger changes to Guile, you'll need to assign
copyright for your changes to the FSF. Please see
http://www.gnu.org/licenses/why-assign.html for the reason why, but in
summary, that gives them more power to defend the license on the code.
If you're willing to, email assign <at> gnu.org and tell them you'd like to
assign copyright for Guile.

Thanks,
Noah

On Tue, May 15, 2012 at 2:48 PM, Sjoerd van Leent <svanleent <at> gmail.com> wrote:
> ---
>  module/language/ecmascript/base.scm |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/module/language/ecmascript/base.scm b/module/language/ecmascript/base.scm
> index b244bec..6f5c65b 100644
> --- a/module/language/ecmascript/base.scm
> +++ b/module/language/ecmascript/base.scm
> @@ -92,7 +92,7 @@
>   (pdel o (string->symbol p)))
>
>  (define-method (has-property? (o <js-object>) p)
> -  (if (hashq-get-handle (js-props o) v)
> +  (if (hashq-get-handle (js-props o) p)
>       #t
>       (let ((proto (js-prototype o)))
>         (if proto
> @@ -176,9 +176,9 @@
>         ((boolean? x) (if x 1 0))
>         ((null? x) 0)
>         ((eq? x *undefined*) +nan.0)
> -        ((is-a? x <js-object>) (object->number x))
> +        ((is-a? x <js-object>) (object->number x #t))
>         ((string? x) (string->number x))
> -        (else (throw 'TypeError o '->number))))
> +        (else (throw 'TypeError x '->number))))
>
>  (define (->integer x)
>   (let ((n (->number x)))
> --
> 1.7.5.4
>
>
>
>

Message #14 received at 10623 <at> debbugs.gnu.org (full text, mbox):

From: Sjoerd van Leent <svanleent <at> gmail.com>
To: 10623 <at> debbugs.gnu.org
Cc: Sjoerd van Leent <svanleent <at> gmail.com>
Subject: [PATCH] Fixed unbound variables and unbound values
Date: Mon, 21 May 2012 20:50:45 +0200

[Message part 1 (text/plain, inline)]

Fixed unbound variables and unbound values for the ecmascript base Guile scheme file.

Afftected are:
  module/langyage/ecmascript/base.scm:

  - has-property? should check against the value p instead of v when
    handling hashq-get-handle

  - When x is of type <js-object> on line 179, it should be appending #t to
    the call to object->number, as object->number requires it

  - Within the same bit, a few lines later, A TypeError should be thrown
    using the value x instead of the non-existant value o

Sjoerd van Leent (1):
  Fixed unbound variables and unbound values for the ecmascript base
    Guile scheme file.

 module/language/ecmascript/base.scm |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

-- 
1.7.5.4

Message #17 received at 10623 <at> debbugs.gnu.org (full text, mbox):

From: Sjoerd van Leent <svanleent <at> gmail.com>
To: 10623 <at> debbugs.gnu.org
Cc: Sjoerd van Leent <svanleent <at> gmail.com>
Subject: [PATCH] Fixed unbound variables and unbound values for the ecmascript
	base Guile scheme file.
Date: Mon, 21 May 2012 20:50:46 +0200

[Message part 1 (text/plain, inline)]

Afftected are:
  module/langyage/ecmascript/base.scm:

  - has-property? should check against the value p instead of v when
    handling hashq-get-handle

  - When x is of type <js-object> on line 179, it should be appending #t to
    the call to object->number, as object->number requires it

  - Within the same bit, a few lines later, A TypeError should be thrown
    using the value x instead of the non-existant value o
---
 module/language/ecmascript/base.scm |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

[0001-Fixed-unbound-variables-and-unbound-values-for-the-e.patch (text/x-patch, attachment)]

Message #22 received at 10623-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Sjoerd van Leent <svanleent <at> gmail.com>
Cc: 10623-done <at> debbugs.gnu.org
Subject: Re: bug#10623: [PATCH] Fixed unbound variables and unbound values
	for the ecmascript base Guile scheme file.
Date: Wed, 04 Jul 2012 21:00:29 +0200

Fixed in 6b5e918e4f3cf011713e699c6af1c4e364bfae36.  Thanks, and thanks
to Noah for applying.

Andy
-- 
http://wingolog.org/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.