From unknown Thu Aug 14 22:24:42 2025 X-Loop: don@donarmstrong.com Subject: bug#1062: 23.0.60; minibuffer-completion-help incomplete Reply-To: Stephen Berman , 1062@debbugs.gnu.org Resent-From: Stephen Berman Original-Sender: steve@escher.local.home Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 01 Oct 2008 10:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1062 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122285526728632 (code B ref -1); Wed, 01 Oct 2008 10:10:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.2 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 1 Oct 2008 10:01:07 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m91A10pd028626 for ; Wed, 1 Oct 2008 03:01:01 -0700 Received: from mail.gnu.org ([199.232.76.166]:57550 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KkyTm-0006sn-3f for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 05:58:46 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KkyVu-0001xQ-3x for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 06:00:59 -0400 Received: from mail.gmx.net ([213.165.64.20]:48756) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KkyVt-0001ws-Hj for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 06:00:57 -0400 Received: (qmail invoked by alias); 01 Oct 2008 10:00:54 -0000 Received: from i5387D545.versanet.de (EHLO escher.local.home) [83.135.213.69] by mail.gmx.net (mp006) with SMTP; 01 Oct 2008 12:00:54 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19M5hhfrd5MZt6yU9XTrGS2xEaLtaEYGZDOixbg// jSvOSFtPB+mknT Received: by escher.local.home (Postfix, from userid 1000) id D87677FBB1; Wed, 1 Oct 2008 12:00:52 +0200 (CEST) From: Stephen Berman To: emacs-pretest-bug@gnu.org Sender: steve@escher.local.home Date: Wed, 01 Oct 2008 12:00:52 +0200 Message-ID: <87od24ljmz.fsf@escher.local.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. GNU Emacs 23.0.60.5 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-10-01 on escher 1. emacs -Q 2. Let some directory contain the files "tested" and "Testing" and no other files beginning with "test" or "Test". 3. M-x set-variable RET read-file-name-completion-ignore-case RET t RET 4. C-x C-f /test 5. Now type TAB or "?" and a *Completions* buffer pops that shows only "tested" as a possible completion. However, typing "i" next and then TAB does complete to "Testing". If before doing step 4 completion-styles is set to (emacs22), then after the first TAB or ? in step 5 the *Completions* buffer shows both "tested" and "Testing". The following patch makes the *Completions* buffer show all possible completions in step 5 also with the default completion-style basic, but I don't know if it has undesirable consequences elsewhere. Steve Berman *** emacs/lisp/minibuffer.el.~1.58.~ 2008-09-04 16:16:19.000000000 +0200 --- emacs/lisp/minibuffer.el 2008-10-01 11:42:40.000000000 +0200 *************** *** 1316,1322 **** "" (list (substring beforepoint (car bounds)) 'point (substring afterpoint 0 (cdr bounds))))) ! (all (completion-pcm--all-completions prefix pattern table pred))) (completion-hilit-commonality (if (consp all) (nconc all (car bounds)) all) point))) --- 1316,1324 ---- "" (list (substring beforepoint (car bounds)) 'point (substring afterpoint 0 (cdr bounds))))) ! (all (if completion-ignore-case ! (all-completions (substring string 0 point) table pred) ! (completion-pcm--all-completions prefix pattern table pred)))) (completion-hilit-commonality (if (consp all) (nconc all (car bounds)) all) point))) From unknown Thu Aug 14 22:24:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Stephen Berman Subject: bug#1062 closed by Chong Yidong (Re: 23.0.60; minibuffer-completion-help incomplete) Message-ID: References: <87bpwq6tqt.fsf@cyd.mit.edu> <87od24ljmz.fsf@escher.local.home> X-Emacs-PR-Message: they-closed 1062 X-Emacs-PR-Package: emacs Reply-To: 1062@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1226163905-21278-1" This is a multi-part message in MIME format... ------------=_1226163905-21278-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #1062: 23.0.60; minibuffer-completion-help incomplete It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 1062: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1062 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1226163905-21278-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From cyd@stupidchicken.com Sat Nov 8 08:57:06 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1062-done) by emacsbugs.donarmstrong.com; 8 Nov 2008 16:57:06 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA8Gv3st019716 for <1062-done@emacsbugs.donarmstrong.com>; Sat, 8 Nov 2008 08:57:05 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id F222D57E195; Sat, 8 Nov 2008 11:57:14 -0500 (EST) From: Chong Yidong To: Stephen Berman Cc: 1062-done@debbugs.gnu.org Subject: Re: 23.0.60; minibuffer-completion-help incomplete Date: Sat, 08 Nov 2008 11:57:14 -0500 Message-ID: <87bpwq6tqt.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > 1. emacs -Q > 2. Let some directory contain the files "tested" and "Testing" and no > other > files beginning with "test" or "Test". > 3. M-x set-variable RET read-file-name-completion-ignore-case RET t RET > 4. C-x C-f /test > 5. Now type TAB or "?" and a *Completions* buffer pops that shows only > "tested" as a possible completion. However, typing "i" next and then > TAB does complete to "Testing". > > The following patch makes the *Completions* buffer show all possible > completions in step 5 also with the default completion-style basic, but > I don't know if it has undesirable consequences elsewhere. The bug was actually in the C code: file-name-all-completions did not handle completion-regexp-list properly. I've checked in a fix. Thanks for the bug report. ------------=_1226163905-21278-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From stephen.berman@gmx.net Wed Oct 1 03:01:07 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.2 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 1 Oct 2008 10:01:07 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m91A10pd028626 for ; Wed, 1 Oct 2008 03:01:01 -0700 Received: from mail.gnu.org ([199.232.76.166]:57550 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KkyTm-0006sn-3f for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 05:58:46 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KkyVu-0001xQ-3x for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 06:00:59 -0400 Received: from mail.gmx.net ([213.165.64.20]:48756) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KkyVt-0001ws-Hj for emacs-pretest-bug@gnu.org; Wed, 01 Oct 2008 06:00:57 -0400 Received: (qmail invoked by alias); 01 Oct 2008 10:00:54 -0000 Received: from i5387D545.versanet.de (EHLO escher.local.home) [83.135.213.69] by mail.gmx.net (mp006) with SMTP; 01 Oct 2008 12:00:54 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19M5hhfrd5MZt6yU9XTrGS2xEaLtaEYGZDOixbg// jSvOSFtPB+mknT Received: by escher.local.home (Postfix, from userid 1000) id D87677FBB1; Wed, 1 Oct 2008 12:00:52 +0200 (CEST) From: Stephen Berman To: emacs-pretest-bug@gnu.org Subject: 23.0.60; minibuffer-completion-help incomplete Sender: steve@escher.local.home Date: Wed, 01 Oct 2008 12:00:52 +0200 Message-ID: <87od24ljmz.fsf@escher.local.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. GNU Emacs 23.0.60.5 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-10-01 on escher 1. emacs -Q 2. Let some directory contain the files "tested" and "Testing" and no other files beginning with "test" or "Test". 3. M-x set-variable RET read-file-name-completion-ignore-case RET t RET 4. C-x C-f /test 5. Now type TAB or "?" and a *Completions* buffer pops that shows only "tested" as a possible completion. However, typing "i" next and then TAB does complete to "Testing". If before doing step 4 completion-styles is set to (emacs22), then after the first TAB or ? in step 5 the *Completions* buffer shows both "tested" and "Testing". The following patch makes the *Completions* buffer show all possible completions in step 5 also with the default completion-style basic, but I don't know if it has undesirable consequences elsewhere. Steve Berman *** emacs/lisp/minibuffer.el.~1.58.~ 2008-09-04 16:16:19.000000000 +0200 --- emacs/lisp/minibuffer.el 2008-10-01 11:42:40.000000000 +0200 *************** *** 1316,1322 **** "" (list (substring beforepoint (car bounds)) 'point (substring afterpoint 0 (cdr bounds))))) ! (all (completion-pcm--all-completions prefix pattern table pred))) (completion-hilit-commonality (if (consp all) (nconc all (car bounds)) all) point))) --- 1316,1324 ---- "" (list (substring beforepoint (car bounds)) 'point (substring afterpoint 0 (cdr bounds))))) ! (all (if completion-ignore-case ! (all-completions (substring string 0 point) table pred) ! (completion-pcm--all-completions prefix pattern table pred)))) (completion-hilit-commonality (if (consp all) (nconc all (car bounds)) all) point))) ------------=_1226163905-21278-1--