GNU bug report logs - #10616
flush procedure for soft ports isn't called

Previous Next

Full log

View this message in rfc822 format

From: Ian Price <ianprice90 <at> googlemail.com>
To: 10616 <at> debbugs.gnu.org
Subject: bug#10616: flush procedure for soft ports isn't called
Date: Fri, 27 Jan 2012 06:44:52 +0000

[Message part 1 (text/plain, inline)]

Ian Price <ianprice90 <at> googlemail.com> writes:

> I notice that sf_write doesn't update this buffer, but instead just
> calls the write procedure directly. In that case, it makes sense that
> the value isn't changing, and therefore maybe I should just change
> sf_flush into a wrapper for the flush procedure?

I decided to go ahead and do this. Patch attached. Test case missing as
is traditional for soft ports :), though in all seriousness, soft ports
have been around for ages, and this lack of testing for it is, unsettling.

-- 
Ian Price

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"

[~/src/guile/0001-Fix-flush-on-soft-ports-so-that-it-actually-runs.patch (message/external-body, inline)]

[Message part 3 (text/x-patch, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.