GNU bug report logs - #10592
movemail.c's error function and certain compiler flags

Previous Next

Full log

Message #19 received at 10592 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rob Browning <rlb <at> defaultvalue.org>
Cc: 10592 <at> debbugs.gnu.org, 655118-forwarded <at> bugs.debian.org, jmm <at> inutil.org,
	655118 <at> bugs.debian.org
Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags
Date: Wed, 25 Jan 2012 01:40:26 -0500

> From: Rob Browning <rlb <at> defaultvalue.org>
> Cc: 10592 <at> debbugs.gnu.org,  655118 <at> bugs.debian.org,  655118-forwarded <at> bugs.debian.org,  jmm <at> inutil.org
> Date: Tue, 24 Jan 2012 20:22:52 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I think the right fix for this is to declare `error' with the
> > appropriate printf attribute.  Alternatively, you could use variable
> > argument lists and call vprintf instead.
> 
> Would something like this be acceptable, and if not, how would you like
> to see it adjusted?  The patch changes error() to use an ANSI
> declaration, and it relies on the printf format attribute:

This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined
in src/config.h) instead of a literal __attribute__(...), which is a
GCC-only thing.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.