From unknown Mon Jun 23 11:23:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10592 <10592@debbugs.gnu.org> To: bug#10592 <10592@debbugs.gnu.org> Subject: Status: movemail.c's error function and certain compiler flags Reply-To: bug#10592 <10592@debbugs.gnu.org> Date: Mon, 23 Jun 2025 18:23:58 +0000 retitle 10592 movemail.c's error function and certain compiler flags reassign 10592 emacs submitter 10592 Rob Browning severity 10592 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 00:06:00 2012 Received: (at submit) by debbugs.gnu.org; 24 Jan 2012 05:06:00 +0000 Received: from localhost ([127.0.0.1]:41206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpYa0-000445-0D for submit@debbugs.gnu.org; Tue, 24 Jan 2012 00:06:00 -0500 Received: from eggs.gnu.org ([140.186.70.92]:44019) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpYZw-00043r-O2 for submit@debbugs.gnu.org; Tue, 24 Jan 2012 00:05:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpYZY-0006Ip-46 for submit@debbugs.gnu.org; Tue, 24 Jan 2012 00:05:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, UNWANTED_LANGUAGE_BODY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:36508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpYZY-0006Ih-1h for submit@debbugs.gnu.org; Tue, 24 Jan 2012 00:05:32 -0500 Received: from eggs.gnu.org ([140.186.70.92]:56239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpYZW-0006gO-Pj for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 00:05:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpYZU-0006IC-4d for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 00:05:30 -0500 Received: from defaultvalue.org ([70.85.129.156]:54988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpYZT-0006I1-Sx for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 00:05:28 -0500 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 8EBBA90D42; Mon, 23 Jan 2012 23:05:42 -0600 (CST) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 6A0A814E034; Mon, 23 Jan 2012 23:05:26 -0600 (CST) From: Rob Browning To: bug-gnu-emacs@gnu.org Subject: Re: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> Date: Mon, 23 Jan 2012 23:05:26 -0600 In-Reply-To: <87wr8h8zhu.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Mon, 23 Jan 2012 23:02:05 -0600") Message-ID: <87pqe98zc9.fsf@trouble.defaultvalue.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: 655118-forwarded@bugs.debian.org, 655118@bugs.debian.org, Moritz =?utf-8?Q?M=C3=BChlenhoff?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) (Sorry, accidentally hit send too early.) Mortiz updated Emacs to support -Wformat -Wformat-security -Werror=format-security. Here are the relevant changes (further details are available at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655118): diff -aur emacs23-23.3+1.orig/lib-src/movemail.c emacs23-23.3+1/lib-src/movemail.c --- emacs23-23.3+1.orig/lib-src/movemail.c 2011-12-29 05:07:27.000000000 +0100 +++ emacs23-23.3+1/lib-src/movemail.c 2012-01-08 17:31:22.000000000 +0100 @@ -615,11 +615,11 @@ { fprintf (stderr, "movemail: "); if (s3) - fprintf (stderr, s1, s2, s3); + fprintf (stderr, "%s%s%s", s1, s2, s3); else if (s2) - fprintf (stderr, s1, s2); + fprintf (stderr, "%s%s", s1, s2); else - fprintf (stderr, s1); + fprintf (stderr, "%s", s1); fprintf (stderr, "\n"); } Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 01:07:02 2012 Received: (at 10592) by debbugs.gnu.org; 24 Jan 2012 06:07:03 +0000 Received: from localhost ([127.0.0.1]:41260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpZX4-0005ST-A5 for submit@debbugs.gnu.org; Tue, 24 Jan 2012 01:07:02 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:60524 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpZX1-0005S7-Rk for 10592@debbugs.gnu.org; Tue, 24 Jan 2012 01:07:01 -0500 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RpZWi-0006sb-8K; Tue, 24 Jan 2012 01:06:40 -0500 Date: Tue, 24 Jan 2012 01:06:40 -0500 Message-Id: From: Eli Zaretskii To: Rob Browning In-reply-to: <87pqe98zc9.fsf@trouble.defaultvalue.org> (message from Rob Browning on Mon, 23 Jan 2012 23:05:26 -0600) Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10592 Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > From: Rob Browning > Date: Mon, 23 Jan 2012 23:05:26 -0600 > Cc: 655118@bugs.debian.org, 655118-forwarded@bugs.debian.org, > Moritz Mühlenhoff > > --- emacs23-23.3+1.orig/lib-src/movemail.c 2011-12-29 05:07:27.000000000 +0100 > +++ emacs23-23.3+1/lib-src/movemail.c 2012-01-08 17:31:22.000000000 +0100 > @@ -615,11 +615,11 @@ > { > fprintf (stderr, "movemail: "); > if (s3) > - fprintf (stderr, s1, s2, s3); > + fprintf (stderr, "%s%s%s", s1, s2, s3); > else if (s2) > - fprintf (stderr, s1, s2); > + fprintf (stderr, "%s%s", s1, s2); > else > - fprintf (stderr, s1); > + fprintf (stderr, "%s", s1); > fprintf (stderr, "\n"); > } How can this possibly be TRT? The commentary to this function says: /* Print error message. `s1' is printf control string, `s2' and `s3' are args for it or null. */ If S1 is the printf control string, how will printing it with %s DTRT? E.g., in this invocation: error ("Error connecting to POP server: %s", pop_error, 0); or in this one: error ("Error in open: %s, %s", strerror (errno), outfile); I think the right fix for this is to declare `error' with the appropriate printf attribute. Alternatively, you could use variable argument lists and call vprintf instead. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 11:17:38 2012 Received: (at 10592) by debbugs.gnu.org; 24 Jan 2012 16:17:39 +0000 Received: from localhost ([127.0.0.1]:41945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rpj3x-00047t-0Z for submit@debbugs.gnu.org; Tue, 24 Jan 2012 11:17:38 -0500 Received: from defaultvalue.org ([70.85.129.156]:58092 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rpj3u-00047k-5A for 10592@debbugs.gnu.org; Tue, 24 Jan 2012 11:17:35 -0500 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 0D7F390D35; Tue, 24 Jan 2012 10:17:28 -0600 (CST) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 42A6914E034; Tue, 24 Jan 2012 10:17:10 -0600 (CST) From: Rob Browning To: Eli Zaretskii Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> Date: Tue, 24 Jan 2012 10:17:10 -0600 In-Reply-To: (Eli Zaretskii's message of "Tue, 24 Jan 2012 01:06:40 -0500") Message-ID: <87d3a9848p.fsf@trouble.defaultvalue.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10592 Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Eli Zaretskii writes: > How can this possibly be TRT? The commentary to this function says: I actually wondered the same thing while I was going to sleep. Obviously I got in too big a hurry last night. I'll fix it correctly myself and re-send. Thanks, and apologies for the noise. -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 13:25:10 2012 Received: (at control) by debbugs.gnu.org; 24 Jan 2012 18:25:11 +0000 Received: from localhost ([127.0.0.1]:42085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rpl3O-00075K-Gw for submit@debbugs.gnu.org; Tue, 24 Jan 2012 13:25:10 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:44700 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rpl3M-00075C-63 for control@debbugs.gnu.org; Tue, 24 Jan 2012 13:25:08 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Rpl30-0006oF-AN for control@debbugs.gnu.org; Tue, 24 Jan 2012 13:24:46 -0500 Date: Tue, 24 Jan 2012 13:24:46 -0500 Message-Id: Subject: control message for bug 10592 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) retitle 10592 movemail.c's error function and certain compiler flags From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 21:23:27 2012 Received: (at 10592) by debbugs.gnu.org; 25 Jan 2012 02:23:27 +0000 Received: from localhost ([127.0.0.1]:42421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpsWE-0003j9-2l for submit@debbugs.gnu.org; Tue, 24 Jan 2012 21:23:27 -0500 Received: from defaultvalue.org ([70.85.129.156]:58425 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpsW7-0003is-N2 for 10592@debbugs.gnu.org; Tue, 24 Jan 2012 21:23:24 -0500 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id D701590D35; Tue, 24 Jan 2012 20:23:10 -0600 (CST) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 0099F14E047; Tue, 24 Jan 2012 20:22:52 -0600 (CST) From: Rob Browning To: Eli Zaretskii Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> Date: Tue, 24 Jan 2012 20:22:52 -0600 In-Reply-To: (Eli Zaretskii's message of "Tue, 24 Jan 2012 01:06:40 -0500") Message-ID: <8739b45xmr.fsf@trouble.defaultvalue.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10592 Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Eli Zaretskii writes: > I think the right fix for this is to declare `error' with the > appropriate printf attribute. Alternatively, you could use variable > argument lists and call vprintf instead. Would something like this be acceptable, and if not, how would you like to see it adjusted? The patch changes error() to use an ANSI declaration, and it relies on the printf format attribute: diff --git a/lib-src/movemail.c b/lib-src/movemail.c index 58add49..6b2fc20 100644 --- a/lib-src/movemail.c +++ b/lib-src/movemail.c @@ -60,6 +60,7 @@ along with GNU Emacs. If not, see . */ #include #include #include +#include #include #include @@ -152,7 +153,7 @@ extern char *rindex __P((const char *, int)); #endif void fatal (); -void error (); +void error (const char *template, ...) __attribute__ ((format (printf, 1, 2))); void pfatal_with_name (); void pfatal_and_delete (); char *concat (); @@ -610,16 +611,13 @@ fatal (s1, s2, s3) are args for it or null. */ void -error (s1, s2, s3) - char *s1, *s2, *s3; +error (const char *template, ...) { + va_list ap; fprintf (stderr, "movemail: "); - if (s3) - fprintf (stderr, s1, s2, s3); - else if (s2) - fprintf (stderr, s1, s2); - else - fprintf (stderr, s1); + va_start (ap, template); + vfprintf (stderr, template, ap); + va_end (ap); fprintf (stderr, "\n"); } @@ -733,13 +731,13 @@ popmail (mailbox, outfile, preserve, password, reverse_order) server = pop_open (hostname, user, password, POP_NO_GETPASS); if (! server) { - error ("Error connecting to POP server: %s", pop_error, 0); + error ("Error connecting to POP server: %s", pop_error); return EXIT_FAILURE; } if (pop_stat (server, &nmsgs, &nbytes)) { - error ("Error getting message count from POP server: %s", pop_error, 0); + error ("Error getting message count from POP server: %s", pop_error); return EXIT_FAILURE; } @@ -761,7 +759,7 @@ popmail (mailbox, outfile, preserve, password, reverse_order) if ((mbf = fdopen (mbfi, "wb")) == NULL) { pop_close (server); - error ("Error in fdopen: %s", strerror (errno), 0); + error ("Error in fdopen: %s", strerror (errno)); close (mbfi); unlink (outfile); return EXIT_FAILURE; @@ -785,7 +783,7 @@ popmail (mailbox, outfile, preserve, password, reverse_order) mbx_delimit_begin (mbf); if (pop_retr (server, i, mbf) != OK) { - error ("%s", Errmsg, 0); + error ("%s", Errmsg); close (mbfi); return EXIT_FAILURE; } @@ -793,7 +791,7 @@ popmail (mailbox, outfile, preserve, password, reverse_order) fflush (mbf); if (ferror (mbf)) { - error ("Error in fflush: %s", strerror (errno), 0); + error ("Error in fflush: %s", strerror (errno)); pop_close (server); close (mbfi); return EXIT_FAILURE; @@ -809,14 +807,14 @@ popmail (mailbox, outfile, preserve, password, reverse_order) #ifdef BSD_SYSTEM if (fsync (mbfi) < 0) { - error ("Error in fsync: %s", strerror (errno), 0); + error ("Error in fsync: %s", strerror (errno)); return EXIT_FAILURE; } #endif if (close (mbfi) == -1) { - error ("Error in close: %s", strerror (errno), 0); + error ("Error in close: %s", strerror (errno)); return EXIT_FAILURE; } @@ -825,7 +823,7 @@ popmail (mailbox, outfile, preserve, password, reverse_order) { if (pop_delete (server, i)) { - error ("Error from POP server: %s", pop_error, 0); + error ("Error from POP server: %s", pop_error); pop_close (server); return EXIT_FAILURE; } @@ -833,7 +831,7 @@ popmail (mailbox, outfile, preserve, password, reverse_order) if (pop_quit (server)) { - error ("Error from POP server: %s", pop_error, 0); + error ("Error from POP server: %s", pop_error); return EXIT_FAILURE; } -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 01:40:56 2012 Received: (at 10592) by debbugs.gnu.org; 25 Jan 2012 06:40:56 +0000 Received: from localhost ([127.0.0.1]:42478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpwXP-00016U-LU for submit@debbugs.gnu.org; Wed, 25 Jan 2012 01:40:56 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:56208 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpwXM-00016M-IF for 10592@debbugs.gnu.org; Wed, 25 Jan 2012 01:40:53 -0500 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RpwWw-0001pz-Oq; Wed, 25 Jan 2012 01:40:26 -0500 Date: Wed, 25 Jan 2012 01:40:26 -0500 Message-Id: From: Eli Zaretskii To: Rob Browning In-reply-to: <8739b45xmr.fsf@trouble.defaultvalue.org> (message from Rob Browning on Tue, 24 Jan 2012 20:22:52 -0600) Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> <8739b45xmr.fsf@trouble.defaultvalue.org> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10592 Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > From: Rob Browning > Cc: 10592@debbugs.gnu.org, 655118@bugs.debian.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org > Date: Tue, 24 Jan 2012 20:22:52 -0600 > > Eli Zaretskii writes: > > > I think the right fix for this is to declare `error' with the > > appropriate printf attribute. Alternatively, you could use variable > > argument lists and call vprintf instead. > > Would something like this be acceptable, and if not, how would you like > to see it adjusted? The patch changes error() to use an ANSI > declaration, and it relies on the printf format attribute: This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined in src/config.h) instead of a literal __attribute__(...), which is a GCC-only thing. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 22:13:46 2012 Received: (at 10592) by debbugs.gnu.org; 26 Jan 2012 03:13:46 +0000 Received: from localhost ([127.0.0.1]:44236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqFmT-00028C-Vz for submit@debbugs.gnu.org; Wed, 25 Jan 2012 22:13:46 -0500 Received: from defaultvalue.org ([70.85.129.156]:59345 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqFmO-000282-SC for 10592@debbugs.gnu.org; Wed, 25 Jan 2012 22:13:45 -0500 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 957A790D35; Wed, 25 Jan 2012 21:13:27 -0600 (CST) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 41B6714E047; Wed, 25 Jan 2012 21:13:02 -0600 (CST) From: Rob Browning To: Eli Zaretskii Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> <8739b45xmr.fsf@trouble.defaultvalue.org> Date: Wed, 25 Jan 2012 21:13:01 -0600 In-Reply-To: (Eli Zaretskii's message of "Wed, 25 Jan 2012 01:40:26 -0500") Message-ID: <87fwf32m2q.fsf@trouble.defaultvalue.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10592 Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Eli Zaretskii writes: > This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined > in src/config.h) instead of a literal __attribute__(...), which is a > GCC-only thing. Will do. Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 22:26:06 2012 Received: (at 10592) by debbugs.gnu.org; 26 Jan 2012 03:26:06 +0000 Received: from localhost ([127.0.0.1]:44241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqFyP-0002PO-DK for submit@debbugs.gnu.org; Wed, 25 Jan 2012 22:26:06 -0500 Received: from defaultvalue.org ([70.85.129.156]:59354 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqFyN-0002PG-Oh for 10592@debbugs.gnu.org; Wed, 25 Jan 2012 22:26:04 -0500 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 511AE90D35; Wed, 25 Jan 2012 21:25:51 -0600 (CST) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 596F014E047; Wed, 25 Jan 2012 21:25:32 -0600 (CST) From: Rob Browning To: Eli Zaretskii Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> <8739b45xmr.fsf@trouble.defaultvalue.org> <87fwf32m2q.fsf@trouble.defaultvalue.org> Date: Wed, 25 Jan 2012 21:25:31 -0600 In-Reply-To: <87fwf32m2q.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Wed, 25 Jan 2012 21:13:01 -0600") Message-ID: <87bopr2lhw.fsf@trouble.defaultvalue.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10592 Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Rob Browning writes: > Eli Zaretskii writes: > >> This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined >> in src/config.h) instead of a literal __attribute__(...), which is a >> GCC-only thing. > > Will do. OK, that appears to be newer than 23.3, so I'll probably stick with the gcc-only changes for now (in Debian). Thanks again. -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 23:22:26 2012 Received: (at 10592-done) by debbugs.gnu.org; 31 Jan 2012 04:22:26 +0000 Received: from localhost ([127.0.0.1]:46099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs5Ef-0008Q7-MP for submit@debbugs.gnu.org; Mon, 30 Jan 2012 23:22:26 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:50593) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rs5Ec-0008Pt-6a for 10592-done@debbugs.gnu.org; Mon, 30 Jan 2012 23:22:23 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C951939E800B; Mon, 30 Jan 2012 20:22:02 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sCcvB8G-mfrE; Mon, 30 Jan 2012 20:22:02 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5BBAD39E8007; Mon, 30 Jan 2012 20:22:02 -0800 (PST) Message-ID: <4F276C6B.5010508@cs.ucla.edu> Date: Mon, 30 Jan 2012 20:22:03 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: 10592-done@debbugs.gnu.org Subject: Re: bug#10592: Bug#655118: Please enabled hardened build flags Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10592-done Cc: 655118@bugs.debian.org, Rob Browning X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) I am not observing this problem in the Emacs trunk, with either GCC 4.6.2 or GCC 4.7.0 20120127 (experimental), when I compile with -Wformat -Wformat-security. I suspect the problem has already been fixed in the trunk in a different way, by rewriting movemail to use prototypes. I'm therefore taking the liberty of marking this bug as fixed in the Emacs bug database; please feel free to reopen it if I've misunderstood the situation. From unknown Mon Jun 23 11:23:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Feb 2012 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator