GNU bug report logs - #10589
24.0.92; vc-register; use deduced backend for checking registered

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: OKAZAKI Tetsurou <okazaki.tetsurou <at> gmail.com>
Subject: bug#10589: closed (Re: bug#10589: 24.0.92; vc-register; use
 deduced backend for checking registered)
Date: Fri, 30 Nov 2012 04:48:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#10589: 24.0.92; vc-register; use deduced backend for checking registered

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 10589 <at> debbugs.gnu.org.

-- 
10589: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10589
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> gnu.org>
To: OKAZAKI Tetsurou <okazaki.tetsurou <at> gmail.com>
Cc: 10589-done <at> debbugs.gnu.org
Subject: Re: bug#10589: 24.0.92; vc-register;
	use deduced backend for checking registered
Date: Fri, 30 Nov 2012 12:45:23 +0800

OKAZAKI Tetsurou <okazaki.tetsurou <at> gmail.com> writes:

> Current implementation of `vc-register' fails to register an
> unregistered item which is already registered to another backend.
>
> Using `vc-call-backend' with deduced `backend' instead of `vc-backend'
> and `vc-registered' resolves this issue.

I've committed your patch to trunk.  Thanks.

[Message part 3 (message/rfc822, inline)]

From: OKAZAKI Tetsurou <okazaki.tetsurou <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.92; vc-register; use deduced backend for checking registered
Date: Tue, 24 Jan 2012 11:35:52 +0900

Current implementation of `vc-register' fails to register an unregistered item
which is already registered to another backend.

Using `vc-call-backend' with deduced `backend' instead of `vc-backend' and
`vc-registered' resolves this issue.


=== modified file 'lisp/vc/vc.el'
*** lisp/vc/vc.el	2012-01-19 07:21:25 +0000
--- lisp/vc/vc.el	2012-01-20 19:55:38 +0000
*************** first backend that could register the fi
*** 1277,1287 ****
      (dolist (fname files)
        (let ((bname (get-file-buffer fname)))
  	(unless fname (setq fname buffer-file-name))
! 	(when (vc-backend fname)
! 	  (if (vc-registered fname)
! 	      (error "This file is already registered")
! 	    (unless (y-or-n-p "Previous master file has vanished.  Make a new one? ")
! 	      (error "Aborted"))))
  	;; Watch out for new buffers of size 0: the corresponding file
  	;; does not exist yet, even though buffer-modified-p is nil.
  	(when bname
--- 1277,1284 ----
      (dolist (fname files)
        (let ((bname (get-file-buffer fname)))
  	(unless fname (setq fname buffer-file-name))
! 	(when (vc-call-backend backend 'registered fname)
! 	  (error "This file is already registered"))
  	;; Watch out for new buffers of size 0: the corresponding file
  	;; does not exist yet, even though buffer-modified-p is nil.
  	(when bname

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.