Subject: bug#10575: "compress" not found: causes many test failures

From: Jim Meyering <[email-masked]>
Date: Sun, 22 Jan 2012 12:29:44 +0100

Stefano Lattarini wrote:
> On 01/21/2012 10:17 PM, Jim Meyering wrote:
>>
>>     FAIL: vala-mix
>>
> And the attached patch (applied to maint) should take care of this
> failure.

Thanks.
This reduces by one more my "FAIL" counter.

> Subject: [PATCH] vala tests: add missing 'valac' requirement, and other minor
>  fixlets
>
> See also automake bug#10575.
>
> * tests/vala-mix.test ($required): Add 'valac'; this will avoid
> spurious failures on systems lacking a Vala compiler.
> Add some explicative comments for a couple of non-obvious make

I think of "explicative" as a word not in common usage
and would use "explanatory" in its place.

> calls.
> Make grepping of "make -n" slightly stricter, to avoid potential
> false positives.
> ---
>  tests/vala-mix.test |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/vala-mix.test b/tests/vala-mix.test
> index f597a7f..73a07d9 100755
> --- a/tests/vala-mix.test
> +++ b/tests/vala-mix.test
> @@ -16,7 +16,7 @@
>
>  # Vala sources and C sources in the same program.  Functional test.
>
> -required='cc GNUmake'
> +required='valac cc GNUmake'
>  . ./defs || Exit 1
>
>  set -e
> @@ -96,8 +96,9 @@ have_generated_files ()
>  # C files.
>  have_generated_files
>
> +# Remake rules are not uselessly triggered.

That added comment didn't help me much, at first.
Then I realized you probably intended this:

  # Ensure that remake rules are not uselessly triggered.

>  $MAKE -q
> -$MAKE -n | grep stamp && Exit 1
> +$MAKE -n | $FGREP vala.stamp && Exit 1
>
>  # Check the distribution.
>  $MAKE distcheck