GNU bug report logs - #10555
automake: wrong use of F77FLAGS instead of FFLAGS?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10555 in the body.
You can then email your comments to 10555 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Cc: "<autoconf <at> gnu.org>" <autoconf <at> gnu.org>
Subject: automake: wrong use of F77FLAGS instead of FFLAGS?
Date: Thu, 19 Jan 2012 14:45:05 +0100

Severity: minor
thanks

In the Automake repository, I'm seeing this:

  $ git grep F77FLAGS
  lib/Automake/Variable.pm:   F77FLAGS => 'AC_PROG_F77',
  $ grep -C 10 F77FLAGS lib/Automake/Variable.pm
  # Macros shipped with Autoconf.
  my %_ac_macro_for_var =
    (
     ALLOCA => 'AC_FUNC_ALLOCA',
     CC => 'AC_PROG_CC',
     CFLAGS => 'AC_PROG_CC',
     CXX => 'AC_PROG_CXX',
     CXXFLAGS => 'AC_PROG_CXX',
     F77 => 'AC_PROG_F77',
     F77FLAGS => 'AC_PROG_F77',
     FC => 'AC_PROG_FC',
     FCFLAGS => 'AC_PROG_FC',
     OBJC => 'AC_PROG_OBJC',
     OBJCFLAGS => 'AC_PROG_OBJC',
     RANLIB => 'AC_PROG_RANLIB',
     UPC => 'AM_PROG_UPC',
     UPCFLAGS => 'AM_PROG_UPC',
     YACC => 'AC_PROG_YACC',
   );

But autoconf uses FFLAGS, not F77FLAGS, as the variable where to look for
switches for the Fortran 77 compiler:

  $ cd src/autoconf
  $ git grep F77FLAGS || echo NOT FOUND
  NOT FOUND
  $ grep FFLAGS lib/autoconf/fortran.m4
  # dialects.  Fortran 77 uses environment variables F77, FFLAGS, and FLIBS,
  ac_compile='$F77 -c $FFLAGS conftest.$ac_ext >&AS_MESSAGE_LOG_FD'
  ac_link='$F77 -o conftest$ac_exeext $FFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&AS_MESSAGE_LOG_FD'
  AC_ARG_VAR([FFLAGS], [Fortran 77 compiler flags])dnl

And the autoconf documentation agrees with that:

  * Variable: FFLAGS
    Debugging and optimization options for the Fortran 77 compiler. If it
    is not set in the environment when configure runs, the default value
    is set when you call AC_PROG_F77 (or empty if you don't). configure
    uses this variable when compiling or linking programs to test for
    Fortran 77 features.

  ...

  ``Fortran 77''
  Do compilation tests using F77 and use extension .f for test programs.
  Use compilation flags: FFLAGS.

So, to all autoconfers: do you happen to know any reason for which Automake
should use F77FLAGS? If not, I'll assume that is due to a typo or clerical
mistake, and fix it (in 48 hours or so).

Thanks,
  Stefano

Message #8 received at 10555 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: 10555 <at> debbugs.gnu.org
Cc: "<autoconf <at> gnu.org>" <autoconf <at> gnu.org>
Subject: Re: bug#10555: automake: wrong use of F77FLAGS instead of FFLAGS?
Date: Fri, 20 Jan 2012 20:53:27 +0100

[Message part 1 (text/plain, inline)]

On 01/19/2012 02:45 PM, Stefano Lattarini wrote:
>
> [SNIP]
>
> So, to all autoconfers: do you happen to know any reason for which Automake
> should use F77FLAGS? If not, I'll assume that is due to a typo or clerical
> mistake, and fix it (in 48 hours or so).
> 
The attached patch should take care of this.  I'll push it tomorrow if there
is no objection.

Thanks,
  Stefano

[0001-fixlet-flags-for-Fortran77-compiler-are-in-FFLAGS-no.patch (text/x-diff, attachment)]

Message #11 received at 10555 <at> debbugs.gnu.org (full text, mbox):

From: Peter Rosin <peda <at> lysator.liu.se>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 10555 <at> debbugs.gnu.org
Subject: Re: bug#10555: automake: wrong use of F77FLAGS instead of FFLAGS?
Date: Fri, 20 Jan 2012 21:08:04 +0100

Stefano Lattarini skrev 2012-01-20 20:53:
> On 01/19/2012 02:45 PM, Stefano Lattarini wrote:
>>
>> [SNIP]
>>
>> So, to all autoconfers: do you happen to know any reason for which Automake
>> should use F77FLAGS? If not, I'll assume that is due to a typo or clerical
>> mistake, and fix it (in 48 hours or so).
>>
> The attached patch should take care of this.  I'll push it tomorrow if there
> is no objection.

Isn't this worthy of a NEWS entry?  Or does it not affect end users at all?

Cheers,
Peter

Message #14 received at 10555 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Rosin <peda <at> lysator.liu.se>
Cc: 10555 <at> debbugs.gnu.org
Subject: Re: bug#10555: automake: wrong use of F77FLAGS instead of FFLAGS?
Date: Sat, 21 Jan 2012 10:26:12 +0100

[Message part 1 (text/plain, inline)]

On 01/20/2012 09:08 PM, Peter Rosin wrote:
> Stefano Lattarini skrev 2012-01-20 20:53:
>> On 01/19/2012 02:45 PM, Stefano Lattarini wrote:
>>>
>>> [SNIP]
>>>
>>> So, to all autoconfers: do you happen to know any reason for which Automake
>>> should use F77FLAGS? If not, I'll assume that is due to a typo or clerical
>>> mistake, and fix it (in 48 hours or so).
>>>
>> The attached patch should take care of this.  I'll push it tomorrow if there
>> is no objection.
> 
> Isn't this worthy of a NEWS entry?  Or does it not affect end users at all?
>
The bug only affected the "hints" printed by automake in some error messages
(e.g., "The usual way to define `F77' is to add AC_PROG_F77 to configure.ac"),
and I believe that is so minor not to require a NEWS entry.  Anyway, I see
this fact wasn't apparent from my commit message, so I've amended it to be
clearer.  Attached is the patch I've pushed.  If you are still convinced it
deserves a NEWS entry anyway, feel free to write one; I won't object.

Thanks,
  Stefano

[0001-fixlet-flags-for-Fortran77-compiler-are-in-FFLAGS-no.patch (text/x-diff, attachment)]

Message #17 received at 10555 <at> debbugs.gnu.org (full text, mbox):

From: Peter Rosin <peda <at> lysator.liu.se>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 10555 <at> debbugs.gnu.org
Subject: Re: bug#10555: automake: wrong use of F77FLAGS instead of FFLAGS?
Date: Sun, 22 Jan 2012 20:00:39 +0100

Stefano Lattarini skrev 2012-01-21 10:26:
> On 01/20/2012 09:08 PM, Peter Rosin wrote:
>> Stefano Lattarini skrev 2012-01-20 20:53:
>>> On 01/19/2012 02:45 PM, Stefano Lattarini wrote:
>>>>
>>>> [SNIP]
>>>>
>>>> So, to all autoconfers: do you happen to know any reason for which Automake
>>>> should use F77FLAGS? If not, I'll assume that is due to a typo or clerical
>>>> mistake, and fix it (in 48 hours or so).
>>>>
>>> The attached patch should take care of this.  I'll push it tomorrow if there
>>> is no objection.
>>
>> Isn't this worthy of a NEWS entry?  Or does it not affect end users at all?
>>
> The bug only affected the "hints" printed by automake in some error messages
> (e.g., "The usual way to define `F77' is to add AC_PROG_F77 to configure.ac"),
> and I believe that is so minor not to require a NEWS entry.  Anyway, I see
> this fact wasn't apparent from my commit message, so I've amended it to be
> clearer.  Attached is the patch I've pushed.  If you are still convinced it
> deserves a NEWS entry anyway, feel free to write one; I won't object.

Ok, in that case a NEWS entry is not needed.  I should have mentioned that I
only thought it was needed in case you had forgotten about it...

Cheers,
Peter

Message #20 received at 10555 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: 10555 <at> debbugs.gnu.org
Subject: close bug
Date: Thu, 02 Feb 2012 10:01:48 +0100

tags 10555 patch
close 10555
thanks

This bug has been fixed by commit 'v1.11-664-g84fbf46',
"fixlet: flags for Fortran77 compiler are in FFLAGS, not F77FLAGS".
I'm thus closing this report.

Regards,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.