From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 16:20:58 2012 Received: (at submit) by debbugs.gnu.org; 18 Jan 2012 21:20:58 +0000 Received: from localhost ([127.0.0.1]:34786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RncwE-0006Ag-0j for submit@debbugs.gnu.org; Wed, 18 Jan 2012 16:20:58 -0500 Received: from eggs.gnu.org ([140.186.70.92]:38427) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RncwB-0006AY-KO for submit@debbugs.gnu.org; Wed, 18 Jan 2012 16:20:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rncv4-00065X-K7 for submit@debbugs.gnu.org; Wed, 18 Jan 2012 16:19:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:38943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rncv4-00065T-Hy for submit@debbugs.gnu.org; Wed, 18 Jan 2012 16:19:46 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rncv1-0005B3-JV for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2012 16:19:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rncv0-000655-Br for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2012 16:19:43 -0500 Received: from mail-yx0-f169.google.com ([209.85.213.169]:56609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rncv0-000651-9H for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2012 16:19:42 -0500 Received: by yenm10 with SMTP id m10so2862127yen.0 for ; Wed, 18 Jan 2012 13:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=hoxGVIsSyaB450V+lYjMtYleOAKqXqD7j2RJ8YYrpqc=; b=hE3l6UhRfj8nV/fwaqO02bKWzucX5sNJy4RhTtjI48vxKDw+KC/JHBoRAJ6MZ39KHs Z80RU0eRRMz0uLpLuztHdb3gqcV8/p2vVT68otad+f0ugK9BC7xqIeSH1Omq31KPbccf SGrTAwBKEFfSMg0NZK4OHalGrnENYABNiVVCE= Received: by 10.236.121.168 with SMTP id r28mr35630107yhh.51.1326921581458; Wed, 18 Jan 2012 13:19:41 -0800 (PST) Received: from anvil.home ([199.233.87.102]) by mx.google.com with ESMTPS id 17sm465789ang.11.2012.01.18.13.19.39 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Jan 2012 13:19:40 -0800 (PST) From: Mike Lamb To: bug-gnu-emacs@gnu.org Subject: 24.0.92; eshell - use pcomplete/ssh from pcmpl-unix.el Date: Wed, 18 Jan 2012 16:18:49 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) When ssh completion is used in eshell for the first time in an emacs session, it only uses pcomplete/ssh from eshell/em-unix.el. All subsequent ssh completions in eshell only use pcomplete/ssh defined in pcmpl-unix.el. pcomplete/ssh in eshell/em-unix.el is an alias to pcomplete/rsh. When pcomplete/rsh executes it only returns the hosts contained in /etc/hosts. When pcomplete/ssh from pcmpl-unix.el executes it returns hosts from ~/.ssh/known_hosts (and other ssh config files). My system only contains a few entries in /etc/hosts to configure the loopback interface so I removed the pcomplete/ssh alias from eshell/em-unix.el and rely only on pcomplete/ssh defined in pcmpl-unix.el. My workaround patch: *** old/lisp/em-unix.el 2012-01-18 16:01:18.000000000 -0500 --- new/lisp/em-unix.el 2012-01-18 16:01:29.000000000 -0500 *************** *** 792,799 **** (funcall (or (pcomplete-find-completion-function (pcomplete-arg 1)) pcomplete-default-completion-function))) - (defalias 'pcomplete/ssh 'pcomplete/rsh) - (defvar block-size) (defvar by-bytes) (defvar dereference-links) --- 792,797 ---- This happens to be the behavior that I expect. In GNU Emacs 24.0.92.1 (x86_64-apple-darwin11.2.0, NS apple-appkit-1138.23) of 2012-01-18 on anvil.home Windowing system distributor `Apple', version 10.3.1138 configured using `configure '--with-ns' '--without-x'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: EShell Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x e s h s s h SPC u @ M-x r e p o r t Recent messages: Loading em-cmpl...done Loading em-dirs...done Loading em-glob...done Loading em-hist...done Loading em-ls...done Loading em-prompt...done Loading em-script...done Loading em-term...done Loading em-unix...done Hit space to flush Load-path shadows: None found. Features: (shadow sort mail-extr message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader emacsbug help-mode view pcmpl-unix ansi-color em-unix pcomplete comint em-term term disp-table ehelp electric em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic esh-opt em-banner em-alias ring esh-var esh-io esh-cmd esh-ext esh-proc esh-arg eldoc help-fns esh-groups eshell esh-module esh-mode esh-util server smtpmail auth-source eieio byte-opt bytecomp byte-compile cconv macroexp assoc gnus-util password-cache sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired-x easymenu dired regexp-opt edmacro kmacro time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 03:21:02 2012 Received: (at 10548-done) by debbugs.gnu.org; 23 Jan 2012 08:21:02 +0000 Received: from localhost ([127.0.0.1]:40459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpF9B-00061Z-Mm for submit@debbugs.gnu.org; Mon, 23 Jan 2012 03:21:02 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:41113 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpF99-00061S-Nb for 10548-done@debbugs.gnu.org; Mon, 23 Jan 2012 03:21:00 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RpF8t-0000Ro-Ny; Mon, 23 Jan 2012 03:20:43 -0500 From: Glenn Morris To: 10548-done@debbugs.gnu.org Subject: Re: bug#10548: 24.0.92; eshell - use pcomplete/ssh from pcmpl-unix.el References: X-Spook: 22nd SAS 64 Vauxhall Cross offensive information warfare X-Ran: %Kmm9"Ct?QOs2,5*>kx}!VByA;qiH`Qv@z>My`O}'aI|CNHc)#XdTo"t)!%B[;7l]f@irw X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 23 Jan 2012 03:20:43 -0500 In-Reply-To: (Mike Lamb's message of "Wed, 18 Jan 2012 16:18:49 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10548-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Version: 24.0.3 Mike Lamb wrote: > - (defalias 'pcomplete/ssh 'pcomplete/rsh) Thanks; applied. IMO, eshell has no business defining such general partial-completion functions as pcomplete/ftp etc. I will open a new bug for that; to be fixed after Emacs 24.1. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 03:28:22 2012 Received: (at control) by debbugs.gnu.org; 23 Jan 2012 08:28:22 +0000 Received: from localhost ([127.0.0.1]:40469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpFGG-0006Ch-Lf for submit@debbugs.gnu.org; Mon, 23 Jan 2012 03:28:21 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:41294 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpFGE-0006Ca-UR for control@debbugs.gnu.org; Mon, 23 Jan 2012 03:28:19 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RpFG0-0001F4-VJ for control@debbugs.gnu.org; Mon, 23 Jan 2012 03:28:05 -0500 Date: Mon, 23 Jan 2012 03:28:04 -0500 Message-Id: Subject: control message for bug 10548 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) fixed 10548 24.0.93 notfixed 10548 24.0.3 From unknown Mon Aug 18 14:21:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Feb 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator