From unknown Thu Aug 14 07:44:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10533 <10533@debbugs.gnu.org> To: bug#10533 <10533@debbugs.gnu.org> Subject: Status: 24.0.92; pcmpl-ssh-known-hosts - parse hosts with non-standard port numbers Reply-To: bug#10533 <10533@debbugs.gnu.org> Date: Thu, 14 Aug 2025 14:44:45 +0000 retitle 10533 24.0.92; pcmpl-ssh-known-hosts - parse hosts with non-standar= d port numbers reassign 10533 emacs submitter 10533 Mike Lamb severity 10533 minor tag 10533 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 12:07:06 2012 Received: (at submit) by debbugs.gnu.org; 17 Jan 2012 17:07:06 +0000 Received: from localhost ([127.0.0.1]:33767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RnCUy-0006kF-GR for submit@debbugs.gnu.org; Tue, 17 Jan 2012 12:07:05 -0500 Received: from eggs.gnu.org ([140.186.70.92]:45189) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn8v4-0000Xw-I6 for submit@debbugs.gnu.org; Tue, 17 Jan 2012 08:17:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rn8tz-0007SK-Sx for submit@debbugs.gnu.org; Tue, 17 Jan 2012 08:16:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:53960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn8tz-0007SG-RC for submit@debbugs.gnu.org; Tue, 17 Jan 2012 08:16:39 -0500 Received: from eggs.gnu.org ([140.186.70.92]:48796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn8tv-00027v-Ie for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2012 08:16:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rn8tt-0007Rm-Jk for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2012 08:16:35 -0500 Received: from mail-vx0-f169.google.com ([209.85.220.169]:59829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn8tt-0007Q7-DH for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2012 08:16:33 -0500 Received: by mail-vx0-f169.google.com with SMTP id fl11so189437vcb.0 for ; Tue, 17 Jan 2012 05:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=dr7Nb6/qpqQQEHMIG52/Yp0faxKQrXVkyQJsxupppeg=; b=vAurOpH6bRmTOAS5WsYEhpwwloDrg3dXr1weTXLyZADl3V/eQvFRjcEKjjcw/SKb4K oMDrU8/uuLIlUJ0GwcFKb97r+eIRTWL0lHlZNzZyA0CHWrXdwtn+8EMiZ+dhMeoTb+VD JctHc5FQnRgkG3g2w3SY3gKHoIKDUirlfQyr8= Received: by 10.220.140.135 with SMTP id i7mr9854844vcu.65.1326806193264; Tue, 17 Jan 2012 05:16:33 -0800 (PST) Received: from anvil.home (pool-71-187-68-105.nwrknj.fios.verizon.net. [71.187.68.105]) by mx.google.com with ESMTPS id hj10sm18289199vdb.0.2012.01.17.05.16.31 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 Jan 2012 05:16:32 -0800 (PST) From: Mike Lamb To: bug-gnu-emacs@gnu.org Subject: 24.0.92; pcmpl-ssh-known-hosts - parse hosts with non-standard port numbers Date: Tue, 17 Jan 2012 08:16:30 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 17 Jan 2012 12:07:02 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) This patch extends the regex in pcmpl-ssh-known-hosts to include hosts that use a non-standard port number. The description of this syntax in the sshd(8) man page is: A hostname or address may optionally be enclosed within `[' and `]' brackets then followed by `:' and a non-standard port number. Patch: *** emacs-24.0.92.4/lisp/pcmpl-unix.el 2012-01-16 17:36:24.000000000 -0500 --- emacs-patch/lisp/pcmpl-unix.el 2012-01-16 17:36:42.000000000 -0500 *************** *** 152,164 **** (file-readable-p pcmpl-ssh-known-hosts-file)) (with-temp-buffer (insert-file-contents-literally pcmpl-ssh-known-hosts-file) ! (let (ssh-hosts-list) ! (while (re-search-forward "^ *\\([-.[:alnum:]]+\\)[, ]" nil t) ! (add-to-list 'ssh-hosts-list (match-string 1)) (while (and (looking-back ",") ! (re-search-forward "\\([-.[:alnum:]]+\\)[, ]" (line-end-position) t)) ! (add-to-list 'ssh-hosts-list (match-string 1)))) ssh-hosts-list)))) (defun pcmpl-ssh-config-hosts () --- 152,166 ---- (file-readable-p pcmpl-ssh-known-hosts-file)) (with-temp-buffer (insert-file-contents-literally pcmpl-ssh-known-hosts-file) ! (let (ssh-hosts-list ! (host-re "\\(?:\\([-.[:alnum:]]+\\)\\|\\[\\([-.[:alnum:]]+\\)\\]:[0-9]+\\)[, ]") ! ) ! (while (re-search-forward (concat "^ *" host-re) nil t) ! (add-to-list 'ssh-hosts-list (concat (match-string 1) (match-string 2))) (while (and (looking-back ",") ! (re-search-forward host-re (line-end-position) t)) ! (add-to-list 'ssh-hosts-list (concat (match-string 1) (match-string 2)) ))) ssh-hosts-list)))) (defun pcmpl-ssh-config-hosts () Test data for ~/.ssh/known_hosts: host1 ssh-rsa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa host2,host3 ssh-rsa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb [host4]:2222 ssh-rsa cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc [host5]:2222,[host6]:2222 ssh-rsa dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd 10.0.0.1 ssh-rsa eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee 10.0.0.2,10.0.0.3 ssh-rsa ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff [10.0.0.4]:2222 ssh-rsa gggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg [10.0.0.5]:2222,[10.0.0.6]:2222 ssh-rsa ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff >From emacs -Q: M-x eshell ssh TAB Without patch: Possible completions are: 10.0.0.3 10.0.0.2 10.0.0.1 host3 host2 host1 With patch: Possible completions are: 10.0.0.6 10.0.0.5 10.0.0.4 10.0.0.3 10.0.0.2 10.0.0.1 host6 host5 host4 host3 host2 host1 In GNU Emacs 24.0.92.4 (x86_64-apple-darwin11.2.0) of 2012-01-16 on anvil.home configured using `configure '--without-x' '--without-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: EShell Minor modes in effect: menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: ESC [ > 0 ; 9 5 ; c ESC x e s h e l l RET s s h SPC TAB DEL SPC TAB DEL DEL DEL DEL DEL ESC x b u g TAB TAB DEL DEL DEL DEL DEL DEL DEL DEL DEL DEL DEL DEL DEL DEL r e p o r t - b TAB RET Recent messages: Loading em-glob...done Loading em-hist...done Loading em-ls...done Loading em-prompt...done Loading em-script...done Loading em-term...done Loading em-unix...done Hit space to flush [2 times] delete-backward-char: Text is read-only Making completion list... Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug help-mode easymenu view pcmpl-unix ansi-color em-unix pcomplete comint regexp-opt em-term term disp-table ehelp electric em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic esh-opt em-banner em-alias ring esh-var esh-io esh-cmd esh-ext esh-proc esh-arg eldoc help-fns esh-groups eshell esh-module esh-mode esh-util time-date ediff-hook vc-hooks lisp-float-type lisp-mode register page menu-bar rfn-eshadow timer jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 16:15:17 2012 Received: (at 10533-done) by debbugs.gnu.org; 27 Jan 2012 21:15:17 +0000 Received: from localhost ([127.0.0.1]:47078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rqt8f-0004rY-6v for submit@debbugs.gnu.org; Fri, 27 Jan 2012 16:15:17 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:32819 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rqt8d-0004rS-Qi for 10533-done@debbugs.gnu.org; Fri, 27 Jan 2012 16:15:16 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Rqt7y-00026M-FI; Fri, 27 Jan 2012 16:14:34 -0500 From: Glenn Morris To: 10533-done@debbugs.gnu.org Subject: Re: bug#10533: 24.0.92; pcmpl-ssh-known-hosts - parse hosts with non-standard port numbers References: X-Spook: Venezuela Osama crypto anarchy MILSATCOM hackers SP4 X-Ran: */PORat\[BYVn3HpzGjKp}i#B'QHH+lB{5`&l9_{`}`S#xYX&>L8Hpk+p^QYpCn"hZcOC4 X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 27 Jan 2012 16:14:34 -0500 In-Reply-To: (Mike Lamb's message of "Tue, 17 Jan 2012 08:16:30 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10533-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Version: 24.0.93 Thank you; applied. From unknown Thu Aug 14 07:44:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Feb 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator