From unknown Sun Aug 10 07:24:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10523 <10523@debbugs.gnu.org> To: bug#10523 <10523@debbugs.gnu.org> Subject: Status: 24.0.92; Wrong init value for eshell-windows-shell-file Reply-To: bug#10523 <10523@debbugs.gnu.org> Date: Sun, 10 Aug 2025 14:24:27 +0000 retitle 10523 24.0.92; Wrong init value for eshell-windows-shell-file reassign 10523 emacs submitter 10523 Lars Ljung severity 10523 normal tag 10523 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 16:47:12 2012 Received: (at submit) by debbugs.gnu.org; 16 Jan 2012 21:47:12 +0000 Received: from localhost ([127.0.0.1]:60746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmuOQ-0001dw-6D for submit@debbugs.gnu.org; Mon, 16 Jan 2012 16:47:10 -0500 Received: from eggs.gnu.org ([140.186.70.92]:39262) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmuOM-0001dn-7h for submit@debbugs.gnu.org; Mon, 16 Jan 2012 16:47:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmuNQ-0007UI-Ma for submit@debbugs.gnu.org; Mon, 16 Jan 2012 16:46:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:35130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmuNQ-0007UD-JS for submit@debbugs.gnu.org; Mon, 16 Jan 2012 16:46:04 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmuNP-00042R-J5 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 16:46:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmuNM-0007Tc-RN for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 16:46:03 -0500 Received: from mail7.surf-town.net ([212.97.132.47]:44170 helo=mailgw13.surf-town.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmuNM-0007T3-MU for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 16:46:00 -0500 Received: by mailgw13.surf-town.net (Postfix, from userid 65534) id A748140372; Mon, 16 Jan 2012 22:45:57 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailgw13.surf-town.net (Postfix) with ESMTP id 6347740642 for ; Mon, 16 Jan 2012 22:45:57 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mailgw13.surf-town.net Received: from mailgw13.surf-town.net ([127.0.0.1]) by localhost (mailgw13.surf-town.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ee7kKmpDGWPs for ; Mon, 16 Jan 2012 22:45:51 +0100 (CET) Received: from [192.168.0.103] (c80-216-217-205.bredband.comhem.se [80.216.217.205]) by mailgw13.surf-town.net (Postfix) with ESMTPSA id 1355440372 for ; Mon, 16 Jan 2012 22:45:50 +0100 (CET) Message-ID: <4F149A8E.50705@matholka.se> Date: Mon, 16 Jan 2012 22:45:50 +0100 From: Lars Ljung User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.0.92; Wrong init value for eshell-windows-shell-file X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) The function eshell-invoke-batch-file expects that eshell-windows-shell-file points to something with the behaviour of cmd.exe. Currently it defaults to the path to cmdproxy.exe (the default value of shell-file-name), which will not work properly. The patch below solves this issue. === modified file 'lisp/eshell/esh-ext.el' --- lisp/eshell/esh-ext.el 2012-01-05 09:46:05 +0000 +++ lisp/eshell/esh-ext.el 2012-01-16 20:21:27 +0000 @@ -91,7 +91,7 @@ (defcustom eshell-windows-shell-file (if (eshell-under-windows-p) - (if (string-match "\\(\\`cmdproxy\\|sh\\)\\.\\(com\\|exe\\)" + (if (string-match "\\(cmdproxy\\|sh\\)\\.\\(com\\|exe\\)" shell-file-name) (or (eshell-search-path "cmd.exe") (eshell-search-path "command.com")) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 22:59:25 2012 Received: (at control) by debbugs.gnu.org; 17 Jan 2012 03:59:25 +0000 Received: from localhost ([127.0.0.1]:60933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn0Ci-00026b-OJ for submit@debbugs.gnu.org; Mon, 16 Jan 2012 22:59:25 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:47676) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn0Cg-00026V-VZ for control@debbugs.gnu.org; Mon, 16 Jan 2012 22:59:23 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id BF24A39E800A for ; Mon, 16 Jan 2012 19:58:24 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iL-790rho5WC for ; Mon, 16 Jan 2012 19:58:24 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7C53139E8006 for ; Mon, 16 Jan 2012 19:58:24 -0800 (PST) Message-ID: <4F14F1F3.1020501@cs.ucla.edu> Date: Mon, 16 Jan 2012 19:58:43 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: Bug#10523 has a patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 10523 patch From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 00:12:23 2012 Received: (at 10523) by debbugs.gnu.org; 17 Jan 2012 05:12:23 +0000 Received: from localhost ([127.0.0.1]:60965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn1LJ-0005NG-Ka for submit@debbugs.gnu.org; Tue, 17 Jan 2012 00:12:22 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:43298) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn1LF-0005N5-O2 for 10523@debbugs.gnu.org; Tue, 17 Jan 2012 00:12:19 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LXX00300FPHX700@a-mtaout21.012.net.il> for 10523@debbugs.gnu.org; Tue, 17 Jan 2012 07:11:15 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.115.9]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXX003L0FQQP1B0@a-mtaout21.012.net.il>; Tue, 17 Jan 2012 07:11:15 +0200 (IST) Date: Tue, 17 Jan 2012 07:11:18 +0200 From: Eli Zaretskii Subject: Re: bug#10523: 24.0.92; Wrong init value for eshell-windows-shell-file In-reply-to: <4F149A8E.50705@matholka.se> X-012-Sender: halo1@inter.net.il To: Lars Ljung Message-id: <83mx9m6hhl.fsf@gnu.org> References: <4F149A8E.50705@matholka.se> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10523 Cc: 10523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Mon, 16 Jan 2012 22:45:50 +0100 > From: Lars Ljung > > The function eshell-invoke-batch-file expects that > eshell-windows-shell-file points to something with the behaviour of > cmd.exe. Currently it defaults to the path to cmdproxy.exe (the default > value of shell-file-name), which will not work properly. Why doesn't it work properly? Can you give a simple test case where it fails, and explain why? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 00:54:50 2012 Received: (at 10523) by debbugs.gnu.org; 17 Jan 2012 05:54:50 +0000 Received: from localhost ([127.0.0.1]:60990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn20P-0006MR-Gm for submit@debbugs.gnu.org; Tue, 17 Jan 2012 00:54:50 -0500 Received: from mail6.surf-town.net ([212.97.132.46]:60604 helo=mailgw6.surf-town.net) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn20N-0006MI-3s for 10523@debbugs.gnu.org; Tue, 17 Jan 2012 00:54:48 -0500 Received: by mailgw6.surf-town.net (Postfix, from userid 65534) id A03D260295; Tue, 17 Jan 2012 06:53:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailgw6.surf-town.net (Postfix) with ESMTP id 7DE335FAA1; Tue, 17 Jan 2012 06:53:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mailgw6.surf-town.net X-Spam-Flag: NO X-Spam-Score: -1.44 X-Spam-Level: X-Spam-Status: No, score=-1.44 tagged_above=-999 required=7 tests=[ALL_TRUSTED=-1.44] autolearn=disabled Received: from mailgw6.surf-town.net ([127.0.0.1]) by localhost (mailgw6.surf-town.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ikajvl87yDEj; Tue, 17 Jan 2012 06:53:40 +0100 (CET) Received: from [192.168.0.103] (c80-216-217-205.bredband.comhem.se [80.216.217.205]) by mailgw6.surf-town.net (Postfix) with ESMTPSA id A04315FACF; Tue, 17 Jan 2012 06:53:39 +0100 (CET) Message-ID: <4F150CE2.9080502@matholka.se> Date: Tue, 17 Jan 2012 06:53:38 +0100 From: Lars Ljung User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#10523: 24.0.92; Wrong init value for eshell-windows-shell-file References: <4F149A8E.50705@matholka.se> <83mx9m6hhl.fsf@gnu.org> In-Reply-To: <83mx9m6hhl.fsf@gnu.org> X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10523 Cc: 10523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) 2012-01-17 06:11, Eli Zaretskii skrev: > Why doesn't it work properly? Can you give a simple test case where > it fails, and explain why? With cmdproxy.exe it will look like this: ~ $ test.bat arg1 arg2 warning: extra args ignored after 'test.bat' The warning is printed by cmdproxy.exe and the reason is that the command gets translated to the following: cmdproxy.exe /c test.bat arg1 arg2 But cmdproxy.exe expects one single argument after /c, .i.e. cmdproxy.exe /c "test.bat arg1 arg2". cmd.exe on the other hand uses all remaining arguments on the command line. To me it looks like the regexp is used to avoid using cmdproxy.exe, but it fails because of the extra \\`. Regards, Lars Ljung From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 04:59:30 2012 Received: (at 10523-done) by debbugs.gnu.org; 4 Feb 2012 09:59:30 +0000 Received: from localhost ([127.0.0.1]:53153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RtcP3-0001D7-U7 for submit@debbugs.gnu.org; Sat, 04 Feb 2012 04:59:30 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:60344) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RtcP1-0001Cs-I5 for 10523-done@debbugs.gnu.org; Sat, 04 Feb 2012 04:59:29 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LYV009005052S00@a-mtaout22.012.net.il> for 10523-done@debbugs.gnu.org; Sat, 04 Feb 2012 11:58:43 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.149.90]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LYV008YN51UZ820@a-mtaout22.012.net.il>; Sat, 04 Feb 2012 11:58:43 +0200 (IST) Date: Sat, 04 Feb 2012 11:58:43 +0200 From: Eli Zaretskii Subject: Re: bug#10523: 24.0.92; Wrong init value for eshell-windows-shell-file In-reply-to: <4F150CE2.9080502@matholka.se> X-012-Sender: halo1@inter.net.il To: Lars Ljung Message-id: <837h02ex7w.fsf@gnu.org> References: <4F149A8E.50705@matholka.se> <83mx9m6hhl.fsf@gnu.org> <4F150CE2.9080502@matholka.se> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10523-done Cc: 10523-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Tue, 17 Jan 2012 06:53:38 +0100 > From: Lars Ljung > CC: 10523@debbugs.gnu.org > > 2012-01-17 06:11, Eli Zaretskii skrev: > > Why doesn't it work properly? Can you give a simple test case where > > it fails, and explain why? > > With cmdproxy.exe it will look like this: > > ~ $ test.bat arg1 arg2 > warning: extra args ignored after 'test.bat' > > The warning is printed by cmdproxy.exe and the reason is that the > command gets translated to the following: > > cmdproxy.exe /c test.bat arg1 arg2 > > But cmdproxy.exe expects one single argument after /c, .i.e. > cmdproxy.exe /c "test.bat arg1 arg2". cmd.exe on the other hand uses all > remaining arguments on the command line. > > To me it looks like the regexp is used to avoid using cmdproxy.exe, but > it fails because of the extra \\`. Thanks, I installed that change (trunk revision 107089). From unknown Sun Aug 10 07:24:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Mar 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator