From unknown Tue Aug 19 14:22:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10500: 23.3.50; wrong relief display for sliced images Resent-From: YAMAMOTO Mitsuharu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2012 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 10500@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.132651642226436 (code B ref -1); Sat, 14 Jan 2012 04:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jan 2012 04:47:02 +0000 Received: from localhost ([127.0.0.1]:57006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlvW9-0006sI-4u for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:47:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]:38313) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlvW6-0006sB-ST for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:47:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlvVQ-00055q-Ta for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:46:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:59142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlvVQ-00055m-Nm for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:46:16 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlvVP-0005Z0-7M for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 23:46:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlvVN-00055Y-Jo for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 23:46:15 -0500 Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:58459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlvVM-00055P-U1 for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 23:46:13 -0500 Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 58540C055D for ; Sat, 14 Jan 2012 13:46:07 +0900 (JST) Date: Sat, 14 Jan 2012 13:46:07 +0900 Message-ID: From: YAMAMOTO Mitsuharu User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?UTF-8?Q?Shij=C5=8D?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) Organization: Faculty of Science, Chiba University MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) You can observe that the image reliefs are displayed unclipped in the following examples for sliced images: (dolist (image (list (create-image "splash.png" nil nil :relief 10 :background "gray75") (create-image "splash.png" nil nil :ascent 10 :relief 10 :background "gray75") (create-image "splash.png" nil nil :ascent 100 :relief 10 :background "gray75"))) (dotimes (i 3) (dotimes (j 3) (insert-image image nil nil (list (* j 100) (* i 80) 100 80)) (insert "spacer")) (newline))) I created a patch below for X11 and tried porting it for W32, but I can't test it the latter. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/mituharu/src/bzr/emacs/emacs-23/etc/DEBUG. In GNU Emacs 23.3.50.1 (x86_64-apple-darwin11.2.0, X toolkit) of 2012-01-14 on yamamoto-no-iMac.local Windowing system distributor `The X.Org Foundation', version 11.0.11003000 configured using `configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no'' === modified file 'src/w32term.c' *** src/w32term.c 2012-01-11 07:52:35 +0000 --- src/w32term.c 2012-01-14 03:47:31 +0000 *************** *** 1657,1664 **** if (left_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! left_x + i, top_y + i, 1, ! bottom_y - top_y - 2 * i + 1); if (raised_p) gc.foreground = f->output_data.w32->black_relief.gc->foreground; --- 1657,1664 ---- if (left_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! left_x + i, top_y + (i + 1) * top_p, 1, ! bottom_y - top_y - (i + 1) * (bot_p + top_p) + 1); if (raised_p) gc.foreground = f->output_data.w32->black_relief.gc->foreground; *************** *** 1676,1683 **** if (right_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! right_x - i, top_y + i + 1, 1, ! bottom_y - top_y - 2 * i - 1); w32_set_clip_rectangle (hdc, NULL); --- 1676,1683 ---- if (right_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! right_x - i, top_y + (i + 1) * top_p, 1, ! bottom_y - top_y - (i + 1) * (bot_p + top_p) + 1); w32_set_clip_rectangle (hdc, NULL); *************** *** 1876,1882 **** x_draw_image_relief (s) struct glyph_string *s; { ! int x0, y0, x1, y1, thick, raised_p; RECT r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); --- 1876,1882 ---- x_draw_image_relief (s) struct glyph_string *s; { ! int x1, y1, thick, raised_p, top_p, bot_p, left_p, right_p; RECT r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); *************** *** 1907,1925 **** raised_p = s->img->relief > 0; } ! x0 = x - thick; ! y0 = y - thick; ! x1 = x + s->slice.width + thick - 1; ! y1 = y + s->slice.height + thick - 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! w32_draw_relief_rect (s->f, x0, y0, x1, y1, thick, raised_p, ! s->slice.y == 0, ! s->slice.y + s->slice.height == s->img->height, ! s->slice.x == 0, ! s->slice.x + s->slice.width == s->img->width, ! &r); } --- 1907,1929 ---- raised_p = s->img->relief > 0; } ! x1 = x + s->slice.width - 1; ! y1 = y + s->slice.height - 1; ! top_p = bot_p = left_p = right_p = 0; ! ! if (s->slice.x == 0) ! x -= thick, left_p = 1; ! if (s->slice.y == 0) ! y -= thick, top_p = 1; ! if (s->slice.x + s->slice.width == s->img->width) ! x1 += thick, right_p = 1; ! if (s->slice.y + s->slice.height == s->img->height) ! y1 += thick, bot_p = 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! w32_draw_relief_rect (s->f, x, y, x1, y1, thick, raised_p, ! top_p, bot_p, left_p, right_p, &r); } === modified file 'src/xterm.c' *** src/xterm.c 2012-01-11 07:52:35 +0000 --- src/xterm.c 2012-01-14 03:21:46 +0000 *************** *** 2060,2066 **** if (left_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! left_x + i, top_y + i, left_x + i, bottom_y - i + 1); XSetClipMask (dpy, gc, None); if (raised_p) --- 2060,2067 ---- if (left_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! left_x + i, top_y + (i + 1) * top_p, ! left_x + i, bottom_y + 1 - (i + 1) * bot_p); XSetClipMask (dpy, gc, None); if (raised_p) *************** *** 2080,2086 **** if (right_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! right_x - i, top_y + i + 1, right_x - i, bottom_y - i); XSetClipMask (dpy, gc, None); } --- 2081,2088 ---- if (right_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! right_x - i, top_y + (i + 1) * top_p, ! right_x - i, bottom_y + 1 - (i + 1) * bot_p); XSetClipMask (dpy, gc, None); } *************** *** 2278,2284 **** x_draw_image_relief (s) struct glyph_string *s; { ! int x0, y0, x1, y1, thick, raised_p; XRectangle r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); --- 2280,2286 ---- x_draw_image_relief (s) struct glyph_string *s; { ! int x1, y1, thick, raised_p, top_p, bot_p, left_p, right_p; XRectangle r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); *************** *** 2309,2327 **** raised_p = s->img->relief > 0; } ! x0 = x - thick; ! y0 = y - thick; ! x1 = x + s->slice.width + thick - 1; ! y1 = y + s->slice.height + thick - 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! x_draw_relief_rect (s->f, x0, y0, x1, y1, thick, raised_p, ! s->slice.y == 0, ! s->slice.y + s->slice.height == s->img->height, ! s->slice.x == 0, ! s->slice.x + s->slice.width == s->img->width, ! &r); } --- 2311,2333 ---- raised_p = s->img->relief > 0; } ! x1 = x + s->slice.width - 1; ! y1 = y + s->slice.height - 1; ! top_p = bot_p = left_p = right_p = 0; ! ! if (s->slice.x == 0) ! x -= thick, left_p = 1; ! if (s->slice.y == 0) ! y -= thick, top_p = 1; ! if (s->slice.x + s->slice.width == s->img->width) ! x1 += thick, right_p = 1; ! if (s->slice.y + s->slice.height == s->img->height) ! y1 += thick, bot_p = 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! x_draw_relief_rect (s->f, x, y, x1, y1, thick, raised_p, ! top_p, bot_p, left_p, right_p, &r); } From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 22:56:22 2012 Received: (at control) by debbugs.gnu.org; 17 Jan 2012 03:56:22 +0000 Received: from localhost ([127.0.0.1]:60928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn09m-00021v-59 for submit@debbugs.gnu.org; Mon, 16 Jan 2012 22:56:22 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:47594) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn09j-00021n-EP for control@debbugs.gnu.org; Mon, 16 Jan 2012 22:56:20 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 8714D39E800A for ; Mon, 16 Jan 2012 19:55:20 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 82DE2HY-8XQY for ; Mon, 16 Jan 2012 19:55:19 -0800 (PST) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id CE02539E8006 for ; Mon, 16 Jan 2012 19:55:19 -0800 (PST) Message-ID: <4F14F137.30402@cs.ucla.edu> Date: Mon, 16 Jan 2012 19:55:35 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: Bug#10500 has a patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 10500 patch From unknown Tue Aug 19 14:22:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: YAMAMOTO Mitsuharu Subject: bug#10500: closed (Re: bug#10500: 23.3.50; wrong relief display for sliced images) Message-ID: References: <87mwxyjy3x.fsf@gnu.org> X-Gnu-PR-Message: they-closed 10500 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 10500@debbugs.gnu.org Date: Sat, 01 Dec 2012 02:41:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1354329662-2344-1" This is a multi-part message in MIME format... ------------=_1354329662-2344-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #10500: 23.3.50; wrong relief display for sliced images which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 10500@debbugs.gnu.org. --=20 10500: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10500 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1354329662-2344-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 10500-done) by debbugs.gnu.org; 1 Dec 2012 02:40:29 +0000 Received: from localhost ([127.0.0.1]:47735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ted0G-0000ay-Oc for submit@debbugs.gnu.org; Fri, 30 Nov 2012 21:40:29 -0500 Received: from mail-da0-f44.google.com ([209.85.210.44]:57076) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ted0D-0000aq-OD for 10500-done@debbugs.gnu.org; Fri, 30 Nov 2012 21:40:26 -0500 Received: by mail-da0-f44.google.com with SMTP id z20so434407dae.3 for <10500-done@debbugs.gnu.org>; Fri, 30 Nov 2012 18:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8YHj/WdAbaaUkqw1jYAZgakkGrswGsvwR4h2OUsP0Fw=; b=oa7w9S2IgFhA34HEfOLKIZRbVUsMqTiUelOWwnDsdfP9U6x6GNlX1oJO8GF83QZeU2 jbWDOLct+AlrzcyeUaOJkylpp1EEYYhWs+9IgXnxMZPlv8zceXFlNHyygZ3cCEFmWEoP i6Psh1io2LBjSaDz4nBVvRlKdLF/R6xdoedqWL+zMCCfhXLnj7X9NSszrkvuDlchLzLu p0TQ7V4vWd9JSqURN2A6gHxsKtFu6qlj5ZJqTK57mRGIjFjT6OmRK+54WNloEO5rkNXb f04O65yBnHxXOA7cqrayD5YHXLhb8EFyzwEjCr3dysWF5Gslk8nLZi7dlqN6qWo6WJus z6Eg== Received: by 10.66.85.129 with SMTP id h1mr8344326paz.14.1354329495562; Fri, 30 Nov 2012 18:38:15 -0800 (PST) Received: from ulysses (cm198.gamma83.maxonline.com.sg. [202.156.83.198]) by mx.google.com with ESMTPS id ak10sm3968603pbd.24.2012.11.30.18.38.12 (version=SSLv3 cipher=OTHER); Fri, 30 Nov 2012 18:38:13 -0800 (PST) From: Chong Yidong To: YAMAMOTO Mitsuharu Subject: Re: bug#10500: 23.3.50; wrong relief display for sliced images References: Date: Sat, 01 Dec 2012 10:38:10 +0800 In-Reply-To: (YAMAMOTO Mitsuharu's message of "Sat, 14 Jan 2012 13:46:07 +0900") Message-ID: <87mwxyjy3x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 10500-done Cc: 10500-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) YAMAMOTO Mitsuharu writes: > You can observe that the image reliefs are displayed unclipped in the > following examples for sliced images: > > I created a patch below for X11 and tried porting it for W32, but I > can't test it the latter. Thanks, I went ahead and committed your patch to trunk. ------------=_1354329662-2344-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jan 2012 04:47:02 +0000 Received: from localhost ([127.0.0.1]:57006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlvW9-0006sI-4u for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:47:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]:38313) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlvW6-0006sB-ST for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:47:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlvVQ-00055q-Ta for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:46:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:59142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlvVQ-00055m-Nm for submit@debbugs.gnu.org; Fri, 13 Jan 2012 23:46:16 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlvVP-0005Z0-7M for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 23:46:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlvVN-00055Y-Jo for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 23:46:15 -0500 Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:58459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlvVM-00055P-U1 for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 23:46:13 -0500 Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 58540C055D for ; Sat, 14 Jan 2012 13:46:07 +0900 (JST) Date: Sat, 14 Jan 2012 13:46:07 +0900 Message-ID: From: YAMAMOTO Mitsuharu To: bug-gnu-emacs@gnu.org Subject: 23.3.50; wrong relief display for sliced images User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) Organization: Faculty of Science, Chiba University MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) You can observe that the image reliefs are displayed unclipped in the following examples for sliced images: (dolist (image (list (create-image "splash.png" nil nil :relief 10 :background "gray75") (create-image "splash.png" nil nil :ascent 10 :relief 10 :background "gray75") (create-image "splash.png" nil nil :ascent 100 :relief 10 :background "gray75"))) (dotimes (i 3) (dotimes (j 3) (insert-image image nil nil (list (* j 100) (* i 80) 100 80)) (insert "spacer")) (newline))) I created a patch below for X11 and tried porting it for W32, but I can't test it the latter. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/mituharu/src/bzr/emacs/emacs-23/etc/DEBUG. In GNU Emacs 23.3.50.1 (x86_64-apple-darwin11.2.0, X toolkit) of 2012-01-14 on yamamoto-no-iMac.local Windowing system distributor `The X.Org Foundation', version 11.0.11003000 configured using `configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no'' === modified file 'src/w32term.c' *** src/w32term.c 2012-01-11 07:52:35 +0000 --- src/w32term.c 2012-01-14 03:47:31 +0000 *************** *** 1657,1664 **** if (left_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! left_x + i, top_y + i, 1, ! bottom_y - top_y - 2 * i + 1); if (raised_p) gc.foreground = f->output_data.w32->black_relief.gc->foreground; --- 1657,1664 ---- if (left_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! left_x + i, top_y + (i + 1) * top_p, 1, ! bottom_y - top_y - (i + 1) * (bot_p + top_p) + 1); if (raised_p) gc.foreground = f->output_data.w32->black_relief.gc->foreground; *************** *** 1676,1683 **** if (right_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! right_x - i, top_y + i + 1, 1, ! bottom_y - top_y - 2 * i - 1); w32_set_clip_rectangle (hdc, NULL); --- 1676,1683 ---- if (right_p) for (i = 0; i < width; ++i) w32_fill_area (f, hdc, gc.foreground, ! right_x - i, top_y + (i + 1) * top_p, 1, ! bottom_y - top_y - (i + 1) * (bot_p + top_p) + 1); w32_set_clip_rectangle (hdc, NULL); *************** *** 1876,1882 **** x_draw_image_relief (s) struct glyph_string *s; { ! int x0, y0, x1, y1, thick, raised_p; RECT r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); --- 1876,1882 ---- x_draw_image_relief (s) struct glyph_string *s; { ! int x1, y1, thick, raised_p, top_p, bot_p, left_p, right_p; RECT r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); *************** *** 1907,1925 **** raised_p = s->img->relief > 0; } ! x0 = x - thick; ! y0 = y - thick; ! x1 = x + s->slice.width + thick - 1; ! y1 = y + s->slice.height + thick - 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! w32_draw_relief_rect (s->f, x0, y0, x1, y1, thick, raised_p, ! s->slice.y == 0, ! s->slice.y + s->slice.height == s->img->height, ! s->slice.x == 0, ! s->slice.x + s->slice.width == s->img->width, ! &r); } --- 1907,1929 ---- raised_p = s->img->relief > 0; } ! x1 = x + s->slice.width - 1; ! y1 = y + s->slice.height - 1; ! top_p = bot_p = left_p = right_p = 0; ! ! if (s->slice.x == 0) ! x -= thick, left_p = 1; ! if (s->slice.y == 0) ! y -= thick, top_p = 1; ! if (s->slice.x + s->slice.width == s->img->width) ! x1 += thick, right_p = 1; ! if (s->slice.y + s->slice.height == s->img->height) ! y1 += thick, bot_p = 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! w32_draw_relief_rect (s->f, x, y, x1, y1, thick, raised_p, ! top_p, bot_p, left_p, right_p, &r); } === modified file 'src/xterm.c' *** src/xterm.c 2012-01-11 07:52:35 +0000 --- src/xterm.c 2012-01-14 03:21:46 +0000 *************** *** 2060,2066 **** if (left_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! left_x + i, top_y + i, left_x + i, bottom_y - i + 1); XSetClipMask (dpy, gc, None); if (raised_p) --- 2060,2067 ---- if (left_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! left_x + i, top_y + (i + 1) * top_p, ! left_x + i, bottom_y + 1 - (i + 1) * bot_p); XSetClipMask (dpy, gc, None); if (raised_p) *************** *** 2080,2086 **** if (right_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! right_x - i, top_y + i + 1, right_x - i, bottom_y - i); XSetClipMask (dpy, gc, None); } --- 2081,2088 ---- if (right_p) for (i = 0; i < width; ++i) XDrawLine (dpy, window, gc, ! right_x - i, top_y + (i + 1) * top_p, ! right_x - i, bottom_y + 1 - (i + 1) * bot_p); XSetClipMask (dpy, gc, None); } *************** *** 2278,2284 **** x_draw_image_relief (s) struct glyph_string *s; { ! int x0, y0, x1, y1, thick, raised_p; XRectangle r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); --- 2280,2286 ---- x_draw_image_relief (s) struct glyph_string *s; { ! int x1, y1, thick, raised_p, top_p, bot_p, left_p, right_p; XRectangle r; int x = s->x; int y = s->ybase - image_ascent (s->img, s->face, &s->slice); *************** *** 2309,2327 **** raised_p = s->img->relief > 0; } ! x0 = x - thick; ! y0 = y - thick; ! x1 = x + s->slice.width + thick - 1; ! y1 = y + s->slice.height + thick - 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! x_draw_relief_rect (s->f, x0, y0, x1, y1, thick, raised_p, ! s->slice.y == 0, ! s->slice.y + s->slice.height == s->img->height, ! s->slice.x == 0, ! s->slice.x + s->slice.width == s->img->width, ! &r); } --- 2311,2333 ---- raised_p = s->img->relief > 0; } ! x1 = x + s->slice.width - 1; ! y1 = y + s->slice.height - 1; ! top_p = bot_p = left_p = right_p = 0; ! ! if (s->slice.x == 0) ! x -= thick, left_p = 1; ! if (s->slice.y == 0) ! y -= thick, top_p = 1; ! if (s->slice.x + s->slice.width == s->img->width) ! x1 += thick, right_p = 1; ! if (s->slice.y + s->slice.height == s->img->height) ! y1 += thick, bot_p = 1; x_setup_relief_colors (s); get_glyph_string_clip_rect (s, &r); ! x_draw_relief_rect (s->f, x, y, x1, y1, thick, raised_p, ! top_p, bot_p, left_p, right_p, &r); } ------------=_1354329662-2344-1-- From unknown Tue Aug 19 14:22:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10500: 23.3.50; wrong relief display for sliced images Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Dec 2012 09:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Chong Yidong Cc: 10500@debbugs.gnu.org, mituharu@math.s.chiba-u.ac.jp, cyd@gnu.org Reply-To: Eli Zaretskii Received: via spool by 10500-submit@debbugs.gnu.org id=B10500.135435367412079 (code B ref 10500); Sat, 01 Dec 2012 09:22:01 +0000 Received: (at 10500) by debbugs.gnu.org; 1 Dec 2012 09:21:14 +0000 Received: from localhost ([127.0.0.1]:47936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TejG6-00038m-GJ for submit@debbugs.gnu.org; Sat, 01 Dec 2012 04:21:14 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:44920) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TejG4-00038c-NS for 10500@debbugs.gnu.org; Sat, 01 Dec 2012 04:21:13 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MEC00600HRZFK00@a-mtaout22.012.net.il> for 10500@debbugs.gnu.org; Sat, 01 Dec 2012 11:19:01 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEC006D3HVODC30@a-mtaout22.012.net.il>; Sat, 01 Dec 2012 11:19:00 +0200 (IST) Date: Sat, 01 Dec 2012 11:18:48 +0200 From: Eli Zaretskii In-reply-to: <87mwxyjy3x.fsf@gnu.org> X-012-Sender: halo1@inter.net.il Message-id: <83d2yut9jb.fsf@gnu.org> References: <87mwxyjy3x.fsf@gnu.org> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Chong Yidong > Date: Sat, 01 Dec 2012 10:38:10 +0800 > Cc: 10500-done@debbugs.gnu.org > > YAMAMOTO Mitsuharu writes: > > > You can observe that the image reliefs are displayed unclipped in the > > following examples for sliced images: > > > > I created a patch below for X11 and tried porting it for W32, but I > > can't test it the latter. > > Thanks, I went ahead and committed your patch to trunk. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Chong Yidong > Date: Sat, 01 Dec 2012 10:38:10 +0800 > Cc: 10500-done@debbugs.gnu.org > > YAMAMOTO Mitsuharu writes: > > > You can observe that the image reliefs are displayed unclipped in the > > following examples for sliced images: > > > > I created a patch below for X11 and tried porting it for W32, but I > > can't test it the latter. > > Thanks, I went ahead and committed your patch to trunk. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4774] > From: Chong Yidong > Date: Sat, 01 Dec 2012 10:38:10 +0800 > Cc: 10500-done@debbugs.gnu.org > > YAMAMOTO Mitsuharu writes: > > > You can observe that the image reliefs are displayed unclipped in the > > following examples for sliced images: > > > > I created a patch below for X11 and tried porting it for W32, but I > > can't test it the latter. > > Thanks, I went ahead and committed your patch to trunk. It's hard for me to say whether the changes work correctly on MS-Windows, since there was no image attached to the bug report to show the correct and the incorrect display. But at least the changes compile on Windows and I do see a difference in the way the test case is displayed before and after the change. Thanks. From unknown Tue Aug 19 14:22:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10500: 23.3.50; wrong relief display for sliced images References: In-Reply-To: Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Dec 2012 23:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 10500@debbugs.gnu.org Received: via spool by 10500-submit@debbugs.gnu.org id=B10500.135440381627837 (code B ref 10500); Sat, 01 Dec 2012 23:17:01 +0000 Received: (at 10500) by debbugs.gnu.org; 1 Dec 2012 23:16:56 +0000 Received: from localhost ([127.0.0.1]:48873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TewIq-0007Ew-2C for submit@debbugs.gnu.org; Sat, 01 Dec 2012 18:16:56 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:40475) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TewIl-0007Em-IH for 10500@debbugs.gnu.org; Sat, 01 Dec 2012 18:16:53 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 8EC9A39E8106 for <10500@debbugs.gnu.org>; Sat, 1 Dec 2012 15:14:37 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UztUFyU7RDgJ for <10500@debbugs.gnu.org>; Sat, 1 Dec 2012 15:14:37 -0800 (PST) Received: from [10.128.212.47] (unknown [12.234.23.143]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 0ABAB39E8105 for <10500@debbugs.gnu.org>; Sat, 1 Dec 2012 15:14:36 -0800 (PST) Message-ID: <50BA8F51.5020005@cs.ucla.edu> Date: Sat, 01 Dec 2012 17:14:25 -0600 From: Paul Eggert User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) As installed in trunk bzr 111050, that patch caused the local variables extra_x and extra_y to be unused. I assume these variables are no longer needed, so I removed them in trunk bzr 111059.