Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy

From: Thierry Volpiatto <[email-masked]>
Date: Fri, 24 Feb 2012 18:23:00 +0100

Michael Albinus <[email-masked]> writes:

> Thierry Volpiatto <[email-masked]> writes:
>
>> (defun files-equal-p (file1 file2)
>>   "Return non-nil if FILE1 and FILE2 name the same file."
>>   (let ((handler (or (find-file-name-handler file1 'files-equal-p)
>>                      (find-file-name-handler file2 'files-equal-p))))
>>     (if handler
>>         (funcall handler 'files-equal-p file1 file2)
>>       (and (equal (file-remote-p file1) (file-remote-p file2))
>
> Not needed anymore, you have called the handler already.
You mean this is not needed:

(and (equal (file-remote-p file1) (file-remote-p file2))

right?

>>            (equal (file-attributes (file-truename file1))
>>                   (file-attributes (file-truename file2)))))))
>
> Here we have the discussion about the inode numbers. But this is an edge
> case; let's go this way. Eli will fix it for Windows :-)
Yes I leave it as it is because it still not clear what to do here.
Think it is safe enough anyway.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997