From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 19:03:08 2012 Received: (at submit) by debbugs.gnu.org; 12 Jan 2012 00:03:08 +0000 Received: from localhost ([127.0.0.1]:54248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rl88J-00072h-P9 for submit@debbugs.gnu.org; Wed, 11 Jan 2012 19:03:08 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34103) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rl88H-00072Z-6l for submit@debbugs.gnu.org; Wed, 11 Jan 2012 19:03:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl87n-0002Gs-Ub for submit@debbugs.gnu.org; Wed, 11 Jan 2012 19:02:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:45781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl87n-0002Go-T5 for submit@debbugs.gnu.org; Wed, 11 Jan 2012 19:02:35 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl87m-0008A2-N0 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2012 19:02:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl87l-0002Gc-6s for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2012 19:02:34 -0500 Received: from mail-bk0-f41.google.com ([209.85.214.41]:42256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl87k-0002GW-UN for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2012 19:02:33 -0500 Received: by bkuw5 with SMTP id w5so1100513bku.0 for ; Wed, 11 Jan 2012 16:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; bh=I0npWEiS2ZxBNGfjCjhLQnuUh3lmQ8Z9JwMWFB05LYo=; b=Ll12TyIU2rOAhaV5IyPyW+PHHNU0vX0NLepZ7aR2M9CT/oB4babH0PGqINzYu9elaA 0F/kv6dZ9j1xTDa47snZNPLcQ/NrX4dRCUtXEAsD4MW/3sM52xLt83wPMUwLf4BWPsGV GROLl2dOhhxt6Yr6yDP7tvjvfYSV/4c7EUK4w= Received: by 10.204.156.207 with SMTP id y15mr335748bkw.93.1326326550390; Wed, 11 Jan 2012 16:02:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.40.80 with HTTP; Wed, 11 Jan 2012 16:02:09 -0800 (PST) From: Eric Hanchrow Date: Wed, 11 Jan 2012 16:02:09 -0800 Message-ID: Subject: 24.0.92; cperl-indent-exp hangs To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Please describe exactly what actions triggered the bug, and the precise symptoms of the bug. If you can, give a recipe starting from `emacs -Q': 1. Save the following to (e.g.) /tmp/bug.el: ===8<======8<======8<======8<======8<======8<======8<======8<======8<=== (switch-to-buffer "frotz.pl") (cperl-mode) (insert "poop ('foo', \n 'bar')") ;(insert ";") (goto-char 5) (cperl-indent-exp) ===8<======8<======8<======8<======8<======8<======8<======8<======8<=== 2. Invoke emacs like "emacs -Q --load /tmp/bug.el". 3. Note that Emacs has hung. If you'd like ... 4. Kill the hung emacs 5. Uncomment the fourth line in bug.el 6. Invoke emacs the same way again 7. Note that Emacs is perfectly happy. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /home/ehanchrow/local/emacs-master-gui/share/emacs/24.0.92/etc/DEBUG. In GNU Emacs 24.0.92.3 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2012-01-03 on rampage.sea Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--prefix=/home/ehanchrow/local/emacs-master-gui'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r e p o r t - e m a c s - b u g Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 22:58:06 2016 Received: (at control) by debbugs.gnu.org; 28 Jun 2016 02:58:06 +0000 Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHjDy-0003xz-8d for submit@debbugs.gnu.org; Mon, 27 Jun 2016 22:58:06 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:33710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHjDx-0003x7-3z for control@debbugs.gnu.org; Mon, 27 Jun 2016 22:58:05 -0400 Received: by mail-oi0-f51.google.com with SMTP id u201so5052512oie.0 for ; Mon, 27 Jun 2016 19:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=63DIjxJgCZIcvkbzq8UUvP6S0mOXpUiCIWopw7B62xI=; b=hFFjFSDIgWzIGRM3FrgcgA19m7Qfv46DQkHGYvPKFE49xabgUdpcdX6iAAAmKkYwDE p1qOjiKrcZzCyWpFVouXzMDGVIl5A6trUWoqP9TfM+45faeGPyb6daLtDnnqXd42Fxb+ lLsK0u1rPrc84p9SxZp+GMrhDGGAGCj3wHB80PIQwld70A31qzQZe9RAg+nxPNJy97CV TBewUY3FMGqUPZAtIViE4xuUueGUe01MCfhihwLotGmW7KAuvQak7tX+ax1eT2dS2owd TP4hBpfDQVr2gDwRbDff8L51KVMn9s2OKxXfJpwmsMllPlVmDfJVlg8TZwhKykJHy4sz 6s6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=63DIjxJgCZIcvkbzq8UUvP6S0mOXpUiCIWopw7B62xI=; b=bHajWq9bYHg3cIffTklWQqzWyWT5WuHDetSitEE3HDCpV9WNq6q9J90aJxuD9WjXGf eDWg+p451FCrPpE+1abAu4fo5+mf1WylTi8dalvkJADQRB2ZWgN7xfx8VgP6GIh3bDbH 0nd4kwKyr0KTvdgJDaX0Q7moQX9wyBo6Y0C7Viqiwr1hOlx5MYMYnwXfKsm206yB3WcN Ca1YNTEVRa17UOPtr9sHiTxzpZ2sth9ro9+dY/gROaF7ucmME2irKWNG1/T+9pTCT5b/ nmdaziKf+rXVCnBDxgikAA8tzGAuW/5M0sGUuOHhCKPPHjedw2+0qYA2+Tpxbn+3MUb5 55xA== X-Gm-Message-State: ALyK8tLdglMacNk8hGXZkrCCd5PitKyKgrBJ/9Jv2C4xqddBAKk2qGGxl+xnVYlnQSgDQ1YbnH4K8U8pZB02RQ== X-Received: by 10.202.5.193 with SMTP id 184mr224942oif.143.1467082679691; Mon, 27 Jun 2016 19:57:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Mon, 27 Jun 2016 19:57:59 -0700 (PDT) From: Noam Postavsky Date: Mon, 27 Jun 2016 22:57:59 -0400 X-Google-Sender-Auth: p5SSpbYxFJMXOua29TlOW5-6sg4 Message-ID: Subject: Bug #10483: 24.0.92; cperl-indent-exp hangs To: GNU bug tracker automated control server Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tag 10483 + confirmed found 10483 25.0.95 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 13:06:18 2020 Received: (at 10483) by debbugs.gnu.org; 31 Aug 2020 17:06:18 +0000 Received: from localhost ([127.0.0.1]:53584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCnG6-0006C6-EY for submit@debbugs.gnu.org; Mon, 31 Aug 2020 13:06:18 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCnG3-0006Bs-UV for 10483@debbugs.gnu.org; Mon, 31 Aug 2020 13:06:17 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id B51B7160061 for <10483@debbugs.gnu.org>; Mon, 31 Aug 2020 19:06:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1598893569; bh=JZTJouHwc4HGW6FKyK0J5QS7ryivGqpqTS3MYSunTQ0=; h=To:From:Subject:Autocrypt:Date:From; b=cPbSj6F+aPekEovkOVwxMuFnGxU650cQP+ftWQs7zNLPeiy2AJxhh2B8BJdGpZZH6 2Mf1Uwic0feQEbJyizt77JVkjSDLx6qtCvjP+cDLmKzaxjAgKSZIcDI8FlOprP7WwF BNY6Vo+ldfZhuqvjZQm5vsDkucqC34VtvfPzcZZPGxzjt7Fg0c2BXlQ7Q6I7Ly9SyR oMSp4Z+JWh9v5wR2YitCUVVbIyv0D8p2C0xPPGHqizYzO1UYnEPtaY2X09wOywv+fQ ZgP/ileGCR2PFHhLgsl2O2pJah/4N0JtxZ7SWMFaKjJRFtM0+T503Mnt0eHZEXyHxY wC8jVjE4ZD9cw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BgGnF215vz6tmD for <10483@debbugs.gnu.org>; Mon, 31 Aug 2020 19:06:09 +0200 (CEST) To: 10483@debbugs.gnu.org From: =?UTF-8?Q?Harald_J=c3=b6rg?= Subject: [PATCH] cperl-mode: Avoid endless loop Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: Date: Mon, 31 Aug 2020 19:06:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5613148A2F609D6D4729EA57" Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 10483 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------5613148A2F609D6D4729EA57 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit That bug has a few more manifestations. An endless loop occurred whenever a statement ended in a closing paren, and the statement was not terminated on the same line. --------------5613148A2F609D6D4729EA57 Content-Type: text/x-patch; charset=UTF-8; name="0001-2020-08-31-Harald-J-rg-haj-posteo.de.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-2020-08-31-Harald-J-rg-haj-posteo.de.patch" =46rom 325dc859a5ed9a912f15ec4e7e123b3fe3bde299 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Harald=3D20J=3DC3=3DB6rg?=3D Date: Mon, 31 Aug 2020 18:35:53 +0200 Subject: [PATCH] =3D?UTF-8?q?2020-08-31=3D20=3D20Harald=3D20J=3DC3=3DB6rg= =3D20=3D20?=3D MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lisp/progmodes/cperl-mode.el (cperl-indent-exp): Fix (Bug#10483) Perl expressions (e.g. function calls) ending in ")" without statement terminator on the same line no longer loop endlessly. --- lisp/progmodes/cperl-mode.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index 44579cfd38..f6ad0b7e6d 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -4820,9 +4820,10 @@ cperl-indent-exp (while (< (point) tmp-end) (parse-partial-sexp (point) tmp-end nil t) ; To start-sexp or eol (or (eolp) (forward-sexp 1))) - (if (> (point) tmp-end) ; Yes, there an unfinished block + (if (> (point) tmp-end) ; Check for an unfinished block nil (if (eq ?\) (preceding-char)) + ;; closing parens can be preceded by up to three sexps (progn ;; Plan B: find by REGEXP block followup this line (setq top (point)) (condition-case nil @@ -4843,7 +4844,9 @@ cperl-indent-exp (progn (goto-char top) (forward-sexp 1) - (setq top (point))))) + (setq top (point))) + ;; no block to be processed: expression ends here + (setq done t))) (error (setq done t))) (goto-char top)) (if (looking-at ; Try Plan C: continuation block --=20 2.20.1 --------------5613148A2F609D6D4729EA57-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 13:25:04 2020 Received: (at 10483) by debbugs.gnu.org; 31 Aug 2020 17:25:04 +0000 Received: from localhost ([127.0.0.1]:53598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCnYG-0006eP-38 for submit@debbugs.gnu.org; Mon, 31 Aug 2020 13:25:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCnYE-0006dr-9r for 10483@debbugs.gnu.org; Mon, 31 Aug 2020 13:25:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60045) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCnY9-0006re-37; Mon, 31 Aug 2020 13:24:57 -0400 Received: from [176.228.60.248] (port=2671 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCnY7-0000Th-BW; Mon, 31 Aug 2020 13:24:57 -0400 Date: Mon, 31 Aug 2020 20:24:41 +0300 Message-Id: <83o8mqwwx2.fsf@gnu.org> From: Eli Zaretskii To: Harald =?utf-8?Q?J=C3=B6rg?= In-Reply-To: (message from Harald =?utf-8?Q?J=C3=B6rg?= on Mon, 31 Aug 2020 19:06:08 +0200) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Harald Jörg > Date: Mon, 31 Aug 2020 19:06:08 +0200 > > That bug has a few more manifestations. An endless loop > occurred whenever a statement ended in a closing paren, and > the statement was not terminated on the same line. Thanks, but could we please also have a test for this issue, so that the bug never happens again? From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 14:08:18 2020 Received: (at 10483) by debbugs.gnu.org; 31 Aug 2020 18:08:18 +0000 Received: from localhost ([127.0.0.1]:53642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCoE6-0007fs-07 for submit@debbugs.gnu.org; Mon, 31 Aug 2020 14:08:18 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCoE2-0007fd-W5 for 10483@debbugs.gnu.org; Mon, 31 Aug 2020 14:08:16 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8F6112400FD for <10483@debbugs.gnu.org>; Mon, 31 Aug 2020 20:08:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1598897288; bh=em5XHz8pgV+J/Q6LRDBe58fUJtHuTkLVp2hee8FoDQc=; h=Subject:To:Cc:From:Autocrypt:Date:From; b=exQOXUpZcpZj+uJACNgIou2ZX6atzk7jDV+mgEp32fXxcCgXzcGVqheg0wiiRMBHp fTOzipJmEbCOc1d7byLtWAoca3ctiKzxUD5dyIbfy4a47tVDuyvuZzy9IbA6q1P06K 6JjA6/cpyVbJssgnLkKXFs+RTykYnxe45g/YyWFwNagIgOGeLheKt8aOlzU3PzVPPO bJ5oXFd2eK+chYNvfKOA61pMJq9gmxaYLyM9S2atLTt4dJx2dfLsDfcwyXKUkRzOih lPP2SmFbtMkPAbkA6AAaSDD5Soi4qtyDNFneHuo2WP8mXb/lpZGOIlLHt37yTJNLTJ tPf+ezK54lUtg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BgJ8l5l6Yz6tm6; Mon, 31 Aug 2020 20:08:07 +0200 (CEST) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop To: Eli Zaretskii References: <83o8mqwwx2.fsf@gnu.org> From: =?UTF-8?Q?Harald_J=c3=b6rg?= Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: Date: Mon, 31 Aug 2020 20:08:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <83o8mqwwx2.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) On 8/31/20 7:24 PM, Eli Zaretskii wrote: >> From: Harald Jörg >> Date: Mon, 31 Aug 2020 19:06:08 +0200 >> >> That bug has a few more manifestations. An endless loop >> occurred whenever a statement ended in a closing paren, and >> the statement was not terminated on the same line. > > Thanks, but could we please also have a test for this issue, so that > the bug never happens again? Sure... I can prepare another patch. The test also ought to verify that terminating the while loop didn't damage cperl-mode's ability to indent the compound statements it handles in this section of code. I was hesitating in this particular case because _if_ this issue ever happens again, then the test just hangs forever. Is there a safeguard against this? -- Cheers, haj From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 14:50:03 2020 Received: (at 10483) by debbugs.gnu.org; 31 Aug 2020 18:50:03 +0000 Received: from localhost ([127.0.0.1]:53687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCosV-0000D7-9t for submit@debbugs.gnu.org; Mon, 31 Aug 2020 14:50:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCosT-0000CQ-Hx for 10483@debbugs.gnu.org; Mon, 31 Aug 2020 14:50:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33221) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCosO-0008KK-7i; Mon, 31 Aug 2020 14:49:56 -0400 Received: from [176.228.60.248] (port=3885 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCosN-0007de-Jk; Mon, 31 Aug 2020 14:49:56 -0400 Date: Mon, 31 Aug 2020 21:49:40 +0300 Message-Id: <83k0xewszf.fsf@gnu.org> From: Eli Zaretskii To: Harald =?utf-8?Q?J=C3=B6rg?= In-Reply-To: (message from Harald =?utf-8?Q?J=C3=B6rg?= on Mon, 31 Aug 2020 20:08:06 +0200) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 10483@debbugs.gnu.org > From: Harald Jörg > Date: Mon, 31 Aug 2020 20:08:06 +0200 > > I was hesitating in this particular case because _if_ this issue ever > happens again, then the test just hangs forever. > > Is there a safeguard against this? You could run the test in a subordinate Emacs process, and have the parent process wait for it to complete with a timeout. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 17:23:35 2020 Received: (at 10483) by debbugs.gnu.org; 31 Aug 2020 21:23:35 +0000 Received: from localhost ([127.0.0.1]:53958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCrH5-0006Df-6k for submit@debbugs.gnu.org; Mon, 31 Aug 2020 17:23:35 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:43363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCrH3-0006DR-MB for 10483@debbugs.gnu.org; Mon, 31 Aug 2020 17:23:34 -0400 Received: by mail-ej1-f53.google.com with SMTP id m22so10378243eje.10 for <10483@debbugs.gnu.org>; Mon, 31 Aug 2020 14:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=f/KUuyo2JEUsZX9LyLzMZkNS8j+j/gXGRqAtWTHKGDw=; b=gl+eFNORdQ0M/KhrNlKMIWieeTfT/vR1CjyLmqdlFqG7X5BOioqcMmQq+eiTIlhlWu iOJMz8HLCyRlU9VubTQ9IqrP4G2djGYZhCuarbOvbV88Wcman1fc4i9Ou+Fo0TeDKm34 FOrsQ7ynx7RC99xCzqdxuF9fpC6ZXY4FMxbiBEVzGK8Ltj0cABust8AHJTuEWpdqcRza dcBs52hlwrsBn/P0PmnxT68rPkdXnxuq55ssbuvpCFSpibDLT5SXGnVICpztryQx84tN NJErm+JjTbT2Dz4fXREBTG2WNe1SPeLlMpydVQhCeHbg9R2+srkTTVa/okCAmnt5xxol rMPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=f/KUuyo2JEUsZX9LyLzMZkNS8j+j/gXGRqAtWTHKGDw=; b=aJweaEd2ml3F+Bx8d72OQ+xf9OBuRw3v8+zieOw0YwSAQf8eOMlJnKFiVWihoXuuCm dg0TSSJOrlZM/nU/o23l9n5iawzQ0gJ0+Gy4/eNlgRsGvSiej6dOx67zLYmbNUyu67ao VPTS1I8wRRlRDYkhbulBPKJBl2QiD5vMix5M8YNB3RnM2BGrL18KjSCI4ibh8EWG2mEr IZ32GybQvZh1d3SAu9GzR+WofXE2S5NsNkRHh6IdvB/rPRkaWsyia/ntTWxNS6UIxKqR YD2CZTLMoWtoK7g0sU1NtelImQWFyrb6QngyMiG9ZWoV60vhyExI10cE2NIR+ZtVVUSX SA7w== X-Gm-Message-State: AOAM532JeaktyxxsgYO1l9wnKxgSUoew7BaNytGfA2O33IWbkTf29e7h JxKMWj7RepDKHCvx4r4oumWTmsg6vD8gLVccBXM= X-Google-Smtp-Source: ABdhPJx6UgMSGxtrzKACnffADf55Pd/fBtV+3Pg2V21a8i3zkr02pNw+QsSfzrmQJGRZy9YfG+f3HUZ1nP54/DS2Ogw= X-Received: by 2002:a17:906:a88a:: with SMTP id ha10mr2895657ejb.532.1598909007809; Mon, 31 Aug 2020 14:23:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 31 Aug 2020 21:23:26 +0000 From: Stefan Kangas In-Reply-To: <83k0xewszf.fsf@gnu.org> References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> MIME-Version: 1.0 Date: Mon, 31 Aug 2020 21:23:26 +0000 Message-ID: Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop To: Eli Zaretskii , =?UTF-8?B?SGFyYWxkIErDtnJn?= Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > You could run the test in a subordinate Emacs process, and have the > parent process wait for it to complete with a timeout. Do we have any test cases working like that today? What would be the best way to do it? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 12:12:42 2020 Received: (at 10483) by debbugs.gnu.org; 1 Sep 2020 16:12:42 +0000 Received: from localhost ([127.0.0.1]:56929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8tl-0001lM-N5 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 12:12:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]:49885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8tj-0001l9-NQ for 10483@debbugs.gnu.org; Tue, 01 Sep 2020 12:12:40 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E327A2400FC for <10483@debbugs.gnu.org>; Tue, 1 Sep 2020 18:12:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1598976752; bh=6hgQHoUctkBkr6uvgg6qpPdb+yIBhyFXxlXvtOmhv1U=; h=Subject:To:From:Autocrypt:Date:From; b=eC6lSrOYkfJZll46l4NQP8iaaylidMQaC8pyJHh7d+UGTMKY8BT9JsjEGjGx8LIVP XhWyor0USJqyRxUz/qsGTwdS/9t/eQhiI+jtaaw/5HcIXanhJvquvMHJiD1Kbt1hlD TI7jVaheMsci75tRfdESRXOC9bxCX7cDoKA1wtiZWKJSV7gx21Y67BSHC532FWIOo2 4OilvYs5wD3ZAvHOvxmrjIiK2TLRNY5IS/VwljVU/X6ErGzBKMmjJlT71M5OzgAEop MoA5sCjTq9NLYiSZhWY4Rv4XOiPlgXllu7MzZ3Qtj0FlrSliUni5OPyQP2TCquactb HSAnPUYmtByug== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BgsXw1bMyz9rxf for <10483@debbugs.gnu.org>; Tue, 1 Sep 2020 18:12:32 +0200 (CEST) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop To: 10483@debbugs.gnu.org References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> From: =?UTF-8?Q?Harald_J=c3=b6rg?= Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> Date: Tue, 1 Sep 2020 18:12:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <83k0xewszf.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------76D0F00860343B40124B75C8" Content-Language: en-US X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 10483 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) This is a multi-part message in MIME format. --------------76D0F00860343B40124B75C8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit [Re-sent to list: my first reply went to Eli Zaretskii only. Sorry.] On 8/31/20 8:49 PM, Eli Zaretskii wrote: >> Cc: 10483@debbugs.gnu.org >> From: Harald Jörg >> Date: Mon, 31 Aug 2020 20:08:06 +0200 >> >> I was hesitating in this particular case because _if_ this issue ever >> happens again, then the test just hangs forever. >> >> Is there a safeguard against this? > > You could run the test in a subordinate Emacs process, and have the > parent process wait for it to complete with a timeout. So be it: My attempt to do this is attached, together with tests to verify that my loop termination isn't harmful to the function. As always, a review is welcome. I still haven't much experience in Elisp. I haven't found examples to steal from, and also missed the fork/waitpid stuff which I use for such tasks in Perl. -- Cheers, haj --------------76D0F00860343B40124B75C8 Content-Type: text/x-patch; charset=UTF-8; name="0001-2020-09-01-Harald-J-rg-haj-posteo.de.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-2020-09-01-Harald-J-rg-haj-posteo.de.patch" >From eb41f40648ee6696acc54964f3aac364336c06e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20J=C3=B6rg?= Date: Tue, 1 Sep 2020 15:50:54 +0200 Subject: [PATCH] =?UTF-8?q?2020-09-01=20=20Harald=20J=C3=B6rg=20=20?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-bug-10483): Add this test to verify that Emacs doesn't hang over a Perl statement which isn't terminated on the same line. * test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-indent-exp): Verify that the fix avoiding the endless loop doesn't stop indenting from working properly. * test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl: Code and result snippets for testing `cperl-indent-exp' --- .../cperl-mode-resources/cperl-indent-exp.pl | 52 +++++++++++ test/lisp/progmodes/cperl-mode-tests.el | 91 ++++++++++++++++++- 2 files changed, 139 insertions(+), 4 deletions(-) create mode 100644 test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl diff --git a/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl b/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl new file mode 100644 index 0000000000..4a9842ffa5 --- /dev/null +++ b/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl @@ -0,0 +1,52 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use 5.020; + +# This file contains test input and expected output for the tests in +# cperl-mode-tests.el, cperl-mode-test-indent-exp. The code is +# syntactically valid, but doesn't make much sense. + +# -------- for loop: input -------- +for my $foo (@ARGV) +{ +...; +} +# -------- for loop: expected output -------- +for my $foo (@ARGV) { + ...; +} +# -------- for loop: end -------- + +# -------- while loop: input -------- +{ +while (1) +{ +say "boring loop"; +} +continue +{ +last; # no endless loop, though +} +} +# -------- while loop: expected output -------- +{ + while (1) { + say "boring loop"; + } continue { + last; # no endless loop, though + } +} +# -------- while loop: end -------- + +# -------- if-then-else: input -------- +if (my $foo) { bar() } elsif (quux()) { baz() } else { quuux } +# -------- if-then-else: expected output -------- +if (my $foo) { + bar(); +} elsif (quux()) { + baz(); +} else { + quuux; +} +# -------- if-then-else: end -------- diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmodes/cperl-mode-tests.el index be8b42d99a..61412025fc 100644 --- a/test/lisp/progmodes/cperl-mode-tests.el +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -9,15 +9,20 @@ ;;; Commentary: -;; This is a collection of tests for the fontification of CPerl-mode. - -;; Run these tests interactively: -;; (ert-run-tests-interactively '(tag :fontification)) +;; This is a collection of tests for CPerl-mode. ;;; Code: (defvar cperl-test-mode #'cperl-mode) +(defvar cperl-mode-tests-data-directory + (expand-file-name "lisp/progmodes/cperl-mode-resources" + (or (getenv "EMACS_TEST_DIRECTORY") + (expand-file-name "../../../" + (or load-file-name + buffer-file-name)))) + "Directory containing cperl-mode test data.") + (defun cperl-test-ppss (text regexp) "Return the `syntax-ppss' of the first character matched by REGEXP in TEXT." (interactive) @@ -48,4 +53,82 @@ cperl-mode-test-bug-42168 (let ((code "{ $a- / $b } # /")) (should (equal (nth 8 (cperl-test-ppss code "/")) 7)))) +(defun cperl-mode-test--run-bug-10483 () + "Runs a short program, intended to be under timer scrutiny. +This function is intended to be used by an Emacs subprocess in +batch mode. The message buffer is used to report the result of +running `cperl-indent-exp' for a very simple input. The result +is expected to be different from the input, to verify that +indentation actually takes place.." + (let ((code "poop ('foo', \n'bar')")) ; see the bug report + (message "Test Bug#10483 started") + (with-temp-buffer + (insert code) + (funcall cperl-test-mode) + (goto-char (point-min)) + (search-forward "poop") + (cperl-indent-exp) + (message "%s" (buffer-string))))) + +(ert-deftest cperl-mode-test-bug-10483 () + "Verifies that a piece of code which ends in a paren without a +statement terminato ron tne same line does not loop forever. The +test starts an asynchronous Emacs batch process under timeout +control." + (interactive) + (let* ((emacs (concat invocation-directory invocation-name)) + (test-function 'cperl-mode-test--run-bug-10483) + (test-function-name (symbol-name test-function)) + (test-file (symbol-file test-function 'defun)) + (ran-out-of-time nil) + (process-connection-type nil) + runner) + (with-temp-buffer + (with-timeout (1 + (delete-process runner) + (setq ran-out-of-time t)) + (setq runner (start-process "speedy" + (current-buffer) + emacs + "-batch" + "--quick" + "--load" test-file + "--funcall" test-function-name)) + (while (accept-process-output runner))) + (should (equal ran-out-of-time nil)) + (goto-char (point-min)) + ;; just a very simple test for indentation: This should + ;; be rather robust with regard to indentation defaults + (should (string-match + "poop ('foo', \n 'bar')" (buffer-string)))))) + +(ert-deftest cperl-mode-test-indent-exp () + "Run various tests for `cperl-indent-exp' edge cases. +These exercise some standard blocks and also the special +treatment for Perl expressions where a closing paren isn't the +end of the statement." + (let ((file (expand-file-name "cperl-indent-exp.pl" + cperl-mode-tests-data-directory))) + (with-temp-buffer + (insert-file-contents file) + (goto-char (point-min)) + (while (re-search-forward + (concat "^# ?-+ \\_<\\(?1:.+?\\)\\_>: input ?-+\n" + "\\(?2:\\(?:.*\n\\)+?\\)" + "# ?-+ \\1: expected output ?-+\n" + "\\(?3:\\(?:.*\n\\)+?\\)" + "# ?-+ \\1: end ?-+") + nil t) + (let ((name (match-string 1)) + (code (match-string 2)) + (expected (match-string 3)) + got) + (with-temp-buffer + (insert code) + (goto-char (point-min)) + (cperl-indent-exp) ; here we go! + (setq expected (concat "test case " name ":\n" expected)) + (setq got (concat "test case " name ":\n" (buffer-string))) + (should (equal got expected)))))))) + ;;; cperl-mode-tests.el ends here -- 2.20.1 --------------76D0F00860343B40124B75C8-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 23:17:58 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 03:17:58 +0000 Received: from localhost ([127.0.0.1]:36751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2Eg-0001He-2G for submit@debbugs.gnu.org; Thu, 03 Sep 2020 23:17:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2Ee-0001HQ-69 for 10483@debbugs.gnu.org; Thu, 03 Sep 2020 23:17:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Op1HEgiQtFP2qy7PBJTaSfj/S5/DziyVGJqLd8vTkW8=; b=HQvpgD3HsHm13pcseBOQ1LZmtO 98vG/P5uErL6vU5zs74I5meAksD/QcxNZw9Un3jEf9i2oNW2Y2UmdI2gOXr6BMJdJbBS/bpuF7+ek o3Ez2HAaxnyU3WBKLOz+agF1fGBmn0jle4kgNkCd8yhjMG3t6K/mHlYiT697p4fT0rNM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE2EV-0001hU-0H; Fri, 04 Sep 2020 05:17:49 +0200 From: Lars Ingebrigtsen To: Harald =?utf-8?Q?J=C3=B6rg?= Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> X-Now-Playing: Machinedrum's _Vapor City Citizenship Programme_: "Knowfuture" Date: Fri, 04 Sep 2020 05:17:45 +0200 In-Reply-To: <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> ("Harald =?utf-8?Q?J=C3=B6rg=22's?= message of "Tue, 1 Sep 2020 18:12:31 +0200") Message-ID: <87k0xafcx2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Harald Jörg writes: > So be it: My attempt to do this is attached, together with tests > to verify that my loop termination isn't harmful to the function. Great; I've applied your fix (along with the test) to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > So be it: My attempt to do this is attached, together with tests > to verify that my loop termination isn't harmful to the function. Great; I've applied your fix (along with the test) to Emacs 28. > As always, a review is welcome. I still haven't much experience > in Elisp. Looks good to me. The only detail is that we normally want the first line of a doc string to be a complete sentence, and in one case it wasn't: +(ert-deftest cperl-mode-test-bug-10483 () + "Verifies that a piece of code which ends in a paren without a +statement terminato ron tne same line does not loop forever. The But this is in the test harness, so I don't think we really have much of a style convention going here, so I didn't fix that up before applying. > I haven't found examples to steal from, and also missed the > fork/waitpid stuff which I use for such tasks in Perl. Yeah... Perhaps Emacs should grow some convenience functions for this stuff? Anyway, the patch fixes the reported bug here, so I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 23:18:03 2020 Received: (at control) by debbugs.gnu.org; 4 Sep 2020 03:18:03 +0000 Received: from localhost ([127.0.0.1]:36755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2El-0001IJ-A8 for submit@debbugs.gnu.org; Thu, 03 Sep 2020 23:18:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE2Ej-0001HW-V2 for control@debbugs.gnu.org; Thu, 03 Sep 2020 23:18:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YFR8yyoMDYeVE/9+gLZAYP0ZdPFzxyV9ZxN8RT3HhFo=; b=DwpB03x6jQOeroDc2MN05YBEwD V2eHLKP+yeN0NMd82ag4ZxykOMa7TpSajOQoLM3FY2AsvDWk6VbTI7c/Zbixa0e2i7ZAHWVx5bZfe +H77jfSaXmWsXt34Lh5CCuwUYIgDGy5sLrJUU9BrdE/WKPjwdYKCuvz6UgWPd4ll8ikU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE2Ec-0001hb-8o for control@debbugs.gnu.org; Fri, 04 Sep 2020 05:17:56 +0200 Date: Fri, 04 Sep 2020 05:17:53 +0200 Message-Id: <87imcufcwu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #10483 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 10483 fixed close 10483 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 10483 fixed close 10483 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 03:16:06 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 07:16:06 +0000 Received: from localhost ([127.0.0.1]:37132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE5x7-0005wT-R5 for submit@debbugs.gnu.org; Fri, 04 Sep 2020 03:16:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE5x6-0005vD-UB for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 03:16:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54058) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE5x1-0003pK-FQ; Fri, 04 Sep 2020 03:15:59 -0400 Received: from [176.228.60.248] (port=3641 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE5x0-0004lO-TT; Fri, 04 Sep 2020 03:15:59 -0400 Date: Fri, 04 Sep 2020 10:15:47 +0300 Message-Id: <831rjiui58.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87k0xafcx2.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 04 Sep 2020 05:17:45 +0200) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Fri, 04 Sep 2020 05:17:45 +0200 > Cc: 10483@debbugs.gnu.org > > > I haven't found examples to steal from, and also missed the > > fork/waitpid stuff which I use for such tasks in Perl. > > Yeah... Perhaps Emacs should grow some convenience functions for this > stuff? I don't think I understand what's missing in what we have already. The equivalent of 'fork' is 'start-process', and the equivalent of 'waitpid' is a test of what 'process-status' returns. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 06:42:13 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 10:42:13 +0000 Received: from localhost ([127.0.0.1]:37534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9Aa-0002vw-OH for submit@debbugs.gnu.org; Fri, 04 Sep 2020 06:42:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9AY-0002vf-Hc for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 06:42:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zirAFiNnx/Ze3tyK1CgUb+mx4uh0dYqYSzzas9PxgME=; b=gbFoTGYARiOGZKughfEgTe3Of8 7TMKarVZGi7ui3vnqPjSU96x0KY36jtP3jpNk4jWC0slgAqfvzmuJqiX9USFtvYlf7cF14WCUGpYt /VMT7KjDiZqa1zY8W309MGCaiigRDzoNwMcAsb0HVn2zIheS3ZNZt3++PtXIdCZtdOBw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE9AH-0006JF-RE; Fri, 04 Sep 2020 12:42:03 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAABGdBTUEAALGPC/xhBQAAAAJi S0dEAP+Hj8y/AAAAB3RJTUUH5AkEAiEukL7KUAAAAOFJREFUSMftlL0RwjAMhT9+KspcjgXUsAJT vF2ymcah8AysQBNsyfg4OBqK6C6FLH/Wk1+S3cx3sf9y/wZswAb8AhzHy7LiIQP8HSDPeUxHgPKW D2bwp452gtQBCnUWUJAlE1jfwUId4VFUWR+Aw2kd83q+rUuX+zTVBBA2nf3WdVCxRa2ZkcOq4irJ y3rzsiCgqrV+aFO6l3jJudsxHrQUcEp2wXPLABQDH3jmMtqLEo2Lwjt57ZQkCYQLyDakIZpxVstm 2XiGwHPzqwc5dnOQbAW8/xjGwOfxhz+BDfgP4AH+CjRRsIuwngAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wNFQwMjozMzo0NiswMDowMPP95CEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDRUMDI6MzM6NDYrMDA6MDCCoFydAAAAAElFTkSuQmCC X-Now-Playing: Machinedrum's _Vapor City Citizenship Programme_: "We R 1" Date: Fri, 04 Sep 2020 12:41:52 +0200 In-Reply-To: <831rjiui58.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Sep 2020 10:15:47 +0300") Message-ID: <87lfhpddsf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I don't think I understand what's missing in what we have already. > The equivalent of 'fork' is 'start-process', and the equivalent of > 'waitpid' is a test of what 'process-status' returns. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I don't think I understand what's missing in what we have already. > The equivalent of 'fork' is 'start-process', and the equivalent of > 'waitpid' is a test of what 'process-status' returns. waitpid waits until a process changes status, doesn't it? In Emacs Lisp we have to write a loop over `process-status', which adds latency and just doesn't seem very elegant. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 06:51:27 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 10:51:27 +0000 Received: from localhost ([127.0.0.1]:37538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9JX-0003Am-NL for submit@debbugs.gnu.org; Fri, 04 Sep 2020 06:51:27 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:38351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9JW-0003Ae-2A for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 06:51:26 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BjZH05pVcz1qs0m; Fri, 4 Sep 2020 12:51:24 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BjZH04715z1qvJ1; Fri, 4 Sep 2020 12:51:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id LrDWrRJS5w4j; Fri, 4 Sep 2020 12:51:23 +0200 (CEST) X-Auth-Info: /leF0EylJRrcYSMNEhH5OKPbiGETtg9ymuNnU6HEIuu+Vjl3omolxbqCB0x75+hB Received: from igel.home (ppp-46-244-164-25.dynamic.mnet-online.de [46.244.164.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 4 Sep 2020 12:51:23 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 3CCD72C25DA; Fri, 4 Sep 2020 12:51:23 +0200 (CEST) From: Andreas Schwab To: Lars Ingebrigtsen Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> X-Yow: America!! I saw it all!! Vomiting! Waving! JERRY FALWELLING into your void tube of UHF oblivion!! SAFEWAY of the mind -- Date: Fri, 04 Sep 2020 12:51:23 +0200 In-Reply-To: <87lfhpddsf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Sep 2020 12:41:52 +0200") Message-ID: <87lfhpbys4.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, Eli Zaretskii , haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sep 04 2020, Lars Ingebrigtsen wrote: > waitpid waits until a process changes status, doesn't it? In Emacs Lisp > we have to write a loop over `process-status', which adds latency and > just doesn't seem very elegant. In Emacs you use accept-process-output and a process sentinel. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 06:56:16 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 10:56:16 +0000 Received: from localhost ([127.0.0.1]:37546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9OC-0003Ii-Fg for submit@debbugs.gnu.org; Fri, 04 Sep 2020 06:56:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9O8-0003IQ-O0 for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 06:56:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nyHKKZda8rtA7fLoi0ghJvX2/1ivhHTJf/cbxqqKZ8A=; b=dZ0OZ94OV5a26PH3NJpTiV/gC/ IifC+POl6Mn66yh9fx84rqNAr1bh98AXYos00LLq4Zira7N6xG8tjvvtSIeCoo2i7ZnzZ2AO1XjZ9 bG8Kqow79zFy3osNdn+J8sJMvooyB4Qd/m3VKT2+fxLgTmUexVUXMvz/gSdcDRx1mqGA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE9Nu-0006QZ-EN; Fri, 04 Sep 2020 12:56:05 +0200 From: Lars Ingebrigtsen To: Andreas Schwab Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <87lfhpbys4.fsf@igel.home> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUhIB4bGRgjIiIi HR1aMjjCN2Toiaj////0Ox8wAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QJBAo3IGWNAzgAAAGzSURB VDjLdVPRdcMwCKR4gcj16zdWm347UTtAEnkDyws08f4jFAGW4ibl5cWSDgHHIXhxDvwTg3e3C4C8 YGsG9gkuhDBg8SbMWOB947IZQAOINSGgpztAUf6RrBh/mjg7/Qf4R4AeAfL4/AYB1jv3AJdLQMSf R0AwkE5sazT7AyAUqwAh3kNogMTgHB4tGlbm6A/eOylnC/h+TGlqmUO+hSsntm5J8+2EFtgXoJ+X ZU5Jtzk5lgvL9TtNtPam5Hhblp84uSNmtaDqQZ/Lcu5PrkVTCaypNM7X+HpxsZXkOY1SonHq+i5e plZJEpAx3afYx3j62tV2ZdZE+znFGC9ePTNz07i7KaDJM3MeQf5HTJOL/kyEUlWuSHtN+8kduiNH sU6D6YY4uVEdSSUwqYHaj0ioAyJAkZPAiYxSJO9lzjWPzwsUziF7SoXcA0b541FF9FC1qhNqoDGV kIQFGGBrqO/Oc56wOdWxzsBwkGrXMdCJ5tD8eM177bYp2PCrRjBhQKdepWVEKiHlRHXaVzpa0QB1 4ExI2Uj5NrvEG+kLX7KnT9CWZ5YD5wrtoLcG8TlZXrFf3ixyMJGWHE4AAAAldEVYdGRhdGU6Y3Jl YXRlADIwMjAtMDktMDRUMTA6NTU6MzIrMDA6MDAVjycSAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIw LTA5LTA0VDEwOjU1OjMyKzAwOjAwZNKfrgAAAABJRU5ErkJggg== X-Now-Playing: Dolby Anol's _Dolby & Gabbana_: "Heather, I'm Dry" Date: Fri, 04 Sep 2020 12:55:56 +0200 In-Reply-To: <87lfhpbys4.fsf@igel.home> (Andreas Schwab's message of "Fri, 04 Sep 2020 12:51:23 +0200") Message-ID: <87h7sddd4z.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andreas Schwab writes: > On Sep 04 2020, Lars Ingebrigtsen wrote: > >> waitpid waits until a process changes status, doesn't it? In Emacs Lisp >> we have to write a loop over `process-status', which adds latency and >> just [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, Eli Zaretskii , haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Schwab writes: > On Sep 04 2020, Lars Ingebrigtsen wrote: > >> waitpid waits until a process changes status, doesn't it? In Emacs Lisp >> we have to write a loop over `process-status', which adds latency and >> just doesn't seem very elegant. > > In Emacs you use accept-process-output and a process sentinel. Which isn't very elegant, either. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 07:35:13 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 11:35:13 +0000 Received: from localhost ([127.0.0.1]:37629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9zt-0006bT-1N for submit@debbugs.gnu.org; Fri, 04 Sep 2020 07:35:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE9zr-0006b4-4r for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 07:35:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38007) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE9zk-0004Cb-Lf; Fri, 04 Sep 2020 07:35:04 -0400 Received: from [176.228.60.248] (port=3802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE9zj-0000ZJ-T6; Fri, 04 Sep 2020 07:35:04 -0400 Date: Fri, 04 Sep 2020 14:34:54 +0300 Message-Id: <83r1rhu65d.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87lfhpddsf.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 04 Sep 2020 12:41:52 +0200) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: haj@posteo.de, 10483@debbugs.gnu.org > Date: Fri, 04 Sep 2020 12:41:52 +0200 > > Eli Zaretskii writes: > > > I don't think I understand what's missing in what we have already. > > The equivalent of 'fork' is 'start-process', and the equivalent of > > 'waitpid' is a test of what 'process-status' returns. > > waitpid waits until a process changes status, doesn't it? In Emacs Lisp > we have to write a loop over `process-status', which adds latency and > just doesn't seem very elegant. But the advantage of a loop is that you can do something while you wait. Whereas if you expose waitpid to Lisp, the Lisp program which calls it will be parked inside the call, and the entire Emacs session will stall. Or what am I missing? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 07:36:32 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 11:36:32 +0000 Received: from localhost ([127.0.0.1]:37637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEA1A-0006e5-Eb for submit@debbugs.gnu.org; Fri, 04 Sep 2020 07:36:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEA18-0006dt-Me for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 07:36:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38110) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEA13-0004XN-9J; Fri, 04 Sep 2020 07:36:25 -0400 Received: from [176.228.60.248] (port=3885 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kEA12-0002KK-8Z; Fri, 04 Sep 2020 07:36:24 -0400 Date: Fri, 04 Sep 2020 14:36:14 +0300 Message-Id: <83pn71u635.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87h7sddd4z.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 04 Sep 2020 12:55:56 +0200) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <87lfhpbys4.fsf@igel.home> <87h7sddd4z.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, schwab@linux-m68k.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , 10483@debbugs.gnu.org, haj@posteo.de > Date: Fri, 04 Sep 2020 12:55:56 +0200 > > > In Emacs you use accept-process-output and a process sentinel. > > Which isn't very elegant, either. Elegance is in eyes of the beholder. FWIW, I think what we have is better suited for interactive program such as Emacs. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 07:59:19 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 11:59:19 +0000 Received: from localhost ([127.0.0.1]:37684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAND-0007D2-GB for submit@debbugs.gnu.org; Fri, 04 Sep 2020 07:59:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEANC-0007Cn-1p for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 07:59:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NaEGS29+9+RngNAAr/gUUyeiiGid3UUNW02lLMteFg0=; b=dAbiwYXptKMMGE7NMBtXL4XKTu 1WMkVntAYaFbefmmvIxoon76tqx8OaQkmCezwD6RXX/2348XSzmshn5AkAKosfzUN89ItVEGMV2QT WZs5kHMkk/IBL++QF2bIYhHAaSw5jGTn0zm097IGI2xeribVaL2IwikC9RBPakZ/1Yio=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEAN0-00077z-7X; Fri, 04 Sep 2020 13:59:11 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <83r1rhu65d.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUEBQIpLyBXZFGS mnBASzi5v5j////6jDnzAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QJBAsWF1Bt2eMAAAGWSURBVDjL 5ZNRcusgDEVFmwVA6v43gvzXqP43hLeAN1T730olKC5pu4NqPGN8TyTEFQH4E+GsA/OLbnw4X/Ju nISxEzhFzJhtA24GBksuSwPLoZvSIpdgZbloTgcPNGJ/IN8WGBARnob+Bnks48YE10q0scRqmrjV rRJHBB6x/uNKsWcQTsBtklm5Ad2DmFul9zOTviXLoxAQ6FX5f+2J+uvW1ahUxkKawQnU5wGkMAkF ppzCjXetVDlSzNKxZEFRR8WGW3Tlslj1w6RkHJTUzDaegojTUNQ0sfpWqcbk7se3oDXigxwsp1n2 4t+jNFPJx1COeaAaLlZydxyPcvqZDFPtuhz7E6nR9on7HuKHjrPNXb/h2t0W+zqJtoE302eq/nWS Q1LwcsJJx9Buh4BozwL8AXo1ARfInvAr5O4FBXGHjHECQXRpmdDKFOeMToACfAdY5AFaTz9BwQD8 oheC5010c5m5WwE933el7dbHV4O+flXHEgQkePe7OfYoZZw8wUrWzFZ8RpK/2QDlLuCMYEL5nlDK B/IFmZCH6NapAAAAEGVYSWZJSSoACAAAAAAAAAAAAAAAnDy5KAAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wNFQxMToyMjoyMiswMDowMM9U8PMAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDRUMTE6MjI6MjIrMDA6MDC+CUhPAAAAAElFTkSuQmCC X-Now-Playing: Tuxedomoon's _Live in Los Angeles (2005)_: "Loneliness" Date: Fri, 04 Sep 2020 13:59:04 +0200 In-Reply-To: <83r1rhu65d.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Sep 2020 14:34:54 +0300") Message-ID: <874kodda7r.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > But the advantage of a loop is that you can do something while you > wait. Whereas if you expose waitpid to Lisp, the Lisp program which > calls it will be parked inside the call, and the entire Ema [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > But the advantage of a loop is that you can do something while you > wait. Whereas if you expose waitpid to Lisp, the Lisp program which > calls it will be parked inside the call, and the entire Emacs session > will stall. Or what am I missing? No, I'm not talking about actually implementing waitpid, but just adding some utility functions for handling multi-processing in a bit more convenient way. Starting a process and then waiting until it's done isn't an unusual thing to do, so a wait-for-process function would be nice (in this instance). In general, it would be nice if Emacs grew a rich feature set for synchronisation (thread and process), perhaps based on futures (or whatever kids these days are using). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 08:01:12 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 12:01:12 +0000 Received: from localhost ([127.0.0.1]:37700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAP1-0007IF-OI for submit@debbugs.gnu.org; Fri, 04 Sep 2020 08:01:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAP0-0007I0-6c for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 08:01:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3jxTYBdWSvsyDk9ho8cdN+SBSQHeojAEDQARMrDzaHo=; b=qfwevhJLmdB2eEVqtqGOA0UO4n q6x89Gco+CpMKgrsc/dgLhryHCjHMUJqJK3I5YXkA41MgQZZw+KbQD8Ewr6SkN4B09Yr47UL+Wi0g bHeIPniZXqsbgBimTD8+5DXE3DQaVTUB77Ab0X5PtjGopdxa1Z3Q6yT90eFFWjgRfhxA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEAOo-0007B3-Lh; Fri, 04 Sep 2020 14:01:01 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <87lfhpbys4.fsf@igel.home> <87h7sddd4z.fsf@gnus.org> <83pn71u635.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUEBQIpLyBXZFGS mnBASzi5v5j////6jDnzAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QJBAsWF1Bt2eMAAAGWSURBVDjL 5ZNRcusgDEVFmwVA6v43gvzXqP43hLeAN1T730olKC5pu4NqPGN8TyTEFQH4E+GsA/OLbnw4X/Ju nISxEzhFzJhtA24GBksuSwPLoZvSIpdgZbloTgcPNGJ/IN8WGBARnob+Bnks48YE10q0scRqmrjV rRJHBB6x/uNKsWcQTsBtklm5Ad2DmFul9zOTviXLoxAQ6FX5f+2J+uvW1ahUxkKawQnU5wGkMAkF ppzCjXetVDlSzNKxZEFRR8WGW3Tlslj1w6RkHJTUzDaegojTUNQ0sfpWqcbk7se3oDXigxwsp1n2 4t+jNFPJx1COeaAaLlZydxyPcvqZDFPtuhz7E6nR9on7HuKHjrPNXb/h2t0W+zqJtoE302eq/nWS Q1LwcsJJx9Buh4BozwL8AXo1ARfInvAr5O4FBXGHjHECQXRpmdDKFOeMToACfAdY5AFaTz9BwQD8 oheC5010c5m5WwE933el7dbHV4O+flXHEgQkePe7OfYoZZw8wUrWzFZ8RpK/2QDlLuCMYEL5nlDK B/IFmZCH6NapAAAAEGVYSWZJSSoACAAAAAAAAAAAAAAAnDy5KAAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wNFQxMToyMjoyMiswMDowMM9U8PMAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDRUMTE6MjI6MjIrMDA6MDC+CUhPAAAAAElFTkSuQmCC X-Now-Playing: Tuxedomoon's _Live in Los Angeles (2005)_: "Loneliness" Date: Fri, 04 Sep 2020 14:00:57 +0200 In-Reply-To: <83pn71u635.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Sep 2020 14:36:14 +0300") Message-ID: <87zh65bvk6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Elegance is in eyes of the beholder. FWIW, I think what we have is > better suited for interactive program such as Emacs. Interactive (editing) things is definitely the Emacs focus, which explains why the primitives are the way they are. That doesn't mean we shouldn't grow functions that make other programming cases easi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, schwab@linux-m68k.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Elegance is in eyes of the beholder. FWIW, I think what we have is > better suited for interactive program such as Emacs. Interactive (editing) things is definitely the Emacs focus, which explains why the primitives are the way they are. That doesn't mean we shouldn't grow functions that make other programming cases easier. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 08:05:15 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 12:05:15 +0000 Received: from localhost ([127.0.0.1]:37704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEASx-0007Nv-BG for submit@debbugs.gnu.org; Fri, 04 Sep 2020 08:05:15 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:43567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEASv-0007Nl-5V for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 08:05:13 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Bjbw76cgtz1qs0P; Fri, 4 Sep 2020 14:05:11 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Bjbw76Cfyz1qvJB; Fri, 4 Sep 2020 14:05:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id LX7QhmfxKUSk; Fri, 4 Sep 2020 14:05:11 +0200 (CEST) X-Auth-Info: yOhaFtA0ZD/nB8uU8aF7i8hwbbZoDf1eZ2jmyHcsCIy3FW94Dv9ghD2WqtLaoBTs Received: from igel.home (ppp-46-244-164-25.dynamic.mnet-online.de [46.244.164.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 4 Sep 2020 14:05:11 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 9BBC62C25DA; Fri, 4 Sep 2020 14:05:10 +0200 (CEST) From: Andreas Schwab To: Lars Ingebrigtsen Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <87lfhpbys4.fsf@igel.home> <87h7sddd4z.fsf@gnus.org> X-Yow: Yes, Private DOBERMAN!! Date: Fri, 04 Sep 2020 14:05:10 +0200 In-Reply-To: <87h7sddd4z.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Sep 2020 12:55:56 +0200") Message-ID: <87h7sdbvd5.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, Eli Zaretskii , haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sep 04 2020, Lars Ingebrigtsen wrote: > Andreas Schwab writes: > >> On Sep 04 2020, Lars Ingebrigtsen wrote: >> >>> waitpid waits until a process changes status, doesn't it? In Emacs Lisp >>> we have to write a loop over `process-status', which adds latency and >>> just doesn't seem very elegant. >> >> In Emacs you use accept-process-output and a process sentinel. > > Which isn't very elegant, either. You asked for the primitives. There is a lot of tooling around. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 08:09:40 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 12:09:40 +0000 Received: from localhost ([127.0.0.1]:37712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAXE-0007U6-Bj for submit@debbugs.gnu.org; Fri, 04 Sep 2020 08:09:40 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:34793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAXD-0007Tz-22 for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 08:09:39 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Bjc1G4QDhz1qs0P; Fri, 4 Sep 2020 14:09:38 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Bjc1G40L7z1qvJ9; Fri, 4 Sep 2020 14:09:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id mFWmn1qfY5Yq; Fri, 4 Sep 2020 14:09:37 +0200 (CEST) X-Auth-Info: 0U5lMpRYbCkEpY0A8CopYmQ1B3H9U4acwfLWkREpMgcYetBqpMa/hV/j6+fPGE9s Received: from igel.home (ppp-46-244-164-25.dynamic.mnet-online.de [46.244.164.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 4 Sep 2020 14:09:37 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 5C2AE2C25DA; Fri, 4 Sep 2020 14:09:37 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <83r1rhu65d.fsf@gnu.org> X-Yow: ...Just enough time to do my LIBERACE impression... Date: Fri, 04 Sep 2020 14:09:37 +0200 In-Reply-To: <83r1rhu65d.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Sep 2020 14:34:54 +0300") Message-ID: <87d031bv5q.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, Lars Ingebrigtsen , haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sep 04 2020, Eli Zaretskii wrote: > But the advantage of a loop is that you can do something while you > wait. Whereas if you expose waitpid to Lisp, the Lisp program which > calls it will be parked inside the call, and the entire Emacs session > will stall. Or what am I missing? It doesn't make sense to expose a waitpid-like function to Lisp, as the Emacs process primitives are already much more elegant. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 08:28:41 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 12:28:41 +0000 Received: from localhost ([127.0.0.1]:37764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEApd-0007xS-J9 for submit@debbugs.gnu.org; Fri, 04 Sep 2020 08:28:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEApb-0007xE-Ps for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 08:28:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41514) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEApW-0003CR-8c; Fri, 04 Sep 2020 08:28:34 -0400 Received: from [176.228.60.248] (port=3088 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kEApU-0007Ll-V8; Fri, 04 Sep 2020 08:28:33 -0400 Date: Fri, 04 Sep 2020 15:28:23 +0300 Message-Id: <83k0x9u3o8.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <874kodda7r.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 04 Sep 2020 13:59:04 +0200) Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <83r1rhu65d.fsf@gnu.org> <874kodda7r.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: haj@posteo.de, 10483@debbugs.gnu.org > Date: Fri, 04 Sep 2020 13:59:04 +0200 > > No, I'm not talking about actually implementing waitpid, but just adding > some utility functions for handling multi-processing in a bit more > convenient way. Starting a process and then waiting until it's done > isn't an unusual thing to do, so a wait-for-process function would be > nice (in this instance). I think at this stage we'd need a more detailed description of the API you have in mind, to continue this discussion in constructive directions. Can you post such an API description? > In general, it would be nice if Emacs grew a rich feature set for > synchronisation (thread and process), perhaps based on futures (or > whatever kids these days are using). Someone™ should try using the threads for providing such a framework, it's supposed to be suitable for what you are describing. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 08:36:39 2020 Received: (at 10483) by debbugs.gnu.org; 4 Sep 2020 12:36:39 +0000 Received: from localhost ([127.0.0.1]:37884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAxL-0008Gl-6j for submit@debbugs.gnu.org; Fri, 04 Sep 2020 08:36:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEAxJ-0008GX-0C for 10483@debbugs.gnu.org; Fri, 04 Sep 2020 08:36:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TokfYWWuM5ShO3nz2mml/m3So/eEmk0SYgWjYEPEAFA=; b=d59EtAL9VH3I32W4aNgaWPuMml Uwoq4QXhp+we9X03v0GnWNCOSvJ13dh05JBA14D5BlWeJpbrZKjSArPL+v2ieX/7+7JNDtKG8rsc5 Se3g7SIYqr1HeLyU5CyIVo7xCgNh4rgd4fw8xoY00emymWBCx5hLJI5h3uHe15w/XMhw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEAx7-0007Wc-3o; Fri, 04 Sep 2020 14:36:31 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#10483: [PATCH] cperl-mode: Avoid endless loop References: <83o8mqwwx2.fsf@gnu.org> <83k0xewszf.fsf@gnu.org> <922046dc-34fa-487d-4695-6597f8db148e@posteo.de> <87k0xafcx2.fsf@gnus.org> <831rjiui58.fsf@gnu.org> <87lfhpddsf.fsf@gnus.org> <83r1rhu65d.fsf@gnu.org> <874kodda7r.fsf@gnus.org> <83k0x9u3o8.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEX+/v7axbn+/f2q infMNijl19DLtqqyn5ReNB2LbFlwSTFOOjFOKxf///+f47hOAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QJBAwjBHOtTA4AAAF9SURBVDjLY2CgARDCIc7sCCRUQ0NVQ5VCQxWQJFKcGRgYy9LTS8vTy8tL EeLsLS4KDJxVK2eWzpy9cvp0hETNERcBBtbCMMGg0MS0VFG4OOuZzS4B2KzmPBWghNVNMUdxODbH AIeETAAOiUhc4SGGSyKNZB3huCTYAxhDxdJSMSVYDY3LREPFCzFlNFMVgKRaKYZEOdSuIjRxpqlQ hrAAqgTbBJgKU1QJ5kUwliCacxthrERUCcZOBSgL3fY5k6AeKkCTiDoZAA0CdK/PWQim1TFDq8MI RJVhBorkSaD9TAaYEkw2E7BYAfZkI1aTgFpWMgQLYJNgyFI0xSYcqpRlpoDEV4JwVCVXrD61FFmh khJIim3VilU9PV0TUSWUlFhndXR0nDlzatX0IFSJ6DMdXWeAoKOja3oqkoTqmq4VK86c6TlzAqjt xMxSuITmiZ4zHSAdJ4B41appcIlwy5kQMGvVqsWJogpQCQUlYM4OVYICBSUkfzCBhZgYKAMADL1p ZasXgLoAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMDRUMTI6MzU6MDQrMDA6MDBwOWrDAAAA JXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA5LTA0VDEyOjM1OjA0KzAwOjAwAWTSfwAAAABJRU5ErkJg gg== X-Now-Playing: Meg Baird & Mary Lattimore's _Ghost Forests_: "Between Two Worlds" Date: Fri, 04 Sep 2020 14:36:23 +0200 In-Reply-To: <83k0x9u3o8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Sep 2020 15:28:23 +0300") Message-ID: <87mu25btx4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think at this stage we'd need a more detailed description of the API > you have in mind, to continue this discussion in constructive > directions. Can you post such an API description? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org, haj@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think at this stage we'd need a more detailed description of the API > you have in mind, to continue this discussion in constructive > directions. Can you post such an API description? I do not have any such description, and I did not mean to start a design discussion here. :-) I was just agreeing with the Harald's side not that it would be nice if Emacs had a more well-developed range of functions for dealing with processes. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 01:58:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Oct 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 14:25:41 2020 Received: (at control) by debbugs.gnu.org; 5 Oct 2020 18:25:41 +0000 Received: from localhost ([127.0.0.1]:50540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPVB7-0007pN-KQ for submit@debbugs.gnu.org; Mon, 05 Oct 2020 14:25:41 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPVB5-0007p8-LW for control@debbugs.gnu.org; Mon, 05 Oct 2020 14:25:41 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 2FE1F16005F for ; Mon, 5 Oct 2020 20:25:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1601922333; bh=8PvRQavdxjfYA0N9aYSJjWWvs/6D+66aiyGxz8XaXJk=; h=To:From:Subject:Autocrypt:Date:From; b=NbzknGlkxLDtwA2NlTCkmwTqQwNL2jXBpMRRH4IbpfxKJnfvvHudM2SMKhGZ8fwro GT6j9+Iuh8FhmBWT0jBfoyvqOb1JAeBqeb381VepzAsx7t3j7jRJQechUOnruBb57F rHYKzbk671/dISl+GbbUYCSguhgPfU/7S8ep+vbEsVk0FMXLJPr+TtgTmBkscDjccG nCFrkBk7GButOYf/evmXQatIzpOZAz77N+6Ei4RftNOB3EBgLPGi94LH17e29O2YZn /UKjysxCK5saaQsjNi7ziCDUx9WLsKiJWwvXXSlEsfOD4GbzDxhdzhtWhULG6piclz 0I1U9l7lh2TEg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4C4pth1TsXz6tmj for ; Mon, 5 Oct 2020 20:25:32 +0200 (CEST) To: control@debbugs.gnu.org From: =?UTF-8?Q?Harald_J=c3=b6rg?= Subject: cperl-mode: Tests fail due to an oversight of mine... Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: Date: Mon, 5 Oct 2020 20:25:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) unarchive 10483 thank you I'd like to add a patch to fix a bad test I've introduced in 2020-09-04 "Fix infloop when indenting in cperl-mode". From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 14:30:42 2020 Received: (at submit) by debbugs.gnu.org; 5 Oct 2020 18:30:42 +0000 Received: from localhost ([127.0.0.1]:50548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPVFy-00008i-7g for submit@debbugs.gnu.org; Mon, 05 Oct 2020 14:30:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:59330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPVFw-00006v-8U for submit@debbugs.gnu.org; Mon, 05 Oct 2020 14:30:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPVFw-0000dC-1d for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 14:30:40 -0400 Received: from mout02.posteo.de ([185.67.36.66]:34333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPVFk-0005T5-Ck for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 14:30:37 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 832582400FD for ; Mon, 5 Oct 2020 20:30:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1601922625; bh=AGtnKUsHLsbj985qQwSxBnqIlsBFNJCRSInXfTt1l0U=; h=From:Subject:To:Autocrypt:Date:From; b=hgSs1eUF9S9ZIGS+8nznMfCbLglCL1BDPZk31cRbKMsxa8GofWxaIHYXx37AtJBHB +Cf0b+gbog/SFuVV+iJ5JBl+aF7WOxV1mQ1KZ42PsxXyfaEOfAh+8H8hCyKy7IffZ+ /vaymAAvRjTCSSDYPEug4tW527MzsWShKOKCzcEXFp3Z614l8ZyR426utFEhp2j7Ud 04b97X0yEAvDg+lduTuIietHawP+nMLp8P2A3BRjnZLBfuFZeQL6kFbZ0nf97wajYy VSv8SGB6BYD+BsFwC1DDH6m8SJ0BL2hDE+tjZnPQPgb7KNWMMre8d3zoMAXNP/pUY/ fZ6oF5r7YBJgQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4C4q0K0SzVz9rxl for ; Mon, 5 Oct 2020 20:30:24 +0200 (CEST) From: =?UTF-8?Q?Harald_J=c3=b6rg?= Subject: [PATCH] Fix a bogus test introduced by treating (Bug#10483) To: bug-gnu-emacs@gnu.org Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: <0db14c37-394c-05bb-5f5a-3f8baa5d59b0@posteo.de> Date: Mon, 5 Oct 2020 20:30:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E5F09668362654E5A9DD8F30" Content-Language: en-US Received-SPF: pass client-ip=185.67.36.66; envelope-from=haj@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/05 09:01:58 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------E5F09668362654E5A9DD8F30 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Severity: minor The commit 2020-09-04 "Fix infloop when indenting in cperl-mode" for (Bug#10483) contained a test to make sure that indenting for some edge cases. This test 'cperl-mode-test-indent-exp' fails unless cperl-mode is activated for the buffer. The attached patch activates cperl-mode, and skips the test under perl-mode, and avoids dependency on how inline comments are indented. I couldn't just open a new bug without unarchiving the old one, perhaps because I've included the old bug number. Please tell me if it is better to treat such follow-ups as entirely new bugs. -- Cheers, haj --------------E5F09668362654E5A9DD8F30 Content-Type: text/x-patch; charset=UTF-8; name="0001-cperl-mode-Fix-a-test-to-ensure-cperl-mode-is-active.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-cperl-mode-Fix-a-test-to-ensure-cperl-mode-is-active.pa"; filename*1="tch" >From 03829b2c8fafe0c83a2629afddc98bb7c2bd98aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20J=C3=B6rg?= Date: Mon, 5 Oct 2020 12:36:56 +0200 Subject: ; cperl-mode: Fix a test to ensure cperl-mode is active Tweaking my commit 2020-09-04 "Fix infloop when indenting in cperl-mode": * test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-indent-exp): Make sure that cperl-mode is active for testing 'cperl-indent-exp', also skip this test under perl-mode. * test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl: Eliminate dependency on unrelated customizable variables. --- test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl | 4 ++-- test/lisp/progmodes/cperl-mode-tests.el | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl b/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl index 4a9842ffa5..8c1883a10f 100644 --- a/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl +++ b/test/lisp/progmodes/cperl-mode-resources/cperl-indent-exp.pl @@ -26,7 +26,7 @@ } continue { -last; # no endless loop, though +last; } } # -------- while loop: expected output -------- @@ -34,7 +34,7 @@ while (1) { say "boring loop"; } continue { - last; # no endless loop, though + last; } } # -------- while loop: end -------- diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmodes/cperl-mode-tests.el index f0ff8e9005..20be7ed68c 100644 --- a/test/lisp/progmodes/cperl-mode-tests.el +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -148,6 +148,7 @@ cperl-mode-test-indent-exp These exercise some standard blocks and also the special treatment for Perl expressions where a closing paren isn't the end of the statement." + (skip-unless (eq cperl-test-mode #'cperl-mode)) (let ((file (expand-file-name "cperl-indent-exp.pl" cperl-mode-tests-data-directory))) (with-temp-buffer @@ -166,6 +167,7 @@ cperl-mode-test-indent-exp got) (with-temp-buffer (insert code) + (cperl-mode) (goto-char (point-min)) (cperl-indent-exp) ; here we go! (setq expected (concat "test case " name ":\n" expected)) -- 2.20.1 --------------E5F09668362654E5A9DD8F30-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 21:41:09 2020 Received: (at 10483) by debbugs.gnu.org; 6 Oct 2020 01:41:09 +0000 Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbyW-0003lu-Rn for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:41:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbyU-0003lY-Rw for 10483@debbugs.gnu.org; Mon, 05 Oct 2020 21:41:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xlc4d1s4QRTlq64r9RUv4kKDi5C3t3b/A3vs7Gghrpo=; b=kF8cNhMuhkXQgPwWxwDxDOvXH2 NDxWP6AQN/ys8IdlAF4kwDCCb3ichLmfhqJV9PtYTbBgeGpnPvmi3aYE2TVpKLOih2FS4rXFkMAMS qU6pNNb1+haux+AUGnOkIJM28pHB60ed9w8XoOJ9aURkZuh2IoiqCL7e/9Yds/Nog4E0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPbyJ-0001Uq-Mw; Tue, 06 Oct 2020 03:41:00 +0200 From: Lars Ingebrigtsen To: Harald =?utf-8?Q?J=C3=B6rg?= Subject: Re: bug#10483: [PATCH] Fix a bogus test introduced by treating (Bug#10483) References: <0db14c37-394c-05bb-5f5a-3f8baa5d59b0@posteo.de> X-Now-Playing: The Notwist's _Pick Up The Phone_: "Red Room" Date: Tue, 06 Oct 2020 03:40:54 +0200 In-Reply-To: <0db14c37-394c-05bb-5f5a-3f8baa5d59b0@posteo.de> ("Harald =?utf-8?Q?J=C3=B6rg=22's?= message of "Mon, 5 Oct 2020 20:30:22 +0200") Message-ID: <87d01wnnbt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Harald Jörg writes: > The commit 2020-09-04 "Fix infloop when indenting in cperl-mode" for > (Bug#10483) contained a test to make sure that indenting for some edge > cases. This test 'cperl-mode-test-indent-exp' fails un [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10483 Cc: 10483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > The commit 2020-09-04 "Fix infloop when indenting in cperl-mode" for > (Bug#10483) contained a test to make sure that indenting for some edge > cases. This test 'cperl-mode-test-indent-exp' fails unless cperl-mode > is activated for the buffer. > > The attached patch activates cperl-mode, and skips the test under > perl-mode, and avoids dependency on how inline comments are indented. Thanks; applied to Emacs 28. > I couldn't just open a new bug without unarchiving the old one, perhaps > because I've included the old bug number. Please tell me if it is > better to treat such follow-ups as entirely new bugs. Opening a new bug report would be better, I think, and just refer back to the previous bug report in the text. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 21:41:26 2020 Received: (at control) by debbugs.gnu.org; 6 Oct 2020 01:41:26 +0000 Received: from localhost ([127.0.0.1]:50933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbyo-0003mR-8K for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:41:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbyl-0003mD-SV for control@debbugs.gnu.org; Mon, 05 Oct 2020 21:41:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YFR8yyoMDYeVE/9+gLZAYP0ZdPFzxyV9ZxN8RT3HhFo=; b=sCf91CFSyO1OSw63aI0ZUrG9T5 ggFRIWiLDRrqCJv2lA/MLvt9i2fTSO3i898YDikFDrAayc4xPdU6RS0Hnqtuvqs2Fb+D+XhrLebkt IhhnR+svMKtIuKnoyba44y7uH0WzJ4SoXfh1+hC8jzGKgPWLctlBsTOm0M5I+brcRIQ8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPbye-0001VE-2B for control@debbugs.gnu.org; Tue, 06 Oct 2020 03:41:18 +0200 Date: Tue, 06 Oct 2020 03:41:14 +0200 Message-Id: <87blhgnnb9.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #10483 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 10483 fixed close 10483 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 10483 fixed close 10483 28.1 quit From unknown Tue Aug 19 01:58:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 03 Nov 2020 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator