From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 17:09:29 2012 Received: (at submit) by debbugs.gnu.org; 10 Jan 2012 22:09:29 +0000 Received: from localhost ([127.0.0.1]:52918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rkjsm-0007x9-HN for submit@debbugs.gnu.org; Tue, 10 Jan 2012 17:09:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55401) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rkjsk-0007x2-5I for submit@debbugs.gnu.org; Tue, 10 Jan 2012 17:09:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkjsN-00034H-4u for submit@debbugs.gnu.org; Tue, 10 Jan 2012 17:09:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:44538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkjsN-00034D-3L for submit@debbugs.gnu.org; Tue, 10 Jan 2012 17:09:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]:60956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkjsM-0007oT-3y for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 17:09:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkjsL-00033t-5W for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 17:09:02 -0500 Received: from acsinet15.oracle.com ([141.146.126.227]:26953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkjsK-00033h-Sk for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 17:09:01 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id q0AM8uTC032719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 10 Jan 2012 22:08:57 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q0AM8uTV022577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 10 Jan 2012 22:08:56 GMT Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q0AM8tnT005921 for ; Tue, 10 Jan 2012 16:08:55 -0600 Received: from dradamslap1 (/10.159.40.40) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Jan 2012 14:08:55 -0800 From: "Drew Adams" To: Subject: 24.0.92; `C-h v' displays `*' indicating user option Date: Tue, 10 Jan 2012 14:08:51 -0800 Message-ID: <18E370DBB9F14AD7AAE6181C1CB116B7@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AczP5G81hhC8m5hkQryKjw+tGcjvlg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090205.4F0CB6FA.0003,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) (defcustom foo nil "*A foobar function or nil." :type '(choice (const :tag "None" nil) function) :group 'convenience) Then `C-h v foo'. The `*' indicating that this is a user variable (e.g. usable by `set-variable') is printed as if it were part of the doc. It should be removed. The fix is trivial: (when (eq ?* (elt doc 0)) (setq doc (substring doc 1))) Yes, Emacs no longer requires a `*' as a doc-string prefix with `defcustom'. But `describe-variable' should still DTRT with doc strings from code that is designed to work also with older Emacs versions. In addition, `user-variable-p' is the test used for functions such as `set-variable', and it`user-variable-p' recognizes the `*' as defining a user variable. This is correct behavior. The only problem is that `describe-variable' should not treat this `*' as if it were part of the doc text. In GNU Emacs 24.0.92.1 (i386-mingw-nt5.1.2600) of 2012-01-05 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.6) --no-opt --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include --ldflags -LD:/devel/emacs/libs/gnutls-3.0.9/lib' From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 08:02:14 2016 Received: (at 10475) by debbugs.gnu.org; 28 Apr 2016 12:02:14 +0000 Received: from localhost ([127.0.0.1]:51447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avke6-0005CB-6y for submit@debbugs.gnu.org; Thu, 28 Apr 2016 08:02:14 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:36823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avke5-0005C4-2m for 10475@debbugs.gnu.org; Thu, 28 Apr 2016 08:02:13 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avkdl-0002bl-J9; Thu, 28 Apr 2016 14:02:12 +0200 From: Lars Ingebrigtsen To: "Drew Adams" Subject: Re: bug#10475: 24.0.92; `C-h v' displays `*' indicating user option References: <18E370DBB9F14AD7AAE6181C1CB116B7@us.oracle.com> Date: Thu, 28 Apr 2016 14:01:53 +0200 In-Reply-To: <18E370DBB9F14AD7AAE6181C1CB116B7@us.oracle.com> (Drew Adams's message of "Tue, 10 Jan 2012 14:08:51 -0800") Message-ID: <87mvoelz66.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10475 Cc: 10475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) "Drew Adams" writes: > (defcustom foo nil > "*A foobar function or nil." > :type '(choice (const :tag "None" nil) function) > :group 'convenience) > > Then `C-h v foo'. The `*' indicating that this is a user variable > (e.g. usable by `set-variable') is printed as if it were part of the > doc. It should be removed. I don't think so. Instead we should remove all the superfluous "*"s in the source code. I'll submit a bug report. > In addition, `user-variable-p' is the test used for functions such as > `set-variable', and it`user-variable-p' recognizes the `*' as defining a > user variable. This is correct behavior. The only problem is that > `describe-variable' should not treat this `*' as if it were part of the > doc text. It no longer does that. It's now an alias for custom-variable-p. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 08:02:24 2016 Received: (at control) by debbugs.gnu.org; 28 Apr 2016 12:02:24 +0000 Received: from localhost ([127.0.0.1]:51450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avkeG-0005CY-Dj for submit@debbugs.gnu.org; Thu, 28 Apr 2016 08:02:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:36830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avkeE-0005CR-Vr for control@debbugs.gnu.org; Thu, 28 Apr 2016 08:02:23 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avkeC-0002cc-Rd for control@debbugs.gnu.org; Thu, 28 Apr 2016 14:02:22 +0200 Date: Thu, 28 Apr 2016 14:02:20 +0200 Message-Id: <87lh3ylz5f.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #10475 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 10475 wontfix close 10475 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 10:16:40 2016 Received: (at 10475) by debbugs.gnu.org; 28 Apr 2016 14:16:40 +0000 Received: from localhost ([127.0.0.1]:53205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avmkC-0000SA-Ge for submit@debbugs.gnu.org; Thu, 28 Apr 2016 10:16:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avmkB-0000Rx-13 for 10475@debbugs.gnu.org; Thu, 28 Apr 2016 10:16:39 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3SEGWIV026604 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Apr 2016 14:16:33 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u3SEGWqQ011798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Apr 2016 14:16:32 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u3SEGTmv016736; Thu, 28 Apr 2016 14:16:31 GMT MIME-Version: 1.0 Message-ID: <3ab52fb9-48c6-4b36-a53f-fe60d607fb2d@default> Date: Thu, 28 Apr 2016 07:16:27 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#10475: 24.0.92; `C-h v' displays `*' indicating user option References: <18E370DBB9F14AD7AAE6181C1CB116B7@us.oracle.com> <87mvoelz66.fsf@gnus.org> In-Reply-To: <87mvoelz66.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 10475 Cc: 10475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > (defcustom foo nil > > "*A foobar function or nil." > > :type '(choice (const :tag "None" nil) function) > > :group 'convenience) > > > > Then `C-h v foo'. The `*' indicating that this is a user variable > > (e.g. usable by `set-variable') is printed as if it were part of the > > doc. It should be removed. >=20 > I don't think so. Instead we should remove all the superfluous "*"s in > the source code. I'll submit a bug report. >=20 > > In addition, `user-variable-p' is the test used for functions such as > > `set-variable', and it`user-variable-p' recognizes the `*' as defining = a > > user variable. This is correct behavior. The only problem is that > > `describe-variable' should not treat this `*' as if it were part of the > > doc text. >=20 > It no longer does that. It's now an alias for custom-variable-p. You're missing the point. "It no longer does that..." Existing code written (and usable) in earlier releases, where `*' here DOES have that meaning and effect, should not be handled by recent Emacs differently wrt `C-h v'. `C-h v' should behave the same across releases in this regard. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 12:50:59 2016 Received: (at 10475) by debbugs.gnu.org; 28 Apr 2016 16:50:59 +0000 Received: from localhost ([127.0.0.1]:53423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avp9X-0005ot-IB for submit@debbugs.gnu.org; Thu, 28 Apr 2016 12:50:59 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avp9V-0005og-SM for 10475@debbugs.gnu.org; Thu, 28 Apr 2016 12:50:58 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3SGoo0Y017169 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Apr 2016 16:50:51 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u3SGoosX018605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Apr 2016 16:50:50 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3SGomUq011655; Thu, 28 Apr 2016 16:50:49 GMT MIME-Version: 1.0 Message-ID: <7f68cec2-a520-47c5-8d4b-820619cc0213@default> Date: Thu, 28 Apr 2016 09:50:47 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#10475: 24.0.92; `C-h v' displays `*' indicating user option References: <18E370DBB9F14AD7AAE6181C1CB116B7@us.oracle.com> <87mvoelz66.fsf@gnus.org> <3ab52fb9-48c6-4b36-a53f-fe60d607fb2d@default> In-Reply-To: <3ab52fb9-48c6-4b36-a53f-fe60d607fb2d@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 10475 Cc: 10475@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If it wasn't clear, consider a library that is perfectly usable in Emacs 25 but also in older Emacs versions that require the `*'. That library _should_ continue to use the `*'. Emacs 25 and later should tolerate it: remove it from the output, knowing that older code will have it. It is narrow-minded to think that just because the latest distributed Emacs code no longer needs something no other Emacs code needs it. From unknown Mon Jun 23 11:28:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 May 2016 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator