GNU bug report logs - #10474
Building guile 2.x under mingw + msys

Previous Next

Full log

Message #113 received at 10474 <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ludo <at> gnu.org, 10474 <at> debbugs.gnu.org
Subject: Re: bug#10474: Building guile 2.x under mingw + msys
Date: Thu, 21 Feb 2013 09:18:40 +0100

On Thu 21 Feb 2013 04:49, Eli Zaretskii <eliz <at> gnu.org> writes:

>> >   extern size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
>> 
>> In these files, `input' is a char*.  So &input should be a char**.
>> Shouldn't that cast to const char** without a warning?
>
> Maybe it's some obscure bug my compiler.  If you can get away without
> a warning in such situations, even when the prototype does specify
> "const char **", then feel free to disregard these changes.  They are
> certainly not Windows or MinGW specific.

I'm not trying to disregard your change, but the cast really shouldn't
be necessary.  Adding an explicit cast to (const char**) would start
causing warnings on platforms that have a posix iconv prototype, like
those with GNU libc.

So, very respectfully, I think I will not apply this one.

Andy
-- 
http://wingolog.org/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.