GNU bug report logs - #1046
23.0.60; vc-dir with Subversion

Previous Next

Package: emacs;

Reported by: Nick Roberts <nickrob <at> snap.net.nz>

Date: Sun, 28 Sep 2008 07:40:03 UTC

Severity: normal

Tags: patch

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #24 received at 1046 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nick Roberts <nickrob <at> snap.net.nz>
Cc: 1046 <at> debbugs.gnu.org
Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion
Date: Sat, 04 Oct 2008 15:54:00 -0400
Nick Roberts wrote:

> Perhaps mention that this function is only in pre Emacs 23.

OK.

> I'm not sure that I understand the current naming convention. 

Me neither.

> (let (result dirlist)
[...]
> (let ((basename (match-string 1))
>       (file (expand-file-name basename dir))
>       (status (or (vc-file-getprop file 'vc-state)
>                   (vc-cvs-parse-entry file t))))

My personal preference is to use as few lets as possible (in case we
start running out...).




This bug report was last modified 16 years and 288 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.