From nickrob@snap.net.nz Sun Sep 28 00:33:26 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 28 Sep 2008 07:33:26 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8S7XNDP001478 for ; Sun, 28 Sep 2008 00:33:24 -0700 Received: from mail.gnu.org ([199.232.76.166]:40934 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KjqkK-0005Jw-M3 for emacs-pretest-bug@gnu.org; Sun, 28 Sep 2008 03:31:12 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KjqmO-00048T-QQ for emacs-pretest-bug@gnu.org; Sun, 28 Sep 2008 03:33:22 -0400 Received: from mx20.gnu.org ([199.232.41.8]:51790) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KjqmO-00048P-D2 for emacs-pretest-bug@gnu.org; Sun, 28 Sep 2008 03:33:20 -0400 Received: from viper.snap.net.nz ([202.37.101.25]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KjqmN-0005tZ-IK for emacs-pretest-bug@gnu.org; Sun, 28 Sep 2008 03:33:19 -0400 Received: from kahikatea.snap.net.nz (120.29.255.123.static.snap.net.nz [123.255.29.120]) by viper.snap.net.nz (Postfix) with ESMTP id B49B53DA4A4 for ; Sun, 28 Sep 2008 20:33:17 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 6F5348FC6D; Sun, 28 Sep 2008 19:33:09 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18655.13103.295021.779321@kahikatea.snap.net.nz> Date: Sun, 28 Sep 2008 19:33:03 +1200 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; vc-dir with Subversion X-Mailer: VM 7.19 under Emacs 22.3.1 X-detected-kernel: by mx20.gnu.org: Linux 2.4-2.6 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) In the past I've remarked that with CVS vc-dir ignores vc-stay-local (and vc-cvs-stay-local) and consults the repository, in any case. I now see that with SVN, vc-dir also ignores vc-stay-local but this time never consults the repository. I'm not sure if it worked with vc-directory, but for this function, the command "svn log -u" was used when vc-stay-local was nil. In Emacs 23.0.60 it always just sends "svn log" -- Nick http://www.inet.net.nz/~nickrob From rgm@gnu.org Wed Oct 1 00:30:58 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.1 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1046) by emacsbugs.donarmstrong.com; 1 Oct 2008 07:30:58 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m917Ut48022798 for <1046@emacsbugs.donarmstrong.com>; Wed, 1 Oct 2008 00:30:56 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Kkw8W-0006qN-40; Wed, 01 Oct 2008 03:28:40 -0400 From: Glenn Morris To: Nick Roberts Cc: 1046@debbugs.gnu.org Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion References: <18655.13103.295021.779321@kahikatea.snap.net.nz> X-Spook: industrial espionage Uzi rs9512c nuclear Firefly BRLO X-Ran: 6:*k.>r,)0.p|bAfIKLAf^|'t6T{QmGITD,[EM&Ii}epZ*3rGh}F`fGaoO[l}9JxED)f^O X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 01 Oct 2008 03:28:39 -0400 In-Reply-To: <18655.13103.295021.779321@kahikatea.snap.net.nz> (Nick Roberts's message of "Sun, 28 Sep 2008 19:33:03 +1200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Nick Roberts wrote: > In the past I've remarked that with CVS vc-dir ignores vc-stay-local (and > vc-cvs-stay-local) and consults the repository, in any case. Can you file a separate bug for that please, if it still applies? > I now see that with SVN, vc-dir also ignores vc-stay-local but this time > never consults the repository. > > I'm not sure if it worked with vc-directory, but for this function, the > command "svn log -u" was used when vc-stay-local was nil. In Emacs 23.0.60 > it always just sends "svn log" You meant "svn status", not "log". Anyway, here is an attempt at a simple-minded patch. *** vc-svn.el.~1.96.~ 2008-09-09 19:28:20.000000000 -0700 --- vc-svn.el 2008-10-01 00:26:48.000000000 -0700 *************** *** 146,152 **** "SVN-specific state heuristic." (vc-svn-state file 'local)) ! (defun vc-svn-after-dir-status (callback) (let ((state-map '((?A . added) (?C . conflict) (?D . removed) --- 146,152 ---- "SVN-specific state heuristic." (vc-svn-state file 'local)) ! (defun vc-svn-after-dir-status (callback &optional remote) (let ((state-map '((?A . added) (?C . conflict) (?D . removed) *************** *** 156,166 **** (?? . unregistered) ;; This is what vc-svn-parse-status does. (?~ . edited))) result) (goto-char (point-min)) ! (while (re-search-forward "^\\(.\\)..... \\(.*\\)$" nil t) ! (let ((state (cdr (assq (aref (match-string 1) 0) state-map))) ! (filename (match-string 2))) (when state (setq result (cons (list filename state) result))))) (funcall callback result))) --- 156,170 ---- (?? . unregistered) ;; This is what vc-svn-parse-status does. (?~ . edited))) + (re (if remote "^\\(.\\)..... \\([ *]\\) +[-0-9]+ +\\(.*\\)$" + "^\\(.\\)....\\(.\\) \\(.*\\)$")) result) (goto-char (point-min)) ! (while (re-search-forward re nil t) ! (let ((state (or (cdr (assq (aref (match-string 1) 0) state-map)) ! (and remote (string-equal (match-string 2) "*") ! 'needs-merge))) ! (filename (match-string 3))) (when state (setq result (cons (list filename state) result))))) (funcall callback result))) *************** *** 169,177 **** "Run 'svn status' for DIR and update BUFFER via CALLBACK. CALLBACK is called as (CALLBACK RESULT BUFFER), where RESULT is a list of conses (FILE . STATE) for directory DIR." ! (vc-svn-command (current-buffer) 'async nil "status") (vc-exec-after ! `(vc-svn-after-dir-status (quote ,callback)))) (defun vc-svn-status-extra-headers (dir) "Generate extra status headers for a Subversion working copy." --- 173,184 ---- "Run 'svn status' for DIR and update BUFFER via CALLBACK. CALLBACK is called as (CALLBACK RESULT BUFFER), where RESULT is a list of conses (FILE . STATE) for directory DIR." ! ;; FIXME should this rather be all the files in dir? ! (let ((remote (not (vc-stay-local-p dir)))) ! (vc-svn-command (current-buffer) 'async nil "status" ! (if remote "-u")) (vc-exec-after ! `(vc-svn-after-dir-status (quote ,callback) ,remote)))) (defun vc-svn-status-extra-headers (dir) "Generate extra status headers for a Subversion working copy." From rgm@gnu.org Wed Oct 1 09:07:20 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.1 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1046) by emacsbugs.donarmstrong.com; 1 Oct 2008 16:07:20 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m91G7HQB024531 for <1046@emacsbugs.donarmstrong.com>; Wed, 1 Oct 2008 09:07:18 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Kl4CE-0003RB-Lf; Wed, 01 Oct 2008 12:05:02 -0400 From: Glenn Morris To: 1046@debbugs.gnu.org Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion References: <18655.13103.295021.779321@kahikatea.snap.net.nz> CC: Nick Roberts X-Spook: CID Roswell kibo bootleg Semtex pipeline military NWO X-Ran: ;@8.lG3h#Uzy!x_m@34Xz9bdx:!)EyR~uKS-$]GL]5z_@EBeWC5[t~][3y/O4B:m9|afqq X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 01 Oct 2008 12:05:02 -0400 In-Reply-To: (Glenn Morris's message of "Wed, 01 Oct 2008 03:28:39 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Slight revision to distinguish needs-update and needs-merge. Perhaps there are other states. *** vc-svn.el 7 Sep 2008 20:24:29 -0000 1.96 --- vc-svn.el 1 Oct 2008 16:00:28 -0000 *************** *** 146,152 **** "SVN-specific state heuristic." (vc-svn-state file 'local)) ! (defun vc-svn-after-dir-status (callback) (let ((state-map '((?A . added) (?C . conflict) (?D . removed) --- 146,152 ---- "SVN-specific state heuristic." (vc-svn-state file 'local)) ! (defun vc-svn-after-dir-status (callback &optional remote) (let ((state-map '((?A . added) (?C . conflict) (?D . removed) *************** *** 156,166 **** (?? . unregistered) ;; This is what vc-svn-parse-status does. (?~ . edited))) result) (goto-char (point-min)) ! (while (re-search-forward "^\\(.\\)..... \\(.*\\)$" nil t) (let ((state (cdr (assq (aref (match-string 1) 0) state-map))) ! (filename (match-string 2))) (when state (setq result (cons (list filename state) result))))) (funcall callback result))) --- 156,173 ---- (?? . unregistered) ;; This is what vc-svn-parse-status does. (?~ . edited))) + (re (if remote "^\\(.\\)..... \\([ *]\\) +[-0-9]+ +\\(.*\\)$" + ;; Subexp 2 is a dummy in this case, so the numbers match. + "^\\(.\\)....\\(.\\) \\(.*\\)$")) result) (goto-char (point-min)) ! (while (re-search-forward re nil t) (let ((state (cdr (assq (aref (match-string 1) 0) state-map))) ! (filename (match-string 3))) ! (and remote (string-equal (match-string 2) "*") ! (setq state (if (eq state 'edited) ! 'needs-merge ! 'needs-update))) (when state (setq result (cons (list filename state) result))))) (funcall callback result))) *************** *** 169,177 **** "Run 'svn status' for DIR and update BUFFER via CALLBACK. CALLBACK is called as (CALLBACK RESULT BUFFER), where RESULT is a list of conses (FILE . STATE) for directory DIR." ! (vc-svn-command (current-buffer) 'async nil "status") (vc-exec-after ! `(vc-svn-after-dir-status (quote ,callback)))) (defun vc-svn-status-extra-headers (dir) "Generate extra status headers for a Subversion working copy." --- 176,187 ---- "Run 'svn status' for DIR and update BUFFER via CALLBACK. CALLBACK is called as (CALLBACK RESULT BUFFER), where RESULT is a list of conses (FILE . STATE) for directory DIR." ! ;; FIXME should this rather be all the files in dir? ! (let ((remote (not (vc-stay-local-p dir)))) ! (vc-svn-command (current-buffer) 'async nil "status" ! (if remote "-u")) (vc-exec-after ! `(vc-svn-after-dir-status (quote ,callback) ,remote)))) (defun vc-svn-status-extra-headers (dir) "Generate extra status headers for a Subversion working copy." From rgm@gnu.org Wed Oct 1 16:05:20 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.1 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1046) by emacsbugs.donarmstrong.com; 1 Oct 2008 23:05:20 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m91N5Gn9032121 for <1046@emacsbugs.donarmstrong.com>; Wed, 1 Oct 2008 16:05:18 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KlAij-0006l7-Gb; Wed, 01 Oct 2008 19:03:01 -0400 From: Glenn Morris To: 1046@debbugs.gnu.org Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion References: <18655.13103.295021.779321@kahikatea.snap.net.nz> CC: Nick Roberts X-Spook: AIEWS Pine Gap Crypto AG satellite imagery Kh-11 Ansar X-Ran: *|vH0a7{)n0)W9:0l (Glenn Morris's message of "Wed, 01 Oct 2008 03:28:39 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Glenn Morris wrote: > Nick Roberts wrote: > >> In the past I've remarked that with CVS vc-dir ignores vc-stay-local (and >> vc-cvs-stay-local) and consults the repository, in any case. > > Can you file a separate bug for that please, if it still applies? Never mind. For a limited time only, your initial bug report entitles you to one complimentary patch for a second issue. *** vc-cvs.el 7 Sep 2008 20:24:27 -0000 1.148 --- vc-cvs.el 1 Oct 2008 23:02:15 -0000 *************** *** 905,912 **** --- 905,943 ---- ;; (funcall update-function result))) ) + ;; Based on vc-cvs-dir-state-heuristic. + (defun vc-cvs-dir-status-heuristic (dir update-function &optional basedir) + "Find the CVS state of all files in DIR, using only local information." + (let (file basename status result dirlist) + (with-temp-buffer + (vc-cvs-get-entries dir) + (goto-char (point-min)) + (while (not (eobp)) + (if (looking-at "D/\\([^/]*\\)////") + (push (expand-file-name (match-string 1) dir) dirlist) + ;; CVS-removed files are not taken under VC control. + (when (looking-at "/\\([^/]*\\)/[^/-]") + (setq basename (match-string 1) + file (expand-file-name basename dir) + status (or (vc-file-getprop file 'vc-state) + (vc-cvs-parse-entry file t))) + (unless (eq status 'up-to-date) + (push (list (if basedir + (file-relative-name file basedir) + basename) + status) result)))) + (forward-line 1))) + (dolist (subdir dirlist) + (setq result (append result + (vc-cvs-dir-status-heuristic subdir nil dir)))) + (if basedir result + (funcall update-function result)))) + (defun vc-cvs-dir-status (dir update-function) "Create a list of conses (file . state) for DIR." + ;; FIXME check all files in DIR instead? + (if (vc-stay-local-p dir) + (vc-cvs-dir-status-heuristic dir update-function) (vc-cvs-command (current-buffer) 'async dir "-f" "status") ;; Alternative implementation: use the "update" command instead of ;; the "status" command. *************** *** 914,920 **** ;; (file-relative-name dir) ;; "-f" "-n" "update" "-d" "-P") (vc-exec-after ! `(vc-cvs-after-dir-status (quote ,update-function)))) (defun vc-cvs-file-to-string (file) "Read the content of FILE and return it as a string." --- 945,951 ---- ;; (file-relative-name dir) ;; "-f" "-n" "update" "-d" "-P") (vc-exec-after ! `(vc-cvs-after-dir-status (quote ,update-function))))) (defun vc-cvs-file-to-string (file) "Read the content of FILE and return it as a string." From rgm@gnu.org Thu Oct 2 14:20:06 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 2 Oct 2008 21:20:06 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m92LK3OM007936 for ; Thu, 2 Oct 2008 14:20:04 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KlVYR-00039a-5Q; Thu, 02 Oct 2008 17:17:47 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18661.14971.116177.674668@fencepost.gnu.org> Date: Thu, 2 Oct 2008 17:17:47 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: ksbR-Gfj07dj>lXr>M+*e0o7q2qu+!1(ZOT{+f'yLO)O*tCgRdo@lt&kzoa6o%)3$aWo*9 X-Debbugs-No-Ack: yes tags 1046 patch tags 1017 patch moreinfo tags 1059 unreproducible tags 1053 notabug wontfix From nickrob@snap.net.nz Sat Oct 4 01:55:34 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1046) by emacsbugs.donarmstrong.com; 4 Oct 2008 08:55:35 +0000 Received: from viper.snap.net.nz (viper.snap.net.nz [202.37.101.25]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m948tUrA022005 for <1046@emacsbugs.donarmstrong.com>; Sat, 4 Oct 2008 01:55:32 -0700 Received: from kahikatea.snap.net.nz (102.31.255.123.static.snap.net.nz [123.255.31.102]) by viper.snap.net.nz (Postfix) with ESMTP id 4F0BF3D812A; Sat, 4 Oct 2008 21:55:29 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 224848FC6D; Sat, 4 Oct 2008 20:53:58 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18663.12069.154443.910505@kahikatea.snap.net.nz> Date: Sat, 4 Oct 2008 20:53:57 +1200 To: Glenn Morris , 1046@debbugs.gnu.org Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion In-Reply-To: References: <18655.13103.295021.779321@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.3.1 > >> In the past I've remarked that with CVS vc-dir ignores vc-stay-local (and > >> vc-cvs-stay-local) and consults the repository, in any case. > > > > Can you file a separate bug for that please, if it still applies? > > Never mind. For a limited time only, your initial bug report entitles > you to one complimentary patch for a second issue. I've glanced over it and tried it out and it looks good to me. Thanks, Nick > > *** vc-cvs.el 7 Sep 2008 20:24:27 -0000 1.148 > --- vc-cvs.el 1 Oct 2008 23:02:15 -0000 > *************** > *** 905,912 **** > --- 905,943 ---- > ;; (funcall update-function result))) > ) > > + ;; Based on vc-cvs-dir-state-heuristic. Perhaps mention that this function is only in pre Emacs 23. I'm not sure that I understand the current naming convention. Some functions now use 'status': vc-cvs-dir-status, while others still use 'state': vc-cvs-state-heuristic. > + (defun vc-cvs-dir-status-heuristic (dir update-function &optional basedir) > + "Find the CVS state of all files in DIR, using only local information." > + (let (file basename status result dirlist) (let (result dirlist) > + (with-temp-buffer > + (vc-cvs-get-entries dir) > + (goto-char (point-min)) > + (while (not (eobp)) > + (if (looking-at "D/\\([^/]*\\)////") > + (push (expand-file-name (match-string 1) dir) dirlist) > + ;; CVS-removed files are not taken under VC control. > + (when (looking-at "/\\([^/]*\\)/[^/-]") > + (setq basename (match-string 1) > + file (expand-file-name basename dir) > + status (or (vc-file-getprop file 'vc-state) > + (vc-cvs-parse-entry file t))) (let ((basename (match-string 1)) (file (expand-file-name basename dir)) (status (or (vc-file-getprop file 'vc-state) (vc-cvs-parse-entry file t)))) No big deal. Perhaps a bit clearer. ... -- Nick http://www.inet.net.nz/~nickrob From rgm@gnu.org Sat Oct 4 12:56:22 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1046) by emacsbugs.donarmstrong.com; 4 Oct 2008 19:56:22 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m94JuJqb024030 for <1046@emacsbugs.donarmstrong.com>; Sat, 4 Oct 2008 12:56:20 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KmDCS-0005o0-6g; Sat, 04 Oct 2008 15:54:00 -0400 From: Glenn Morris To: Nick Roberts Cc: 1046@debbugs.gnu.org Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion References: <18655.13103.295021.779321@kahikatea.snap.net.nz> <18663.12069.154443.910505@kahikatea.snap.net.nz> X-Spook: explosion government import corporate security Honduras X-Ran: :>AOcNQW('lJg]O'LcZc~w(8TYfrd\h|)%s"yDJ2z@o1dhPcF

(Nick Roberts's message of "Sat, 4 Oct 2008 20:53:57 +1200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Nick Roberts wrote: > Perhaps mention that this function is only in pre Emacs 23. OK. > I'm not sure that I understand the current naming convention. Me neither. > (let (result dirlist) [...] > (let ((basename (match-string 1)) > (file (expand-file-name basename dir)) > (status (or (vc-file-getprop file 'vc-state) > (vc-cvs-parse-entry file t)))) My personal preference is to use as few lets as possible (in case we start running out...). From rgm@gnu.org Sat Oct 4 13:25:55 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 4 Oct 2008 20:25:55 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m94KPqL6031877 for ; Sat, 4 Oct 2008 13:25:53 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KmDf3-0007VG-9Z; Sat, 04 Oct 2008 16:23:33 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18663.53445.228410.170092@fencepost.gnu.org> Date: Sat, 4 Oct 2008 16:23:33 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: cyan X-Ran: Zq.JARFw|pds"U3bxplhOZdjN[=8%)5%A62=:VIb|+lW1*LT$zhu0#mQ$%}b>UyWr4k^WU X-Debbugs-No-Ack: yes close 1046 From monnier@IRO.UMontreal.CA Mon Oct 6 07:18:51 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1046) by emacsbugs.donarmstrong.com; 6 Oct 2008 14:18:52 +0000 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m96EImSb012215 for <1046@emacsbugs.donarmstrong.com>; Mon, 6 Oct 2008 07:18:49 -0700 Received: from alfajor.home (vpn-132-204-232-40.acd.umontreal.ca [132.204.232.40]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m96EIj6e017385; Mon, 6 Oct 2008 10:18:45 -0400 Received: by alfajor.home (Postfix, from userid 20848) id 6780F1C3E8; Mon, 6 Oct 2008 10:18:45 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Cc: 1046@debbugs.gnu.org, Nick Roberts Subject: Re: bug#1046: 23.0.60; vc-dir with Subversion Message-ID: References: <18655.13103.295021.779321@kahikatea.snap.net.nz> <18663.12069.154443.910505@kahikatea.snap.net.nz> Date: Mon, 06 Oct 2008 10:18:45 -0400 In-Reply-To: (Glenn Morris's message of "Sat, 04 Oct 2008 15:54:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3118=0 >> (let (result dirlist) > [...] >> (let ((basename (match-string 1)) >> (file (expand-file-name basename dir)) >> (status (or (vc-file-getprop file 'vc-state) >> (vc-cvs-parse-entry file t)))) > My personal preference is to use as few lets as possible (in case we > start running out...). We still have a large supply of `let's, so you can use them liberally. Especially if they can eliminate a few pesky `setq's. They only problem with `let's as of now is that they eat up indentation space, but it's rarely a serious problem. Stefan From unknown Fri Aug 15 21:23:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Nov 2008 15:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator