GNU bug report logs - #10454
23.3; Different result from `C-h k' and `C-h ? k'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10454 in the body.
You can then email your comments to 10454 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Röthlisberger <david <at> rothlis.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Sun, 8 Jan 2012 11:36:42 +0000

If I have ido-mode enabled, the output of `C-h k C-x C-f' is:

> C-x C-f runs the command ido-find-file, which is an interactive
> compiled Lisp function in `ido.el'.


But if I'm just learning Emacs and I do `C-h ? k C-x C-f', the output is for (non-ido) find-file:

> C-x C-f runs the command find-file, which is an interactive compiled
> Lisp function in `files.el'.


I'm not sure what causes this. `help-for-help' in `help.el' seems to use the same `help-map' that binds `C-h k' to `describe-key'; I couldn't understand the `make-help-screen' macro so that's as far as I got with my investigation.

I reproduced this on Emacs 23.3 and a 2012-01-08 nightly build of 24.0.92.1 (revno: 106821).

Recipe starting from `emacs -Q':

M-: (ido-mode t)
C-h k C-x C-f
C-h ? k C-x C-f

Thanks,
Dave.

Message #8 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: David Röthlisberger <david <at> rothlis.net>
Cc: 10454 <at> debbugs.gnu.org
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Mon, 09 Jan 2012 19:19:01 +0100

> If I have ido-mode enabled, the output of `C-h k C-x C-f' is:
>
>> C-x C-f runs the command ido-find-file, which is an interactive
>> compiled Lisp function in `ido.el'.
>
>
> But if I'm just learning Emacs and I do `C-h ? k C-x C-f', the output is for (non-ido) find-file:
>
>> C-x C-f runs the command find-file, which is an interactive compiled
>> Lisp function in `files.el'.

FWIW this is due to `make-help-screen' binding `minor-mode-map-alist' to
nil.  Applying the patch below seems to fix it, but maybe someone more
knowledgeable has a better solution.  (If you want to try the patch,
make sure to recompile help.el after compiling help-macro.el).

martin


*** lisp/help-macro.el	2011-01-25 04:08:28 +0000
--- lisp/help-macro.el	2012-01-09 18:05:39 +0000
***************
*** 186,192 ****
  			       (setq config nil))
  			     ;; `defn' must make sure that its frame is
  			     ;; selected, so we won't iconify it below.
! 			     (call-interactively defn)
  			     (when new-frame
  			       ;; Do not iconify the selected frame.
  			       (unless (eq new-frame (selected-frame))
--- 186,193 ----
  			       (setq config nil))
  			     ;; `defn' must make sure that its frame is
  			     ;; selected, so we won't iconify it below.
! 			     (let ((minor-mode-map-alist new-minor-mode-map-alist))
! 			       (call-interactively defn))
  			     (when new-frame
  			       ;; Do not iconify the selected frame.
  			       (unless (eq new-frame (selected-frame))

Message #11 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 10454 <at> debbugs.gnu.org,
	David Röthlisberger <david <at> rothlis.net>
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Tue, 17 Jan 2012 14:12:17 -0500

martin rudalics wrote:

> FWIW this is due to `make-help-screen' binding `minor-mode-map-alist' to
> nil.  Applying the patch below seems to fix it, but maybe someone more
> knowledgeable has a better solution.

I'm no more knowledgeable, but it must be something to do with
minor-mode-map-alist, so FWIW if your solution makes it work I suggest
installing it and closing this.

Message #14 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: David Röthlisberger <david <at> rothlis.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 10454 <at> debbugs.gnu.org
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Thu, 19 Jan 2012 08:20:13 +0000

martin rudalics wrote:

> (If you want to try the patch, make sure to recompile help.el
> after compiling help-macro.el).

The patch doesn't work for me -- am I doing something wrong?

I'm finding "help.el.gz" by going `C-h k C-h k' and clicking on
the `help.el' link in the help buffer.

Then I open help-macro.el.gz in the same directory; apply the
patch; then
M-x byte-compile-file help-macro.el.gz
M-x byte-compile-file help.el.gz
and restart Emacs.

Thanks!
Dave.

Message #17 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: David Röthlisberger <david <at> rothlis.net>
Cc: martin rudalics <rudalics <at> gmx.at>, 10454 <at> debbugs.gnu.org
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Thu, 19 Jan 2012 09:29:13 +0100

David Röthlisberger <david <at> rothlis.net> writes:

> Then I open help-macro.el.gz in the same directory; apply the
> patch; then
> M-x byte-compile-file help-macro.el.gz
> M-x byte-compile-file help.el.gz

You need to reload help-macro inbetween.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #20 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: David Röthlisberger <david <at> rothlis.net>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: martin rudalics <rudalics <at> gmx.at>, 10454 <at> debbugs.gnu.org
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Thu, 19 Jan 2012 09:07:41 +0000

Andreas Schwab wrote:

>> Then I open help-macro.el.gz in the same directory; apply the
>> patch; then
>> M-x byte-compile-file help-macro.el.gz
>> M-x byte-compile-file help.el.gz
> 
> You need to reload help-macro inbetween.


Good point. I have now tried that, as well as trying the following:
* Deleting help.elc & help-macro.elc altogether, then restarting Emacs
* M-x eval-buffer on help-macro.el.gz before & after byte-compiling it, then M-x eval-buffer on help.el.gz before byte-compiling it, then restarting Emacs.
* M-x load-file help-macro.el.gz before & after byte-compiling it, then M-x load-file help.el.gz before byte-compiling it, then restarting Emacs.
* Restarting Emacs after byte-compiling help-macro.el.gz, then byte-compiling help.el.gz, then restarting Emacs.

In all cases the patch still doesn't work for me.

Message #23 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: David Röthlisberger <david <at> rothlis.net>
Cc: Andreas Schwab <schwab <at> linux-m68k.org>, 10454 <at> debbugs.gnu.org
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Thu, 19 Jan 2012 11:48:27 -0500

David Röthlisberger wrote:

> * Deleting help.elc & help-macro.elc altogether, then restarting Emacs
> * M-x eval-buffer on help-macro.el.gz before & after byte-compiling it, then M-x eval-buffer on help.el.gz before byte-compiling it, then restarting Emacs.
> * M-x load-file help-macro.el.gz before & after byte-compiling it, then M-x load-file help.el.gz before byte-compiling it, then restarting Emacs.
> * Restarting Emacs after byte-compiling help-macro.el.gz, then byte-compiling help.el.gz, then restarting Emacs.

help.el is dumped into the Emacs image, so restarting Emacs defeats all
your good work. You either need to rebuild Emacs, or (should work),
explicitly load help-macro.el and then load help.el, then try it in the
same Emacs session.

Message #26 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: David Röthlisberger <david <at> rothlis.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: martin rudalics <rudalics <at> gmx.at>, Andreas Schwab <schwab <at> linux-m68k.org>,
	10454 <at> debbugs.gnu.org
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Thu, 19 Jan 2012 17:08:29 +0000

Glenn Morris wrote:

> help.el is dumped into the Emacs image, so restarting Emacs defeats all
> your good work. You either need to rebuild Emacs, or (should work),
> explicitly load help-macro.el and then load help.el, then try it in the
> same Emacs session.

Heheh, no wonder. I can now confirm that Martin's patch does work
for me. :-)

Thank you all for all your help.
Dave.

Message #29 received at 10454 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 10454 <at> debbugs.gnu.org,
	David Röthlisberger <david <at> rothlis.net>
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Fri, 20 Jan 2012 10:20:17 +0100

> I'm no more knowledgeable, but it must be something to do with
> minor-mode-map-alist, so FWIW if your solution makes it work I suggest
> installing it and closing this.

Done.

martin

Message #34 received at 10454-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 10454-done <at> debbugs.gnu.org
Cc: David Röthlisberger <david <at> rothlis.net>
Subject: Re: bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'
Date: Fri, 20 Jan 2012 10:19:48 +0100

> I can now confirm that Martin's patch does work
> for me. :-)

Installed in revision 106895 on trunk.

> Thank you all for all your help.

Thank you for the precise report.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.