From unknown Tue Jun 24 15:44:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10445: 24.0.92; patch: dired.el: mark files by regexp Resent-From: Eduard Wiebe Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2012 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10445 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 10445@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13258850829117 (code B ref -1); Fri, 06 Jan 2012 21:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jan 2012 21:24:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjHHE-0002Mz-TY for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:24:41 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjHHC-0002Mn-Kb for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:24:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjHDg-0002ro-0L for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:21:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:32894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjHDf-0002rk-V8 for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:20:59 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjHDf-0003DD-3b for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 16:20:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjHDd-0002rT-WB for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 16:20:59 -0500 Received: from wp093.webpack.hosteurope.de ([80.237.132.100]:46845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjHDd-0002rN-Rk for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 16:20:57 -0500 Received: from g227150182.adsl.alicedsl.de ([92.227.150.182] helo=nirvana); authenticated by wp093.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1RjHDa-0004Br-Vl; Fri, 06 Jan 2012 22:20:55 +0100 Received: from ew by nirvana with local (Exim 4.72) (envelope-from ) id 1RjHAK-0000ql-Ba for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 22:17:32 +0100 From: Eduard Wiebe Date: Fri, 06 Jan 2012 22:17:32 +0100 Message-ID: <87ty48sf83.fsf@pusto.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-bounce-key: webpack.hosteurope.de;ew@pusto.de;1325884857;ab7c323f; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.8 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --=-=-= Content-Type: text/plain Hi all, i want to suggest this simple patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dired.el.patch diff -r 068c58b8caca lisp/dired.el --- a/lisp/dired.el Thu Jan 05 09:03:42 2012 +0100 +++ b/lisp/dired.el Thu Jan 05 09:07:14 2012 +0100 @@ -3103,8 +3103,8 @@ (dired-mark-if (and (not (looking-at dired-re-dot)) (not (eolp)) ; empty line - (let ((fn (dired-get-filename nil t))) - (and fn (string-match regexp (file-name-nondirectory fn))))) + (let ((fn (dired-get-filename t t))) + (and fn (string-match regexp fn)))) "matching file"))) (defun dired-mark-files-containing-regexp (regexp &optional marker-char) --=-=-= Content-Type: text/plain With this patch i am able to mark entries in dired buffer even when these contain directory parts. (Try `find-dired' in emacs.bzr/trunk/test and mark all entries files in "automated/" entries.) -- Eduard Wiebe --=-=-=-- From unknown Tue Jun 24 15:44:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eduard Wiebe Subject: bug#10445: closed (Re: bug#10445: 24.0.92; patch: dired.el: mark files by regexp) Message-ID: References: <87ty48sf83.fsf@pusto.de> X-Gnu-PR-Message: they-closed 10445 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 10445@debbugs.gnu.org Date: Fri, 27 Jan 2012 21:43:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1327700582-21235-1" This is a multi-part message in MIME format... ------------=_1327700582-21235-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #10445: 24.0.92; patch: dired.el: mark files by regexp which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 10445@debbugs.gnu.org. --=20 10445: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10445 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1327700582-21235-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 10445-done) by debbugs.gnu.org; 27 Jan 2012 21:42:38 +0000 Received: from localhost ([127.0.0.1]:47094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqtZ7-0005Vv-9L for submit@debbugs.gnu.org; Fri, 27 Jan 2012 16:42:38 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:33392 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RqtZ2-0005Vl-0x for 10445-done@debbugs.gnu.org; Fri, 27 Jan 2012 16:42:35 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RqtYJ-0006pb-Hu; Fri, 27 Jan 2012 16:41:47 -0500 From: Glenn Morris To: 10445-done@debbugs.gnu.org Subject: Re: bug#10445: 24.0.92; patch: dired.el: mark files by regexp References: <87ty48sf83.fsf@pusto.de> X-Spook: mania Ft. Bragg bluebird Albania freedom bomb X-Ran: s (Eduard Wiebe's message of "Fri, 06 Jan 2012 22:17:32 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10445-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Version: 24.0.93 Thank you; applied. ------------=_1327700582-21235-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jan 2012 21:24:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjHHE-0002Mz-TY for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:24:41 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjHHC-0002Mn-Kb for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:24:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjHDg-0002ro-0L for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:21:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:32894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjHDf-0002rk-V8 for submit@debbugs.gnu.org; Fri, 06 Jan 2012 16:20:59 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjHDf-0003DD-3b for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 16:20:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjHDd-0002rT-WB for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 16:20:59 -0500 Received: from wp093.webpack.hosteurope.de ([80.237.132.100]:46845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjHDd-0002rN-Rk for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 16:20:57 -0500 Received: from g227150182.adsl.alicedsl.de ([92.227.150.182] helo=nirvana); authenticated by wp093.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1RjHDa-0004Br-Vl; Fri, 06 Jan 2012 22:20:55 +0100 Received: from ew by nirvana with local (Exim 4.72) (envelope-from ) id 1RjHAK-0000ql-Ba for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2012 22:17:32 +0100 From: Eduard Wiebe To: bug-gnu-emacs@gnu.org Subject: 24.0.92; patch: dired.el: mark files by regexp Date: Fri, 06 Jan 2012 22:17:32 +0100 Message-ID: <87ty48sf83.fsf@pusto.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-bounce-key: webpack.hosteurope.de;ew@pusto.de;1325884857;ab7c323f; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.8 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --=-=-= Content-Type: text/plain Hi all, i want to suggest this simple patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dired.el.patch diff -r 068c58b8caca lisp/dired.el --- a/lisp/dired.el Thu Jan 05 09:03:42 2012 +0100 +++ b/lisp/dired.el Thu Jan 05 09:07:14 2012 +0100 @@ -3103,8 +3103,8 @@ (dired-mark-if (and (not (looking-at dired-re-dot)) (not (eolp)) ; empty line - (let ((fn (dired-get-filename nil t))) - (and fn (string-match regexp (file-name-nondirectory fn))))) + (let ((fn (dired-get-filename t t))) + (and fn (string-match regexp fn)))) "matching file"))) (defun dired-mark-files-containing-regexp (regexp &optional marker-char) --=-=-= Content-Type: text/plain With this patch i am able to mark entries in dired buffer even when these contain directory parts. (Try `find-dired' in emacs.bzr/trunk/test and mark all entries files in "automated/" entries.) -- Eduard Wiebe --=-=-=-- ------------=_1327700582-21235-1--