From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 17:16:57 2012 Received: (at submit) by debbugs.gnu.org; 5 Jan 2012 22:16:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RivcF-0006YW-DI for submit@debbugs.gnu.org; Thu, 05 Jan 2012 17:16:57 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RivcD-0006YO-Tj for submit@debbugs.gnu.org; Thu, 05 Jan 2012 17:16:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RivYm-0006ZQ-I6 for submit@debbugs.gnu.org; Thu, 05 Jan 2012 17:13:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:56036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RivYm-0006ZM-Cr for submit@debbugs.gnu.org; Thu, 05 Jan 2012 17:13:20 -0500 Received: from eggs.gnu.org ([140.186.70.92]:38901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RivYl-0001eu-DA for bug-automake@gnu.org; Thu, 05 Jan 2012 17:13:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RivYk-0006Z4-Bw for bug-automake@gnu.org; Thu, 05 Jan 2012 17:13:19 -0500 Received: from mail.lysator.liu.se ([130.236.254.3]:58344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RivYk-0006Yx-5G for bug-automake@gnu.org; Thu, 05 Jan 2012 17:13:18 -0500 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id DB55B40004 for ; Thu, 5 Jan 2012 23:13:16 +0100 (CET) Received: from [192.168.0.150] (h57n3fls301o1095.telia.com [81.230.178.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id C1DC640003 for ; Thu, 5 Jan 2012 23:13:16 +0100 (CET) Message-ID: <4F062082.3030203@lysator.liu.se> Date: Thu, 05 Jan 2012 23:13:22 +0100 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: The testsuite assumes that ln -s really creates a symlink Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Hi! "ln -s" on MSYS does not create a symlink, instead it makes a regular copy. Lots of test cases (on master) FAIL due to this. "test -h foo" will simply not return success on MSYS, ever. Affected tests (that I have noticed): add-missing.tap (lots of failing test cases) copy.test Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 04:55:45 2012 Received: (at control) by debbugs.gnu.org; 8 Jan 2012 09:55:45 +0000 Received: from localhost ([127.0.0.1]:49467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjpTc-0005Bc-Ts for submit@debbugs.gnu.org; Sun, 08 Jan 2012 04:55:45 -0500 Received: from mail-ey0-f172.google.com ([209.85.215.172]:47927) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjpTb-0005BP-9F for control@debbugs.gnu.org; Sun, 08 Jan 2012 04:55:43 -0500 Received: by eaak10 with SMTP id k10so1675981eaa.3 for ; Sun, 08 Jan 2012 01:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=97vHw8ZyrjtdQNptTnwPIyR9B9H76qB/OyKj79irZHQ=; b=hBXdjrPLbGaRSWDULapbXWuMKH1Bz0lvby1bB+UmQwJEny5D3DCsreXE1NVK/N3Pl+ ZXU5waoGOqLevb3ZM+qMDxBU9ktn0ZS6QHEaRMPlpe8N2Y5PQzFwm4wMAY+AoTQhqBLK zSZG4CrRv4VGBVvQ0UVp1lq5ELlPJC8xJktNk= Received: by 10.213.27.15 with SMTP id g15mr768737ebc.143.1326016530273; Sun, 08 Jan 2012 01:55:30 -0800 (PST) Received: from [82.56.38.65] (host65-38-dynamic.56-82-r.retail.telecomitalia.it. [82.56.38.65]) by mx.google.com with ESMTPS id q67sm212578319eea.8.2012.01.08.01.55.29 (version=SSLv3 cipher=OTHER); Sun, 08 Jan 2012 01:55:29 -0800 (PST) Message-ID: <4F096810.8040009@gmail.com> Date: Sun, 08 Jan 2012 10:55:28 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) severity 10371 important severity 8753 important severity 10441 important severity 10128 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 07:56:56 2012 Received: (at 10441) by debbugs.gnu.org; 8 Jan 2012 12:56:56 +0000 Received: from localhost ([127.0.0.1]:49611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjsIx-0004qJ-MN for submit@debbugs.gnu.org; Sun, 08 Jan 2012 07:56:56 -0500 Received: from mail-ey0-f172.google.com ([209.85.215.172]:36405) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjsIv-0004q4-Hm for 10441@debbugs.gnu.org; Sun, 08 Jan 2012 07:56:54 -0500 Received: by eaak10 with SMTP id k10so1715611eaa.3 for <10441@debbugs.gnu.org>; Sun, 08 Jan 2012 04:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=MNEkuS+7TSlPB6GCKrHIYZw+9li0YTJ1kT2ho2a8Iyk=; b=YNw/NAdv5eJeQpnTSOZ+Wh6UDaQ5KyNU9hfHmYzzH4lEL9Ww3CZWXIoLFjV6qQj6Uh 20AhivRVck4Ms0NEb6R6MTO0acwiLxaL0dKDxJ7CT89xoWLSlMsoCrd2ssxqQ7WC9XQL Uc9wXrmKlAK7Z64OdtrF5rupVKrB9EdH1UFEo= Received: by 10.213.32.76 with SMTP id b12mr2523498ebd.6.1326027399600; Sun, 08 Jan 2012 04:56:39 -0800 (PST) Received: from [82.56.38.65] (host65-38-dynamic.56-82-r.retail.telecomitalia.it. [82.56.38.65]) by mx.google.com with ESMTPS id y12sm275296253eeb.11.2012.01.08.04.56.38 (version=SSLv3 cipher=OTHER); Sun, 08 Jan 2012 04:56:39 -0800 (PST) Message-ID: <4F099284.4090400@gmail.com> Date: Sun, 08 Jan 2012 13:56:36 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#10441: The testsuite assumes that ln -s really creates a symlink References: <4F062082.3030203@lysator.liu.se> In-Reply-To: <4F062082.3030203@lysator.liu.se> Content-Type: multipart/mixed; boundary="------------050100030706060406010301" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10441 Cc: 10441@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------050100030706060406010301 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 01/05/2012 11:13 PM, Peter Rosin wrote: > Hi! > Hi Peter, thanks for the report. > "ln -s" on MSYS does not create a symlink, instead it makes a > regular copy. Lots of test cases (on master) FAIL due to this. > > "test -h foo" will simply not return success on MSYS, ever. > > Affected tests (that I have noticed): > add-missing.tap (lots of failing test cases) > copy.test > The attached patch should take care of the problem. Tested using this script in PATH as the `ln' program: #!/bin/bash declare -a args=() for i in "$@"; do test x"$i" = x"-s" && continue args=("${args[@]}" "$i") done exec /bin/ln "${args[@]}" I will push after your ACK or in 48 hours, whichever comes first. Regards, Stefano --------------050100030706060406010301 Content-Type: text/x-diff; name="0001-tests-avoid-many-spurious-failures-on-MSYS-due-to-la.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-tests-avoid-many-spurious-failures-on-MSYS-due-to-la.pa"; filename*1="tch" >From 7fe475b6ef6dd3e55f609e80f4c203d99c3890c5 Mon Sep 17 00:00:00 2001 Message-Id: <7fe475b6ef6dd3e55f609e80f4c203d99c3890c5.1326027223.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Sun, 8 Jan 2012 13:36:46 +0100 Subject: [PATCH] tests: avoid many spurious failures on MSYS due to lack of symlinks Fixes automake bug#10441. * tests/add-missing.tap: Do not assume the system supports real symlinks, as this is not the case for MinGW/MSYS. Skip checks that would spuriously fail in that situation. * tests/copy.test: Likewise. Reported by Peter Rosin. --- tests/add-missing.tap | 39 ++++++++++++++++++++++++++++----------- tests/copy.test | 29 +++++++++++++++++++++-------- 2 files changed, 49 insertions(+), 19 deletions(-) diff --git a/tests/add-missing.tap b/tests/add-missing.tap index 36f7676..4f5d682 100755 --- a/tests/add-missing.tap +++ b/tests/add-missing.tap @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2011 Free Software Foundation, Inc. +# Copyright (C) 2011, 2012 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -36,6 +36,16 @@ else am_diff=diff fi +# MinGW/MSYS lacks real symlinks, so we'll have to skip some checks +# on that system. More details below. +echo dummy > foo +if ln -s foo bar && test -h bar; then + have_true_symlinks=yes +else + have_true_symlinks=no +fi +rm -f foo bar + cat > configure.stub << END AC_INIT([$me], [1.0]) AC_CONFIG_AUX_DIR([$build_aux]) @@ -195,19 +205,26 @@ check_ () "$pfx all and only expected files installed" \ $am_diff files.exp files.got # The files should be copied by `--copy' and symlinked otherwise. + # But these checks make no sense on systems like MSYS/MinGW where + # there are no true symlinks ('ln -s' behaves like 'cp -p'), so be + # ready to skip the checks in that case. See automake bug#10441. for f in $files; do - if test -h $build_aux/$f; then - is_symlink=yes + if test $have_true_symlinks = no; then + skip_ -r "system lacks true symlinks" "$pfx $f is a symlink or not" else - is_symlink=no + if test -h $build_aux/$f; then + is_symlink=yes + else + is_symlink=no + fi + case $action,$is_symlink in + link,yes) ok_ "$pfx $f has been symlinked" ;; + link,no) not_ok_ "$pfx $f has not been symlinked" ;; + copy,yes) not_ok_ "$pfx $f has been symlinked" ;; + copy,no) ok_ "$pfx $f has not been symlinked" ;; + *) fatal_ "invalid condition in case" ;; + esac fi - case $action,$is_symlink in - link,yes) ok_ "$pfx $f has been symlinked" ;; - link,no) not_ok_ "$pfx $f has not been symlinked" ;; - copy,yes) not_ok_ "$pfx $f has been symlinked" ;; - copy,no) ok_ "$pfx $f has not been symlinked" ;; - *) fatal_ "invalid condition in case" ;; - esac done # Now that the required auxiliary files have been installed, automake # should not complain anymore even if the `--add-missing' option is diff --git a/tests/copy.test b/tests/copy.test index 8ad3f2a..d8aa090 100755 --- a/tests/copy.test +++ b/tests/copy.test @@ -1,6 +1,6 @@ #! /bin/sh -# Copyright (C) 1999, 2001, 2002, 2010, 2011 Free Software Foundation, -# Inc. +# Copyright (C) 1999, 2001, 2002, 2010, 2011, 2012 Free Software +# Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -20,6 +20,19 @@ . ./defs || Exit 1 +# We'll have to cater to systems like MSYS/MinGW where there are no +# true symlinks ('ln -s' behaves like 'cp -p'); see automake bug#10441. + +echo dummy > foo +if ln -s foo bar && test -h bar; then + is_symlink () { test -h "$1"; } + is_not_symlink () { test ! -h "$1"; } +else + is_symlink () { return 0; } # Avoid spurious failures. + is_not_symlink () { return 0; } +fi +rm -f foo bar + # First a simple test, where the auxdir is automatically determined # by automake. @@ -31,7 +44,7 @@ $AUTOMAKE -c -a ls -l # For debugging. test -f install-sh -test ! -h install-sh +is_not_symlink install-sh # Let's do a couple of more elaborated tests, this time with the auxdir # explicitly defined in configure.in. @@ -62,9 +75,9 @@ echo FAKE-DEPCOMP > auxdir/depcomp $AUTOMAKE -a ls -l auxdir # For debugging. test -f auxdir/install-sh -test -h auxdir/install-sh +is_symlink auxdir/install-sh test -f auxdir/depcomp -test ! -h auxdir/depcomp +is_not_symlink auxdir/depcomp test FAKE-DEPCOMP = `cat auxdir/depcomp` # `automake -a -c' should not create symlinks, even when there are @@ -79,11 +92,11 @@ cd .. $AUTOMAKE -a -c ls -l auxdir # For debugging. test -f auxdir/install-sh -test -h auxdir/install-sh +is_symlink auxdir/install-sh test -f auxdir/missing -test -h auxdir/missing +is_symlink auxdir/missing test -f auxdir/depcomp -test ! -h auxdir/depcomp +is_not_symlink auxdir/depcomp diff "$am_scriptdir"/depcomp auxdir/depcomp : -- 1.7.7.3 --------------050100030706060406010301-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 10:49:29 2012 Received: (at 10441) by debbugs.gnu.org; 8 Jan 2012 15:49:29 +0000 Received: from localhost ([127.0.0.1]:50183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rjuzw-0000Uj-N3 for submit@debbugs.gnu.org; Sun, 08 Jan 2012 10:49:28 -0500 Received: from mail.lysator.liu.se ([130.236.254.3]:43339) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rjuzt-0000UW-IF for 10441@debbugs.gnu.org; Sun, 08 Jan 2012 10:49:27 -0500 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id DF3B440006; Sun, 8 Jan 2012 16:49:13 +0100 (CET) Received: from [192.168.0.150] (h57n3fls301o1095.telia.com [81.230.178.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id A3B0340005; Sun, 8 Jan 2012 16:49:13 +0100 (CET) Message-ID: <4F09BAF9.1080400@lysator.liu.se> Date: Sun, 08 Jan 2012 16:49:13 +0100 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#10441: The testsuite assumes that ln -s really creates a symlink References: <4F062082.3030203@lysator.liu.se> <4F099284.4090400@gmail.com> In-Reply-To: <4F099284.4090400@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10441 Cc: 10441@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefano Lattarini skrev 2012-01-08 13:56: > On 01/05/2012 11:13 PM, Peter Rosin wrote: >> Hi! >> > Hi Peter, thanks for the report. > >> "ln -s" on MSYS does not create a symlink, instead it makes a >> regular copy. Lots of test cases (on master) FAIL due to this. >> >> "test -h foo" will simply not return success on MSYS, ever. >> >> Affected tests (that I have noticed): >> add-missing.tap (lots of failing test cases) >> copy.test >> > The attached patch should take care of the problem. Tested using > this script in PATH as the `ln' program: > > #!/bin/bash > declare -a args=() > for i in "$@"; do > test x"$i" = x"-s" && continue > args=("${args[@]}" "$i") > done > exec /bin/ln "${args[@]}" > > I will push after your ACK or in 48 hours, whichever comes first. add-missing.tap: 351 PASS, 50 skip copy.test: PASS Thanks! Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 11:08:10 2012 Received: (at submit) by debbugs.gnu.org; 8 Jan 2012 16:08:10 +0000 Received: from localhost ([127.0.0.1]:50227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjvI1-0000vb-He for submit@debbugs.gnu.org; Sun, 08 Jan 2012 11:08:10 -0500 Received: from eggs.gnu.org ([140.186.70.92]:35668) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjvHz-0000vQ-66 for submit@debbugs.gnu.org; Sun, 08 Jan 2012 11:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjvHk-0000E8-LC for submit@debbugs.gnu.org; Sun, 08 Jan 2012 11:07:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:35550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjvHk-0000E2-Jd for submit@debbugs.gnu.org; Sun, 08 Jan 2012 11:07:52 -0500 Received: from eggs.gnu.org ([140.186.70.92]:57928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjvHj-0005qR-Rl for bug-automake@gnu.org; Sun, 08 Jan 2012 11:07:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjvHj-0000DV-1t for bug-automake@gnu.org; Sun, 08 Jan 2012 11:07:51 -0500 Received: from mail-qw0-f48.google.com ([209.85.216.48]:61901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjvHi-0000DP-UO for bug-automake@gnu.org; Sun, 08 Jan 2012 11:07:51 -0500 Received: by qadc16 with SMTP id c16so1980255qad.0 for ; Sun, 08 Jan 2012 08:07:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=4sQ/dnTXdEtNuGJKTTTWEpdfuH37lJSOYd3l11Qwqok=; b=QFzj51SYnFmRRS82AUTZ2XjB/LCotcT+Jm82byFIrD2TDS4UxvKl3lgb1yG6FMJ2XS jjNUCYY+je7EncyD+Zk1hYy/aE5WoJAIgJYJr1ZFAwrjSSjkYEG2sO+Z42I4fMyEuYyB uJdfKFknlC4EafgS9W+GZjo+NCzuBJWY2kZ9o= Received: by 10.224.184.79 with SMTP id cj15mr3931120qab.78.1326038869852; Sun, 08 Jan 2012 08:07:49 -0800 (PST) Received: from [192.168.1.102] (c-69-255-224-25.hsd1.md.comcast.net. [69.255.224.25]) by mx.google.com with ESMTPS id hv20sm136802855qab.22.2012.01.08.08.07.48 (version=SSLv3 cipher=OTHER); Sun, 08 Jan 2012 08:07:48 -0800 (PST) Message-ID: <4F09BF12.6080005@gmail.com> Date: Sun, 08 Jan 2012 11:06:42 -0500 From: Peter Johansson User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.2.24) Gecko/20111103 Thunderbird/3.1.16 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: Re: bug#10441: The testsuite assumes that ln -s really creates a symlink References: <4F062082.3030203@lysator.liu.se> <4F099284.4090400@gmail.com> In-Reply-To: <4F099284.4090400@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On 1/8/12 7:56 AM, Stefano Lattarini wrote: > > > The attached patch should take care of the problem. Tested using > this script in PATH as the `ln' program: Hi Stefano, I'm just curious if there is a reason not to use AC_PROG_LN_S as provided by Autoconf. I thought one could call that macro in Autoconf and place a line LN_S=@LN_S@ in 'defs.in' and then replace all 'ln -s' with '$LN_S' in tests. In that way you avoid having another script to maintain. Am I missing something? Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 11:58:23 2012 Received: (at 10441) by debbugs.gnu.org; 8 Jan 2012 16:58:23 +0000 Received: from localhost ([127.0.0.1]:50241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rjw4d-00022p-IU for submit@debbugs.gnu.org; Sun, 08 Jan 2012 11:58:23 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]:40947) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rjw4b-00022d-Iw for 10441@debbugs.gnu.org; Sun, 08 Jan 2012 11:58:22 -0500 Received: by eekc14 with SMTP id c14so2425617eek.3 for <10441@debbugs.gnu.org>; Sun, 08 Jan 2012 08:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=890SOqhDmMfv+SX/sLB3VyCZWlB9bklk/cjJ86T51Tg=; b=DIGlGdKavYoTOMoRoioW5UaqUufxu41bRBykXmioIPQZgdHcsdB/QkG94b6cIdZTXU hsLZ6/QsP+B85Qs/msS1GKbxpIsyugwdt65Fnx/hMXfYTknDXOMzR9fWvw61J86MqMLV icsvNicARYrbBG84d87BFvnchdmCykehCZMI4= Received: by 10.213.26.197 with SMTP id f5mr2647407ebc.143.1326041886873; Sun, 08 Jan 2012 08:58:06 -0800 (PST) Received: from [87.5.99.141] (host141-99-dynamic.5-87-r.retail.telecomitalia.it. [87.5.99.141]) by mx.google.com with ESMTPS id q67sm217248065eea.8.2012.01.08.08.58.05 (version=SSLv3 cipher=OTHER); Sun, 08 Jan 2012 08:58:06 -0800 (PST) Message-ID: <4F09CB16.2060203@gmail.com> Date: Sun, 08 Jan 2012 17:57:58 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Johansson Subject: Re: bug#10441: The testsuite assumes that ln -s really creates a symlink References: <4F062082.3030203@lysator.liu.se> <4F099284.4090400@gmail.com> <4F09BF12.6080005@gmail.com> In-Reply-To: <4F09BF12.6080005@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10441 Cc: 10441@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 01/08/2012 05:06 PM, Peter Johansson wrote: > On 1/8/12 7:56 AM, Stefano Lattarini wrote: >> >> >> The attached patch should take care of the problem. Tested using >> this script in PATH as the `ln' program: > > Hi Stefano, > Hi Peter. > I'm just curious if there is a reason not to use AC_PROG_LN_S as provided > by Autoconf. > > I thought one could call that macro in Autoconf and place a line > > LN_S=@LN_S@ > > in 'defs.in' and then replace all 'ln -s' with '$LN_S' in tests. > Ah, but the "ln -s" in the testsuite are used only in places where we want *real* symlinks (and want to skip some tests if they are not available), so using $LN_S would quite defy the purpose. > In that way you avoid having another script to maintain. > Oh, don't worry: that script was only a temporary hack to allow me testing the patch on GNU/Linux, since I don't have easy access to a MinGW system. It has already been deleted and forgotten. Sorry if I haven't been clear. > Am I missing something? > I hope the above clarifies your doubts. Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 12:06:19 2012 Received: (at 10441) by debbugs.gnu.org; 8 Jan 2012 17:06:19 +0000 Received: from localhost ([127.0.0.1]:50255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjwCJ-0002F9-3M for submit@debbugs.gnu.org; Sun, 08 Jan 2012 12:06:19 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]:48293) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjwCG-0002Es-5r; Sun, 08 Jan 2012 12:06:17 -0500 Received: by eekc14 with SMTP id c14so2429838eek.3 for ; Sun, 08 Jan 2012 09:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=pwCAGnVgnaeAOTllL/XVRz6EqXBX1EpSBfeSNHRs1kw=; b=wcrsUtOPVAjqIps4NEqPWv1TMDvRf1pO//HQQq1oJnlfV0PLU+f4SK/6Plc/TEJJsH hIvhkvgz8+g3s8HBQrByEkpGIMvopiuBI6+HAonZuNVmdyBwvqa/iFfm5YGpUipVP/Zz 4l6hN37eeUdapWhYtx2iBMQhrTjI5Z5HzYEBs= Received: by 10.14.126.80 with SMTP id a56mr5145500eei.121.1326042361216; Sun, 08 Jan 2012 09:06:01 -0800 (PST) Received: from [87.5.99.141] (host141-99-dynamic.5-87-r.retail.telecomitalia.it. [87.5.99.141]) by mx.google.com with ESMTPS id 76sm279192580eeh.0.2012.01.08.09.06.00 (version=SSLv3 cipher=OTHER); Sun, 08 Jan 2012 09:06:00 -0800 (PST) Message-ID: <4F09CCF7.50903@gmail.com> Date: Sun, 08 Jan 2012 18:05:59 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#10441: The testsuite assumes that ln -s really creates a symlink References: <4F062082.3030203@lysator.liu.se> <4F099284.4090400@gmail.com> <4F09BAF9.1080400@lysator.liu.se> In-Reply-To: <4F09BAF9.1080400@lysator.liu.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10441 Cc: 10441@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 10441 patch close 10441 thanks On 01/08/2012 04:49 PM, Peter Rosin wrote: > > add-missing.tap: 351 PASS, 50 skip > copy.test: PASS > > Thanks! > Good! Patch pushed, and bug report closed. Thanks again for all the testing, Stefano From unknown Wed Jun 25 03:53:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Feb 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator