From unknown Wed Jun 25 09:09:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10440 <10440@debbugs.gnu.org> To: bug#10440 <10440@debbugs.gnu.org> Subject: Status: Can't locate TAP/Parser.pm Reply-To: bug#10440 <10440@debbugs.gnu.org> Date: Wed, 25 Jun 2025 16:09:45 +0000 retitle 10440 Can't locate TAP/Parser.pm reassign 10440 automake submitter 10440 Peter Rosin severity 10440 normal tag 10440 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 16:58:30 2012 Received: (at submit) by debbugs.gnu.org; 5 Jan 2012 21:58:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RivKQ-000680-4h for submit@debbugs.gnu.org; Thu, 05 Jan 2012 16:58:30 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RivKN-00067s-7O for submit@debbugs.gnu.org; Thu, 05 Jan 2012 16:58:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RivGw-0003uA-1N for submit@debbugs.gnu.org; Thu, 05 Jan 2012 16:54:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:41804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RivGv-0003u6-WA for submit@debbugs.gnu.org; Thu, 05 Jan 2012 16:54:54 -0500 Received: from eggs.gnu.org ([140.186.70.92]:39366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RivGu-0007F4-Si for bug-automake@gnu.org; Thu, 05 Jan 2012 16:54:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RivGt-0003tm-1M for bug-automake@gnu.org; Thu, 05 Jan 2012 16:54:52 -0500 Received: from mail.lysator.liu.se ([130.236.254.3]:36347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RivGs-0003tL-Gs for bug-automake@gnu.org; Thu, 05 Jan 2012 16:54:50 -0500 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id F12E540004 for ; Thu, 5 Jan 2012 22:54:46 +0100 (CET) Received: from [192.168.0.150] (h57n3fls301o1095.telia.com [81.230.178.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id C574B40003 for ; Thu, 5 Jan 2012 22:54:46 +0100 (CET) Message-ID: <4F061C2C.7000505@lysator.liu.se> Date: Thu, 05 Jan 2012 22:54:52 +0100 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: Can't locate TAP/Parser.pm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Hi! I tried make check on MSYS with the current master, and among other things, this problem stands out as it FAILs so many test cases. I'm using tap-bailout-w.test as an example, no use reporting the same problem 80+ times, right :-) The perl version is 5.8.8 Here's tap-bailout-w.log: ./tap-bailout-w.test: will source ./tap-bailout.test Running from installcheck: no Using TAP: no PATH = /home/peda/automake/tests:/c/Program Files (x86)/Microsoft F#/v4.0/:/c/Program Files (x86)/Microsoft Visual Studio 10.0/VSTSDB/Deploy:/c/Program Files (x86)/Microsoft Visual Studio 10.0/Common7/IDE/:/c/Program Files (x86)/Microsoft Visual Studio 10.0/VC/BIN:/c/Program Files (x86)/Microsoft Visual Studio 10.0/Common7/Tools/:/c/Windows/Microsoft.NET/Framework/v4.0.30319:/c/Windows/Microsoft.NET/Framework/v3.5:/c/Program Files (x86)/Microsoft Visual Studio 10.0/VC/VCPackages:/c/Program Files (x86)/HTML Help Workshop:/c/Program Files (x86)/Microsoft Visual Studio 10.0/Team Tools/Performance Tools:/c/Program Files (x86)/Microsoft SDKs/Windows/v7.0A/bin/NETFX 4.0 Tools:.:/usr/local/bin:/mingw/bin:/bin:/c/Program Files/Common Files/Microsoft Shared/Windows Live:/c/Program Files (x86)/Common Files/Microsoft Shared/Windows Live:/c/Windows/system32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0/ +++ pwd /home/peda/automake/tests/tap-bailout-w.dir ++ . /home/peda/automake/tests/tap-setup.sh +++ test -f ../defs-static +++ test -f ../defs +++ test '!' -f Makefile.am +++ test -d ../tap-common-setup.dir +++ cp -Rp ../tap-common-setup.dir/Makefile ../tap-common-setup.dir/Makefile.am ../tap-common-setup.dir/Makefile.in ../tap-common-setup.dir/aclocal.m4 ../tap-common-setup.dir/config.log ../tap-common-setup.dir/config.status ../tap-common-setup.dir/configure ../tap-common-setup.dir/configure.in ../tap-common-setup.dir/depcomp ../tap-common-setup.dir/install-sh ../tap-common-setup.dir/missing . +++ fetch_tap_driver +++ case $am_tap_implementation in +++ sed '1s|#!.*|#! /bin/perl -w|' /home/peda/automake/lib/tap-driver.pl +++ chmod a+x tap-driver +++ sed 10q tap-driver #! /bin/perl -w # Copyright (C) 2011 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2, or (at your option) # any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of +++ test -f Makefile.am~ +++ : ++ : ++ cat ++ cat ++ cat ++ cat ++ cat ++ cat ++ cat ++ echo 'ERROR: d.test - Bail out! mktemp -d: Permission denied' ++ cat ++ echo 'ERROR: e.test - Bail out!' ++ test_counts='total=12 pass=3 fail=1 xpass=1 xfail=1 skip=1 error=5' ++ TESTS='a.test b.test c.test d.test e.test' ++ make -e check Can't locate TAP/Parser.pm in @INC (@INC contains: /usr/lib/perl5/5.8/msys /usr/lib/perl5/5.8 /usr/lib/perl5/site_perl/5.8/msys /usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/vendor_perl/5.8/msys /usr/lib/perl5/vendor_perl/5.8 /usr/lib/perl5/vendor_perl/5.8 .) at ./tap-driver line 33. BEGIN failed--compilation aborted at ./tap-driver line 33. make[2]: *** [a.log] Error 2 make[1]: *** [check-TESTS] Error 2 make: *** [check-am] Error 2 ++ cat stdout make check-TESTS make[1]: Entering directory `/home/peda/automake/tests/tap-bailout-w.dir' make[2]: Entering directory `/home/peda/automake/tests/tap-bailout-w.dir' make[2]: Leaving directory `/home/peda/automake/tests/tap-bailout-w.dir' make[1]: Leaving directory `/home/peda/automake/tests/tap-bailout-w.dir' ++ count_test_results total=12 pass=3 fail=1 xpass=1 xfail=1 skip=1 error=5 ++ total=ERR ++ pass=ERR ++ fail=ERR ++ xpass=ERR ++ xfail=ERR ++ skip=ERR ++ error=ERR ++ eval total=12 pass=3 fail=1 xpass=1 xfail=1 skip=1 error=5 +++ total=12 +++ pass=3 +++ fail=1 +++ xpass=1 +++ xfail=1 +++ skip=1 +++ error=5 ++ /bin/grep -E -i '(total|x?pass|x?fail|skip|error)' stdout ++ : ++ rc=0 ++ set +e +++ grep -c '^PASS:' stdout ++ test 0 -eq 3 ++ rc=1 +++ grep -c '^XFAIL:' stdout ++ test 0 -eq 1 ++ rc=1 +++ grep -c '^SKIP:' stdout ++ test 0 -eq 1 ++ rc=1 +++ grep -c '^FAIL:' stdout ++ test 0 -eq 1 ++ rc=1 +++ grep -c '^XPASS:' stdout ++ test 0 -eq 1 ++ rc=1 +++ grep -c '^ERROR:' stdout ++ test 0 -eq 5 ++ rc=1 ++ grep '^# TOTAL: *12$' stdout ++ rc=1 ++ grep '^# PASS: *3$' stdout ++ rc=1 ++ grep '^# XFAIL: *1$' stdout ++ rc=1 ++ grep '^# SKIP: *1$' stdout ++ rc=1 ++ grep '^# FAIL: *1$' stdout ++ rc=1 ++ grep '^# XPASS: *1$' stdout ++ rc=1 ++ grep '^# ERROR: *5$' stdout ++ rc=1 ++ test 1 -eq 0 + exit_status=1 + set +e + cd /home/peda/automake/tests + test no = yes + case $am_explicit_skips in + test 1 -eq 0 + keep_testdirs=yes + am_keeping_testdirs + case $keep_testdirs in + return 0 + set +x tap-bailout-w: exit 1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 07:38:34 2012 Received: (at 10440) by debbugs.gnu.org; 6 Jan 2012 12:38:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rj945-0004BK-P8 for submit@debbugs.gnu.org; Fri, 06 Jan 2012 07:38:34 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rj943-0004BD-9r for 10440@debbugs.gnu.org; Fri, 06 Jan 2012 07:38:33 -0500 Received: by wgbdq10 with SMTP id dq10so1633223wgb.15 for <10440@debbugs.gnu.org>; Fri, 06 Jan 2012 04:34:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=zfq0yn1dyybcf6Z2iQ9FNYwGFPgXza7DFnEiAdvo3sg=; b=OY6DPXxx5r1LYvLlMHB/31ufkra2mu2QqFkaOHkamfVHYUl7JgsEnq5dyQsykmpPVs EOOLItnOZ9pYlfx34hE/pPvpSzGiI+jbOVJowRKHvvXn5b/Hl0hwuJrpyNwUOz54AXSV VIt/0dxqCy6sncJG+meU49oWUWbSXBR+fi+To= Received: by 10.180.19.6 with SMTP id a6mr889476wie.14.1325853294977; Fri, 06 Jan 2012 04:34:54 -0800 (PST) Received: from [87.0.103.105] (host105-103-dynamic.0-87-r.retail.telecomitalia.it. [87.0.103.105]) by mx.google.com with ESMTPS id fv13sm35943425wbb.21.2012.01.06.04.34.53 (version=SSLv3 cipher=OTHER); Fri, 06 Jan 2012 04:34:54 -0800 (PST) Message-ID: <4F06EA6B.6020709@gmail.com> Date: Fri, 06 Jan 2012 13:34:51 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#10440: Can't locate TAP/Parser.pm References: <4F061C2C.7000505@lysator.liu.se> In-Reply-To: <4F061C2C.7000505@lysator.liu.se> Content-Type: multipart/mixed; boundary="------------010902010403090209060501" X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 10440 Cc: automake-patches@gnu.org, 10440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) This is a multi-part message in MIME format. --------------010902010403090209060501 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 01/05/2012 10:54 PM, Peter Rosin wrote: > Hi! > Hi Peter, and thanks for your relentless testing on MinGW/MSYS. > I tried make check on MSYS with the current master, and among other > things, this problem stands out as it FAILs so many test cases. > > I'm using tap-bailout-w.test as an example, no use reporting the > same problem 80+ times, right :-) > > The perl version is 5.8.8 > > Here's tap-bailout-w.log: > > ./tap-bailout-w.test: will source ./tap-bailout.test > Running from installcheck: no > Using TAP: no > > [SNIP] > > ++ TESTS='a.test b.test c.test d.test e.test' > ++ make -e check > Can't locate TAP/Parser.pm in @INC (@INC contains: /usr/lib/perl5/5.8/msys /usr/lib/perl5/5.8 /usr/lib/perl5/site_perl/5.8/msys /usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/vendor_perl/5.8/msys /usr/lib/perl5/vendor_perl/5.8 /usr/lib/perl5/vendor_perl/5.8 .) at ./tap-driver line 33. > BEGIN failed--compilation aborted at ./tap-driver line 33. > make[2]: *** [a.log] Error 2 > make[1]: *** [check-TESTS] Error 2 > make: *** [check-am] Error 2 > Bummer. I had taken for granted that all perl installations modern enough to correctly run automake also came with a built-int TAP::Parser module -- but it seems this is not the case after all. Anyway, since the perl implementation of the TAP driver is meant to be used only for prototyping and consistency checks (the "real" TAP driver being the portable one implemented in awk), this is not a big deal, and we just need to skip the affected tests on systems lacking TAP::Parser. Could you verify that the attached patch solves the issue? I've tested it by putting a broken TAP::Parser early in @INC, so it should work; but as you know there is no substitute to testing with the "real thing". Thanks, Stefano --------------010902010403090209060501 Content-Type: text/x-diff; name="0001-tests-skip-tests-on-perl-TAP-driver-if-TAP-Parser-mo.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-tests-skip-tests-on-perl-TAP-driver-if-TAP-Parser-mo.pa"; filename*1="tch" >From 9cbc0a359cff1378d90f1bc71cff25ee616fa662 Mon Sep 17 00:00:00 2001 Message-Id: <9cbc0a359cff1378d90f1bc71cff25ee616fa662.1325853223.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Fri, 6 Jan 2012 12:39:24 +0100 Subject: [PATCH] tests: skip tests on perl TAP driver if TAP::Parser module not available Fixes automake bug#10440. * tests/defs (fetch_tap_driver): Skip the whole test case if the desired tap driver implementation is the perl one but the TAP::Parser module is unavailable. * tests/tap-bad-prog.tap: Adjust order of calls to `plan_' and `fetch_tap_driver', to ensure the test is not skipped after the TAP plan has been outputted (which would lead to a spurious error). * tests/tap-bad-signal.tap: Tweak to avoid the need to source the `tap-setup.sh' script, as that might cause a test skip too late, i.e., after a TAP plan has been already printed. * tests/tap-test-number-0.test: Do not force the test to skip when the tested TAP driver implementation is not the perl one. On the other hand, when it *is* the perl one, skip the test if the TAP::Parser module is unavailable. * tests/test-driver-cond.test: Skip the part of the test actually running "make check" if the TAP::Parser module is unavailable. * tests/get-sysconf.test: Also print the version of the `TAP::Parser' module, if available. Reported by Peter Rosin. --- tests/defs | 14 +++++++++----- tests/get-sysconf.test | 6 +++++- tests/tap-bad-prog.tap | 6 +++--- tests/tap-signal.tap | 15 +++++++++++++-- tests/tap-test-number-0.test | 40 ++++++++++++++++++++++------------------ tests/test-driver-cond.test | 5 ++++- 6 files changed, 56 insertions(+), 30 deletions(-) diff --git a/tests/defs b/tests/defs index 835788d..41ee262 100644 --- a/tests/defs +++ b/tests/defs @@ -1,8 +1,8 @@ # -*- shell-script -*- # # Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, -# 2005, 2006, 2007, 2008, 2009, 2010, 2011 Free Software Foundation, -# Inc. +# 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Free Software +# Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -602,12 +602,16 @@ fetch_tap_driver () # TODO: with /bin/sh, for better coverage. case $am_tap_implementation in perl) - sed "1s|#!.*|#! $PERL -w|" "$am_scriptdir"/tap-driver.pl ;; + $PERL -MTAP::Parser -e 1 \ + || skip_all_ "cannot import TAP::Parser perl module" + sed "1s|#!.*|#! $PERL -w|" "$am_scriptdir"/tap-driver.pl >tap-driver + ;; shell) - sed "1s|#!.*|#! $SHELL|" "$am_scriptdir"/tap-driver.sh ;; + sed "1s|#!.*|#! $SHELL|" "$am_scriptdir"/tap-driver.sh >tap-driver + ;; *) fatal_ "invalid \$am_tap_implementation '$am_tap_implementation'" ;; - esac > tap-driver \ + esac \ && chmod a+x tap-driver \ || framework_failure_ "couldn't fetch $am_tap_implementation TAP driver" sed 10q tap-driver # For debugging. diff --git a/tests/get-sysconf.test b/tests/get-sysconf.test index 039a436..789a015 100755 --- a/tests/get-sysconf.test +++ b/tests/get-sysconf.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2011 Free Software Foundation, Inc. +# Copyright (C) 2011, 2012 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -37,6 +37,10 @@ else ' "$top_testsrcdir"/ChangeLog || st=1 fi $PERL -V || st=1 +# It's OK for the user not to have the TAP::Parser module; this can +# happen with older perl installation, or on MinGW/MSYS. +$PERL -e 'use TAP::Parser; print $TAP::Parser::VERSION, "\n"' || : + cat "$top_testbuilddir/config.log" || st=1 cat "$testbuilddir/aclocal-$APIVERSION" || st=1 cat "$testbuilddir/automake-$APIVERSION" || st=1 diff --git a/tests/tap-bad-prog.tap b/tests/tap-bad-prog.tap index a59a1dc..212633f 100755 --- a/tests/tap-bad-prog.tap +++ b/tests/tap-bad-prog.tap @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2011 Free Software Foundation, Inc. +# Copyright (C) 2011, 2012 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -21,10 +21,10 @@ am_parallel_tests=yes . ./defs || Exit 1 -plan_ 5 - fetch_tap_driver +plan_ 5 + cat >> configure.in <> configure.in < Makefile.am << END +TEST_LOG_DRIVER = \$(srcdir)/tap-driver TEST_LOG_COMPILER = $PERL -w ## Will be updated later. TESTS = @@ -58,7 +65,11 @@ results_count=`ls *.test | wc -l | tr -d "$tab$sp"` chmod a+x *.test -. "$testsrcdir"/tap-setup.sh || fatal_ "sourcing tap-setup.sh" +$ACLOCAL +$AUTOCONF +$AUTOMAKE + +./configure signal_caught () { diff --git a/tests/tap-test-number-0.test b/tests/tap-test-number-0.test index 8a117ce..6e77a5d 100755 --- a/tests/tap-test-number-0.test +++ b/tests/tap-test-number-0.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2011 Free Software Foundation, Inc. +# Copyright (C) 2011, 2012 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -21,23 +21,27 @@ am_parallel_tests=yes . ./defs || Exit 1 -if $PERL -w -e ' - use warnings FATAL => "all"; use strict; - use TAP::Parser; - my $parser = TAP::Parser->new({tap => "1..1\n" . "ok 0\n"}); - my $result = $parser->next; - $result->is_plan or die "first line is not TAP plan"; - $result = $parser->next; - $result->is_test or die "second line is not TAP test result"; - my $testno = $result->number; - $parser->next and die "unexpected further TAP stream"; - exit ($testno == 0 ? 0 : 77); -'; then - : # Nothing to do. -elif test $? -eq 77; then - skip_ 'TAP::Parser bug: test number 0 gets relabelled as 1' -else - fatal_ "error analyzing TAP::Parser module for bugs" +if test $am_tap_implementation = perl; then + $PERL -MTAP::Parser -e 1 \ + || skip_ "cannot import TAP::Parser perl module" + if $PERL -w -e ' + use warnings FATAL => "all"; use strict; + use TAP::Parser; + my $parser = TAP::Parser->new({tap => "1..1\n" . "ok 0\n"}); + my $result = $parser->next; + $result->is_plan or die "first line is not TAP plan"; + $result = $parser->next; + $result->is_test or die "second line is not TAP test result"; + my $testno = $result->number; + $parser->next and die "unexpected further TAP stream"; + exit ($testno == 0 ? 0 : 77); + '; then + : # Nothing to do. + elif test $? -eq 77; then + skip_ 'TAP::Parser bug: test number 0 gets relabelled as 1' + else + fatal_ "error analyzing TAP::Parser module for bugs" + fi fi . "$testsrcdir"/tap-setup.sh || fatal_ "sourcing tap-setup.sh" diff --git a/tests/test-driver-cond.test b/tests/test-driver-cond.test index 3ed48a9..46986ff 100755 --- a/tests/test-driver-cond.test +++ b/tests/test-driver-cond.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2011 Free Software Foundation, Inc. +# Copyright (C) 2011, 2012 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -87,6 +87,9 @@ grep '^my_LOG_DRIVER *=' Makefile.in \ grep '^TEST_LOG_DRIVER =.*\$(SHELL).*/test-driver' Makefile.in +$PERL -MTAP::Parser -e 1 \ + || skip_ "cannot import TAP::Parser perl module" + ./configure do_count () -- 1.7.7.3 --------------010902010403090209060501-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 10:53:56 2012 Received: (at 10440) by debbugs.gnu.org; 6 Jan 2012 15:53:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjC79-0000Ee-LQ for submit@debbugs.gnu.org; Fri, 06 Jan 2012 10:53:56 -0500 Received: from mail.lysator.liu.se ([130.236.254.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjC75-0000EU-7a for 10440@debbugs.gnu.org; Fri, 06 Jan 2012 10:53:53 -0500 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 3C62E40022; Fri, 6 Jan 2012 16:50:13 +0100 (CET) Received: from [192.168.0.150] (h57n3fls301o1095.telia.com [81.230.178.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 00FB540012; Fri, 6 Jan 2012 16:50:12 +0100 (CET) Message-ID: <4F07183B.6010405@lysator.liu.se> Date: Fri, 06 Jan 2012 16:50:19 +0100 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#10440: Can't locate TAP/Parser.pm References: <4F061C2C.7000505@lysator.liu.se> <4F06EA6B.6020709@gmail.com> In-Reply-To: <4F06EA6B.6020709@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 10440 Cc: automake-patches@gnu.org, 10440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) Stefano Lattarini skrev 2012-01-06 13:34: > On 01/05/2012 10:54 PM, Peter Rosin wrote: >> Hi! >> > Hi Peter, and thanks for your relentless testing on MinGW/MSYS. > >> I tried make check on MSYS with the current master, and among other >> things, this problem stands out as it FAILs so many test cases. >> >> I'm using tap-bailout-w.test as an example, no use reporting the >> same problem 80+ times, right :-) *SNIP* > Could you verify that the attached patch solves the issue? I've tested > it by putting a broken TAP::Parser early in @INC, so it should work; but > as you know there is no substitute to testing with the "real thing". Yes, this works, loads of SKIPs instead of FAILs, as expected (but I haven't checked all tests in detail since there's still too much noise). Please push anyway as it's a huge improvement even if there is some minor perl-tap thing left behind, and thanks for the quick fix! Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 12:41:34 2012 Received: (at 10440) by debbugs.gnu.org; 6 Jan 2012 17:41:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjDnJ-0002fA-Uq for submit@debbugs.gnu.org; Fri, 06 Jan 2012 12:41:34 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjDnH-0002f3-Fq for 10440@debbugs.gnu.org; Fri, 06 Jan 2012 12:41:32 -0500 Received: by eekc14 with SMTP id c14so1580705eek.3 for <10440@debbugs.gnu.org>; Fri, 06 Jan 2012 09:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=fL3qVuhcLbsDn2EsTt1i/d/JSfk2patwi3+U4tFvN8g=; b=xSnkoCJzixQAx1mPr7ycZjwT+hDISnklEmTd++pYYu49bWAvEjWsMpibHEobXbMKB9 PQKAiklxUtYMnVffGtMMJrfHbCwDW4nYQx6F71ElH80or/0y+SFnIR5TRkky4luLW4lI KvzPJOAQthOvu+yFgngZ55KJ7JKRHe7rOT5+w= Received: by 10.213.12.194 with SMTP id y2mr1312248eby.136.1325871473781; Fri, 06 Jan 2012 09:37:53 -0800 (PST) Received: from [87.2.103.82] (host82-103-dynamic.2-87-r.retail.telecomitalia.it. [87.2.103.82]) by mx.google.com with ESMTPS id s16sm250366324eef.2.2012.01.06.09.37.51 (version=SSLv3 cipher=OTHER); Fri, 06 Jan 2012 09:37:51 -0800 (PST) Message-ID: <4F073162.4010506@gmail.com> Date: Fri, 06 Jan 2012 18:37:38 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#10440: Can't locate TAP/Parser.pm References: <4F061C2C.7000505@lysator.liu.se> <4F06EA6B.6020709@gmail.com> <4F07183B.6010405@lysator.liu.se> In-Reply-To: <4F07183B.6010405@lysator.liu.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 10440 Cc: automake-patches@gnu.org, 10440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On 01/06/2012 04:50 PM, Peter Rosin wrote: > Stefano Lattarini skrev 2012-01-06 13:34: >> On 01/05/2012 10:54 PM, Peter Rosin wrote: >>> Hi! >>> >> Hi Peter, and thanks for your relentless testing on MinGW/MSYS. >> >>> I tried make check on MSYS with the current master, and among other >>> things, this problem stands out as it FAILs so many test cases. >>> >>> I'm using tap-bailout-w.test as an example, no use reporting the >>> same problem 80+ times, right :-) > > *SNIP* > >> Could you verify that the attached patch solves the issue? I've tested >> it by putting a broken TAP::Parser early in @INC, so it should work; but >> as you know there is no substitute to testing with the "real thing". > > Yes, this works, loads of SKIPs instead of FAILs, as expected (but > I haven't checked all tests in detail since there's still too much > noise). Please push anyway as it's a huge improvement even if there > is some minor perl-tap thing left behind, and thanks for the quick > fix! > OK, I've pushed the patch with this improved commit message: tests: skip tests on perl TAP driver if TAP::Parser is not available We had so far taken for granted that all the perl installations modern enough to correctly run automake also came with a built-in TAP::Parser module; unfortunately, testing on MinGW/MSYS has shown that this is not always true, and that a lot of spurious testsuite failures would take place in such a situation (see automake bug#10440). Luckily, the perl implementation of the Automake TAP driver is only meant to be used for prototyping and consistency checks, the "real" Automake TAP driver being the portable one implemented in awk. So we can simply skip the affected tests on systems lacking TAP::Parser. * tests/defs (fetch_tap_driver): Skip the whole test case if the desired tap driver implementation is the perl one but the TAP::Parser module is unavailable. * tests/tap-bad-prog.tap: Adjust order of calls to `plan_' and `fetch_tap_driver', to ensure the test is not skipped after the TAP plan has been outputted (which would lead to a spurious error). * tests/tap-bad-signal.tap: Tweak to avoid the need to source the `tap-setup.sh' script, as that might cause a test skip too late, i.e., after a TAP plan has been already printed. * tests/tap-test-number-0.test: Do not force the test to skip when the tested TAP driver implementation is not the perl one. On the other hand, when it *is* the perl one, skip the test if the TAP::Parser module is unavailable. * tests/test-driver-cond.test: Skip the part of the test actually running "make check" if the TAP::Parser module is unavailable. * tests/get-sysconf.test: Also print the version of the `TAP::Parser' module, if available. Reported by Peter Rosin. Thanks for all the testing, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 13:05:24 2012 Received: (at control) by debbugs.gnu.org; 6 Jan 2012 18:05:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjEAN-0003DD-N7 for submit@debbugs.gnu.org; Fri, 06 Jan 2012 13:05:24 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RjEAK-0003D3-MX for control@debbugs.gnu.org; Fri, 06 Jan 2012 13:05:21 -0500 Received: by eekc14 with SMTP id c14so1597292eek.3 for ; Fri, 06 Jan 2012 10:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=HSGLjNAwBXhI8r+b1y6T3ue/WvhPV85ZtNDpzHqd8w4=; b=XFTcmxBQrcO+JrD8LdXAvKUgfLNJpJZ8ntL+O/WDjvzJH8VsHoTNcxLXOlsYon2mxr DZFXbhrhNfuiLPK90xbbmg6MahSkmk7rrDVy2wpnAHUHLrTD+tMIdN9V+zzFTsb0S0SI ORrDOS07ERBy2gS/tHXXyhERgrxDNlNyAt0bk= Received: by 10.14.99.76 with SMTP id w52mr2583060eef.85.1325872903114; Fri, 06 Jan 2012 10:01:43 -0800 (PST) Received: from [87.2.103.82] (host82-103-dynamic.2-87-r.retail.telecomitalia.it. [87.2.103.82]) by mx.google.com with ESMTPS id e12sm99835293eea.5.2012.01.06.10.01.41 (version=SSLv3 cipher=OTHER); Fri, 06 Jan 2012 10:01:42 -0800 (PST) Message-ID: <4F073703.2060703@gmail.com> Date: Fri, 06 Jan 2012 19:01:39 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) tags 10440 patch close 10440 thanks From unknown Wed Jun 25 09:09:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Feb 2012 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator