From unknown Sun Jun 22 07:53:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10437: parallel-tests: `recheck' recipe can cause sed to be invoked with too long input lines (was: Re: bug#10427: coreutils-8.14.116-1e18d: testsuite failures on NetBSD 5.1) Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 05 Jan 2012 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10437 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Paul Eggert Cc: 10437@debbugs.gnu.org, jim@meyering.net, 10427@debbugs.gnu.org X-Debbugs-Original-Cc: bug-automake@gnu.org, jim@meyering.net, 10427@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.132577265910703 (code B ref -1); Thu, 05 Jan 2012 14:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jan 2012 14:10:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rio1y-0002mZ-W4 for submit@debbugs.gnu.org; Thu, 05 Jan 2012 09:10:59 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rio1x-0002mO-35 for submit@debbugs.gnu.org; Thu, 05 Jan 2012 09:10:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RinyU-0000oF-ER for submit@debbugs.gnu.org; Thu, 05 Jan 2012 09:07:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:34555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RinyU-0000o4-AL for submit@debbugs.gnu.org; Thu, 05 Jan 2012 09:07:22 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RinyO-0004jA-Ex for bug-automake@gnu.org; Thu, 05 Jan 2012 09:07:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RinyI-0000mV-Ad for bug-automake@gnu.org; Thu, 05 Jan 2012 09:07:16 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:63678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RinyH-0000mC-U7 for bug-automake@gnu.org; Thu, 05 Jan 2012 09:07:10 -0500 Received: by werf1 with SMTP id f1so497256wer.0 for ; Thu, 05 Jan 2012 06:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=orcijTZ3ASjC0fUeMb7oFTaRfhQETkRGUYs43oYD2e8=; b=LKU+Ren3oat37Nbf1knGcw2+jrOkG/c0QnCko7fk3H7RlfUaURK4fRtfAzpFC5jl2/ hmIQtb5rQe7VypmpWhla5seDI/iu78PjJKPXzHv2faPz4cTfFeHOIFA1xYfNiYWf3eNp uTR9auvsPgouQq1LHRVuQxE7cpFrU2ooQeRl4= Received: by 10.180.90.179 with SMTP id bx19mr838629wib.1.1325772429211; Thu, 05 Jan 2012 06:07:09 -0800 (PST) Received: from [82.54.101.15] (host15-101-dynamic.54-82-r.retail.telecomitalia.it. [82.54.101.15]) by mx.google.com with ESMTPS id eu3sm32635542wib.6.2012.01.05.06.07.08 (version=SSLv3 cipher=OTHER); Thu, 05 Jan 2012 06:07:08 -0800 (PST) Message-ID: <4F05AE8A.1070105@gmail.com> Date: Thu, 05 Jan 2012 15:07:06 +0100 From: Stefano Lattarini MIME-Version: 1.0 References: <87aa64k902.fsf@rho.meyering.net> <4F033BB0.4090305@gmail.com> <4F0566B3.2030104@cs.ucla.edu> In-Reply-To: <4F0566B3.2030104@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) [adding bug-automake in CC:] Reference: Hi Paul, thanks for the report and diagnosis. On 01/05/2012 10:00 AM, Paul Eggert wrote: > The latest coreutils snapshot fail to build > >> On 01/03/2012 06:10 PM, Jim Meyering wrote: >>> FYI, here's a snapshot of what will soon be coreutils-8.15, >>> expected on Thursday or Friday. >>> >>> coreutils snapshot: >>> http://meyering.net/cu/coreutils-ss.tar.xz 5.2 MB >>> http://meyering.net/cu/coreutils-ss.tar.xz.sig >>> http://meyering.net/cu/coreutils-8.14.116-1e18d.tar.xz > > This snapshot doesn't build on Solaris 8 (sparc) with native tools, > for a couple of reasons. I don't expect Solaris 8 is an active > porting target any more, but these problems could well happen on > active targets. > I agree. > Second, there's code like this in tests/Makefile.in: > > @list='$(TEST_LOGS)'; \ > list=`for i in $$list; do \ > test .log = $$i || echo $$i; \ > done | tr '\012\015' ' '`; \ > list=`echo "$$list" | sed 's/ *$$//'`; \ > > This generates a long line and sends it to 'sed', > which complains "Output line too long." and outputs nothing. > And if I'm not mistaken, sed is allowed such a behaviour by POSIX, so this is a portability problem in automake. > This code is also generated by Automake. How about changing Automake > to generate something like this instead? > > @test_logs='$(TEST_LOGS)'; \ > list=; \ > for i in $$test_logs; do \ > test .log = "$$i" || list="$$list $$i"; \ > done; \ > > This avoids the business with echo and tr and ` sed and > avoids the sed limitation with long lines. > Good idea. I will followed your idea (with some tweaks). Patch coming up soon. > Automake does this latter sort of thing in about 4 places, > Which "sort of thing" exactly? I could find only one place which suffers of the problem you've pointed out, i.e., the `recheck recheck-html' rules in lib/am/check.am. Am I missing something? > and I figure it's done that way for a reason, but I don't > know what the reason is. > The comments in lib/am/check.am should be explicative enough. if not, that's a (minor) bug, so feel free to report it! Thanks, Stefano From unknown Sun Jun 22 07:53:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10437: parallel-tests: `recheck' recipe can cause sed to be invoked with too long input lines Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 05 Jan 2012 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10437 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Paul Eggert Cc: 10437@debbugs.gnu.org, automake-patches@gnu.org, 10427@debbugs.gnu.org Received: via spool by 10437-submit@debbugs.gnu.org id=B10437.132577485313969 (code B ref 10437); Thu, 05 Jan 2012 14:48:02 +0000 Received: (at 10437) by debbugs.gnu.org; 5 Jan 2012 14:47:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RiobM-0003dF-Jq for submit@debbugs.gnu.org; Thu, 05 Jan 2012 09:47:33 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RiobJ-0003d4-TF; Thu, 05 Jan 2012 09:47:31 -0500 Received: by wgbdq10 with SMTP id dq10so622246wgb.15 for ; Thu, 05 Jan 2012 06:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=98pvezTXs/0ZjR11zc5kWFo+BrwbuBkzZ5XlGeg8/Oo=; b=poWgELQsK6fR41Y05vCHsh9qFBRUrihEoeQI8nrKUWJkyf4+2jw3e6FmLr5TQfpJc7 LHrBvZlX8BnBg4IUV5KcTYp2+D3d/76ZF5LOYlKbiRnYxgwrbGlzZABjzR8dv4lIhM97 wJ08g2Bnae/eB9EMXeajLBW5VV/Svh8hEN6/4= Received: by 10.227.59.205 with SMTP id m13mr2002444wbh.28.1325774638203; Thu, 05 Jan 2012 06:43:58 -0800 (PST) Received: from [82.54.101.15] (host15-101-dynamic.54-82-r.retail.telecomitalia.it. [82.54.101.15]) by mx.google.com with ESMTPS id ba4sm43355324wib.5.2012.01.05.06.43.56 (version=SSLv3 cipher=OTHER); Thu, 05 Jan 2012 06:43:57 -0800 (PST) Message-ID: <4F05B72A.7050403@gmail.com> Date: Thu, 05 Jan 2012 15:43:54 +0100 From: Stefano Lattarini MIME-Version: 1.0 References: <87aa64k902.fsf@rho.meyering.net> <4F033BB0.4090305@gmail.com> <4F0566B3.2030104@cs.ucla.edu> <4F05AE8A.1070105@gmail.com> In-Reply-To: <4F05AE8A.1070105@gmail.com> Content-Type: multipart/mixed; boundary="------------060102070501050307070109" X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) This is a multi-part message in MIME format. --------------060102070501050307070109 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reference: On 01/05/2012 03:07 PM, Stefano Lattarini wrote: > > Patch coming up soon. > And here it is. I will push by this evening if there is no objection. Regards, Stefano --------------060102070501050307070109 Content-Type: text/x-diff; name="0001-parallel-tests-avoid-issue-with-overly-long-lines-in.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-parallel-tests-avoid-issue-with-overly-long-lines-in.pa"; filename*1="tch" >From e3b0e12400f5fa4220fc0aa79dd0989e56def9c6 Mon Sep 17 00:00:00 2001 Message-Id: From: Stefano Lattarini Date: Thu, 5 Jan 2012 15:13:30 +0100 Subject: [PATCH] parallel-tests: avoid issue with overly long lines in sed input See automake bug#10437: and coreutils bug#10427: * lib/am/check.am (recheck, recheck-html): In order to strip trailing whitespace from the definition of the `$list' variable, we used to invoke sed in a way that could cause it to get passed overly long input lines, causing spurious failures. So rework the logic of the recipe to avoid any sed invocation, relying on simpler shell idioms instead. (check-TESTS): Reorganize the recipe to be more similar to the one of `recheck', for consistency and simplicity. * NEWS: Update. Report and analysis by Paul Eggert. --- NEWS | 4 ++++ lib/am/check.am | 38 +++++++++++++++++++++----------------- 2 files changed, 25 insertions(+), 17 deletions(-) diff --git a/NEWS b/NEWS index 2e572e4..7e52d83 100644 --- a/NEWS +++ b/NEWS @@ -89,6 +89,10 @@ Bugs fixed in 1.11.0a: * Bugs introduced by 1.11: + - The parallel-tests harness doesn't trip anymore on sed implementations + with stricter limits on the length of input lines (problem seen at + least on Solaris 8). + - The `parallel-tests' test driver works around a GNU make 3.80 bug with trailing white space in the test list (`TESTS = foo $(EMPTY)'), and does not report spurious successes when used with concurrent FreeBSD diff --git a/lib/am/check.am b/lib/am/check.am index 3d0188d..29faa38 100644 --- a/lib/am/check.am +++ b/lib/am/check.am @@ -245,15 +245,16 @@ check-TESTS: ## OTOH, this means that, in the rule for `$(TEST_SUITE_LOG)', we ## cannot use `$?' to compute the set of lazily rerun tests, lest ## we rely on .PHONY to work portably. -## + @test -z "$(TEST_SUITE_LOG)" || rm -f $(TEST_SUITE_LOG) + @list='' list2='$(TEST_LOGS)'; for f in $$list2; do \ ## Trailing whitespace in `TESTS = foo.test $(empty)' causes GNU make ## 3.80 to erroneously expand $(TESTS_LOGS) to `foo.log .log'. ## Work around this bug. - @test -z "$(TEST_SUITE_LOG)" || rm -f $(TEST_SUITE_LOG) - @list='$(TEST_LOGS)'; \ - list=`for f in $$list; do \ - test .log = $$f || echo $$f; \ - done | tr '\012\015' ' '`; \ + test .log = $$f && continue; \ +## Be careful to avoid extra whitespace in the definition of $list. See +## comments in `recheck' below for why this might be useful. + if test -z "$$list"; then list=$$f; else list="$$list $$f"; fi; \ + done; \ $(MAKE) $(AM_MAKEFLAGS) $(TEST_SUITE_LOG) TEST_LOGS="$$list" AM_RECURSIVE_TARGETS += check @@ -298,17 +299,20 @@ AM_RECURSIVE_TARGETS += check-html ## Rerun all FAILed or XPASSed tests. recheck recheck-html: - @target=`echo $@ | sed 's,^re,,'`; \ - list='$(TEST_LOGS)'; \ - list=`for f in $$list; do \ - test -f $$f || continue; \ - if test -r $$f && read line < $$f; then \ - case $$line in FAIL*|XPASS*) echo $$f;; esac; \ - else echo $$f; fi; \ - done | tr '\012\015' ' '`; \ -## This apparently useless munging helps to avoid a nasty bug (a -## segmentation fault!) on Solaris XPG4 make. - list=`echo "$$list" | sed 's/ *$$//'`; \ + @target=`echo $@ | sed 's,^re,,'`; \ + list='' list2='$(TEST_LOGS)'; for f in $$list2; do \ + test -f $$f || continue; \ + if test -r $$f && read line < $$f; then \ + case $$line in FAIL*|XPASS*) : ;; *) continue;; esac; \ + fi; \ +## Be careful to avoid extra whitespace in the definition of $list, since +## its value will be passed to the recursive make invocation below through +## the TEST_LOGS macro, and leading/trailing white space in a make macro +## definition can be problematic. In this particular case, trailing white +## space was known to cause a segmentation fault on Solaris 10 XPG4 make: +## + if test -z "$$list"; then list=$$f; else list="$$list $$f"; fi; \ + done; \ $(MAKE) $(AM_MAKEFLAGS) $$target AM_MAKEFLAGS='$(AM_MAKEFLAGS) TEST_LOGS="'"$$list"'"' .PHONY: recheck recheck-html -- 1.7.7.3 --------------060102070501050307070109-- From unknown Sun Jun 22 07:53:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10437: parallel-tests: `recheck' recipe can cause sed to be invoked with too long input lines Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 05 Jan 2012 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10437 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Stefano Lattarini Cc: 10437@debbugs.gnu.org, jim@meyering.net, 10427@debbugs.gnu.org X-Debbugs-Original-Cc: bug-automake@gnu.org, jim@meyering.net, 10427@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13257870483205 (code B ref -1); Thu, 05 Jan 2012 18:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jan 2012 18:10:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rirm3-0000pc-QM for submit@debbugs.gnu.org; Thu, 05 Jan 2012 13:10:48 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rirm2-0000pW-5l for submit@debbugs.gnu.org; Thu, 05 Jan 2012 13:10:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ririb-0000R0-Oa for submit@debbugs.gnu.org; Thu, 05 Jan 2012 13:07:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:44865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ririb-0000Qw-N5 for submit@debbugs.gnu.org; Thu, 05 Jan 2012 13:07:13 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiriW-0005Lb-OI for bug-automake@gnu.org; Thu, 05 Jan 2012 13:07:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiriV-0000NW-HW for bug-automake@gnu.org; Thu, 05 Jan 2012 13:07:08 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:56116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiriV-0000ID-Az for bug-automake@gnu.org; Thu, 05 Jan 2012 13:07:07 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B0AB4A60009; Thu, 5 Jan 2012 10:06:58 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CP1lhdE1uMpG; Thu, 5 Jan 2012 10:06:57 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DDB07A60008; Thu, 5 Jan 2012 10:06:57 -0800 (PST) Message-ID: <4F05E6C1.7060303@cs.ucla.edu> Date: Thu, 05 Jan 2012 10:06:57 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 References: <87aa64k902.fsf@rho.meyering.net> <4F033BB0.4090305@gmail.com> <4F0566B3.2030104@cs.ucla.edu> <4F05AE8A.1070105@gmail.com> In-Reply-To: <4F05AE8A.1070105@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.7 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) On 01/05/12 06:07, Stefano Lattarini wrote: > Which "sort of thing" exactly? I could find only one place which suffers > of the problem you've pointed out, i.e., the `recheck recheck-html' rules > in lib/am/check.am. Am I missing something? Sorry, that appears to have been a miscount on my part: I was counting some files that Automake generates for itself while building. In Automake source there are only two instances, which your patch caught: the 'recheck recheck-html' rule and the 'check-TESTS' rule (the latter is what actually triggered the problem with coreutils). So this should be OK. Thanks for the quick fixes, by the way! From unknown Sun Jun 22 07:53:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10437: parallel-tests: `recheck' recipe can cause sed to be invoked with too long input lines Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 05 Jan 2012 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10437 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Paul Eggert Cc: 10437@debbugs.gnu.org, 10427@debbugs.gnu.org Received: via spool by 10437-submit@debbugs.gnu.org id=B10437.13257881054737 (code B ref 10437); Thu, 05 Jan 2012 18:29:02 +0000 Received: (at 10437) by debbugs.gnu.org; 5 Jan 2012 18:28:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ris37-0001EL-F4 for submit@debbugs.gnu.org; Thu, 05 Jan 2012 13:28:25 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ris34-0001EA-M1; Thu, 05 Jan 2012 13:28:24 -0500 Received: by eekc14 with SMTP id c14so760480eek.3 for ; Thu, 05 Jan 2012 10:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=aFebrfGLIpZeHsnlgdR6e7zthWc9S0eZnERN43tgf0E=; b=t3Anw9ulgpsIb2qMuUE/wSMfnmaCwSE/hidx8nqeYSahQERlMWNmzv4Xx4cYhDn3oP dl/dqWFboXr2mKTvF/urXQ0pGTJRmN2Z5XJEeq/ZCbeXqalMXzfKFjY/9BAQszs3WEmD jy8kfP3FobKpUCa1JGg5sJQwxde3CbGrGNCQE= Received: by 10.213.33.17 with SMTP id f17mr664519ebd.110.1325787890559; Thu, 05 Jan 2012 10:24:50 -0800 (PST) Received: from [82.58.49.113] (host113-49-dynamic.58-82-r.retail.telecomitalia.it. [82.58.49.113]) by mx.google.com with ESMTPS id q67sm174858759eea.8.2012.01.05.10.24.49 (version=SSLv3 cipher=OTHER); Thu, 05 Jan 2012 10:24:50 -0800 (PST) Message-ID: <4F05EAF0.8070405@gmail.com> Date: Thu, 05 Jan 2012 19:24:48 +0100 From: Stefano Lattarini MIME-Version: 1.0 References: <87aa64k902.fsf@rho.meyering.net> <4F033BB0.4090305@gmail.com> <4F0566B3.2030104@cs.ucla.edu> <4F05AE8A.1070105@gmail.com> <4F05E6C1.7060303@cs.ucla.edu> In-Reply-To: <4F05E6C1.7060303@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On 01/05/2012 07:06 PM, Paul Eggert wrote: > On 01/05/12 06:07, Stefano Lattarini wrote: >> Which "sort of thing" exactly? I could find only one place which suffers >> of the problem you've pointed out, i.e., the `recheck recheck-html' rules >> in lib/am/check.am. Am I missing something? > > Sorry, that appears to have been a miscount on my part: > I was counting some files that Automake generates for itself > while building. In Automake source there are only two instances, > which your patch caught: the 'recheck recheck-html' rule and > the 'check-TESTS' rule (the latter is what actually triggered > the problem with coreutils). > Wait, the `check-TESTS' rules didn't use any sed invocation, so it wouldn't make sense for it to trip for a sed failure ... What am I missing? Thanks, Stefano From unknown Sun Jun 22 07:53:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10437: bug#10427: bug#10437: parallel-tests: `recheck' recipe can cause sed to be invoked with too long input lines Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 05 Jan 2012 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10437 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Paul Eggert Cc: 10437@debbugs.gnu.org, 10427@debbugs.gnu.org Received: via spool by 10437-submit@debbugs.gnu.org id=B10437.13257889436029 (code B ref 10437); Thu, 05 Jan 2012 18:43:01 +0000 Received: (at 10437) by debbugs.gnu.org; 5 Jan 2012 18:42:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RisGb-0001ZA-A5 for submit@debbugs.gnu.org; Thu, 05 Jan 2012 13:42:22 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RisGZ-0001Z0-Js; Thu, 05 Jan 2012 13:42:20 -0500 Received: by eekc14 with SMTP id c14so773105eek.3 for ; Thu, 05 Jan 2012 10:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=waEY0eMqLxrQXQJAuy97LxeVpW5wE1NxARxkPhkbVQU=; b=r/LF979v3lRBUQ5XSWjud9F0TNX3ZGR2orKzTRoor4Y2LFnH+43HghU7vwVpqGSU0m ZHp4KepciGQYUCellU/P7vCqZP4VUMKxTleMiih2m0tOk34CscsAKpsGokwQw1WcFIQI t1czJe1w3YmYxih94spD+Z23SJJqo3dlHWmxg= Received: by 10.213.31.66 with SMTP id x2mr647111ebc.60.1325788727257; Thu, 05 Jan 2012 10:38:47 -0800 (PST) Received: from [82.58.49.113] (host113-49-dynamic.58-82-r.retail.telecomitalia.it. [82.58.49.113]) by mx.google.com with ESMTPS id t1sm236857604eeb.3.2012.01.05.10.38.46 (version=SSLv3 cipher=OTHER); Thu, 05 Jan 2012 10:38:46 -0800 (PST) Message-ID: <4F05EE2F.70901@gmail.com> Date: Thu, 05 Jan 2012 19:38:39 +0100 From: Stefano Lattarini MIME-Version: 1.0 References: <87aa64k902.fsf@rho.meyering.net> <4F033BB0.4090305@gmail.com> <4F0566B3.2030104@cs.ucla.edu> <4F05AE8A.1070105@gmail.com> <4F05E6C1.7060303@cs.ucla.edu> <4F05EAF0.8070405@gmail.com> In-Reply-To: <4F05EAF0.8070405@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On 01/05/2012 07:24 PM, Stefano Lattarini wrote: > On 01/05/2012 07:06 PM, Paul Eggert wrote: >> On 01/05/12 06:07, Stefano Lattarini wrote: >>> Which "sort of thing" exactly? I could find only one place which suffers >>> of the problem you've pointed out, i.e., the `recheck recheck-html' rules >>> in lib/am/check.am. Am I missing something? >> >> Sorry, that appears to have been a miscount on my part: >> I was counting some files that Automake generates for itself >> while building. In Automake source there are only two instances, >> which your patch caught: the 'recheck recheck-html' rule and >> the 'check-TESTS' rule (the latter is what actually triggered >> the problem with coreutils). >> > Wait, the `check-TESTS' rules didn't use any sed invocation, so it wouldn't make > sense for it to trip for a sed failure ... What am I missing? > I will answer myself: I was missing the fact that such a sed invocation had been added to check-TESTS, *but in master only*. Anyway, the maint -> master merge will take care of everything. Thanks, and sorry for the noise, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 05:05:20 2012 Received: (at control) by debbugs.gnu.org; 6 Jan 2012 10:05:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rj6fo-0007df-7C for submit@debbugs.gnu.org; Fri, 06 Jan 2012 05:05:20 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rj6fn-0007dZ-Et for control@debbugs.gnu.org; Fri, 06 Jan 2012 05:05:19 -0500 Received: by werb14 with SMTP id b14so1070840wer.3 for ; Fri, 06 Jan 2012 02:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=XmSFFCkRROSwJLRrNUXMtw8cmu/Vof/Jao+pePL1vm8=; b=TTGyErVRnioAaLttrpr8aVZ+66R7Sdu20UR16VIWCVRiOZp32DckBjmWgv+9c4Q80p jWrxWfxi11siMhxX2t+rZvp1cWlv4dLFnYjV/7gOQoCqTIbDWV3OPgIy2cvbSdfsy+6c 8jimntJ86YFeY7FmdlmevbD/w4QJejZYopbNY= Received: by 10.216.137.155 with SMTP id y27mr2776816wei.53.1325844103893; Fri, 06 Jan 2012 02:01:43 -0800 (PST) Received: from [87.0.103.105] (host105-103-dynamic.0-87-r.retail.telecomitalia.it. [87.0.103.105]) by mx.google.com with ESMTPS id fo18sm67686641wbb.12.2012.01.06.02.01.42 (version=SSLv3 cipher=OTHER); Fri, 06 Jan 2012 02:01:43 -0800 (PST) Message-ID: <4F06C685.9060803@gmail.com> Date: Fri, 06 Jan 2012 11:01:41 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) tags 10437 patch tags 10436 patch close 10436 close 10437 thanks