GNU bug report logs - #10418
10 test failures on Fedora 16

Previous Next

Full log

Message #38 received at 10418-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: automake-patches <at> gnu.org, 10418-done <at> debbugs.gnu.org
Subject: Re: bug#10418: [PATCH] {master} tap/perl: handle missing or
	non-executable scripts better
Date: Thu, 02 Feb 2012 20:28:52 +0100

Stefano Lattarini wrote:

> Hi Jim, thanks for the quick review.
...
>>> +    $@ = "";
>>> +    eval { open3(*STDIN, *STDOUT, *STDERR, "am--no-such-command") };
>>> +    $@ =~ m/\bopen3:.*am--no-such-command/
>>> +      or die "Bad \$@ value: \"$@\"\n";
>>> +  '; then
>>> +    : # OK. IPC::Open3 should be good enough.
>>> +  else
>>> +    for s in '"missing plan" message' 'results'; do
>>> +      skip_ -r "IPC::Open3 not good enough" "no spurious $s"
>>> +    done
>>
>> Perhaps it's just your preferred style, but the quotes around 'results'
>> are unnecessary, so I would remove them.
>>
> I'd rather leave them, for consistency with the other item
> ('"missing plan" message').  Hope that's OK with you.

consistency?  They are required on the first term to quote the '"'s.
There is no need for them in the latter.

Of course, you're welcome to keep them in any case.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.