GNU bug report logs - #10410
guile: uri module confused by domain names starting with numbers, ipv6 addresses

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#10410: closed (guile: uri module confused by domain names
 starting with numbers, ipv6 addresses)
Date: Fri, 06 Jul 2012 12:17:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 06 Jul 2012 13:15:12 +0200
with message-id <87mx3dywcf.fsf <at> pobox.com>
and subject line Re: bug#10410: bump: Bug#10410: numbers, ipv6 addresses in uri module
has caused the debbugs.gnu.org bug report #10410,
regarding guile: uri module confused by domain names starting with numbers, ipv6 addresses
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
10410: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10410
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Hartwig <mandyke <at> gmail.com>
To: submit <at> debbugs.gnu.org
Subject: guile: uri module confused by domain names starting with numbers,
	ipv6 addresses
Date: Fri, 30 Dec 2011 18:14:56 +0800

[Message part 3 (text/plain, inline)]

Package: guile
Version: 2.0.3
Tags: patch
X-Debbugs-CC: guile-devel <at> gnu.org


Hello

I have noticed that the (web uri) module does not handle domain names
that start with numbers:

scheme@(guile-user)> (string->uri "http://123.com")
$1 = #f
scheme@(guile-user)> (build-uri 'http #:host "123.com")
web/uri.scm:85:6: In procedure build-uri:
web/uri.scm:85:6: Throw to key `uri-error' with args `("Expected valid
host: ~s" ("123.com"))'.


Also, `string->uri' does not handle ipv6 addresses:

scheme@(guile-user)> (string->uri "http://[2001:db8::1]")
$2 = #f


Attached patch implements support for domain names that start with
numbers by correcting the
regular expressions used by `valid-host?' as well as some related tests.

`string->uri' requires similar changes to support the ipv6 address
literals.  I'm yet to found a very elegant way to do this though it is
easy enough to simply butcher `authority-pat'.

[0001-support-URIs-with-domain-names-starting-with-numbers.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Andy Wingo <wingo <at> pobox.com>
To: Daniel Hartwig <mandyke <at> gmail.com>
Cc: 10410-done <at> debbugs.gnu.org
Subject: Re: bug#10410: bump: Bug#10410: numbers, ipv6 addresses in uri module
Date: Fri, 06 Jul 2012 13:15:12 +0200

On Wed 22 Feb 2012 07:15, Daniel Hartwig <mandyke <at> gmail.com> writes:

> Bumping this bug report as it is relevant to commit 1868309 which
> recently addressed the issue with domain names starting with numbers.

Sorry for the long delay.  I have applied your patches on my hasty
commits.  There were a couple bugs that this brought out; for example on
my system, inet-pton does not expect the address to be surrounded by
[].  I fixed this to have the uri-host / build-uri #:host to never have
brackets.

WDYT?  Marking as done as your code is in, with tests.  Thanks very much
for the report and patch!

Andy
-- 
http://wingolog.org/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.