GNU bug report logs - #10407
Random point jumps

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10407 in the body.
You can then email your comments to 10407 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Random point jumps
Date: Fri, 30 Dec 2011 13:55:57 +0800

*Steps to reproduction*:

In the *Group* buffer with topic-mode enabled. Move point to be on a
topic with zero unread articles (i.e. empty topic) and type T H (M-x
gnus-topic-toggle-display-empty-topics)

*What happened*:

`point' is moved to the first group counting from the _bottom_ of the
buffer with unread articles. This comes as most surprising when I finish
reading the last unread article in a topic and then quit the summary
buffer when gnus-topic-display-empty-topics is set to nil.


*Expected behaviour*:

point should stay close to where it was, such as the next unread group.


Gnus v5.13
GNU Emacs 23.3.50.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0 AppKit 1038.36)
 of 2011-12-21 on localhost
200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok)
101 Capability list:
VERSION 2
IMPLEMENTATION INN 2.5.1
AUTHINFO USER
HDR
LIST ACTIVE ACTIVE.TIMES DISTRIB.PATS HEADERS NEWSGROUPS OVERVIEW.FMT
OVER
POST
READER
STARTTLS
.

Message #8 received at 10407 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 10407 <at> debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#10407: Random point jumps
Date: Fri, 30 Dec 2011 15:13:51 +0800

The following patch against emacs-24 fixes the bug. Could someone review
and fix it in Emacs-24 too? Thanks.

=== modified file 'lisp/gnus/gnus-topic.el'
--- lisp/gnus/gnus-topic.el	2011-11-25 07:14:48 +0000
+++ lisp/gnus/gnus-topic.el	2011-12-30 07:09:11 +0000
@@ -969,12 +969,15 @@
   (if (not group)
       (if (not (memq 'gnus-topic props))
 	  (goto-char (point-max))
-	(gnus-topic-goto-topic (symbol-name (cadr (memq 'gnus-topic props)))))
+	(let ((topic (symbol-name (cadr (memq 'gnus-topic props)))))
+	  (or (gnus-topic-goto-topic topic)
+	      (gnus-topic-goto-topic (gnus-topic-next-topic topic)))))
     (if (gnus-group-goto-group group)
 	t
       ;; The group is no longer visible.
       (let* ((list (assoc (gnus-group-topic group) gnus-topic-alist))
-	     (after (cdr (member group (cdr list)))))
+	     (topic-visible (save-excursion (gnus-topic-goto-topic (car list))))
+	     (after (and topic-visible (cdr (member group (cdr list))))))
 	;; First try to put point on a group after the current one.
 	(while (and after
 		    (not (gnus-group-goto-group (car after))))
@@ -989,7 +992,9 @@
 	(if (not (car list))
 	    (goto-char (point-min))
 	  (unless after
-	    (gnus-topic-goto-topic (car list))
+	    (if topic-visible
+		(gnus-goto-char topic-visible)
+	      (gnus-topic-goto-topic (gnus-topic-next-topic (car list))))
 	    (setq after nil)))
 	t))))
 

Message #11 received at 10407 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 10407 <at> debbugs.gnu.org
Subject: Re: bug#10407: Random point jumps
Date: Tue, 03 Jan 2012 20:08:01 +0100

Leo <sdl.web <at> gmail.com> writes:

> The following patch against emacs-24 fixes the bug. Could someone review
> and fix it in Emacs-24 too? Thanks.

Thanks; applied.

This is the second "tiny change" applied without any copyright
assignment papers, though, so you're getting close to the limit that can
be applied without paperwork.  Would you be willing to sign copyright
assignment papers to cover any subsequent patches you might be
submitting in the future?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.