Subject: Re: bug#10397: [PATCH] Under Remote Desktop, NUMCOLORS is unreliable; workaround

From: Juanma Barranquero <[email-masked]>
Date: Thu, 29 Dec 2011 17:27:48 +0100

On Thu, Dec 29, 2011 at 17:23, Daniel Colascione <[email-masked]> wrote:

> Why? What's the point of adding the extra complexity?
> Setting cap to -1 leads to this line
>
>    1 << min (dpyinfo->n_planes * dpyinfo->n_cbits, 24);
>
> which produces a reasonable result for direct color displays.
> Why keep using NUMCOLORS, which we know to be broken?

No, you said that NUMCOLORS is known to be broken in a very specific
case. In the general, non-RemoteDektop case, it works. Can you
guarantee that for every non-palettized display, it will produce the
same number? Because otherwise you're changing the current behavior
for people who's not affected by the RemoteDeskopt-related bug.

    Juanma