GNU bug report logs - #10369
coreutils: [PATCH] chmod.c usage() order items alphabetically

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10369 in the body.
You can then email your comments to 10369 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: bug-coreutils <at> gnu.org
Subject: coreutils: [PATCH] chmod.c usage() order items alphabetically
Date: Sun, 25 Dec 2011 18:36:03 +0200

[Message part 1 (text/plain, inline)]

The following patch is against Git 6e3299f (2011-12-22). The patch makes
chmod similar to cp(1), mv(1) whose manual page lists options in
alphabetical order.

2011-12-25  Jari Aalto  <jari.aalto <at> cante.net>

	* chmod.c (usage): order options alphabetically.

[0001-src-chmod.c-usage-order-options-alphabetically.patch (text/x-diff, inline)]

From 2b5d42b0e19e6a6b73e2af3323ee4db6129ee72e Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sun, 25 Dec 2011 18:30:20 +0200
Subject: [PATCH] src/chmod.c: (usage): order options alphabetically
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 src/chmod.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/chmod.c b/src/chmod.c
index 6fec84a..411fd6e 100644
--- a/src/chmod.c
+++ b/src/chmod.c
@@ -379,16 +379,12 @@ Usage: %s [OPTION]... MODE[,MODE]... FILE...\n\
 Change the mode of each FILE to MODE.\n\
 \n\
   -c, --changes           like verbose but report only when a change is made\n\
-"), stdout);
-      fputs (_("\
+  -f, --silent, --quiet   suppress most error messages\n\
       --no-preserve-root  do not treat `/' specially (the default)\n\
       --preserve-root     fail to operate recursively on `/'\n\
-"), stdout);
-      fputs (_("\
-  -f, --silent, --quiet   suppress most error messages\n\
-  -v, --verbose           output a diagnostic for every file processed\n\
-      --reference=RFILE   use RFILE's mode instead of MODE values\n\
   -R, --recursive         change files and directories recursively\n\
+      --reference=RFILE   use RFILE's mode instead of MODE values\n\
+  -v, --verbose           output a diagnostic for every file processed\n\
 "), stdout);
       fputs (HELP_OPTION_DESCRIPTION, stdout);
       fputs (VERSION_OPTION_DESCRIPTION, stdout);
-- 
1.7.7.3

Message #10 received at 10369-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 10369-done <at> debbugs.gnu.org
Subject: Re: bug#10369: coreutils: [PATCH] chmod.c usage() order items
	alphabetically
Date: Mon, 26 Dec 2011 10:20:03 +0000

On 12/25/2011 04:36 PM, Jari Aalto wrote:
> 
> The following patch is against Git 6e3299f (2011-12-22). The patch makes
> chmod similar to cp(1), mv(1) whose manual page lists options in
> alphabetical order.
> 
> 2011-12-25  Jari Aalto  <jari.aalto <at> cante.net>
> 
> 	* chmod.c (usage): order options alphabetically.
> 

chcon, chgrp need the same adjustment.
Note I'd prefer to keep -R and -v together
as they're more general than --ref and
can use the same translations.

I'll make those adjustments and commit.

cheers,
Pádraig.

Message #13 received at 10369 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 10369 <at> debbugs.gnu.org, P <at> draigBrady.com
Subject: Re: bug#10369: coreutils: [PATCH] chmod.c usage() order items
	alphabetically
Date: Mon, 26 Dec 2011 02:25:33 -0800

On 12/26/11 02:20, Pádraig Brady wrote:

> chcon, chgrp need the same adjustment.
> Note I'd prefer to keep -R and -v together
> as they're more general than --ref and
> can use the same translations.

If we're going to list options in some order
than alphabetically (which often makes sense),
shouldn't -c, -f, and -v be kept together?
This would be for the same reason that --no-preserve-root
and --preserve-root are kept together: they're related
options.

Message #16 received at 10369 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 10369 <at> debbugs.gnu.org
Subject: Re: bug#10369: coreutils: [PATCH] chmod.c usage() order items
	alphabetically
Date: Mon, 26 Dec 2011 11:11:11 +0000

On 12/26/2011 10:25 AM, Paul Eggert wrote:
> On 12/26/11 02:20, Pádraig Brady wrote:
> 
>> chcon, chgrp need the same adjustment.
>> Note I'd prefer to keep -R and -v together
>> as they're more general than --ref and
>> can use the same translations.
> 
> If we're going to list options in some order
> than alphabetically (which often makes sense),
> shouldn't -c, -f, and -v be kept together?
> This would be for the same reason that --no-preserve-root
> and --preserve-root are kept together: they're related
> options.

Agreed. I'll adjust like:

-c, -f, -v
--{no-,}preserve-root
--recursive
--reference
--$command_specific
--help
--version

cheers,
Pádraig.

Message #19 received at 10369 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 10369 <at> debbugs.gnu.org
Subject: Re: bug#10369: coreutils: [PATCH] doc: homologize ch{con, grp, mod,
	own} option descriptions
Date: Mon, 26 Dec 2011 19:37:46 +0000

[Message part 1 (text/plain, inline)]

On 12/26/2011 11:11 AM, Pádraig Brady wrote:
> On 12/26/2011 10:25 AM, Paul Eggert wrote:
>> On 12/26/11 02:20, Pádraig Brady wrote:
>>
>>> chcon, chgrp need the same adjustment.
>>> Note I'd prefer to keep -R and -v together
>>> as they're more general than --ref and
>>> can use the same translations.
>>
>> If we're going to list options in some order
>> than alphabetically (which often makes sense),
>> shouldn't -c, -f, and -v be kept together?
>> This would be for the same reason that --no-preserve-root
>> and --preserve-root are kept together: they're related
>> options.
> 
> Agreed. I'll adjust like:
> 
> -c, -f, -v
> --{no-,}preserve-root
> --recursive
> --reference
> --$command_specific
> --help
> --version

That attached patch handles this,
and fixes an issue where --dereference
was not documented in `chcon`

cheers,
Pádraig.

[ch-opt-order.diff (text/plain, attachment)]

Message #22 received at 10369 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 10369 <at> debbugs.gnu.org
Subject: Re: bug#10369: coreutils: [PATCH] doc: homologize ch{con, grp, mod,
	own} option descriptions
Date: Mon, 26 Dec 2011 22:44:32 +0100

Pádraig Brady wrote:
> On 12/26/2011 11:11 AM, Pádraig Brady wrote:
>> On 12/26/2011 10:25 AM, Paul Eggert wrote:
>>> On 12/26/11 02:20, Pádraig Brady wrote:
>>>
>>>> chcon, chgrp need the same adjustment.
>>>> Note I'd prefer to keep -R and -v together
>>>> as they're more general than --ref and
>>>> can use the same translations.
>>>
>>> If we're going to list options in some order
>>> than alphabetically (which often makes sense),
>>> shouldn't -c, -f, and -v be kept together?
>>> This would be for the same reason that --no-preserve-root
>>> and --preserve-root are kept together: they're related
>>> options.
>>
>> Agreed. I'll adjust like:
>>
>> -c, -f, -v
>> --{no-,}preserve-root
>> --recursive
>> --reference
>> --$command_specific
>> --help
>> --version
>
> That attached patch handles this,
> and fixes an issue where --dereference
> was not documented in `chcon`

Thanks!

> Subject: [PATCH] doc: homologize ch{con,grp,mod,own} option descriptions
>
> * src/chgrp.c (usage): Group associated options together
> and minimize the individual messages between these four utils.

minimize differences between?

> * src/chmod.c: Likewise.
> * src/chown.c: Likewise.
> * src/chcon.c (usage): Likewise.  Add documention for
> the --dereference option.
>
> Suggested by Paul Eggert and Jari Aalto

Message #25 received at 10369 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 10369 <at> debbugs.gnu.org
Subject: Re: bug#10369: coreutils: [PATCH] doc: homologize ch{con, grp, mod,
	own} option descriptions
Date: Mon, 26 Dec 2011 22:16:47 +0000

On 12/26/2011 09:44 PM, Jim Meyering wrote:
> Pádraig Brady wrote:
>> On 12/26/2011 11:11 AM, Pádraig Brady wrote:

>> * src/chgrp.c (usage): Group associated options together
>> and minimize the individual messages between these four utils.
> 
> minimize differences between?

True, I didn't reduce any wording :)

thanks for the review,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.