GNU bug report logs - #1035
23.0.60; DOS eol decoding bug

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Jason Rumney <jasonr <at> gnu.org>
Subject: bug#1035: marked as done (23.0.60; DOS eol decoding bug)
Date: Sat, 20 Dec 2008 08:10:07 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 20 Dec 2008 16:02:54 +0800
with message-id <494CA6AE.9070609 <at> gnu.org>
and subject line Re: bug#1035: 23.0.60; DOS eol decoding bug
has caused the Emacs bug report #1035,
regarding 23.0.60; DOS eol decoding bug
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
1035: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1035
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: bojohan+mail <at> dd.chalmers.se (Johan Bockgård)
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; DOS eol decoding bug
Date: Fri, 26 Sep 2008 22:34:12 +0200

Decoding a chunk of DOS text that ends in \r results in an extra chunk
of garbage.

    (progn
      (with-temp-file "/tmp/bar"
        (insert-char ?x 10)
        (insert "\r"))
      (with-temp-buffer
        (let ((coding-system-for-read 'raw-text-dos))
          (insert-file-contents "/tmp/bar")
          (buffer-size))))

      => 21 (expected result 11)


I think the problem was introduced with this change:

2008-03-02  Kenichi Handa  <handa <at> m17n.org>

    * coding.c (decode_coding_utf_8): When eol-type of CODING is `dos',
    don't decode '\r' if that is the last in the source.
    (decode_coding_utf_16, decode_coding_emacs_mule)
    (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
    (decode_coding_raw_text, decode_coding_charset): Likewise.
    (produce_chars): Don't decode EOL here. Use EMACS_INT.

-- 
Johan Bockgård

[Message part 3 (message/rfc822, inline)]

From: Jason Rumney <jasonr <at> gnu.org>
To: Johan Bockgård <bojohan+mail <at> dd.chalmers.se>,
        1035-done <at> debbugs.gnu.org
Subject: Re: bug#1035: 23.0.60; DOS eol decoding bug
Date: Sat, 20 Dec 2008 16:02:54 +0800

Johan Bockgård wrote:
> Decoding a chunk of DOS text that ends in \r results in an extra chunk
> of garbage.
>   

Thanks for reporting it, I have fixed this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.