GNU bug report logs - #1035
23.0.60; DOS eol decoding bug

Previous Next

Package: emacs;

Reported by: bojohan+mail <at> dd.chalmers.se (Johan Bockgård)

Date: Fri, 26 Sep 2008 20:40:04 UTC

Severity: normal

Done: Jason Rumney <jasonr <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: bojohan+mail <at> dd.chalmers.se (Johan Bockgård)
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; DOS eol decoding bug
Date: Fri, 26 Sep 2008 22:34:12 +0200

Decoding a chunk of DOS text that ends in \r results in an extra chunk
of garbage.

    (progn
      (with-temp-file "/tmp/bar"
        (insert-char ?x 10)
        (insert "\r"))
      (with-temp-buffer
        (let ((coding-system-for-read 'raw-text-dos))
          (insert-file-contents "/tmp/bar")
          (buffer-size))))

      => 21 (expected result 11)


I think the problem was introduced with this change:

2008-03-02  Kenichi Handa  <handa <at> m17n.org>

    * coding.c (decode_coding_utf_8): When eol-type of CODING is `dos',
    don't decode '\r' if that is the last in the source.
    (decode_coding_utf_16, decode_coding_emacs_mule)
    (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
    (decode_coding_raw_text, decode_coding_charset): Likewise.
    (produce_chars): Don't decode EOL here. Use EMACS_INT.

-- 
Johan Bockgård
This bug report was last modified 15 years and 249 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.