GNU bug report logs - #10345
24.0.92; `save-buffer' and `basic-save-buffer': add MSG arg

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10345 in the body.
You can then email your comments to 10345 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.92; `save-buffer' and `basic-save-buffer': add MSG arg
Date: Wed, 21 Dec 2011 14:09:45 -0800

Please make it possible to call this function without it displaying a
message.  E.g., add an optional MSG argument that is always non-nil
interactively.
 
One motivation:
 
An Emacs function might do a series of things, including calling
`save-buffer'.  Sometimes the whole series could take a while, and a
caller of the function might want to give a specific progress message:
"Foo-barring..." and end with "Foo-barring...done".  When the series of
operations includes `save-buffer' this messaging is interrupted, and the
user sees a message from `save-buffer', with no `...' to indicate that
the overall operation (series) is not finished.
 
In sum, since this function is sometimes called from Lisp, it makes
little sense for it to systematically display a message.  A caller
should be able to control the messaging behavior.
 
Same thing applies for `basic-save-buffer'.  These functions are called
from Lisp.  They deserve optional MSG args to control message display.
(Obviously, this applies only to the use of `message', not also to
reading input or raising errors.)

In GNU Emacs 24.0.92.1 (i386-mingw-nt5.1.2600) of 2011-12-06 on MARVIN
 Windowing system distributor `Microsoft Corp.', version 5.1.2600
 configured using `configure --with-gcc (4.6) --no-opt --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-2.10.1/include --ldflags
 -LD:/devel/emacs/libs/gnutls-2.10.1/lib'
 

Message #8 received at 10345 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <10345 <at> debbugs.gnu.org>
Subject: RE: bug#10345: 24.0.92;
	`save-buffer' and `basic-save-buffer': add MSG arg
Date: Sun, 16 Sep 2012 17:20:25 -0700

ping

Message #11 received at 10345 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 10345 <at> debbugs.gnu.org
Subject: Re: bug#10345: 24.0.92;
 `save-buffer' and `basic-save-buffer': add MSG arg
Date: Thu, 28 Apr 2016 13:48:18 +0200

"Drew Adams" <drew.adams <at> oracle.com> writes:

> Please make it possible to call this function without it displaying a
> message.  E.g., add an optional MSG argument that is always non-nil
> interactively.
>
> One motivation:
>
> An Emacs function might do a series of things, including calling
> `save-buffer'.  Sometimes the whole series could take a while, and a
> caller of the function might want to give a specific progress message:
> "Foo-barring..." and end with "Foo-barring...done".  When the series of
> operations includes `save-buffer' this messaging is interrupted, and the
> user sees a message from `save-buffer', with no `...' to indicate that
> the overall operation (series) is not finished.
>
> In sum, since this function is sometimes called from Lisp, it makes
> little sense for it to systematically display a message.  A caller
> should be able to control the messaging behavior.
>
> Same thing applies for `basic-save-buffer'.  These functions are called
> from Lisp.  They deserve optional MSG args to control message display.
> (Obviously, this applies only to the use of `message', not also to
> reading input or raising errors.)

If you wish to save buffers without messaging, you use `write-region' or
the like.  `save-buffers' is a very user level function.  Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 10345 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 10345 <at> debbugs.gnu.org
Subject: RE: bug#10345: 24.0.92; `save-buffer' and `basic-save-buffer': add
 MSG arg
Date: Thu, 28 Apr 2016 07:09:26 -0700 (PDT)

> If you wish to save buffers without messaging, you use `write-region' or
> the like.  `save-buffers' is a very user level function.  Closing.

No. `write-region' does not do the same thing at all.
And no, `save-buffers' is not only "a very user level function".

As I said:

 > In sum, since this function is sometimes called from Lisp,
 > it makes little sense for it to systematically display a
 > message.  A caller should be able to control the messaging
 > behavior.

Do you deny that this function is sometimes called from Lisp?
If you instead accept that, then why shouldn't a caller of it
be able to control the messaging behavior?

What does it cost Emacs to add an optional MSG argument?

Message #21 received at 10345 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: larsi <at> gnus.org, 10345 <at> debbugs.gnu.org
Subject: Re: bug#10345: 24.0.92;
 `save-buffer' and `basic-save-buffer': add MSG arg
Date: Thu, 28 Apr 2016 17:15:40 +0300

> Date: Thu, 28 Apr 2016 07:09:26 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> Cc: 10345 <at> debbugs.gnu.org
> 
> Do you deny that this function is sometimes called from Lisp?
> If you instead accept that, then why shouldn't a caller of it
> be able to control the messaging behavior?
> 
> What does it cost Emacs to add an optional MSG argument?

Emacs 25 has the inhibit-message variable for this purpose, so I think
this argument is no longer relevant.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.